* [PATCH] drm/i915: Remove unused i915_gem_context_lookup_engine
@ 2019-07-09 9:31 Tvrtko Ursulin
2019-07-09 9:32 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2019-07-09 9:31 UTC (permalink / raw)
To: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
There are no known plans to start using it either.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_context.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.h b/drivers/gpu/drm/i915/gem/i915_gem_context.h
index 9691dd062f72..106e2ccf7a4c 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.h
@@ -197,12 +197,6 @@ i915_gem_context_unlock_engines(struct i915_gem_context *ctx)
mutex_unlock(&ctx->engines_mutex);
}
-static inline struct intel_context *
-i915_gem_context_lookup_engine(struct i915_gem_context *ctx, unsigned int idx)
-{
- return i915_gem_context_engines(ctx)->engines[idx];
-}
-
static inline struct intel_context *
i915_gem_context_get_engine(struct i915_gem_context *ctx, unsigned int idx)
{
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Remove unused i915_gem_context_lookup_engine 2019-07-09 9:31 [PATCH] drm/i915: Remove unused i915_gem_context_lookup_engine Tvrtko Ursulin @ 2019-07-09 9:32 ` Chris Wilson 2019-07-09 20:37 ` Chris Wilson 2019-07-09 12:48 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-07-10 0:17 ` ✓ Fi.CI.IGT: " Patchwork 2 siblings, 1 reply; 5+ messages in thread From: Chris Wilson @ 2019-07-09 9:32 UTC (permalink / raw) To: Intel-gfx, Tvrtko Ursulin Quoting Tvrtko Ursulin (2019-07-09 10:31:05) > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > There are no known plans to start using it either. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> I think I used it in the patch/series and you talked me out of it. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Remove unused i915_gem_context_lookup_engine 2019-07-09 9:32 ` Chris Wilson @ 2019-07-09 20:37 ` Chris Wilson 0 siblings, 0 replies; 5+ messages in thread From: Chris Wilson @ 2019-07-09 20:37 UTC (permalink / raw) To: Intel-gfx, Tvrtko Ursulin Quoting Chris Wilson (2019-07-09 10:32:57) > Quoting Tvrtko Ursulin (2019-07-09 10:31:05) > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > > > There are no known plans to start using it either. > > > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > I think I used it in the patch/series and you talked me out of it. > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Pushed before someone finds a use. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Remove unused i915_gem_context_lookup_engine 2019-07-09 9:31 [PATCH] drm/i915: Remove unused i915_gem_context_lookup_engine Tvrtko Ursulin 2019-07-09 9:32 ` Chris Wilson @ 2019-07-09 12:48 ` Patchwork 2019-07-10 0:17 ` ✓ Fi.CI.IGT: " Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-07-09 12:48 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: intel-gfx == Series Details == Series: drm/i915: Remove unused i915_gem_context_lookup_engine URL : https://patchwork.freedesktop.org/series/63437/ State : success == Summary == CI Bug Log - changes from CI_DRM_6440 -> Patchwork_13579 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/ Known issues ------------ Here are the changes found in Patchwork_13579 that come from known issues: ### IGT changes ### #### Possible fixes #### * igt@gem_mmap_gtt@basic-short: - fi-icl-u3: [DMESG-WARN][1] ([fdo#107724]) -> [PASS][2] +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/fi-icl-u3/igt@gem_mmap_gtt@basic-short.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/fi-icl-u3/igt@gem_mmap_gtt@basic-short.html #### Warnings #### * igt@i915_pm_rpm@basic-pci-d3-state: - fi-kbl-guc: [FAIL][3] ([fdo#110829]) -> [SKIP][4] ([fdo#109271]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#110829]: https://bugs.freedesktop.org/show_bug.cgi?id=110829 [fdo#111049]: https://bugs.freedesktop.org/show_bug.cgi?id=111049 Participating hosts (51 -> 46) ------------------------------ Additional (2): fi-icl-dsi fi-pnv-d510 Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ivb-3770 fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_6440 -> Patchwork_13579 CI_DRM_6440: f3ee9eaf13443e179a5ad263da0abe241ea04172 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5092: 2a66ae6626d5583240509f84117d1345a799b75a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13579: 7b5fa8f85418b6ba992a6baf41465c740574f6a0 @ git://anongit.freedesktop.org/gfx-ci/linux == Kernel 32bit build == Warning: Kernel 32bit buildtest failed: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/build_32bit.log CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 112 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1287: recipe for target 'modules' failed make: *** [modules] Error 2 == Linux commits == 7b5fa8f85418 drm/i915: Remove unused i915_gem_context_lookup_engine == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Remove unused i915_gem_context_lookup_engine 2019-07-09 9:31 [PATCH] drm/i915: Remove unused i915_gem_context_lookup_engine Tvrtko Ursulin 2019-07-09 9:32 ` Chris Wilson 2019-07-09 12:48 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-07-10 0:17 ` Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-07-10 0:17 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: intel-gfx == Series Details == Series: drm/i915: Remove unused i915_gem_context_lookup_engine URL : https://patchwork.freedesktop.org/series/63437/ State : success == Summary == CI Bug Log - changes from CI_DRM_6440_full -> Patchwork_13579_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_13579_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_eio@reset-stress: - shard-snb: [PASS][1] -> [FAIL][2] ([fdo#109661]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-snb4/igt@gem_eio@reset-stress.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-snb5/igt@gem_eio@reset-stress.html * igt@i915_pm_rpm@drm-resources-equal: - shard-iclb: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#108840]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-iclb1/igt@i915_pm_rpm@drm-resources-equal.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-iclb2/igt@i915_pm_rpm@drm-resources-equal.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-apl8/igt@i915_suspend@fence-restore-tiled2untiled.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@i915_suspend@sysfs-reader: - shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-kbl2/igt@i915_suspend@sysfs-reader.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-kbl4/igt@i915_suspend@sysfs-reader.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-skl: [PASS][9] -> [INCOMPLETE][10] ([fdo#104108]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-skl7/igt@kms_fbcon_fbt@fbc-suspend.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-skl9/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-expired-vblank: - shard-glk: [PASS][11] -> [FAIL][12] ([fdo#105363]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-glk8/igt@kms_flip@flip-vs-expired-vblank.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-glk3/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][13] -> [FAIL][14] ([fdo#105363]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-skl: [PASS][15] -> [INCOMPLETE][16] ([fdo#109507]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-skl8/igt@kms_flip@flip-vs-suspend-interruptible.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-skl5/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +4 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html #### Possible fixes #### * igt@gem_exec_nop@basic-series: - shard-iclb: [INCOMPLETE][21] ([fdo#107713] / [fdo#109100]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-iclb1/igt@gem_exec_nop@basic-series.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-iclb7/igt@gem_exec_nop@basic-series.html * igt@gem_workarounds@suspend-resume-fd: - shard-skl: [INCOMPLETE][23] ([fdo#104108]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-skl1/igt@gem_workarounds@suspend-resume-fd.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-skl2/igt@gem_workarounds@suspend-resume-fd.html * igt@i915_suspend@fence-restore-untiled: - shard-kbl: [DMESG-WARN][25] ([fdo#108566]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-kbl4/igt@i915_suspend@fence-restore-untiled.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-kbl6/igt@i915_suspend@fence-restore-untiled.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-apl: [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_flip@2x-flip-vs-wf_vblank-interruptible: - shard-hsw: [INCOMPLETE][29] ([fdo#103540]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-hsw7/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-hsw5/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html * igt@kms_flip_tiling@flip-y-tiled: - shard-iclb: [FAIL][31] ([fdo#108303]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-iclb6/igt@kms_flip_tiling@flip-y-tiled.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-iclb3/igt@kms_flip_tiling@flip-y-tiled.html * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack: - shard-skl: [FAIL][33] ([fdo#103167]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-skl2/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-skl8/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: - shard-iclb: [FAIL][35] ([fdo#103167]) -> [PASS][36] +3 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][37] ([fdo#108145]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [FAIL][39] ([fdo#108145] / [fdo#110403]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@psr2_suspend: - shard-iclb: [SKIP][41] ([fdo#109441]) -> [PASS][42] +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-iclb7/igt@kms_psr@psr2_suspend.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-iclb2/igt@kms_psr@psr2_suspend.html * igt@kms_rotation_crc@multiplane-rotation-cropping-top: - shard-kbl: [FAIL][43] ([fdo#109016]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6440/shard-kbl6/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/shard-kbl6/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840 [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507 [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_6440 -> Patchwork_13579 CI_DRM_6440: f3ee9eaf13443e179a5ad263da0abe241ea04172 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5092: 2a66ae6626d5583240509f84117d1345a799b75a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13579: 7b5fa8f85418b6ba992a6baf41465c740574f6a0 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13579/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-10 0:17 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-07-09 9:31 [PATCH] drm/i915: Remove unused i915_gem_context_lookup_engine Tvrtko Ursulin 2019-07-09 9:32 ` Chris Wilson 2019-07-09 20:37 ` Chris Wilson 2019-07-09 12:48 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-07-10 0:17 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.