All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v7 10/12] drm/i915/perf: allow holding preemption on filtered ctx
Date: Tue, 09 Jul 2019 11:00:43 +0100	[thread overview]
Message-ID: <156266644341.9375.1105653276634114123@skylake-alporthouse-com> (raw)
In-Reply-To: <20190709093208.20470-11-lionel.g.landwerlin@intel.com>

Quoting Lionel Landwerlin (2019-07-09 10:32:06)
> We would like to make use of perf in Vulkan. The Vulkan API is much
> lower level than OpenGL, with applications directly exposed to the
> concept of command buffers (pretty much equivalent to our batch
> buffers). In Vulkan, queries are always limited in scope to a command
> buffer. In OpenGL, the lack of command buffer concept meant that
> queries' duration could span multiple command buffers.
> 
> With that restriction gone in Vulkan, we would like to simplify
> measuring performance just by measuring the deltas between the counter
> snapshots written by 2 MI_RECORD_PERF_COUNT commands, rather than the
> more complex scheme we currently have in the GL driver, using 2
> MI_RECORD_PERF_COUNT commands and doing some post processing on the
> stream of OA reports, coming from the global OA buffer, to remove any
> unrelated deltas in between the 2 MI_RECORD_PERF_COUNT.
> 
> Disabling preemption only apply to a single context with which want to
> query performance counters for and is considered a privileged
> operation, by default protected by CAP_SYS_ADMIN. It is possible to
> enable it for a normal user by disabling the paranoid stream setting.
> 
> v2: Store preemption setting in intel_context (Chris)
> 
> v3: Use priorities to avoid preemption rather than the HW mechanism
> 
> v4: Just modify the port priority reporting function
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Could you split this into two -- separate the backend mechanism from
perf setting the flag? I want to add a selftest and apply.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-07-09 10:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  9:31 [PATCH v7 00/12] drm/i915: Vulkan performance query support Lionel Landwerlin
2019-07-09  9:31 ` [PATCH v7 01/12] drm/i915/perf: ensure we keep a reference on the driver Lionel Landwerlin
2019-07-09  9:35   ` Chris Wilson
2019-07-09  9:31 ` [PATCH v7 02/12] drm/i915/perf: add missing delay for OA muxes configuration Lionel Landwerlin
2019-07-09  9:36   ` Chris Wilson
2019-07-09  9:31 ` [PATCH v7 03/12] drm/i915/perf: introduce a versioning of the i915-perf uapi Lionel Landwerlin
2019-07-09  9:37   ` Chris Wilson
2019-07-09  9:32 ` [PATCH v7 04/12] drm/i915/perf: allow for CS OA configs to be created lazily Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 05/12] drm/i915: enumerate scratch fields Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 06/12] drm/i915/perf: implement active wait for noa configurations Lionel Landwerlin
2019-07-09  9:53   ` Chris Wilson
2019-07-09 10:44     ` Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 07/12] drm/i915: introduce a mechanism to extend execbuf2 Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 08/12] drm/i915: add syncobj timeline support Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 09/12] drm/i915: add a new perf configuration execbuf parameter Lionel Landwerlin
2019-07-09  9:58   ` Chris Wilson
2019-07-09 10:59     ` Lionel Landwerlin
2019-07-09 11:06       ` Chris Wilson
2019-07-09 11:10         ` Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 10/12] drm/i915/perf: allow holding preemption on filtered ctx Lionel Landwerlin
2019-07-09 10:00   ` Chris Wilson [this message]
2019-07-09 10:45     ` Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 11/12] drm/i915/perf: execute OA configuration from command stream Lionel Landwerlin
2019-07-09 10:02   ` Chris Wilson
2019-07-09 11:04     ` Lionel Landwerlin
2019-07-09 11:16       ` Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 12/12] drm/i915: add support for perf configuration queries Lionel Landwerlin
2019-07-09 10:07   ` Chris Wilson
2019-07-09 11:33     ` Lionel Landwerlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156266644341.9375.1105653276634114123@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.