All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v7 11/12] drm/i915/perf: execute OA configuration from command stream
Date: Tue, 09 Jul 2019 11:02:58 +0100	[thread overview]
Message-ID: <156266657826.9375.60632268806953517@skylake-alporthouse-com> (raw)
In-Reply-To: <20190709093208.20470-12-lionel.g.landwerlin@intel.com>

Quoting Lionel Landwerlin (2019-07-09 10:32:07)
> +static int emit_oa_config(struct drm_i915_private *i915,
> +                         struct i915_perf_stream *stream)
>  {
> -       u32 i;
> +       struct i915_oa_config *oa_config = stream->oa_config;
> +       struct i915_request *rq = stream->initial_config_rq;
> +       struct i915_vma *vma;
> +       u32 *cs;
> +       int err;
>  
> -       for (i = 0; i < n_regs; i++) {
> -               const struct i915_oa_reg *reg = regs + i;
> +       vma = i915_vma_instance(oa_config->obj, &i915->ggtt.vm, NULL);
> +       if (unlikely(IS_ERR(vma)))
> +               return PTR_ERR(vma);
> +
> +       err = i915_vma_pin(vma, 0, 0, PIN_GLOBAL);
> +       if (err)
> +               return err;

Hmm, still a lock inversion here as we will not be allowed to pin from
underneath rq->timeline->mutex.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-07-09 10:03 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  9:31 [PATCH v7 00/12] drm/i915: Vulkan performance query support Lionel Landwerlin
2019-07-09  9:31 ` [PATCH v7 01/12] drm/i915/perf: ensure we keep a reference on the driver Lionel Landwerlin
2019-07-09  9:35   ` Chris Wilson
2019-07-09  9:31 ` [PATCH v7 02/12] drm/i915/perf: add missing delay for OA muxes configuration Lionel Landwerlin
2019-07-09  9:36   ` Chris Wilson
2019-07-09  9:31 ` [PATCH v7 03/12] drm/i915/perf: introduce a versioning of the i915-perf uapi Lionel Landwerlin
2019-07-09  9:37   ` Chris Wilson
2019-07-09  9:32 ` [PATCH v7 04/12] drm/i915/perf: allow for CS OA configs to be created lazily Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 05/12] drm/i915: enumerate scratch fields Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 06/12] drm/i915/perf: implement active wait for noa configurations Lionel Landwerlin
2019-07-09  9:53   ` Chris Wilson
2019-07-09 10:44     ` Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 07/12] drm/i915: introduce a mechanism to extend execbuf2 Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 08/12] drm/i915: add syncobj timeline support Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 09/12] drm/i915: add a new perf configuration execbuf parameter Lionel Landwerlin
2019-07-09  9:58   ` Chris Wilson
2019-07-09 10:59     ` Lionel Landwerlin
2019-07-09 11:06       ` Chris Wilson
2019-07-09 11:10         ` Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 10/12] drm/i915/perf: allow holding preemption on filtered ctx Lionel Landwerlin
2019-07-09 10:00   ` Chris Wilson
2019-07-09 10:45     ` Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 11/12] drm/i915/perf: execute OA configuration from command stream Lionel Landwerlin
2019-07-09 10:02   ` Chris Wilson [this message]
2019-07-09 11:04     ` Lionel Landwerlin
2019-07-09 11:16       ` Lionel Landwerlin
2019-07-09  9:32 ` [PATCH v7 12/12] drm/i915: add support for perf configuration queries Lionel Landwerlin
2019-07-09 10:07   ` Chris Wilson
2019-07-09 11:33     ` Lionel Landwerlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156266657826.9375.60632268806953517@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.