* [U-Boot] [PATCH] mmc: fsl_esdhc_imx: fix config check issue when building in SPL
@ 2019-07-11 3:29 Ye Li
2019-07-11 4:12 ` Bin Meng
2019-07-15 7:04 ` Peng Fan
0 siblings, 2 replies; 3+ messages in thread
From: Ye Li @ 2019-07-11 3:29 UTC (permalink / raw)
To: u-boot
Should use CONFIG_IS_ENABLED not IS_ENABLED for clock and regulator drivers,
CONFIG_IS_ENABLED will check the CONFIG_SPL_CLK and CONFIG_SPL_DM_REGULATOR
when building SPL.
Signed-off-by: Ye Li <ye.li@nxp.com>
---
drivers/mmc/fsl_esdhc_imx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c
index c0d47ba..4938202 100644
--- a/drivers/mmc/fsl_esdhc_imx.c
+++ b/drivers/mmc/fsl_esdhc_imx.c
@@ -146,7 +146,7 @@ struct fsl_esdhc_priv {
u32 tuning_start_tap;
u32 strobe_dll_delay_target;
u32 signal_voltage;
-#if IS_ENABLED(CONFIG_DM_REGULATOR)
+#if CONFIG_IS_ENABLED(DM_REGULATOR)
struct udevice *vqmmc_dev;
struct udevice *vmmc_dev;
#endif
@@ -1515,7 +1515,7 @@ static int fsl_esdhc_probe(struct udevice *dev)
init_clk_usdhc(dev->seq);
- if (IS_ENABLED(CONFIG_CLK)) {
+ if (CONFIG_IS_ENABLED(CLK)) {
/* Assigned clock already set clock */
ret = clk_get_by_name(dev, "per", &priv->per_clk);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mmc: fsl_esdhc_imx: fix config check issue when building in SPL
2019-07-11 3:29 [U-Boot] [PATCH] mmc: fsl_esdhc_imx: fix config check issue when building in SPL Ye Li
@ 2019-07-11 4:12 ` Bin Meng
2019-07-15 7:04 ` Peng Fan
1 sibling, 0 replies; 3+ messages in thread
From: Bin Meng @ 2019-07-11 4:12 UTC (permalink / raw)
To: u-boot
On Thu, Jul 11, 2019 at 11:29 AM Ye Li <ye.li@nxp.com> wrote:
>
> Should use CONFIG_IS_ENABLED not IS_ENABLED for clock and regulator drivers,
> CONFIG_IS_ENABLED will check the CONFIG_SPL_CLK and CONFIG_SPL_DM_REGULATOR
> when building SPL.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> ---
> drivers/mmc/fsl_esdhc_imx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mmc: fsl_esdhc_imx: fix config check issue when building in SPL
2019-07-11 3:29 [U-Boot] [PATCH] mmc: fsl_esdhc_imx: fix config check issue when building in SPL Ye Li
2019-07-11 4:12 ` Bin Meng
@ 2019-07-15 7:04 ` Peng Fan
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2019-07-15 7:04 UTC (permalink / raw)
To: u-boot
> Subject: [PATCH] mmc: fsl_esdhc_imx: fix config check issue when building in
> SPL
>
> Should use CONFIG_IS_ENABLED not IS_ENABLED for clock and regulator
> drivers, CONFIG_IS_ENABLED will check the CONFIG_SPL_CLK and
> CONFIG_SPL_DM_REGULATOR when building SPL.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> ---
> drivers/mmc/fsl_esdhc_imx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c
> index c0d47ba..4938202 100644
> --- a/drivers/mmc/fsl_esdhc_imx.c
> +++ b/drivers/mmc/fsl_esdhc_imx.c
> @@ -146,7 +146,7 @@ struct fsl_esdhc_priv {
> u32 tuning_start_tap;
> u32 strobe_dll_delay_target;
> u32 signal_voltage;
> -#if IS_ENABLED(CONFIG_DM_REGULATOR)
> +#if CONFIG_IS_ENABLED(DM_REGULATOR)
> struct udevice *vqmmc_dev;
> struct udevice *vmmc_dev;
> #endif
> @@ -1515,7 +1515,7 @@ static int fsl_esdhc_probe(struct udevice *dev)
>
> init_clk_usdhc(dev->seq);
>
> - if (IS_ENABLED(CONFIG_CLK)) {
> + if (CONFIG_IS_ENABLED(CLK)) {
> /* Assigned clock already set clock */
> ret = clk_get_by_name(dev, "per", &priv->per_clk);
> if (ret) {
Applied to mmc/master.
Thanks,
Peng.
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-15 7:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11 3:29 [U-Boot] [PATCH] mmc: fsl_esdhc_imx: fix config check issue when building in SPL Ye Li
2019-07-11 4:12 ` Bin Meng
2019-07-15 7:04 ` Peng Fan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.