* [PATCH] libvirt: Only add polkit to PACKAGECONFIG if polkit is in DISTRO_FEATURES
@ 2019-07-12 6:45 mingli.yu
2019-07-12 14:52 ` Bruce Ashfield
0 siblings, 1 reply; 4+ messages in thread
From: mingli.yu @ 2019-07-12 6:45 UTC (permalink / raw)
To: meta-virtualization
From: Mingli Yu <Mingli.Yu@windriver.com>
At first, the polkit support is always enabled in
PACKAGECONFIG and since Feb 27 2014, use x11
DISTRO_FEATURES to control the polkit support
with below commit.
=========================================================
commit ce991a62d5f2ce006074ee4b8a97c6029308548c
Author: Jonas Eriksson <jonas.eriksson@enea.com>
Date: Thu Feb 27 17:10:09 2014 +0100
libvirt: Disable polkit driver when there is no x11
To avoid having the default build of libvirt depend on virtual/x11
through polkit and consolekit, check for x11 in DISTRO_FEATURES before
enabling the polkit support in the default PKG_CONFIG.
Signed-off-by: Jonas Eriksson <jonas.eriksson@enea.com>
Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
diff --git a/recipes-extended/libvirt/libvirt_1.2.1.bb b/recipes-extended/libvirt/libvirt_1.2.1.bb
index 5365b8d..4c9cf36 100644
--- a/recipes-extended/libvirt/libvirt_1.2.1.bb
+++ b/recipes-extended/libvirt/libvirt_1.2.1.bb
@@ -109,10 +109,11 @@ INITSCRIPT_PARAMS_${PN}-libvirtd = "defaults 72"
#PACKAGECONFIG ??= "xen libxl xen-inotify test remote libvirtd"
# full config
-PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 polkit lxc test \
+PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 lxc test \
remote macvtap libvirtd netcf udev python ebtables \
${@base_contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
${@base_contains('DISTRO_FEATURES', 'xen', 'xen libxl xen-inotify', '', d)} \
+ ${@base_contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
"
=========================================================
After below commits to add polkit as a required distro feature
in meta-oe, we should unify altogether to enable polkit if
polkit distro feature is set.
97a1a55 polkit: add polkit as a required distro
feature c049e02 polkit: inherit distro_features_check
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
recipes-extended/libvirt/libvirt_5.3.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-extended/libvirt/libvirt_5.3.0.bb b/recipes-extended/libvirt/libvirt_5.3.0.bb
index c54a99e..286f0de 100644
--- a/recipes-extended/libvirt/libvirt_5.3.0.bb
+++ b/recipes-extended/libvirt/libvirt_5.3.0.bb
@@ -188,7 +188,7 @@ PACKAGECONFIG ??= "qemu yajl openvz vmware vbox esx iproute2 lxc test \
fuse iproute2 firewalld libpcap \
${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit libcap-ng', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'xen', 'libxl', '', d)} \
- ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
+ ${@bb.utils.contains('DISTRO_FEATURES', 'polkit', 'polkit', '', d)} \
${@bb.utils.contains('KARCH', 'arm', '', 'numactl', d)} \
"
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] libvirt: Only add polkit to PACKAGECONFIG if polkit is in DISTRO_FEATURES
2019-07-12 6:45 [PATCH] libvirt: Only add polkit to PACKAGECONFIG if polkit is in DISTRO_FEATURES mingli.yu
@ 2019-07-12 14:52 ` Bruce Ashfield
2019-07-15 2:09 ` [PATCH v2] " mingli.yu
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Ashfield @ 2019-07-12 14:52 UTC (permalink / raw)
To: Yu, Mingli; +Cc: meta-virtualization
I just pushed an update to libvirt to master. Can you rebase and
resend this on top of the latest ?
Bruce
On Fri, Jul 12, 2019 at 2:46 AM <mingli.yu@windriver.com> wrote:
>
> From: Mingli Yu <Mingli.Yu@windriver.com>
>
> At first, the polkit support is always enabled in
> PACKAGECONFIG and since Feb 27 2014, use x11
> DISTRO_FEATURES to control the polkit support
> with below commit.
> =========================================================
> commit ce991a62d5f2ce006074ee4b8a97c6029308548c
> Author: Jonas Eriksson <jonas.eriksson@enea.com>
> Date: Thu Feb 27 17:10:09 2014 +0100
>
> libvirt: Disable polkit driver when there is no x11
>
> To avoid having the default build of libvirt depend on virtual/x11
> through polkit and consolekit, check for x11 in DISTRO_FEATURES before
> enabling the polkit support in the default PKG_CONFIG.
>
> Signed-off-by: Jonas Eriksson <jonas.eriksson@enea.com>
> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>
> diff --git a/recipes-extended/libvirt/libvirt_1.2.1.bb b/recipes-extended/libvirt/libvirt_1.2.1.bb
> index 5365b8d..4c9cf36 100644
> --- a/recipes-extended/libvirt/libvirt_1.2.1.bb
> +++ b/recipes-extended/libvirt/libvirt_1.2.1.bb
> @@ -109,10 +109,11 @@ INITSCRIPT_PARAMS_${PN}-libvirtd = "defaults 72"
> #PACKAGECONFIG ??= "xen libxl xen-inotify test remote libvirtd"
>
> # full config
> -PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 polkit lxc test \
> +PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 lxc test \
> remote macvtap libvirtd netcf udev python ebtables \
> ${@base_contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
> ${@base_contains('DISTRO_FEATURES', 'xen', 'xen libxl xen-inotify', '', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
> "
> =========================================================
>
> After below commits to add polkit as a required distro feature
> in meta-oe, we should unify altogether to enable polkit if
> polkit distro feature is set.
> 97a1a55 polkit: add polkit as a required distro
> feature c049e02 polkit: inherit distro_features_check
>
> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> ---
> recipes-extended/libvirt/libvirt_5.3.0.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-extended/libvirt/libvirt_5.3.0.bb b/recipes-extended/libvirt/libvirt_5.3.0.bb
> index c54a99e..286f0de 100644
> --- a/recipes-extended/libvirt/libvirt_5.3.0.bb
> +++ b/recipes-extended/libvirt/libvirt_5.3.0.bb
> @@ -188,7 +188,7 @@ PACKAGECONFIG ??= "qemu yajl openvz vmware vbox esx iproute2 lxc test \
> fuse iproute2 firewalld libpcap \
> ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit libcap-ng', '', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'xen', 'libxl', '', d)} \
> - ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'polkit', 'polkit', '', d)} \
> ${@bb.utils.contains('KARCH', 'arm', '', 'numactl', d)} \
> "
>
> --
> 2.7.4
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] libvirt: Only add polkit to PACKAGECONFIG if polkit is in DISTRO_FEATURES
2019-07-12 14:52 ` Bruce Ashfield
@ 2019-07-15 2:09 ` mingli.yu
2019-07-16 19:42 ` Bruce Ashfield
0 siblings, 1 reply; 4+ messages in thread
From: mingli.yu @ 2019-07-15 2:09 UTC (permalink / raw)
To: meta-virtualization, bruce.ashfield
From: Mingli Yu <Mingli.Yu@windriver.com>
At first, the polkit support is always enabled in
PACKAGECONFIG and since Feb 27 2014, use x11
DISTRO_FEATURES to control the polkit support
with below commit.
=========================================================
commit ce991a62d5f2ce006074ee4b8a97c6029308548c
Author: Jonas Eriksson <jonas.eriksson@enea.com>
Date: Thu Feb 27 17:10:09 2014 +0100
libvirt: Disable polkit driver when there is no x11
To avoid having the default build of libvirt depend on virtual/x11
through polkit and consolekit, check for x11 in DISTRO_FEATURES before
enabling the polkit support in the default PKG_CONFIG.
Signed-off-by: Jonas Eriksson <jonas.eriksson@enea.com>
Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
diff --git a/recipes-extended/libvirt/libvirt_1.2.1.bb b/recipes-extended/libvirt/libvirt_1.2.1.bb
index 5365b8d..4c9cf36 100644
--- a/recipes-extended/libvirt/libvirt_1.2.1.bb
+++ b/recipes-extended/libvirt/libvirt_1.2.1.bb
@@ -109,10 +109,11 @@ INITSCRIPT_PARAMS_${PN}-libvirtd = "defaults 72"
#PACKAGECONFIG ??= "xen libxl xen-inotify test remote libvirtd"
# full config
-PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 polkit lxc test \
+PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 lxc test \
remote macvtap libvirtd netcf udev python ebtables \
${@base_contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
${@base_contains('DISTRO_FEATURES', 'xen', 'xen libxl xen-inotify', '', d)} \
+ ${@base_contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
"
=========================================================
After below commits to add polkit as a required distro feature
in meta-oe, we should unify altogether to enable polkit if
polkit distro feature is set.
97a1a55 polkit: add polkit as a required distro
feature c049e02 polkit: inherit distro_features_check
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
recipes-extended/libvirt/libvirt_5.5.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-extended/libvirt/libvirt_5.5.0.bb b/recipes-extended/libvirt/libvirt_5.5.0.bb
index 222654a..7ed40a6 100644
--- a/recipes-extended/libvirt/libvirt_5.5.0.bb
+++ b/recipes-extended/libvirt/libvirt_5.5.0.bb
@@ -188,7 +188,7 @@ PACKAGECONFIG ??= "qemu yajl openvz vmware vbox esx iproute2 lxc test \
fuse iproute2 firewalld libpcap \
${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit libcap-ng', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'xen', 'libxl', '', d)} \
- ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
+ ${@bb.utils.contains('DISTRO_FEATURES', 'polkit', 'polkit', '', d)} \
${@bb.utils.contains('KARCH', 'arm', '', 'numactl', d)} \
"
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] libvirt: Only add polkit to PACKAGECONFIG if polkit is in DISTRO_FEATURES
2019-07-15 2:09 ` [PATCH v2] " mingli.yu
@ 2019-07-16 19:42 ` Bruce Ashfield
0 siblings, 0 replies; 4+ messages in thread
From: Bruce Ashfield @ 2019-07-16 19:42 UTC (permalink / raw)
To: Yu, Mingli; +Cc: meta-virtualization
Thanks for the rebase.
Merged.
Bruce
On Sun, Jul 14, 2019 at 10:10 PM <mingli.yu@windriver.com> wrote:
>
> From: Mingli Yu <Mingli.Yu@windriver.com>
>
> At first, the polkit support is always enabled in
> PACKAGECONFIG and since Feb 27 2014, use x11
> DISTRO_FEATURES to control the polkit support
> with below commit.
> =========================================================
> commit ce991a62d5f2ce006074ee4b8a97c6029308548c
> Author: Jonas Eriksson <jonas.eriksson@enea.com>
> Date: Thu Feb 27 17:10:09 2014 +0100
>
> libvirt: Disable polkit driver when there is no x11
>
> To avoid having the default build of libvirt depend on virtual/x11
> through polkit and consolekit, check for x11 in DISTRO_FEATURES before
> enabling the polkit support in the default PKG_CONFIG.
>
> Signed-off-by: Jonas Eriksson <jonas.eriksson@enea.com>
> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>
> diff --git a/recipes-extended/libvirt/libvirt_1.2.1.bb b/recipes-extended/libvirt/libvirt_1.2.1.bb
> index 5365b8d..4c9cf36 100644
> --- a/recipes-extended/libvirt/libvirt_1.2.1.bb
> +++ b/recipes-extended/libvirt/libvirt_1.2.1.bb
> @@ -109,10 +109,11 @@ INITSCRIPT_PARAMS_${PN}-libvirtd = "defaults 72"
> #PACKAGECONFIG ??= "xen libxl xen-inotify test remote libvirtd"
>
> # full config
> -PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 polkit lxc test \
> +PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 lxc test \
> remote macvtap libvirtd netcf udev python ebtables \
> ${@base_contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
> ${@base_contains('DISTRO_FEATURES', 'xen', 'xen libxl xen-inotify', '', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
> "
> =========================================================
>
> After below commits to add polkit as a required distro feature
> in meta-oe, we should unify altogether to enable polkit if
> polkit distro feature is set.
> 97a1a55 polkit: add polkit as a required distro
> feature c049e02 polkit: inherit distro_features_check
>
> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> ---
> recipes-extended/libvirt/libvirt_5.5.0.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-extended/libvirt/libvirt_5.5.0.bb b/recipes-extended/libvirt/libvirt_5.5.0.bb
> index 222654a..7ed40a6 100644
> --- a/recipes-extended/libvirt/libvirt_5.5.0.bb
> +++ b/recipes-extended/libvirt/libvirt_5.5.0.bb
> @@ -188,7 +188,7 @@ PACKAGECONFIG ??= "qemu yajl openvz vmware vbox esx iproute2 lxc test \
> fuse iproute2 firewalld libpcap \
> ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit libcap-ng', '', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'xen', 'libxl', '', d)} \
> - ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'polkit', 'polkit', '', d)} \
> ${@bb.utils.contains('KARCH', 'arm', '', 'numactl', d)} \
> "
>
> --
> 2.7.4
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-16 19:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-12 6:45 [PATCH] libvirt: Only add polkit to PACKAGECONFIG if polkit is in DISTRO_FEATURES mingli.yu
2019-07-12 14:52 ` Bruce Ashfield
2019-07-15 2:09 ` [PATCH v2] " mingli.yu
2019-07-16 19:42 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.