From: Walter Wu <walter-zh.wu@mediatek.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
"Vasily Gorbik" <gor@linux.ibm.com>,
Andrey Konovalov <andreyknvl@google.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Miles Chen <miles.chen@mediatek.com>,
kasan-dev <kasan-dev@googlegroups.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
wsd_upstream <wsd_upstream@mediatek.com>
Subject: Re: [PATCH v3] kasan: add memory corruption identification for software tag-based mode
Date: Fri, 26 Jul 2019 21:19:24 +0800 [thread overview]
Message-ID: <1564147164.515.10.camel@mtksdccf07> (raw)
In-Reply-To: <71df2bd5-7bc8-2c82-ee31-3f68c3b6296d@virtuozzo.com>
On Fri, 2019-07-26 at 15:52 +0300, Andrey Ryabinin wrote:
>
> On 7/26/19 3:28 PM, Walter Wu wrote:
> > On Fri, 2019-07-26 at 15:00 +0300, Andrey Ryabinin wrote:
> >>
> >
> >>>
> >>>
> >>> I remember that there are already the lists which you concern. Maybe we
> >>> can try to solve those problems one by one.
> >>>
> >>> 1. deadlock issue? cause by kmalloc() after kfree()?
> >>
> >> smp_call_on_cpu()
> >
> >>> 2. decrease allocation fail, to modify GFP_NOWAIT flag to GFP_KERNEL?
> >>
> >> No, this is not gonna work. Ideally we shouldn't have any allocations there.
> >> It's not reliable and it hurts performance.
> >>
> > I dont know this meaning, we need create a qobject and put into
> > quarantine, so may need to call kmem_cache_alloc(), would you agree this
> > action?
> >
>
> How is this any different from what you have now?
I originally thought you already agreed the free-list(tag-based
quarantine) after fix those issue. If no allocation there, i think maybe
only move generic quarantine into tag-based kasan, but its memory
consumption is more bigger our patch. what do you think?
WARNING: multiple messages have this Message-ID (diff)
From: Walter Wu <walter-zh.wu@mediatek.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Arnd Bergmann <arnd@arndb.de>, Vasily Gorbik <gor@linux.ibm.com>,
Andrey Konovalov <andreyknvl@google.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Miles Chen <miles.chen@mediatek.com>,
kasan-dev <kasan-dev@googlegroups.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
wsd_upstream <wsd_upstream@mediatek.com>
Subject: Re: [PATCH v3] kasan: add memory corruption identification for software tag-based mode
Date: Fri, 26 Jul 2019 21:19:24 +0800 [thread overview]
Message-ID: <1564147164.515.10.camel@mtksdccf07> (raw)
In-Reply-To: <71df2bd5-7bc8-2c82-ee31-3f68c3b6296d@virtuozzo.com>
On Fri, 2019-07-26 at 15:52 +0300, Andrey Ryabinin wrote:
>
> On 7/26/19 3:28 PM, Walter Wu wrote:
> > On Fri, 2019-07-26 at 15:00 +0300, Andrey Ryabinin wrote:
> >>
> >
> >>>
> >>>
> >>> I remember that there are already the lists which you concern. Maybe we
> >>> can try to solve those problems one by one.
> >>>
> >>> 1. deadlock issue? cause by kmalloc() after kfree()?
> >>
> >> smp_call_on_cpu()
> >
> >>> 2. decrease allocation fail, to modify GFP_NOWAIT flag to GFP_KERNEL?
> >>
> >> No, this is not gonna work. Ideally we shouldn't have any allocations there.
> >> It's not reliable and it hurts performance.
> >>
> > I dont know this meaning, we need create a qobject and put into
> > quarantine, so may need to call kmem_cache_alloc(), would you agree this
> > action?
> >
>
> How is this any different from what you have now?
I originally thought you already agreed the free-list(tag-based
quarantine) after fix those issue. If no allocation there, i think maybe
only move generic quarantine into tag-based kasan, but its memory
consumption is more bigger our patch. what do you think?
WARNING: multiple messages have this Message-ID (diff)
From: Walter Wu <walter-zh.wu@mediatek.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: wsd_upstream <wsd_upstream@mediatek.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Vasily Gorbik <gor@linux.ibm.com>, Arnd Bergmann <arnd@arndb.de>,
Linux-MM <linux-mm@kvack.org>,
Andrey Konovalov <andreyknvl@google.com>,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Pekka Enberg <penberg@kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Miles Chen <miles.chen@mediatek.com>,
Alexander Potapenko <glider@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
David Rientjes <rientjes@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
Christoph Lameter <cl@linux.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v3] kasan: add memory corruption identification for software tag-based mode
Date: Fri, 26 Jul 2019 21:19:24 +0800 [thread overview]
Message-ID: <1564147164.515.10.camel@mtksdccf07> (raw)
In-Reply-To: <71df2bd5-7bc8-2c82-ee31-3f68c3b6296d@virtuozzo.com>
On Fri, 2019-07-26 at 15:52 +0300, Andrey Ryabinin wrote:
>
> On 7/26/19 3:28 PM, Walter Wu wrote:
> > On Fri, 2019-07-26 at 15:00 +0300, Andrey Ryabinin wrote:
> >>
> >
> >>>
> >>>
> >>> I remember that there are already the lists which you concern. Maybe we
> >>> can try to solve those problems one by one.
> >>>
> >>> 1. deadlock issue? cause by kmalloc() after kfree()?
> >>
> >> smp_call_on_cpu()
> >
> >>> 2. decrease allocation fail, to modify GFP_NOWAIT flag to GFP_KERNEL?
> >>
> >> No, this is not gonna work. Ideally we shouldn't have any allocations there.
> >> It's not reliable and it hurts performance.
> >>
> > I dont know this meaning, we need create a qobject and put into
> > quarantine, so may need to call kmem_cache_alloc(), would you agree this
> > action?
> >
>
> How is this any different from what you have now?
I originally thought you already agreed the free-list(tag-based
quarantine) after fix those issue. If no allocation there, i think maybe
only move generic quarantine into tag-based kasan, but its memory
consumption is more bigger our patch. what do you think?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-26 13:19 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 8:13 [PATCH v3] kasan: add memory corruption identification for software tag-based mode Walter Wu
2019-06-13 8:13 ` Walter Wu
2019-06-13 8:13 ` Walter Wu
2019-06-13 12:27 ` Andrey Ryabinin
2019-06-13 12:27 ` Andrey Ryabinin
2019-06-13 12:27 ` Andrey Ryabinin
2019-06-13 13:05 ` Dmitry Vyukov
2019-06-13 13:05 ` Dmitry Vyukov
2019-06-13 13:05 ` Dmitry Vyukov
2019-06-13 13:05 ` Dmitry Vyukov
2019-06-13 15:50 ` Andrey Ryabinin
2019-06-13 15:50 ` Andrey Ryabinin
2019-06-13 17:46 ` Walter Wu
2019-06-13 17:46 ` Walter Wu
2019-06-13 17:46 ` Walter Wu
2019-06-14 2:32 ` Walter Wu
2019-06-14 2:32 ` Walter Wu
2019-06-14 2:32 ` Walter Wu
2019-06-17 4:00 ` Walter Wu
2019-06-17 4:00 ` Walter Wu
2019-06-17 4:00 ` Walter Wu
2019-06-17 11:57 ` Dmitry Vyukov
2019-06-17 11:57 ` Dmitry Vyukov
2019-06-17 11:57 ` Dmitry Vyukov
2019-06-17 12:32 ` Walter Wu
2019-06-17 12:32 ` Walter Wu
2019-06-17 12:32 ` Walter Wu
2019-07-01 9:56 ` Walter Wu
2019-07-01 9:56 ` Walter Wu
2019-07-01 9:56 ` Walter Wu
2019-07-05 13:34 ` Dmitry Vyukov
2019-07-05 13:34 ` Dmitry Vyukov
2019-07-05 13:34 ` Dmitry Vyukov
2019-07-08 16:33 ` Andrey Ryabinin
2019-07-08 16:33 ` Andrey Ryabinin
2019-07-09 2:53 ` Walter Wu
2019-07-09 2:53 ` Walter Wu
2019-07-09 2:53 ` Walter Wu
2019-07-10 18:24 ` Andrey Ryabinin
2019-07-10 18:24 ` Andrey Ryabinin
2019-07-11 10:06 ` Walter Wu
2019-07-11 10:06 ` Walter Wu
2019-07-11 10:06 ` Walter Wu
2019-07-12 10:52 ` Andrey Ryabinin
2019-07-12 10:52 ` Andrey Ryabinin
2019-07-15 3:06 ` Walter Wu
2019-07-15 3:06 ` Walter Wu
2019-07-15 3:06 ` Walter Wu
2019-07-18 16:11 ` Andrey Ryabinin
2019-07-18 16:11 ` Andrey Ryabinin
2019-07-22 9:52 ` Walter Wu
2019-07-22 9:52 ` Walter Wu
2019-07-22 9:52 ` Walter Wu
2019-07-26 12:00 ` Andrey Ryabinin
2019-07-26 12:00 ` Andrey Ryabinin
2019-07-26 12:28 ` Walter Wu
2019-07-26 12:28 ` Walter Wu
2019-07-26 12:28 ` Walter Wu
2019-07-26 12:52 ` Andrey Ryabinin
2019-07-26 12:52 ` Andrey Ryabinin
2019-07-26 13:19 ` Walter Wu [this message]
2019-07-26 13:19 ` Walter Wu
2019-07-26 13:19 ` Walter Wu
2019-07-31 17:04 ` Andrey Ryabinin
2019-07-31 17:04 ` Andrey Ryabinin
2019-08-02 3:04 ` Walter Wu
2019-08-02 3:04 ` Walter Wu
2019-08-02 3:04 ` Walter Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564147164.515.10.camel@mtksdccf07 \
--to=walter-zh.wu@mediatek.com \
--cc=Jason@zx2c4.com \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=gor@linux.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=schwidefsky@de.ibm.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.