* [PATCH] drm/i915: Check for a second VCS engine more carefully
@ 2019-08-09 5:13 Chris Wilson
2019-08-09 5:52 ` ✓ Fi.CI.BAT: success for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Chris Wilson @ 2019-08-09 5:13 UTC (permalink / raw)
To: intel-gfx
To use the legacy BSD selector, you must have a second VCS engine, or
else the ABI simply maps the request for another engine onto VCS0.
However, we only checked a single VCS1 location and overlooking the
possibility of a sparse VCS set being mapped to the dense ABI.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 566e8a4844cf..a43a9bd48bc5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -2200,7 +2200,10 @@ eb_select_legacy_ring(struct i915_execbuffer *eb,
return -1;
}
- if (user_ring_id == I915_EXEC_BSD && HAS_ENGINE(i915, VCS1)) {
+ BUILD_BUG_ON(I915_MAX_VCS > 8); /* see hweight8() below */
+ if (user_ring_id == I915_EXEC_BSD &&
+ hweight8((INTEL_INFO(i915)->engine_mask >> VCS0) &
+ (BIT(I915_MAX_VCS) - 1)) > 1) { /* silly abi is abi */
unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;
if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
--
2.23.0.rc1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Check for a second VCS engine more carefully
2019-08-09 5:13 [PATCH] drm/i915: Check for a second VCS engine more carefully Chris Wilson
@ 2019-08-09 5:52 ` Patchwork
2019-08-09 8:57 ` [PATCH] " Joonas Lahtinen
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-08-09 5:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check for a second VCS engine more carefully
URL : https://patchwork.freedesktop.org/series/64938/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6660 -> Patchwork_13930
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/
Known issues
------------
Here are the changes found in Patchwork_13930 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-cml-u: [PASS][1] -> [INCOMPLETE][2] ([fdo#110566])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/fi-cml-u/igt@gem_ctx_create@basic-files.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/fi-cml-u/igt@gem_ctx_create@basic-files.html
* igt@gem_mmap_gtt@basic-copy:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/fi-icl-u3/igt@gem_mmap_gtt@basic-copy.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/fi-icl-u3/igt@gem_mmap_gtt@basic-copy.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#109483] / [fdo#109635 ])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#103167])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@prime_vgem@basic-fence-flip:
- fi-kbl-7500u: [PASS][9] -> [SKIP][10] ([fdo#109271]) +23 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/fi-kbl-7500u/igt@prime_vgem@basic-fence-flip.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/fi-kbl-7500u/igt@prime_vgem@basic-fence-flip.html
#### Possible fixes ####
* igt@prime_vgem@basic-fence-flip:
- fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
#### Warnings ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [FAIL][13] ([fdo#110829]) -> [SKIP][14] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
[fdo#110829]: https://bugs.freedesktop.org/show_bug.cgi?id=110829
Participating hosts (55 -> 46)
------------------------------
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6660 -> Patchwork_13930
CI-20190529: 20190529
CI_DRM_6660: 4fc4f95e16a6accec47d7dbc04a5df2ad3317f67 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5127: f43f5fa12ac1b93febfe3eeb9e9985f5f3e2eff0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13930: 5a654f48a901ae721dcff943498c57cde71a0369 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5a654f48a901 drm/i915: Check for a second VCS engine more carefully
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Check for a second VCS engine more carefully
2019-08-09 5:13 [PATCH] drm/i915: Check for a second VCS engine more carefully Chris Wilson
2019-08-09 5:52 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-08-09 8:57 ` Joonas Lahtinen
2019-08-09 9:03 ` [PATCH v2] " Chris Wilson
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Joonas Lahtinen @ 2019-08-09 8:57 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Quoting Chris Wilson (2019-08-09 08:13:54)
> To use the legacy BSD selector, you must have a second VCS engine, or
> else the ABI simply maps the request for another engine onto VCS0.
> However, we only checked a single VCS1 location and overlooking the
> possibility of a sparse VCS set being mapped to the dense ABI.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index 566e8a4844cf..a43a9bd48bc5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -2200,7 +2200,10 @@ eb_select_legacy_ring(struct i915_execbuffer *eb,
> return -1;
> }
>
> - if (user_ring_id == I915_EXEC_BSD && HAS_ENGINE(i915, VCS1)) {
> + BUILD_BUG_ON(I915_MAX_VCS > 8); /* see hweight8() below */
> + if (user_ring_id == I915_EXEC_BSD &&
> + hweight8((INTEL_INFO(i915)->engine_mask >> VCS0) &
> + (BIT(I915_MAX_VCS) - 1)) > 1) { /* silly abi is abi */
This is definitely not a hot path, so how about something like:
hweight64(INTEL_INFO(i915)->engine_mask &
GENMASK_ULL(VCS0 + I915_MAX_VCS, VCS0))
Reads better to me. Regardless, this is;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] drm/i915: Check for a second VCS engine more carefully
2019-08-09 5:13 [PATCH] drm/i915: Check for a second VCS engine more carefully Chris Wilson
2019-08-09 5:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-09 8:57 ` [PATCH] " Joonas Lahtinen
@ 2019-08-09 9:03 ` Chris Wilson
2019-08-09 11:31 ` ✓ Fi.CI.BAT: success for drm/i915: Check for a second VCS engine more carefully (rev2) Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2019-08-09 9:03 UTC (permalink / raw)
To: intel-gfx
To use the legacy BSD selector, you must have a second VCS engine, or
else the ABI simply maps the request for another engine onto VCS0.
However, we only checked a single VCS1 location and overlooking the
possibility of a sparse VCS set being mapped to the dense ABI.
v2: num_vcs_engines() turns out to be reusable and futureproof it so we
never have to worry about this silly bit of ABI again!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 566e8a4844cf..dc8b80c6c317 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -2102,6 +2102,12 @@ static int eb_submit(struct i915_execbuffer *eb)
return 0;
}
+static int num_vcs_engines(const struct drm_i915_private *i915)
+{
+ return hweight64(INTEL_INFO(i915)->engine_mask &
+ GENMASK_ULL(VCS0 + I915_MAX_VCS, VCS0));
+}
+
/*
* Find one BSD ring to dispatch the corresponding BSD command.
* The engine index is returned.
@@ -2200,7 +2206,7 @@ eb_select_legacy_ring(struct i915_execbuffer *eb,
return -1;
}
- if (user_ring_id == I915_EXEC_BSD && HAS_ENGINE(i915, VCS1)) {
+ if (user_ring_id == I915_EXEC_BSD && num_vcs_engines(i915) > 1) {
unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;
if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
--
2.23.0.rc1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Check for a second VCS engine more carefully (rev2)
2019-08-09 5:13 [PATCH] drm/i915: Check for a second VCS engine more carefully Chris Wilson
` (2 preceding siblings ...)
2019-08-09 9:03 ` [PATCH v2] " Chris Wilson
@ 2019-08-09 11:31 ` Patchwork
2019-08-09 16:46 ` ✓ Fi.CI.IGT: success for drm/i915: Check for a second VCS engine more carefully Patchwork
2019-08-10 4:04 ` ✗ Fi.CI.IGT: failure for drm/i915: Check for a second VCS engine more carefully (rev2) Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-08-09 11:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check for a second VCS engine more carefully (rev2)
URL : https://patchwork.freedesktop.org/series/64938/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6667 -> Patchwork_13935
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13935:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@i915_selftest@live_gt_timelines}:
- fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/fi-bsw-kefka/igt@i915_selftest@live_gt_timelines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/fi-bsw-kefka/igt@i915_selftest@live_gt_timelines.html
Known issues
------------
Here are the changes found in Patchwork_13935 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-c:
- fi-kbl-7500u: [PASS][3] -> [SKIP][4] ([fdo#109271] / [fdo#109278]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
* igt@kms_chamelium@dp-edid-read:
- fi-cml-u2: [PASS][5] -> [FAIL][6] ([fdo#109483])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-skl-gvtdvm: [DMESG-FAIL][7] ([fdo#111108]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [FAIL][9] ([fdo#110627]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7567u: [FAIL][11] ([fdo#109485]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/fi-kbl-7567u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/fi-kbl-7567u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][13] ([fdo#102614]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#110627]: https://bugs.freedesktop.org/show_bug.cgi?id=110627
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
Participating hosts (55 -> 46)
------------------------------
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6667 -> Patchwork_13935
CI-20190529: 20190529
CI_DRM_6667: e4aebcb3848d8118eb9d42456bdff183268b221c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5127: f43f5fa12ac1b93febfe3eeb9e9985f5f3e2eff0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13935: 9e564acbc1e803e48721bdc9bbb77cbba1a367c0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9e564acbc1e8 drm/i915: Check for a second VCS engine more carefully
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Check for a second VCS engine more carefully
2019-08-09 5:13 [PATCH] drm/i915: Check for a second VCS engine more carefully Chris Wilson
` (3 preceding siblings ...)
2019-08-09 11:31 ` ✓ Fi.CI.BAT: success for drm/i915: Check for a second VCS engine more carefully (rev2) Patchwork
@ 2019-08-09 16:46 ` Patchwork
2019-08-10 4:04 ` ✗ Fi.CI.IGT: failure for drm/i915: Check for a second VCS engine more carefully (rev2) Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-08-09 16:46 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check for a second VCS engine more carefully
URL : https://patchwork.freedesktop.org/series/64938/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6660_full -> Patchwork_13930_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13930_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +10 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb4/igt@gem_exec_schedule@out-order-bsd2.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb8/igt@gem_exec_schedule@out-order-bsd2.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#103184] / [fdo#103232] / [fdo#108472])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-skl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-skl6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][9] -> [FAIL][10] ([fdo#105363])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([fdo#108566]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#108341])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb4/igt@kms_psr@no_drrs.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#99912])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-skl5/igt@kms_setmode@basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-skl8/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
- shard-iclb: [PASS][21] -> [INCOMPLETE][22] ([fdo#107713])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb5/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb1/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#105010])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb2/igt@perf_pmu@rc6-runtime-pm-long.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb4/igt@perf_pmu@rc6-runtime-pm-long.html
#### Possible fixes ####
* igt@gem_exec_schedule@fifo-bsd2:
- shard-iclb: [SKIP][25] ([fdo#109276]) -> [PASS][26] +7 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb6/igt@gem_exec_schedule@fifo-bsd2.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb4/igt@gem_exec_schedule@fifo-bsd2.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][27] ([fdo#111325]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb3/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_unref_active_buffers:
- shard-iclb: [INCOMPLETE][29] ([fdo#107713]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb7/igt@gem_unref_active_buffers.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb8/igt@gem_unref_active_buffers.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-hsw: [FAIL][33] ([fdo#103355]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [FAIL][35] ([fdo#105363]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-glk3/igt@kms_flip@flip-vs-expired-vblank.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-glk7/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@wf_vblank-ts-check-interruptible:
- shard-hsw: [INCOMPLETE][37] ([fdo#103540]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-hsw5/igt@kms_flip@wf_vblank-ts-check-interruptible.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-hsw6/igt@kms_flip@wf_vblank-ts-check-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-skl: [INCOMPLETE][41] ([fdo#104108]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-skl10/igt@kms_frontbuffer_tracking@fbc-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-skl10/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6660/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/shard-apl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6660 -> Patchwork_13930
CI-20190529: 20190529
CI_DRM_6660: 4fc4f95e16a6accec47d7dbc04a5df2ad3317f67 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5127: f43f5fa12ac1b93febfe3eeb9e9985f5f3e2eff0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13930: 5a654f48a901ae721dcff943498c57cde71a0369 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13930/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: Check for a second VCS engine more carefully (rev2)
2019-08-09 5:13 [PATCH] drm/i915: Check for a second VCS engine more carefully Chris Wilson
` (4 preceding siblings ...)
2019-08-09 16:46 ` ✓ Fi.CI.IGT: success for drm/i915: Check for a second VCS engine more carefully Patchwork
@ 2019-08-10 4:04 ` Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-08-10 4:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check for a second VCS engine more carefully (rev2)
URL : https://patchwork.freedesktop.org/series/64938/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6667_full -> Patchwork_13935_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13935_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_13935_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13935_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_exec@basic-invalid-context-vcs0:
- shard-glk: [PASS][1] -> [FAIL][2] +9 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-glk3/igt@gem_ctx_exec@basic-invalid-context-vcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-glk2/igt@gem_ctx_exec@basic-invalid-context-vcs0.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-skl: [PASS][3] -> [FAIL][4] +7 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl8/igt@gem_eio@in-flight-contexts-10ms.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl5/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-iclb: [PASS][5] -> [FAIL][6] +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb2/igt@gem_eio@in-flight-contexts-1us.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb8/igt@gem_eio@in-flight-contexts-1us.html
- shard-apl: NOTRUN -> [FAIL][7] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-apl4/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_parallel@contexts:
- shard-apl: [PASS][8] -> [FAIL][9] +5 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-apl7/igt@gem_exec_parallel@contexts.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-apl5/igt@gem_exec_parallel@contexts.html
* igt@gem_exec_parallel@vcs0-fds:
- shard-hsw: [PASS][10] -> [FAIL][11] +5 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-hsw2/igt@gem_exec_parallel@vcs0-fds.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-hsw2/igt@gem_exec_parallel@vcs0-fds.html
* igt@prime_vgem@busy-bsd:
- shard-iclb: NOTRUN -> [SKIP][12]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb5/igt@prime_vgem@busy-bsd.html
* igt@prime_vgem@sync-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb1/igt@prime_vgem@sync-bsd.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb5/igt@prime_vgem@sync-bsd.html
#### Warnings ####
* igt@gem_ctx_shared@q-independent-bsd:
- shard-iclb: [SKIP][15] ([fdo#110839]) -> [SKIP][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb6/igt@gem_ctx_shared@q-independent-bsd.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb3/igt@gem_ctx_shared@q-independent-bsd.html
Known issues
------------
Here are the changes found in Patchwork_13935_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#110841])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@preempt-hang-blt:
- shard-iclb: [PASS][19] -> [INCOMPLETE][20] ([fdo#107713] / [fdo#109100])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb6/igt@gem_exec_schedule@preempt-hang-blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb7/igt@gem_exec_schedule@preempt-hang-blt.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109276]) +20 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preempt-queue-chain-bsd:
- shard-glk: [PASS][23] -> [SKIP][24] ([fdo#109271]) +20 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-glk3/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-glk1/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
* igt@gem_exec_schedule@preempt-self-bsd:
- shard-skl: [PASS][25] -> [SKIP][26] ([fdo#109271]) +19 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl7/igt@gem_exec_schedule@preempt-self-bsd.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl7/igt@gem_exec_schedule@preempt-self-bsd.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#111325]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([fdo#108566]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-kbl6/igt@i915_suspend@sysfs-reader.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-kbl6/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen:
- shard-snb: [PASS][33] -> [SKIP][34] ([fdo#109271]) +5 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-snb1/igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-snb2/igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#105363])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-panning-vs-hang-interruptible:
- shard-iclb: [PASS][37] -> [INCOMPLETE][38] ([fdo#107713])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb6/igt@kms_flip@flip-vs-panning-vs-hang-interruptible.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb4/igt@kms_flip@flip-vs-panning-vs-hang-interruptible.html
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#100368])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl7/igt@kms_flip@plain-flip-ts-check-interruptible.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-iclb: [PASS][41] -> [FAIL][42] ([fdo#103167]) +5 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-modesetfrombusy.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-modesetfrombusy.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-iclb: [PASS][43] -> [INCOMPLETE][44] ([fdo#106978] / [fdo#107713])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][45] -> [FAIL][46] ([fdo#108145] / [fdo#110403])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-skl: [PASS][47] -> [DMESG-WARN][48] ([fdo#106885])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl4/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl4/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html
* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-glk: [PASS][49] -> [INCOMPLETE][50] ([fdo#103359] / [k.org#198133])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-glk3/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-glk2/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][51] -> [FAIL][52] ([fdo#99912])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-apl6/igt@kms_setmode@basic.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-apl2/igt@kms_setmode@basic.html
* igt@perf_pmu@rc6:
- shard-kbl: [PASS][53] -> [SKIP][54] ([fdo#109271])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-kbl3/igt@perf_pmu@rc6.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-kbl7/igt@perf_pmu@rc6.html
* igt@prime_vgem@busy-bsd:
- shard-hsw: [PASS][55] -> [SKIP][56] ([fdo#109271]) +6 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-hsw2/igt@prime_vgem@busy-bsd.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-hsw2/igt@prime_vgem@busy-bsd.html
* igt@prime_vgem@sync-bsd:
- shard-apl: [PASS][57] -> [SKIP][58] ([fdo#109271]) +17 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-apl3/igt@prime_vgem@sync-bsd.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-apl7/igt@prime_vgem@sync-bsd.html
#### Possible fixes ####
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [SKIP][59] ([fdo#111325]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb6/igt@gem_exec_async@concurrent-writes-bsd.html
* igt@gem_exec_blt@dumb-buf-min:
- shard-apl: [INCOMPLETE][61] ([fdo#103927]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-apl1/igt@gem_exec_blt@dumb-buf-min.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-apl3/igt@gem_exec_blt@dumb-buf-min.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][63] ([fdo#108566]) -> [PASS][64] +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-apl5/igt@gem_softpin@noreloc-s3.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-apl8/igt@gem_softpin@noreloc-s3.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][65] ([fdo#108566]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled:
- shard-skl: [FAIL][67] ([fdo#103184] / [fdo#103232] / [fdo#108472]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl3/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [FAIL][69] ([fdo#105363]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-panning-interruptible:
- shard-hsw: [INCOMPLETE][71] ([fdo#103540]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-hsw7/igt@kms_flip@flip-vs-panning-interruptible.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-hsw4/igt@kms_flip@flip-vs-panning-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][73] ([fdo#103167]) -> [PASS][74] +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][75] ([fdo#104108] / [fdo#106978]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl4/igt@kms_frontbuffer_tracking@psr-suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl4/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][77] ([fdo#108145]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][79] ([fdo#109441]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_setmode@basic:
- shard-skl: [FAIL][81] ([fdo#99912]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-skl6/igt@kms_setmode@basic.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-skl1/igt@kms_setmode@basic.html
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-iclb: [FAIL][83] ([fdo#105010]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb6/igt@perf_pmu@rc6-runtime-pm-long.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb2/igt@perf_pmu@rc6-runtime-pm-long.html
- shard-apl: [FAIL][85] ([fdo#105010]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-apl7/igt@perf_pmu@rc6-runtime-pm-long.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-apl1/igt@perf_pmu@rc6-runtime-pm-long.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][87] ([fdo#109276]) -> [PASS][88] +13 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][89] ([fdo#111329]) -> [SKIP][90] ([fdo#109276])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_shared@exec-single-timeline-bsd1:
- shard-iclb: [FAIL][91] ([fdo#111327]) -> [SKIP][92] ([fdo#109276])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [FAIL][93] ([fdo#110946]) -> [SKIP][94] ([fdo#109276])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb4/igt@gem_exec_schedule@independent-bsd2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb3/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][95] ([fdo#111330]) -> [SKIP][96] ([fdo#109276])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb2/igt@gem_mocs_settings@mocs-reset-bsd2.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb8/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [SKIP][97] ([fdo#109276]) -> [FAIL][98] ([fdo#111330])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb8/igt@gem_mocs_settings@mocs-settings-bsd2.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb1/igt@gem_mocs_settings@mocs-settings-bsd2.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][99] ([fdo#109349]) -> [DMESG-WARN][100] ([fdo#107724])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6667/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13935/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/i915: Check for a second VCS engine more carefully
2019-08-09 9:10 [CI 1/3] drm/i915: Check for a second VCS engine more carefully Chris Wilson
@ 2019-08-09 12:31 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2019-08-09 12:31 UTC (permalink / raw)
To: intel-gfx
To use the legacy BSD selector, you must have a second VCS engine, or
else the ABI simply maps the request for another engine onto VCS0.
However, we only checked a single VCS1 location and overlooking the
possibility of a sparse VCS set being mapped to the dense ABI.
v2: num_vcs_engines() turns out to be reusable and futureproof it so we
never have to worry about this silly bit of ABI again!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
Off-by-one in the VCS mask, we don't want to include VECS0!
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 566e8a4844cf..e3be6b039db7 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -2102,6 +2102,12 @@ static int eb_submit(struct i915_execbuffer *eb)
return 0;
}
+static int num_vcs_engines(const struct drm_i915_private *i915)
+{
+ return hweight64(INTEL_INFO(i915)->engine_mask &
+ GENMASK_ULL(VCS0 + I915_MAX_VCS - 1, VCS0));
+}
+
/*
* Find one BSD ring to dispatch the corresponding BSD command.
* The engine index is returned.
@@ -2200,7 +2206,7 @@ eb_select_legacy_ring(struct i915_execbuffer *eb,
return -1;
}
- if (user_ring_id == I915_EXEC_BSD && HAS_ENGINE(i915, VCS1)) {
+ if (user_ring_id == I915_EXEC_BSD && num_vcs_engines(i915) > 1) {
unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;
if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
--
2.23.0.rc1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-08-10 4:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 5:13 [PATCH] drm/i915: Check for a second VCS engine more carefully Chris Wilson
2019-08-09 5:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-09 8:57 ` [PATCH] " Joonas Lahtinen
2019-08-09 9:03 ` [PATCH v2] " Chris Wilson
2019-08-09 11:31 ` ✓ Fi.CI.BAT: success for drm/i915: Check for a second VCS engine more carefully (rev2) Patchwork
2019-08-09 16:46 ` ✓ Fi.CI.IGT: success for drm/i915: Check for a second VCS engine more carefully Patchwork
2019-08-10 4:04 ` ✗ Fi.CI.IGT: failure for drm/i915: Check for a second VCS engine more carefully (rev2) Patchwork
2019-08-09 9:10 [CI 1/3] drm/i915: Check for a second VCS engine more carefully Chris Wilson
2019-08-09 12:31 ` [PATCH] " Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.