* [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
@ 2019-08-08 17:22 Chris Wilson
2019-08-08 21:38 ` ✓ Fi.CI.BAT: success for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Chris Wilson @ 2019-08-08 17:22 UTC (permalink / raw)
To: intel-gfx
Cc: linux-fsdevel, linux-kernel, Chris Wilson, Sergey Senozhatsky,
Sedat Dilek, Hugh Dickins, Matthew Auld, Al Viro
The filesystem reconfigure API is undergoing a transition, breaking our
current code. As we only set the default options, we can simply remove
the call to s_op->remount_fs(). In the future, when HW permits, we can
try re-enabling huge page support, albeit as suggested with new per-file
controls.
Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Suggested-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
drivers/gpu/drm/i915/gem/i915_gemfs.c | 31 ++++++++-------------------
1 file changed, 9 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c
index 099f3397aada..be94598cb304 100644
--- a/drivers/gpu/drm/i915/gem/i915_gemfs.c
+++ b/drivers/gpu/drm/i915/gem/i915_gemfs.c
@@ -20,31 +20,18 @@ int i915_gemfs_init(struct drm_i915_private *i915)
if (!type)
return -ENODEV;
- gemfs = kern_mount(type);
- if (IS_ERR(gemfs))
- return PTR_ERR(gemfs);
-
/*
- * Enable huge-pages for objects that are at least HPAGE_PMD_SIZE, most
- * likely 2M. Note that within_size may overallocate huge-pages, if say
- * we allocate an object of size 2M + 4K, we may get 2M + 2M, but under
- * memory pressure shmem should split any huge-pages which can be
- * shrunk.
+ * By creating our own shmemfs mountpoint, we can pass in
+ * mount flags that better match our usecase.
+ *
+ * One example, although it is probably better with a per-file
+ * control, is selecting huge page allocations ("huge=within").
+ * Currently unused due to bandwidth issues (slow reads) on Broadwell+.
*/
- if (has_transparent_hugepage()) {
- struct super_block *sb = gemfs->mnt_sb;
- /* FIXME: Disabled until we get W/A for read BW issue. */
- char options[] = "huge=never";
- int flags = 0;
- int err;
-
- err = sb->s_op->remount_fs(sb, &flags, options);
- if (err) {
- kern_unmount(gemfs);
- return err;
- }
- }
+ gemfs = kern_mount(type);
+ if (IS_ERR(gemfs))
+ return PTR_ERR(gemfs);
i915->mm.gemfs = gemfs;
--
2.23.0.rc1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Stop reconfiguring our shmemfs mountpoint
2019-08-08 17:22 [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint Chris Wilson
@ 2019-08-08 21:38 ` Patchwork
2019-08-08 21:56 ` [PATCH] " Hugh Dickins
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2019-08-08 21:38 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Stop reconfiguring our shmemfs mountpoint
URL : https://patchwork.freedesktop.org/series/64922/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6658 -> Patchwork_13926
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/
Known issues
------------
Here are the changes found in Patchwork_13926 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_execlists:
- fi-skl-gvtdvm: [PASS][1] -> [DMESG-FAIL][2] ([fdo#111108])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
* igt@kms_busy@basic-flip-c:
- fi-kbl-7500u: [PASS][3] -> [SKIP][4] ([fdo#109271] / [fdo#109278]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: [PASS][5] -> [WARN][6] ([fdo#109380])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#103167])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-kbl-7567u: [PASS][9] -> [SKIP][10] ([fdo#109271]) +23 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
* igt@prime_vgem@basic-fence-wait-default:
- fi-icl-u3: [PASS][11] -> [DMESG-WARN][12] ([fdo#107724])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-icl-u3/igt@prime_vgem@basic-fence-wait-default.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-icl-u3/igt@prime_vgem@basic-fence-wait-default.html
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-cml-u2: [INCOMPLETE][13] ([fdo#110566]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-cml-u2/igt@gem_ctx_create@basic-files.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-cml-u2/igt@gem_ctx_create@basic-files.html
* igt@i915_module_load@reload:
- fi-blb-e6850: [INCOMPLETE][15] ([fdo#107718]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-blb-e6850/igt@i915_module_load@reload.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-blb-e6850/igt@i915_module_load@reload.html
- fi-icl-u3: [DMESG-WARN][17] ([fdo#107724]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-icl-u3/igt@i915_module_load@reload.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-icl-u3/igt@i915_module_load@reload.html
* igt@i915_module_load@reload-no-display:
- fi-whl-u: [INCOMPLETE][19] -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-whl-u/igt@i915_module_load@reload-no-display.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-whl-u/igt@i915_module_load@reload-no-display.html
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: [SKIP][21] ([fdo#109271] / [fdo#109278]) -> [PASS][22] +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
[fdo#111155]: https://bugs.freedesktop.org/show_bug.cgi?id=111155
Participating hosts (54 -> 46)
------------------------------
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6658 -> Patchwork_13926
CI-20190529: 20190529
CI_DRM_6658: e41ece75bb6eefa046aa90827b8459412cf00f17 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5127: f43f5fa12ac1b93febfe3eeb9e9985f5f3e2eff0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13926: 263fe0abaafcbd3597c4db74c6b2f59ce18bfc97 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
263fe0abaafc drm/i915: Stop reconfiguring our shmemfs mountpoint
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
2019-08-08 17:22 [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint Chris Wilson
2019-08-08 21:38 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-08-08 21:56 ` Hugh Dickins
2019-08-09 10:16 ` ✓ Fi.CI.IGT: success for " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Hugh Dickins @ 2019-08-08 21:56 UTC (permalink / raw)
To: Chris Wilson
Cc: intel-gfx, linux-fsdevel, linux-kernel, Sergey Senozhatsky,
Sedat Dilek, Hugh Dickins, Matthew Auld, Al Viro
On Thu, 8 Aug 2019, Chris Wilson wrote:
> + * By creating our own shmemfs mountpoint, we can pass in
> + * mount flags that better match our usecase.
> + *
> + * One example, although it is probably better with a per-file
> + * control, is selecting huge page allocations ("huge=within").
s/within/within_size/
Not that either of us is recommending that direction,
but since it's mentioned, better to give the correct name.
> + * Currently unused due to bandwidth issues (slow reads) on Broadwell+.
Thanks,
Hugh
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Stop reconfiguring our shmemfs mountpoint
2019-08-08 17:22 [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint Chris Wilson
2019-08-08 21:38 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-08 21:56 ` [PATCH] " Hugh Dickins
@ 2019-08-09 10:16 ` Patchwork
2019-08-09 18:47 ` Matthew Auld
2019-08-12 7:11 ` Sergey Senozhatsky
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2019-08-09 10:16 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Stop reconfiguring our shmemfs mountpoint
URL : https://patchwork.freedesktop.org/series/64922/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6658_full -> Patchwork_13926_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13926_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@unwedge-stress:
- shard-snb: [PASS][1] -> [FAIL][2] ([fdo#109661]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-snb5/igt@gem_eio@unwedge-stress.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-snb5/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb8/igt@gem_exec_schedule@reorder-wide-bsd.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-skl: [PASS][5] -> [INCOMPLETE][6] ([fdo#104108])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-skl10/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-skl2/igt@gem_exec_suspend@basic-s3.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#103184] / [fdo#103232] / [fdo#108472])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-skl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [PASS][9] -> [INCOMPLETE][10] ([fdo#103540])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-hsw1/igt@kms_flip@flip-vs-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-hsw2/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#108566]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-apl5/igt@kms_frontbuffer_tracking@fbc-suspend.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-apl5/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145] / [fdo#110403])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-skl: [PASS][17] -> [DMESG-WARN][18] ([fdo#106885])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-skl2/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-skl2/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-glk: [PASS][21] -> [DMESG-FAIL][22] ([fdo#105763] / [fdo#106538])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-glk6/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-glk4/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-apl: [PASS][23] -> [FAIL][24] ([fdo#105010])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-apl6/igt@perf_pmu@rc6-runtime-pm-long.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-apl4/igt@perf_pmu@rc6-runtime-pm-long.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109276]) +14 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][27] ([fdo#110841]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_await@wide-all:
- shard-iclb: [FAIL][29] ([fdo#110946]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb2/igt@gem_exec_await@wide-all.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb6/igt@gem_exec_await@wide-all.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][31] ([fdo#111325]) -> [PASS][32] +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb2/igt@gem_exec_schedule@preemptive-hang-bsd.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@i915_pm_rpm@i2c:
- shard-hsw: [FAIL][33] ([fdo#104097]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-hsw2/igt@i915_pm_rpm@i2c.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-hsw8/igt@i915_pm_rpm@i2c.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][35] ([fdo#108566]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][37] ([fdo#105363]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +5 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [INCOMPLETE][41] ([fdo#103665]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [DMESG-WARN][43] ([fdo#108566]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][45] ([fdo#108145]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][47] ([fdo#108145] / [fdo#110403]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][49] ([fdo#109642] / [fdo#111068]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][51] ([fdo#109441]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
* igt@perf@blocking:
- shard-skl: [FAIL][53] ([fdo#110728]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-skl7/igt@perf@blocking.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-skl10/igt@perf@blocking.html
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-skl: [FAIL][55] ([fdo#105010]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-skl9/igt@perf_pmu@rc6-runtime-pm-long.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-skl1/igt@perf_pmu@rc6-runtime-pm-long.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][57] ([fdo#109276]) -> [PASS][58] +20 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb5/igt@prime_busy@hang-bsd2.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb2/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_ctx_shared@exec-single-timeline-bsd1:
- shard-iclb: [SKIP][59] ([fdo#109276]) -> [FAIL][60] ([fdo#111327]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
* igt@gem_exec_schedule@independent-bsd1:
- shard-iclb: [SKIP][61] ([fdo#109276]) -> [FAIL][62] ([fdo#110946])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb3/igt@gem_exec_schedule@independent-bsd1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb4/igt@gem_exec_schedule@independent-bsd1.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [FAIL][63] ([fdo#110946]) -> [SKIP][64] ([fdo#109276])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb7/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [SKIP][65] ([fdo#109276]) -> [FAIL][66] ([fdo#111330])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6658/shard-iclb8/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/shard-iclb2/igt@gem_mocs_settings@mocs-isolation-bsd2.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110946]: https://bugs.freedesktop.org/show_bug.cgi?id=110946
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111327]: https://bugs.freedesktop.org/show_bug.cgi?id=111327
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6658 -> Patchwork_13926
CI-20190529: 20190529
CI_DRM_6658: e41ece75bb6eefa046aa90827b8459412cf00f17 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5127: f43f5fa12ac1b93febfe3eeb9e9985f5f3e2eff0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13926: 263fe0abaafcbd3597c4db74c6b2f59ce18bfc97 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13926/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
2019-08-08 17:22 [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint Chris Wilson
@ 2019-08-09 18:47 ` Matthew Auld
2019-08-08 21:56 ` [PATCH] " Hugh Dickins
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Matthew Auld @ 2019-08-09 18:47 UTC (permalink / raw)
To: Chris Wilson
Cc: Intel Graphics Development, Sedat Dilek, Hugh Dickins,
kernel list, Sergey Senozhatsky, Matthew Auld, linux-fsdevel,
Al Viro
On Thu, 8 Aug 2019 at 18:23, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> The filesystem reconfigure API is undergoing a transition, breaking our
> current code. As we only set the default options, we can simply remove
> the call to s_op->remount_fs(). In the future, when HW permits, we can
> try re-enabling huge page support, albeit as suggested with new per-file
> controls.
>
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Suggested-by: Hugh Dickins <hughd@google.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
@ 2019-08-09 18:47 ` Matthew Auld
0 siblings, 0 replies; 11+ messages in thread
From: Matthew Auld @ 2019-08-09 18:47 UTC (permalink / raw)
To: Chris Wilson
Cc: Intel Graphics Development, Hugh Dickins, kernel list,
Sergey Senozhatsky, Matthew Auld, Sedat Dilek, linux-fsdevel,
Al Viro
On Thu, 8 Aug 2019 at 18:23, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> The filesystem reconfigure API is undergoing a transition, breaking our
> current code. As we only set the default options, we can simply remove
> the call to s_op->remount_fs(). In the future, when HW permits, we can
> try re-enabling huge page support, albeit as suggested with new per-file
> controls.
>
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Suggested-by: Hugh Dickins <hughd@google.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
2019-08-09 18:47 ` Matthew Auld
(?)
@ 2019-08-09 18:52 ` Chris Wilson
2019-08-09 20:11 ` Sedat Dilek
-1 siblings, 1 reply; 11+ messages in thread
From: Chris Wilson @ 2019-08-09 18:52 UTC (permalink / raw)
To: Matthew Auld
Cc: Intel Graphics Development, Sedat Dilek, Hugh Dickins,
kernel list, Sergey Senozhatsky, Matthew Auld, linux-fsdevel,
Al Viro
Quoting Matthew Auld (2019-08-09 19:47:02)
> On Thu, 8 Aug 2019 at 18:23, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > The filesystem reconfigure API is undergoing a transition, breaking our
> > current code. As we only set the default options, we can simply remove
> > the call to s_op->remount_fs(). In the future, when HW permits, we can
> > try re-enabling huge page support, albeit as suggested with new per-file
> > controls.
> >
> > Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> > Suggested-by: Hugh Dickins <hughd@google.com>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Matthew Auld <matthew.auld@intel.com>
> > Cc: Hugh Dickins <hughd@google.com>
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Thanks, picked up with the s/within/within_size/ fix.
-Chris
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
2019-08-09 18:52 ` [Intel-gfx] " Chris Wilson
@ 2019-08-09 20:11 ` Sedat Dilek
0 siblings, 0 replies; 11+ messages in thread
From: Sedat Dilek @ 2019-08-09 20:11 UTC (permalink / raw)
To: Chris Wilson
Cc: Matthew Auld, Intel Graphics Development, Hugh Dickins,
kernel list, Sergey Senozhatsky, Matthew Auld, linux-fsdevel,
Al Viro
On Fri, Aug 9, 2019 at 8:52 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Matthew Auld (2019-08-09 19:47:02)
> > On Thu, 8 Aug 2019 at 18:23, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > The filesystem reconfigure API is undergoing a transition, breaking our
> > > current code. As we only set the default options, we can simply remove
> > > the call to s_op->remount_fs(). In the future, when HW permits, we can
> > > try re-enabling huge page support, albeit as suggested with new per-file
> > > controls.
> > >
> > > Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> > > Suggested-by: Hugh Dickins <hughd@google.com>
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Matthew Auld <matthew.auld@intel.com>
> > > Cc: Hugh Dickins <hughd@google.com>
> > > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
> Thanks, picked up with the s/within/within_size/ fix.
> -Chris
For the records and followers:
[1] https://cgit.freedesktop.org/drm-intel/commit/?h=for-linux-next&id=72e67f04637432f91e4cc5e8e4f7eb4e38461e8e
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
2019-08-08 17:22 [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint Chris Wilson
` (3 preceding siblings ...)
2019-08-09 18:47 ` Matthew Auld
@ 2019-08-12 7:11 ` Sergey Senozhatsky
2019-08-12 7:13 ` Chris Wilson
4 siblings, 1 reply; 11+ messages in thread
From: Sergey Senozhatsky @ 2019-08-12 7:11 UTC (permalink / raw)
To: Chris Wilson
Cc: intel-gfx, linux-fsdevel, linux-kernel, Sergey Senozhatsky,
Sedat Dilek, Hugh Dickins, Matthew Auld, Al Viro
On (08/08/19 18:22), Chris Wilson wrote:
[..]
> @@ -20,31 +20,18 @@ int i915_gemfs_init(struct drm_i915_private *i915)
> if (!type)
> return -ENODEV;
[..]
> + gemfs = kern_mount(type);
> + if (IS_ERR(gemfs))
> + return PTR_ERR(gemfs);
>
> i915->mm.gemfs = gemfs;
We still have to put_filesystem(). Right?
-ss
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
2019-08-12 7:11 ` Sergey Senozhatsky
@ 2019-08-12 7:13 ` Chris Wilson
0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2019-08-12 7:13 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: intel-gfx, linux-fsdevel, linux-kernel, Sergey Senozhatsky,
Sedat Dilek, Hugh Dickins, Matthew Auld, Al Viro
Quoting Sergey Senozhatsky (2019-08-12 08:11:48)
> On (08/08/19 18:22), Chris Wilson wrote:
> [..]
> > @@ -20,31 +20,18 @@ int i915_gemfs_init(struct drm_i915_private *i915)
> > if (!type)
> > return -ENODEV;
> [..]
> > + gemfs = kern_mount(type);
> > + if (IS_ERR(gemfs))
> > + return PTR_ERR(gemfs);
> >
> > i915->mm.gemfs = gemfs;
>
> We still have to put_filesystem(). Right?
Yes. We still your patches for EXPORT_SYMBOL.
-Chris
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint
@ 2019-08-12 7:13 ` Chris Wilson
0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2019-08-12 7:13 UTC (permalink / raw)
Cc: intel-gfx, linux-fsdevel, linux-kernel, Sergey Senozhatsky,
Sedat Dilek, Hugh Dickins, Matthew Auld, Al Viro
Quoting Sergey Senozhatsky (2019-08-12 08:11:48)
> On (08/08/19 18:22), Chris Wilson wrote:
> [..]
> > @@ -20,31 +20,18 @@ int i915_gemfs_init(struct drm_i915_private *i915)
> > if (!type)
> > return -ENODEV;
> [..]
> > + gemfs = kern_mount(type);
> > + if (IS_ERR(gemfs))
> > + return PTR_ERR(gemfs);
> >
> > i915->mm.gemfs = gemfs;
>
> We still have to put_filesystem(). Right?
Yes. We still your patches for EXPORT_SYMBOL.
-Chris
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-08-12 7:13 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08 17:22 [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint Chris Wilson
2019-08-08 21:38 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-08 21:56 ` [PATCH] " Hugh Dickins
2019-08-09 10:16 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-08-09 18:47 ` [Intel-gfx] [PATCH] " Matthew Auld
2019-08-09 18:47 ` Matthew Auld
2019-08-09 18:52 ` [Intel-gfx] " Chris Wilson
2019-08-09 20:11 ` Sedat Dilek
2019-08-12 7:11 ` Sergey Senozhatsky
2019-08-12 7:13 ` Chris Wilson
2019-08-12 7:13 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.