From: chris@chris-wilson.co.uk (Chris Wilson) Subject: [PATCH] Revert "nvme-pci: use host managed power state for suspend" Date: Fri, 16 Aug 2019 15:12:11 +0100 [thread overview] Message-ID: <156596473180.11610.10618280744615593681@skylake-alporthouse-com> (raw) In-Reply-To: <CAOSXXT54LyxmF7sAgfxYr7G_vnvDjhiEiHnVm7Zrm1vjS7zLQA@mail.gmail.com> Quoting Keith Busch (2019-08-16 13:46:41) > On Fri, Aug 16, 2019@6:38 AM Christoph Hellwig <hch@lst.de> wrote: > > On Fri, Aug 16, 2019@01:30:29PM +0100, Chris Wilson wrote: > > > Quoting Christoph Hellwig (2019-08-16 13:26:44) > > > > Please, report the actual problem. Blindly reverting a patch without > > > > even an explanation of your regressions is not the way to do it. > > > > > > As stated, the system doesn't suspend. > > > > > > If you would like to wait, you will get test results from our CI > > > giving the current failed state and the outcome of the patch. > > > > Platform type, SSD vendor and type, firmware version? Which platform were you interested in, and is that information not present in the debug log? The issue is observed across multiple different SSD and vendors. > Also not a fan of knee-jerk reverts. Even if it may turn out to be > necessary, let's at least start with a bug report for an opportunity > to fix first! I just did report that we successfully bisected the earlier bug we reported, and was testing a revert for our CI. > Could you please try Rafael's solution? These two commits here: > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=xps13-9380-20190812&id=accd2dd72c8f087441d725dd916688171519e4e6 > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=xps13-9380-20190812&id=4eaefe8c621c6195c91044396ed8060c179f7aae Which indeed work, thank you. -Chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk> To: Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@gmail.com> Cc: Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>, intel-gfx@lists.freedesktop.org, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, linux-nvme <linux-nvme@lists.infradead.org>, Keith Busch <keith.busch@intel.com>, Keith Busch <kbusch@kernel.org> Subject: Re: [PATCH] Revert "nvme-pci: use host managed power state for suspend" Date: Fri, 16 Aug 2019 15:12:11 +0100 [thread overview] Message-ID: <156596473180.11610.10618280744615593681@skylake-alporthouse-com> (raw) In-Reply-To: <CAOSXXT54LyxmF7sAgfxYr7G_vnvDjhiEiHnVm7Zrm1vjS7zLQA@mail.gmail.com> Quoting Keith Busch (2019-08-16 13:46:41) > On Fri, Aug 16, 2019 at 6:38 AM Christoph Hellwig <hch@lst.de> wrote: > > On Fri, Aug 16, 2019 at 01:30:29PM +0100, Chris Wilson wrote: > > > Quoting Christoph Hellwig (2019-08-16 13:26:44) > > > > Please, report the actual problem. Blindly reverting a patch without > > > > even an explanation of your regressions is not the way to do it. > > > > > > As stated, the system doesn't suspend. > > > > > > If you would like to wait, you will get test results from our CI > > > giving the current failed state and the outcome of the patch. > > > > Platform type, SSD vendor and type, firmware version? Which platform were you interested in, and is that information not present in the debug log? The issue is observed across multiple different SSD and vendors. > Also not a fan of knee-jerk reverts. Even if it may turn out to be > necessary, let's at least start with a bug report for an opportunity > to fix first! I just did report that we successfully bisected the earlier bug we reported, and was testing a revert for our CI. > Could you please try Rafael's solution? These two commits here: > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=xps13-9380-20190812&id=accd2dd72c8f087441d725dd916688171519e4e6 > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=xps13-9380-20190812&id=4eaefe8c621c6195c91044396ed8060c179f7aae Which indeed work, thank you. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-16 14:12 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-16 12:15 [PATCH] Revert "nvme-pci: use host managed power state for suspend" Chris Wilson 2019-08-16 12:15 ` Chris Wilson 2019-08-16 12:26 ` Christoph Hellwig 2019-08-16 12:26 ` Christoph Hellwig 2019-08-16 12:30 ` Chris Wilson 2019-08-16 12:30 ` Chris Wilson 2019-08-16 12:38 ` Christoph Hellwig 2019-08-16 12:38 ` Christoph Hellwig 2019-08-16 12:46 ` Keith Busch 2019-08-16 12:46 ` Keith Busch 2019-08-16 14:12 ` Chris Wilson [this message] 2019-08-16 14:12 ` Chris Wilson 2019-08-16 14:26 ` Keith Busch 2019-08-16 14:26 ` Keith Busch 2019-08-16 16:59 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=156596473180.11610.10618280744615593681@skylake-alporthouse-com \ --to=chris@chris-wilson.co.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.