From: Raphael Norwitz <raphael.norwitz@nutanix.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" <mst@redhat.com>, Raphael Norwitz <raphael.norwitz@nutanix.com> Subject: [Qemu-devel] [PATCH 2/2] backends/vhost-user.c: prevent using uninitialized vqs Date: Thu, 22 Aug 2019 11:34:25 -0700 [thread overview] Message-ID: <1566498865-55506-2-git-send-email-raphael.norwitz@nutanix.com> (raw) In-Reply-To: <1566498865-55506-1-git-send-email-raphael.norwitz@nutanix.com> Similar rational to: e6cc11d64fc998c11a4dfcde8fda3fc33a74d844 For vhost scsi and vhost-user-scsi an issue was observed where, of the 3 virtqueues, seabios would only set cmd, leaving ctrl and event without a physical address. This can caused vhost_verify_ring_part_mapping to return ENOMEM, causing the following logs: qemu-system-x86_64: Unable to map available ring for ring 0 qemu-system-x86_64: Verify ring failure on region 0 The issue has already been fixed elsewhere, but it was noted that in backends/vhost-user.c, the vhost_user_backend_dev_init() function, which other vdevs use in their realize() to initialize their vqs, was not being properly zeroing out the queues. This commit ensures hardware modules using the vhost_user_backend_dev_init() API properly zero out their vqs on initialization. Suggested-by: Philippe Mathieu-Daude <philmd@redhat.com> Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com> --- backends/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/vhost-user.c b/backends/vhost-user.c index 0a13506..2bf3406 100644 --- a/backends/vhost-user.c +++ b/backends/vhost-user.c @@ -46,7 +46,7 @@ vhost_user_backend_dev_init(VhostUserBackend *b, VirtIODevice *vdev, b->vdev = vdev; b->dev.nvqs = nvqs; - b->dev.vqs = g_new(struct vhost_virtqueue, nvqs); + b->dev.vqs = g_new0(struct vhost_virtqueue, nvqs); ret = vhost_dev_init(&b->dev, &b->vhost_user, VHOST_BACKEND_TYPE_USER, 0); if (ret < 0) { -- 1.9.4
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: qemu-devel@nongnu.org Cc: Peter Maydell <peter.maydell@linaro.org>, Philippe Mathieu-Daude <philmd@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Raphael Norwitz <raphael.norwitz@nutanix.com> Subject: [Qemu-devel] [PULL 04/10] backends/vhost-user.c: prevent using uninitialized vqs Date: Tue, 17 Sep 2019 11:10:49 -0400 [thread overview] Message-ID: <1566498865-55506-2-git-send-email-raphael.norwitz@nutanix.com> (raw) Message-ID: <20190917151049.0OTxS_DataignyoJ220RACDjRnokt_hR3TwU5Y8ZZm0@z> (raw) In-Reply-To: <20190917151011.24588-1-mst@redhat.com> From: Raphael Norwitz <raphael.norwitz@nutanix.com> Similar rational to: e6cc11d64fc998c11a4dfcde8fda3fc33a74d844 For vhost scsi and vhost-user-scsi an issue was observed where, of the 3 virtqueues, seabios would only set cmd, leaving ctrl and event without a physical address. This can caused vhost_verify_ring_part_mapping to return ENOMEM, causing the following logs: qemu-system-x86_64: Unable to map available ring for ring 0 qemu-system-x86_64: Verify ring failure on region 0 The issue has already been fixed elsewhere, but it was noted that in backends/vhost-user.c, the vhost_user_backend_dev_init() function, which other vdevs use in their realize() to initialize their vqs, was not being properly zeroing out the queues. This commit ensures hardware modules using the vhost_user_backend_dev_init() API properly zero out their vqs on initialization. Suggested-by: Philippe Mathieu-Daude <philmd@redhat.com> Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com> Message-Id: <1566498865-55506-2-git-send-email-raphael.norwitz@nutanix.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> --- backends/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/vhost-user.c b/backends/vhost-user.c index 0a13506c98..2bf3406525 100644 --- a/backends/vhost-user.c +++ b/backends/vhost-user.c @@ -46,7 +46,7 @@ vhost_user_backend_dev_init(VhostUserBackend *b, VirtIODevice *vdev, b->vdev = vdev; b->dev.nvqs = nvqs; - b->dev.vqs = g_new(struct vhost_virtqueue, nvqs); + b->dev.vqs = g_new0(struct vhost_virtqueue, nvqs); ret = vhost_dev_init(&b->dev, &b->vhost_user, VHOST_BACKEND_TYPE_USER, 0); if (ret < 0) { -- MST
next prev parent reply other threads:[~2019-08-22 18:40 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-22 18:34 [Qemu-devel] [PATCH 1/2] vhost-user-blk: prevent using uninitialized vqs Raphael Norwitz 2019-09-17 15:10 ` [Qemu-devel] [PULL 03/10] " Michael S. Tsirkin 2019-08-22 18:34 ` Raphael Norwitz [this message] 2019-09-17 15:10 ` [Qemu-devel] [PULL 04/10] backends/vhost-user.c: " Michael S. Tsirkin 2019-08-28 8:29 ` [Qemu-devel] [PATCH 2/2] " Stefan Hajnoczi 2019-08-23 3:43 ` [Qemu-devel] [Qemu-block] [PATCH 1/2] vhost-user-blk: " yuchenlin via Qemu-devel 2019-08-28 8:28 ` [Qemu-devel] " Stefan Hajnoczi -- strict thread matches above, loose matches on Subject: below -- 2019-09-17 15:10 [Qemu-devel] [PULL 00/10] virtio, vhost, pc: features, fixes, cleanups Michael S. Tsirkin 2019-09-19 10:13 ` Peter Maydell 2019-09-16 8:07 [Qemu-devel] [PATCH v3 0/4] intel_iommu: Do sanity check of vfio-pci earlier Peter Xu 2019-09-16 8:07 ` [Qemu-devel] [PATCH v3 1/4] intel_iommu: Sanity check vfio-pci config on machine init done Peter Xu 2019-09-17 15:10 ` [Qemu-devel] [PULL 05/10] " Michael S. Tsirkin 2019-09-16 8:07 ` [Qemu-devel] [PATCH v3 2/4] qdev/machine: Introduce hotplug_allowed hook Peter Xu 2019-09-17 15:10 ` [Qemu-devel] [PULL 06/10] " Michael S. Tsirkin 2019-09-16 8:07 ` [Qemu-devel] [PATCH v3 3/4] pc/q35: Disallow vfio-pci hotplug without VT-d caching mode Peter Xu 2019-09-17 15:11 ` [Qemu-devel] [PULL 07/10] " Michael S. Tsirkin 2019-09-16 8:07 ` [Qemu-devel] [PATCH v3 4/4] intel_iommu: Remove the caching-mode check during flag change Peter Xu 2019-09-17 15:11 ` [Qemu-devel] [PULL 08/10] " Michael S. Tsirkin 2019-09-13 12:06 [Qemu-devel] [PATCH v3] virtio-mmio: implement modern (v2) personality (virtio-1) Sergio Lopez 2019-09-17 15:11 ` [Qemu-devel] [PULL 10/10] " Michael S. Tsirkin 2019-09-16 14:40 ` [Qemu-devel] [PATCH v3] " Cornelia Huck 2019-09-21 7:06 ` [Qemu-devel] [PATCH v3] virtio-mmio: implement modern (v2), " Vasyl Vavrychuk 2019-09-23 13:58 ` Sergio Lopez 2019-09-10 14:03 [Qemu-devel] [PATCH v2] MAINTAINERS: update virtio-rng and virtio-serial maintainer Laurent Vivier 2019-09-17 15:10 ` [Qemu-devel] [PULL 01/10] " Michael S. Tsirkin 2019-08-21 12:16 [Qemu-devel] [PATCH v3] virtio pmem: user document Pankaj Gupta 2019-09-17 15:11 ` [Qemu-devel] [PULL 09/10] " Michael S. Tsirkin 2019-08-26 12:46 ` [Qemu-devel] [PATCH v3] " Cornelia Huck 2019-09-16 6:30 ` Pankaj Gupta 2019-08-01 0:40 [Qemu-devel] [PATCH v2] docs/nvdimm: add example on persistent backend setup Wei Yang 2019-09-17 15:10 ` [Qemu-devel] [PULL 02/10] " Michael S. Tsirkin 2019-08-01 8:05 ` [Qemu-devel] [PATCH v2] " Stefan Hajnoczi 2019-09-11 8:51 ` Wei Yang 2019-09-12 12:16 ` Stefan Hajnoczi 2019-09-12 21:44 ` Wei Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1566498865-55506-2-git-send-email-raphael.norwitz@nutanix.com \ --to=raphael.norwitz@nutanix.com \ --cc=mst@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.