All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Jean Texier <pjtexier@koncepto.io>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] fw_env: fix build error
Date: Fri, 23 Aug 2019 23:03:17 +0200	[thread overview]
Message-ID: <1566594199-25314-3-git-send-email-pjtexier@koncepto.io> (raw)
In-Reply-To: <1566594199-25314-1-git-send-email-pjtexier@koncepto.io>

The following error appears:

tools/env/fw_env.c:1149:25: error: lvalue required as unary ‘&’ operand
  rc = write(fd, &ENV_REDUND_OBSOLETE, sizeof(ENV_REDUND_OBSOLETE));

Fixes: d3716dd ("env: Rename the redundancy flags")

Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
---
 tools/env/fw_env.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
index 876bf2b..b8b936f 100644
--- a/tools/env/fw_env.c
+++ b/tools/env/fw_env.c
@@ -1146,7 +1146,7 @@ static int flash_flag_obsolete(int dev, int fd, off_t offset)
 		return rc;
 	}
 	ioctl(fd, MEMUNLOCK, &erase);
-	rc = write(fd, &ENV_REDUND_OBSOLETE, sizeof(ENV_REDUND_OBSOLETE));
+	rc = write(fd, ENV_REDUND_OBSOLETE, sizeof(ENV_REDUND_OBSOLETE));
 	ioctl(fd, MEMLOCK, &erase);
 	if (rc < 0)
 		perror("Could not set obsolete flag");
-- 
2.7.4

  parent reply	other threads:[~2019-08-23 21:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 21:03 [U-Boot] [PATCH 0/4] env: fix build error for envtools Pierre-Jean Texier
2019-08-23 21:03 ` [U-Boot] [PATCH 1/4] fw_env: remove duplicated definitions Pierre-Jean Texier
2019-08-24  8:50   ` Joris OFFOUGA
2019-08-26  6:56   ` Heiko Schocher
2019-09-03 22:35   ` Joe Hershberger
2019-08-23 21:03 ` Pierre-Jean Texier [this message]
2019-08-24  8:49   ` [U-Boot] [PATCH 2/4] fw_env: fix build error Joris OFFOUGA
2019-08-26  6:57   ` Heiko Schocher
2019-08-26  8:59     ` Heiko Schocher
2019-08-26 10:54       ` Pierre-Jean Texier
2019-08-23 21:03 ` [U-Boot] [PATCH 3/4] env: add missing <compiler.h> header file Pierre-Jean Texier
2019-08-24  8:50   ` Joris OFFOUGA
2019-08-26  6:57   ` Heiko Schocher
2019-08-23 21:03 ` [U-Boot] [PATCH 4/4] ci: add envtools support Pierre-Jean Texier
2019-08-26  6:58   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1566594199-25314-3-git-send-email-pjtexier@koncepto.io \
    --to=pjtexier@koncepto.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.