All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joris OFFOUGA <offougajoris@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] fw_env: remove duplicated definitions
Date: Sat, 24 Aug 2019 10:50:48 +0200	[thread overview]
Message-ID: <CACr73kCXvkX7gMN7O91J+Jh628FLf4bnKV2sk8dft3GPPrOcjA@mail.gmail.com> (raw)
In-Reply-To: <1566594199-25314-2-git-send-email-pjtexier@koncepto.io>

Hi Pierre-Jean

It's work on my side.

Tested-by Joris Offouga <offougajoris@gmail.com>

Best Regards,
Joris Offouga

Le ven. 23 août 2019 à 23:04, Pierre-Jean Texier <pjtexier@koncepto.io> a
écrit :

> Since commit d3716dd ("env: Rename the redundancy flags"), the
> definitions of ENV_REDUND_OBSOLETE & ENV_REDUND_ACTIVE was moved
> to env.h.
>
> Fixes:
>
> tools/env/fw_env.c:122:22: error: ‘ENV_REDUND_ACTIVE’ redeclared as
> different kind of symbol
>  static unsigned char ENV_REDUND_ACTIVE = 1;
>                       ^~~~~~~~~~~~~~~~~
> In file included from tools/env/fw_env.c:13:
> include/env.h:63:2: note: previous definition of ‘ENV_REDUND_ACTIVE’ was
> here
>   ENV_REDUND_ACTIVE = 1,
>   ^~~~~~~~~~~~~~~~~
> tools/env/fw_env.c:127:22: error: ‘ENV_REDUND_OBSOLETE’ redeclared as
> different kind of symbol
>  static unsigned char ENV_REDUND_OBSOLETE;
>                       ^~~~~~~~~~~~~~~~~~~
> In file included from tools/env/fw_env.c:13:
> include/env.h:62:2: note: previous definition of ‘ENV_REDUND_OBSOLETE’ was
> here
>   ENV_REDUND_OBSOLETE = 0,
>
> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> ---
>  tools/env/fw_env.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
> index 95c9984..876bf2b 100644
> --- a/tools/env/fw_env.c
> +++ b/tools/env/fw_env.c
> @@ -119,13 +119,6 @@ static struct environment environment = {
>
>  static int have_redund_env;
>
> -static unsigned char ENV_REDUND_ACTIVE = 1;
> -/*
> - * ENV_REDUND_OBSOLETE must be 0 to efficiently set it on NOR flash
> without
> - * erasing
> - */
> -static unsigned char ENV_REDUND_OBSOLETE;
> -
>  #define DEFAULT_ENV_INSTANCE_STATIC
>  #include <env_default.h>
>
> --
> 2.7.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>

  reply	other threads:[~2019-08-24  8:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 21:03 [U-Boot] [PATCH 0/4] env: fix build error for envtools Pierre-Jean Texier
2019-08-23 21:03 ` [U-Boot] [PATCH 1/4] fw_env: remove duplicated definitions Pierre-Jean Texier
2019-08-24  8:50   ` Joris OFFOUGA [this message]
2019-08-26  6:56   ` Heiko Schocher
2019-09-03 22:35   ` Joe Hershberger
2019-08-23 21:03 ` [U-Boot] [PATCH 2/4] fw_env: fix build error Pierre-Jean Texier
2019-08-24  8:49   ` Joris OFFOUGA
2019-08-26  6:57   ` Heiko Schocher
2019-08-26  8:59     ` Heiko Schocher
2019-08-26 10:54       ` Pierre-Jean Texier
2019-08-23 21:03 ` [U-Boot] [PATCH 3/4] env: add missing <compiler.h> header file Pierre-Jean Texier
2019-08-24  8:50   ` Joris OFFOUGA
2019-08-26  6:57   ` Heiko Schocher
2019-08-23 21:03 ` [U-Boot] [PATCH 4/4] ci: add envtools support Pierre-Jean Texier
2019-08-26  6:58   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACr73kCXvkX7gMN7O91J+Jh628FLf4bnKV2sk8dft3GPPrOcjA@mail.gmail.com \
    --to=offougajoris@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.