* [PATCH v2] coresight: etm4x: Add support for ThunderX2
@ 2019-09-10 6:25 Tanmay Vilas Kumar Jagdale
2019-09-16 19:58 ` Mathieu Poirier
0 siblings, 1 reply; 3+ messages in thread
From: Tanmay Vilas Kumar Jagdale @ 2019-09-10 6:25 UTC (permalink / raw)
To: mathieu.poirier
Cc: Ganapatrao Kulkarni, Tomasz Nowicki, suzuki.poulose,
Jayachandran Chandrasekharan Nair, Tanmay Vilas Kumar Jagdale,
linux-arm-kernel
Add ETMv4 periperhal ID for Marvell's ThunderX2 chip.
This chip contains ETMv4.1 version.
Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
---
Changes since v1:
- Updated commit message.
- Use UCI to identify ETMv4.
- Remove addition of ETMv4.1 version checks.
drivers/hwtracing/coresight/coresight-etm4x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
index a128b5063f46..47839b4a8bc0 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x.c
@@ -1211,6 +1211,7 @@ static const struct amba_id etm4_ids[] = {
CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */
CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */
+ CS_AMBA_UCI_ID(0x000cc0af, uci_id_etm4),/* Marvell ThunderX2 */
{},
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] coresight: etm4x: Add support for ThunderX2
2019-09-10 6:25 [PATCH v2] coresight: etm4x: Add support for ThunderX2 Tanmay Vilas Kumar Jagdale
@ 2019-09-16 19:58 ` Mathieu Poirier
2019-09-17 8:39 ` Suzuki K Poulose
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Poirier @ 2019-09-16 19:58 UTC (permalink / raw)
To: Tanmay Vilas Kumar Jagdale
Cc: Tomasz Nowicki, Jayachandran Chandrasekharan Nair,
Ganapatrao Kulkarni, linux-arm-kernel, suzuki.poulose
On Tue, Sep 10, 2019 at 06:25:02AM +0000, Tanmay Vilas Kumar Jagdale wrote:
> Add ETMv4 periperhal ID for Marvell's ThunderX2 chip.
> This chip contains ETMv4.1 version.
>
> Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
mpoirier@xps15:~/work/coresight/kernel-maint$ ./scripts/checkpatch.pl 0001-coresight-etm4x-Add-support-for-ThunderX2.patch
WARNING: Missing Signed-off-by: line by nominal patch author 'Tanmay Vilas Kumar Jagdale <tanmay@marvell.com>'
total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
0001-coresight-etm4x-Add-support-for-ThunderX2.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS
> ---
> Changes since v1:
> - Updated commit message.
> - Use UCI to identify ETMv4.
> - Remove addition of ETMv4.1 version checks.
>
> drivers/hwtracing/coresight/coresight-etm4x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
> index a128b5063f46..47839b4a8bc0 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
> @@ -1211,6 +1211,7 @@ static const struct amba_id etm4_ids[] = {
> CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
> CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */
> CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */
> + CS_AMBA_UCI_ID(0x000cc0af, uci_id_etm4),/* Marvell ThunderX2 */
> {},
> };
>
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] coresight: etm4x: Add support for ThunderX2
2019-09-16 19:58 ` Mathieu Poirier
@ 2019-09-17 8:39 ` Suzuki K Poulose
0 siblings, 0 replies; 3+ messages in thread
From: Suzuki K Poulose @ 2019-09-17 8:39 UTC (permalink / raw)
To: mathieu.poirier, tanmay; +Cc: tnowicki, jnair, gkulkarni, linux-arm-kernel
Hi Tanmay,
On 16/09/2019 20:58, Mathieu Poirier wrote:
> On Tue, Sep 10, 2019 at 06:25:02AM +0000, Tanmay Vilas Kumar Jagdale wrote:
>> Add ETMv4 periperhal ID for Marvell's ThunderX2 chip.
>> This chip contains ETMv4.1 version.
>>
>> Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
>
> mpoirier@xps15:~/work/coresight/kernel-maint$ ./scripts/checkpatch.pl 0001-coresight-etm4x-Add-support-for-ThunderX2.patch
> WARNING: Missing Signed-off-by: line by nominal patch author 'Tanmay Vilas Kumar Jagdale <tanmay@marvell.com>'
>
To translate that message a bit more, "Signed-off-by:" is kind of a legal
declaration. So, please use your full legal name.
Cheers
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-17 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 6:25 [PATCH v2] coresight: etm4x: Add support for ThunderX2 Tanmay Vilas Kumar Jagdale
2019-09-16 19:58 ` Mathieu Poirier
2019-09-17 8:39 ` Suzuki K Poulose
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.