* [Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373
@ 2019-09-11 13:19 Aleksandar Markovic
2019-09-11 14:20 ` Aleksandar Markovic
0 siblings, 1 reply; 2+ messages in thread
From: Aleksandar Markovic @ 2019-09-11 13:19 UTC (permalink / raw)
To: qemu-devel; +Cc: arikalo, Libo Zhou, amarkovic
From: Libo Zhou <zhlb29@foxmail.com>
Multiple report from users were received regarding failures
of "packet g" comminucation with gdb. Revert this commit until
a better solution is developed.
Suggested-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Libo Zhou <zhlb29@foxmail.com>
Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
---
target/mips/gdbstub.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/mips/gdbstub.c b/target/mips/gdbstub.c
index ebcc98b..bbb2544 100644
--- a/target/mips/gdbstub.c
+++ b/target/mips/gdbstub.c
@@ -38,7 +38,7 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)
return gdb_get_regl(mem_buf, (int32_t)env->active_fpu.fcr0);
default:
if (env->CP0_Status & (1 << CP0St_FR)) {
- return gdb_get_reg64(mem_buf,
+ return gdb_get_regl(mem_buf,
env->active_fpu.fpr[n - 38].d);
} else {
return gdb_get_regl(mem_buf,
@@ -99,7 +99,6 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
break;
default:
if (env->CP0_Status & (1 << CP0St_FR)) {
- uint64_t tmp = ldq_p(mem_buf);
env->active_fpu.fpr[n - 38].d = tmp;
} else {
env->active_fpu.fpr[n - 38].w[FP_ENDIAN_IDX] = tmp;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373
2019-09-11 13:19 [Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373 Aleksandar Markovic
@ 2019-09-11 14:20 ` Aleksandar Markovic
0 siblings, 0 replies; 2+ messages in thread
From: Aleksandar Markovic @ 2019-09-11 14:20 UTC (permalink / raw)
To: Aleksandar Markovic; +Cc: Libo Zhou, arikalo, qemu-devel, amarkovic
11.09.2019. 15.21, "Aleksandar Markovic" <aleksandar.markovic@rt-rk.com> је
написао/ла:
>
> From: Libo Zhou <zhlb29@foxmail.com>
>
> Multiple report from users were received regarding failures
> of "packet g" comminucation with gdb. Revert this commit until
> a better solution is developed.
>
> Suggested-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> Signed-off-by: Libo Zhou <zhlb29@foxmail.com>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> target/mips/gdbstub.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/mips/gdbstub.c b/target/mips/gdbstub.c
> index ebcc98b..bbb2544 100644
> --- a/target/mips/gdbstub.c
> +++ b/target/mips/gdbstub.c
> @@ -38,7 +38,7 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t
*mem_buf, int n)
> return gdb_get_regl(mem_buf, (int32_t)env->active_fpu.fcr0);
> default:
> if (env->CP0_Status & (1 << CP0St_FR)) {
> - return gdb_get_reg64(mem_buf,
> + return gdb_get_regl(mem_buf,
> env->active_fpu.fpr[n - 38].d);
> } else {
> return gdb_get_regl(mem_buf,
> @@ -99,7 +99,6 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t
*mem_buf, int n)
> break;
> default:
> if (env->CP0_Status & (1 << CP0St_FR)) {
> - uint64_t tmp = ldq_p(mem_buf);
> env->active_fpu.fpr[n - 38].d = tmp;
> } else {
> env->active_fpu.fpr[n - 38].w[FP_ENDIAN_IDX] = tmp;
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-11 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 13:19 [Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373 Aleksandar Markovic
2019-09-11 14:20 ` Aleksandar Markovic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.