* [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l
@ 2019-10-04 11:20 Kiran Gunda
2019-10-05 4:38 ` Bjorn Andersson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Kiran Gunda @ 2019-10-04 11:20 UTC (permalink / raw)
To: bjorn.andersson, Andy Gross, Linus Walleij, Rob Herring,
Mark Rutland, linux-arm-msm, linux-gpio, devicetree,
linux-kernel
Cc: Kiran Gunda
Add support for the PM6150 and PM6150L GPIO support to the
Qualcomm PMIC GPIO binding.
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
index c32bf32..2f48cca 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
@@ -23,6 +23,8 @@ PMIC's from Qualcomm.
"qcom,pms405-gpio"
"qcom,pm8150-gpio"
"qcom,pm8150b-gpio"
+ "qcom,pm6150-gpio"
+ "qcom,pm6150l-gpio"
And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
if the device is on an spmi bus or an ssbi bus respectively
@@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
and gpio8)
gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
gpio1-gpio12 for pm8150l (hole on gpio7)
+ gpio1-gpio10 for pm6150
+ gpio1-gpio12 for pm6150l
- function:
Usage: required
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index f1fece5..387917c 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct platform_device *pdev)
{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
/* pm8150l has 12 GPIOs with holes on 7 */
{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
+ { .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
+ { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
{ },
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l
2019-10-04 11:20 [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l Kiran Gunda
@ 2019-10-05 4:38 ` Bjorn Andersson
2019-10-09 9:19 ` Linus Walleij
2019-10-16 8:15 ` Vinod Koul
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2019-10-05 4:38 UTC (permalink / raw)
To: Kiran Gunda
Cc: Andy Gross, Linus Walleij, Rob Herring, Mark Rutland,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Fri 04 Oct 04:20 PDT 2019, Kiran Gunda wrote:
> Add support for the PM6150 and PM6150L GPIO support to the
> Qualcomm PMIC GPIO binding.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index c32bf32..2f48cca 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -23,6 +23,8 @@ PMIC's from Qualcomm.
> "qcom,pms405-gpio"
> "qcom,pm8150-gpio"
> "qcom,pm8150b-gpio"
> + "qcom,pm6150-gpio"
> + "qcom,pm6150l-gpio"
>
> And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
> if the device is on an spmi bus or an ssbi bus respectively
> @@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
> and gpio8)
> gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
> gpio1-gpio12 for pm8150l (hole on gpio7)
> + gpio1-gpio10 for pm6150
> + gpio1-gpio12 for pm6150l
>
> - function:
> Usage: required
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index f1fece5..387917c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct platform_device *pdev)
> { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
> /* pm8150l has 12 GPIOs with holes on 7 */
> { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
> + { .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
> + { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
> { },
> };
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l
2019-10-04 11:20 [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l Kiran Gunda
@ 2019-10-09 9:19 ` Linus Walleij
2019-10-09 9:19 ` Linus Walleij
2019-10-16 8:15 ` Vinod Koul
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2019-10-09 9:19 UTC (permalink / raw)
To: Kiran Gunda
Cc: Bjorn Andersson, Andy Gross, Rob Herring, Mark Rutland, MSM,
open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Fri, Oct 4, 2019 at 1:20 PM Kiran Gunda <kgunda@codeaurora.org> wrote:
> Add support for the PM6150 and PM6150L GPIO support to the
> Qualcomm PMIC GPIO binding.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l
@ 2019-10-09 9:19 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2019-10-09 9:19 UTC (permalink / raw)
To: Kiran Gunda
Cc: Bjorn Andersson, Andy Gross, Rob Herring, Mark Rutland, MSM,
open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Fri, Oct 4, 2019 at 1:20 PM Kiran Gunda <kgunda@codeaurora.org> wrote:
> Add support for the PM6150 and PM6150L GPIO support to the
> Qualcomm PMIC GPIO binding.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l
2019-10-04 11:20 [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l Kiran Gunda
2019-10-05 4:38 ` Bjorn Andersson
2019-10-09 9:19 ` Linus Walleij
@ 2019-10-16 8:15 ` Vinod Koul
2019-10-16 8:48 ` kgunda
2 siblings, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2019-10-16 8:15 UTC (permalink / raw)
To: Kiran Gunda
Cc: bjorn.andersson, Andy Gross, Linus Walleij, Rob Herring,
Mark Rutland, linux-arm-msm, linux-gpio, devicetree,
linux-kernel
On 04-10-19, 16:50, Kiran Gunda wrote:
> Add support for the PM6150 and PM6150L GPIO support to the
> Qualcomm PMIC GPIO binding.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index c32bf32..2f48cca 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -23,6 +23,8 @@ PMIC's from Qualcomm.
> "qcom,pms405-gpio"
> "qcom,pm8150-gpio"
> "qcom,pm8150b-gpio"
> + "qcom,pm6150-gpio"
> + "qcom,pm6150l-gpio"
>
> And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
> if the device is on an spmi bus or an ssbi bus respectively
> @@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
> and gpio8)
> gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
> gpio1-gpio12 for pm8150l (hole on gpio7)
> + gpio1-gpio10 for pm6150
> + gpio1-gpio12 for pm6150l
No holes on these?
Other than this:
Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
> - function:
> Usage: required
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index f1fece5..387917c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct platform_device *pdev)
> { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
> /* pm8150l has 12 GPIOs with holes on 7 */
> { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
> + { .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
> + { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
> { },
> };
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l
2019-10-16 8:15 ` Vinod Koul
@ 2019-10-16 8:48 ` kgunda
0 siblings, 0 replies; 6+ messages in thread
From: kgunda @ 2019-10-16 8:48 UTC (permalink / raw)
To: Vinod Koul
Cc: bjorn.andersson, Andy Gross, Linus Walleij, Rob Herring,
Mark Rutland, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-arm-msm-owner
On 2019-10-16 13:45, Vinod Koul wrote:
> On 04-10-19, 16:50, Kiran Gunda wrote:
>> Add support for the PM6150 and PM6150L GPIO support to the
>> Qualcomm PMIC GPIO binding.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
>> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>> b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>> index c32bf32..2f48cca 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>> @@ -23,6 +23,8 @@ PMIC's from Qualcomm.
>> "qcom,pms405-gpio"
>> "qcom,pm8150-gpio"
>> "qcom,pm8150b-gpio"
>> + "qcom,pm6150-gpio"
>> + "qcom,pm6150l-gpio"
>>
>> And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
>> if the device is on an spmi bus or an ssbi bus respectively
>> @@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
>> and gpio8)
>> gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
>> gpio1-gpio12 for pm8150l (hole on gpio7)
>> + gpio1-gpio10 for pm6150
>> + gpio1-gpio12 for pm6150l
>
> No holes on these?
>
Yes. No holes.
> Other than this:
>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
>>
>> - function:
>> Usage: required
>> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> index f1fece5..387917c 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> @@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct
>> platform_device *pdev)
>> { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
>> /* pm8150l has 12 GPIOs with holes on 7 */
>> { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
>> + { .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
>> + { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
>> { },
>> };
>>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-16 8:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 11:20 [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l Kiran Gunda
2019-10-05 4:38 ` Bjorn Andersson
2019-10-09 9:19 ` Linus Walleij
2019-10-09 9:19 ` Linus Walleij
2019-10-16 8:15 ` Vinod Koul
2019-10-16 8:48 ` kgunda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.