All of lore.kernel.org
 help / color / mirror / Atom feed
From: liu.ming50@gmail.com
To: meta-virtualization@yoctoproject.org
Cc: stefan.agner@toradex.com, Ming Liu <liu.ming50@gmail.com>
Subject: [PATCH] podman: drop selinux sanity check
Date: Mon,  7 Oct 2019 12:45:49 +0200	[thread overview]
Message-ID: <1570445149-7427-1-git-send-email-liu.ming50@gmail.com> (raw)

From: Ming Liu <liu.ming50@gmail.com>

libselinux is not a dependency of podman, drop a useless sanity check.

Also fix some invalid comments.

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 recipes-containers/podman/podman_git.bb | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
index 64e2672..835e4d5 100644
--- a/recipes-containers/podman/podman_git.bb
+++ b/recipes-containers/podman/podman_git.bb
@@ -16,18 +16,12 @@ DEPENDS = " \
 
 python __anonymous() {
     msg = ""
-    # ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
+    # ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/podman/podman_git.bb DEPENDS on or otherwise requires it).
     # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
-    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']
+    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'podman', 'libseccomp']
     if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
         msg += "Make sure meta-security should be present as it provides 'libseccomp'"
         raise bb.parse.SkipRecipe(msg)
-    # ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
-    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
-    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux']
-    elif 'selinux' not in d.getVar('BBFILE_COLLECTIONS').split():
-        msg += "Make sure meta-selinux should be present as it provides 'libselinux'"
-        raise bb.parse.SkipRecipe(msg)
 }
 
 SRCREV = "00057929f5acfd98341964d85722383363376d52"
-- 
2.7.4



             reply	other threads:[~2019-10-07 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 10:45 liu.ming50 [this message]
2019-10-07 12:04 ` [PATCH] podman: drop selinux sanity check Bruce Ashfield
2019-10-07 12:10   ` Ming Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1570445149-7427-1-git-send-email-liu.ming50@gmail.com \
    --to=liu.ming50@gmail.com \
    --cc=meta-virtualization@yoctoproject.org \
    --cc=stefan.agner@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.