[PATCH] podman: drop selinux sanity check

[PATCH] podman: drop selinux sanity check

[liu.ming50]

From: Ming Liu <liu.ming50@gmail.com>

libselinux is not a dependency of podman, drop a useless sanity check.

Also fix some invalid comments.

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 recipes-containers/podman/podman_git.bb | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
index 64e2672..835e4d5 100644
--- a/recipes-containers/podman/podman_git.bb
+++ b/recipes-containers/podman/podman_git.bb
@@ -16,18 +16,12 @@ DEPENDS = " \
 
 python __anonymous() {
     msg = ""
-    # ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
+    # ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/podman/podman_git.bb DEPENDS on or otherwise requires it).
     # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
-    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']
+    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'podman', 'libseccomp']
     if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
         msg += "Make sure meta-security should be present as it provides 'libseccomp'"
         raise bb.parse.SkipRecipe(msg)
-    # ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
-    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
-    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux']
-    elif 'selinux' not in d.getVar('BBFILE_COLLECTIONS').split():
-        msg += "Make sure meta-selinux should be present as it provides 'libselinux'"
-        raise bb.parse.SkipRecipe(msg)
 }
 
 SRCREV = "00057929f5acfd98341964d85722383363376d52"
-- 
2.7.4

Re: [PATCH] podman: drop selinux sanity check

[Bruce Ashfield]

I also have a fix for this, that I hadn't pushed yet.

Will push my change later today.

Cheers,

Bruce

On Mon, Oct 7, 2019 at 6:46 AM <liu.ming50@gmail.com> wrote:
>
> From: Ming Liu <liu.ming50@gmail.com>
>
> libselinux is not a dependency of podman, drop a useless sanity check.
>
> Also fix some invalid comments.
>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
>  recipes-containers/podman/podman_git.bb | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
> index 64e2672..835e4d5 100644
> --- a/recipes-containers/podman/podman_git.bb
> +++ b/recipes-containers/podman/podman_git.bb
> @@ -16,18 +16,12 @@ DEPENDS = " \
>
>  python __anonymous() {
>      msg = ""
> -    # ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
> +    # ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/podman/podman_git.bb DEPENDS on or otherwise requires it).
>      # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> -    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']
> +    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'podman', 'libseccomp']
>      if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
>          msg += "Make sure meta-security should be present as it provides 'libseccomp'"
>          raise bb.parse.SkipRecipe(msg)
> -    # ERROR: Nothing PROVIDES 'libselinux' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it).
> -    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> -    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libselinux']
> -    elif 'selinux' not in d.getVar('BBFILE_COLLECTIONS').split():
> -        msg += "Make sure meta-selinux should be present as it provides 'libselinux'"
> -        raise bb.parse.SkipRecipe(msg)
>  }
>
>  SRCREV = "00057929f5acfd98341964d85722383363376d52"
> --
> 2.7.4
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [PATCH] podman: drop selinux sanity check

[Ming Liu]

[-- Attachment #1: Type: text/plain, Size: 2980 bytes --]

Great! Good to know that, we are currently blocked by this sanity check.

//Ming Liu

Bruce Ashfield <bruce.ashfield@gmail.com> 於 2019年10月7日 週一 下午2:05寫道：

> I also have a fix for this, that I hadn't pushed yet.
>
> Will push my change later today.
>
> Cheers,
>
> Bruce
>
> On Mon, Oct 7, 2019 at 6:46 AM <liu.ming50@gmail.com> wrote:
> >
> > From: Ming Liu <liu.ming50@gmail.com>
> >
> > libselinux is not a dependency of podman, drop a useless sanity check.
> >
> > Also fix some invalid comments.
> >
> > Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> > ---
> >  recipes-containers/podman/podman_git.bb | 10 ++--------
> >  1 file changed, 2 insertions(+), 8 deletions(-)
> >
> > diff --git a/recipes-containers/podman/podman_git.bb
> b/recipes-containers/podman/podman_git.bb
> > index 64e2672..835e4d5 100644
> > --- a/recipes-containers/podman/podman_git.bb
> > +++ b/recipes-containers/podman/podman_git.bb
> > @@ -16,18 +16,12 @@ DEPENDS = " \
> >
> >  python __anonymous() {
> >      msg = ""
> > -    # ERROR: Nothing PROVIDES 'libseccomp' (but
> /buildarea/layers/meta-virtualization/recipes-containers/cri-o/
> cri-o_git.bb DEPENDS on or otherwise requires it).
> > +    # ERROR: Nothing PROVIDES 'libseccomp' (but
> /buildarea/layers/meta-virtualization/recipes-containers/podman/
> podman_git.bb DEPENDS on or otherwise requires it).
> >      # ERROR: Required build target 'meta-world-pkgdata' has no
> buildable providers.
> > -    # Missing or unbuildable dependency chain was:
> ['meta-world-pkgdata', 'cri-o', 'libseccomp']
> > +    # Missing or unbuildable dependency chain was:
> ['meta-world-pkgdata', 'podman', 'libseccomp']
> >      if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
> >          msg += "Make sure meta-security should be present as it
> provides 'libseccomp'"
> >          raise bb.parse.SkipRecipe(msg)
> > -    # ERROR: Nothing PROVIDES 'libselinux' (but
> /buildarea/layers/meta-virtualization/recipes-containers/cri-o/
> cri-o_git.bb DEPENDS on or otherwise requires it).
> > -    # ERROR: Required build target 'meta-world-pkgdata' has no
> buildable providers.
> > -    # Missing or unbuildable dependency chain was:
> ['meta-world-pkgdata', 'cri-o', 'libselinux']
> > -    elif 'selinux' not in d.getVar('BBFILE_COLLECTIONS').split():
> > -        msg += "Make sure meta-selinux should be present as it provides
> 'libselinux'"
> > -        raise bb.parse.SkipRecipe(msg)
> >  }
> >
> >  SRCREV = "00057929f5acfd98341964d85722383363376d52"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > meta-virtualization mailing list
> > meta-virtualization@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>

[-- Attachment #2: Type: text/html, Size: 4681 bytes --]