From: Walter Wu <walter-zh.wu@mediatek.com>
To: Qian Cai <cai@lca.pw>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux-MM <linux-mm@kvack.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
wsd_upstream <wsd_upstream@mediatek.com>
Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y
Date: Tue, 8 Oct 2019 19:02:08 +0800 [thread overview]
Message-ID: <1570532528.4686.102.camel@mtksdccf07> (raw)
In-Reply-To: <B53A3CC0-CEA6-4E1C-BC38-19315D949F38@lca.pw>
On Tue, 2019-10-08 at 05:47 -0400, Qian Cai wrote:
>
> > On Oct 8, 2019, at 2:16 AM, Walter Wu <walter-zh.wu@mediatek.com> wrote:
> >
> > It is an undefined behavior to pass a negative numbers to
> > memset()/memcpy()/memmove(), so need to be detected by KASAN.
>
> Why can’t this be detected by UBSAN?
I don't know very well in UBSAN, but I try to build ubsan kernel and
test a negative number in memset and kmalloc_memmove_invalid_size(), it
look like no check.
WARNING: multiple messages have this Message-ID (diff)
From: Walter Wu <walter-zh.wu@mediatek.com>
To: Qian Cai <cai@lca.pw>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux-MM <linux-mm@kvack.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
wsd_upstream <wsd_upstream@mediatek.com>
Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y
Date: Tue, 8 Oct 2019 19:02:08 +0800 [thread overview]
Message-ID: <1570532528.4686.102.camel@mtksdccf07> (raw)
In-Reply-To: <B53A3CC0-CEA6-4E1C-BC38-19315D949F38@lca.pw>
On Tue, 2019-10-08 at 05:47 -0400, Qian Cai wrote:
>
> > On Oct 8, 2019, at 2:16 AM, Walter Wu <walter-zh.wu@mediatek.com> wrote:
> >
> > It is an undefined behavior to pass a negative numbers to
> > memset()/memcpy()/memmove(), so need to be detected by KASAN.
>
> Why can’t this be detected by UBSAN?
I don't know very well in UBSAN, but I try to build ubsan kernel and
test a negative number in memset and kmalloc_memmove_invalid_size(), it
look like no check.
WARNING: multiple messages have this Message-ID (diff)
From: Walter Wu <walter-zh.wu@mediatek.com>
To: Qian Cai <cai@lca.pw>
Cc: wsd_upstream <wsd_upstream@mediatek.com>,
linux-mediatek@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux-MM <linux-mm@kvack.org>,
Alexander Potapenko <glider@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y
Date: Tue, 8 Oct 2019 19:02:08 +0800 [thread overview]
Message-ID: <1570532528.4686.102.camel@mtksdccf07> (raw)
In-Reply-To: <B53A3CC0-CEA6-4E1C-BC38-19315D949F38@lca.pw>
On Tue, 2019-10-08 at 05:47 -0400, Qian Cai wrote:
>
> > On Oct 8, 2019, at 2:16 AM, Walter Wu <walter-zh.wu@mediatek.com> wrote:
> >
> > It is an undefined behavior to pass a negative numbers to
> > memset()/memcpy()/memmove(), so need to be detected by KASAN.
>
> Why can’t this be detected by UBSAN?
I don't know very well in UBSAN, but I try to build ubsan kernel and
test a negative number in memset and kmalloc_memmove_invalid_size(), it
look like no check.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-08 11:02 UTC|newest]
Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 3:43 [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y Walter Wu
2019-09-27 3:43 ` Walter Wu
2019-09-27 3:43 ` Walter Wu
2019-09-27 13:07 ` Dmitry Vyukov
2019-09-27 13:07 ` Dmitry Vyukov
2019-09-27 13:07 ` Dmitry Vyukov
2019-09-27 14:22 ` Walter Wu
2019-09-27 14:22 ` Walter Wu
2019-09-27 14:22 ` Walter Wu
2019-09-27 19:41 ` Dmitry Vyukov
2019-09-27 19:41 ` Dmitry Vyukov
2019-09-27 19:41 ` Dmitry Vyukov
2019-09-30 4:36 ` Walter Wu
2019-09-30 4:36 ` Walter Wu
2019-09-30 8:57 ` Marc Gonzalez
2019-09-30 8:57 ` Marc Gonzalez
2019-10-01 2:36 ` Walter Wu
2019-10-01 2:36 ` Walter Wu
2019-10-01 3:01 ` Dmitry Vyukov
2019-10-01 3:01 ` Dmitry Vyukov
2019-10-01 3:18 ` Walter Wu
2019-10-01 3:18 ` Walter Wu
2019-10-02 12:15 ` Walter Wu
2019-10-02 12:15 ` Walter Wu
2019-10-02 12:15 ` Walter Wu
2019-10-02 13:57 ` Dmitry Vyukov
2019-10-02 13:57 ` Dmitry Vyukov
2019-10-02 13:57 ` Dmitry Vyukov
2019-10-03 2:17 ` Walter Wu
2019-10-03 2:17 ` Walter Wu
2019-10-03 6:26 ` Dmitry Vyukov
2019-10-03 6:26 ` Dmitry Vyukov
2019-10-03 6:26 ` Dmitry Vyukov
2019-10-03 9:38 ` Walter Wu
2019-10-03 9:38 ` Walter Wu
2019-10-03 9:38 ` Walter Wu
2019-10-03 13:51 ` Walter Wu
2019-10-03 13:51 ` Walter Wu
2019-10-03 13:51 ` Walter Wu
2019-10-03 14:53 ` Dmitry Vyukov
2019-10-03 14:53 ` Dmitry Vyukov
2019-10-03 14:53 ` Dmitry Vyukov
2019-10-04 4:42 ` Walter Wu
2019-10-04 4:42 ` Walter Wu
2019-10-04 4:42 ` Walter Wu
2019-10-04 8:02 ` Walter Wu
2019-10-04 8:02 ` Walter Wu
2019-10-04 8:02 ` Walter Wu
2019-10-04 9:18 ` Dmitry Vyukov
2019-10-04 9:18 ` Dmitry Vyukov
2019-10-04 9:18 ` Dmitry Vyukov
2019-10-04 9:44 ` Walter Wu
2019-10-04 9:44 ` Walter Wu
2019-10-04 9:44 ` Walter Wu
2019-10-04 9:54 ` Dmitry Vyukov
2019-10-04 9:54 ` Dmitry Vyukov
2019-10-04 9:54 ` Dmitry Vyukov
2019-10-04 9:54 ` Dmitry Vyukov
2019-10-04 12:05 ` Walter Wu
2019-10-04 12:05 ` Walter Wu
2019-10-04 12:05 ` Walter Wu
2019-10-04 13:52 ` Dmitry Vyukov
2019-10-04 13:52 ` Dmitry Vyukov
2019-10-04 13:52 ` Dmitry Vyukov
2019-10-07 3:22 ` Walter Wu
2019-10-07 3:22 ` Walter Wu
2019-10-07 3:22 ` Walter Wu
2019-10-07 7:29 ` Dmitry Vyukov
2019-10-07 7:29 ` Dmitry Vyukov
2019-10-07 7:29 ` Dmitry Vyukov
2019-10-07 8:18 ` Walter Wu
2019-10-07 8:18 ` Walter Wu
2019-10-07 8:18 ` Walter Wu
2019-10-07 8:24 ` Dmitry Vyukov
2019-10-07 8:24 ` Dmitry Vyukov
2019-10-07 8:24 ` Dmitry Vyukov
2019-10-07 8:24 ` Dmitry Vyukov
2019-10-07 8:51 ` Walter Wu
2019-10-07 8:51 ` Walter Wu
2019-10-07 8:51 ` Walter Wu
2019-10-07 8:54 ` Dmitry Vyukov
2019-10-07 8:54 ` Dmitry Vyukov
2019-10-07 8:54 ` Dmitry Vyukov
2019-10-07 9:03 ` Walter Wu
2019-10-07 9:03 ` Walter Wu
2019-10-07 9:03 ` Walter Wu
2019-10-07 9:10 ` Dmitry Vyukov
2019-10-07 9:10 ` Dmitry Vyukov
2019-10-07 9:10 ` Dmitry Vyukov
2019-10-07 9:10 ` Dmitry Vyukov
2019-10-07 9:28 ` Walter Wu
2019-10-07 9:28 ` Walter Wu
2019-10-07 9:28 ` Walter Wu
2019-10-07 9:50 ` Walter Wu
2019-10-07 9:50 ` Walter Wu
2019-10-07 9:50 ` Walter Wu
2019-10-07 10:51 ` Dmitry Vyukov
2019-10-07 10:51 ` Dmitry Vyukov
2019-10-07 10:51 ` Dmitry Vyukov
2019-10-07 12:03 ` Walter Wu
2019-10-07 12:03 ` Walter Wu
2019-10-07 12:03 ` Walter Wu
2019-10-07 12:19 ` Dmitry Vyukov
2019-10-07 12:19 ` Dmitry Vyukov
2019-10-07 12:19 ` Dmitry Vyukov
2019-10-07 12:32 ` Walter Wu
2019-10-07 12:32 ` Walter Wu
2019-10-07 12:32 ` Walter Wu
2019-10-07 13:33 ` Dmitry Vyukov
2019-10-07 13:33 ` Dmitry Vyukov
2019-10-07 13:33 ` Dmitry Vyukov
2019-10-08 6:15 ` Walter Wu
2019-10-08 6:15 ` Walter Wu
2019-10-08 6:15 ` Walter Wu
2019-10-08 9:47 ` Qian Cai
2019-10-08 9:47 ` Qian Cai
2019-10-08 11:02 ` Walter Wu [this message]
2019-10-08 11:02 ` Walter Wu
2019-10-08 11:02 ` Walter Wu
2019-10-08 11:42 ` Qian Cai
2019-10-08 11:42 ` Qian Cai
2019-10-08 12:07 ` Walter Wu
2019-10-08 12:07 ` Walter Wu
2019-10-08 12:07 ` Walter Wu
2019-10-08 12:11 ` Dmitry Vyukov
2019-10-08 12:11 ` Dmitry Vyukov
2019-10-08 12:11 ` Dmitry Vyukov
2019-10-08 12:11 ` Dmitry Vyukov
2019-10-14 2:19 ` Walter Wu
2019-10-14 2:19 ` Walter Wu
2019-10-14 2:19 ` Walter Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570532528.4686.102.camel@mtksdccf07 \
--to=walter-zh.wu@mediatek.com \
--cc=aryabinin@virtuozzo.com \
--cc=cai@lca.pw \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.