* [PATCH 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC
@ 2019-10-14 3:26 Peter Chen
2019-10-18 15:12 ` André Draszik
2019-10-31 2:18 ` Peter Chen
0 siblings, 2 replies; 4+ messages in thread
From: Peter Chen @ 2019-10-14 3:26 UTC (permalink / raw)
To: shawnguo
Cc: André Draszik, Peter Chen, kernel, linux-arm-kernel, linux-imx
Otherwise, the system will hang if USB driver try to access
portsc register.
Cc: André Draszik <git@andred.net>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
arch/arm/boot/dts/imx7s.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index c1a4fff5ceda..a5b380f530f8 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -658,6 +658,12 @@
reg = <1>;
power-supply = <®_1p0d>;
};
+
+ pgc_hsic_phy: power-domain@2 {
+ #power-domain-cells = <0>;
+ reg = <2>;
+ power-supply = <®_1p2>;
+ };
};
};
};
@@ -1101,6 +1107,7 @@
compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
reg = <0x30b30000 0x200>;
interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&pgc_hsic_phy>;
clocks = <&clks IMX7D_USB_CTRL_CLK>;
fsl,usbphy = <&usbphynop3>;
fsl,usbmisc = <&usbmisc3 0>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC
2019-10-14 3:26 [PATCH 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC Peter Chen
@ 2019-10-18 15:12 ` André Draszik
2019-10-31 2:18 ` Peter Chen
1 sibling, 0 replies; 4+ messages in thread
From: André Draszik @ 2019-10-18 15:12 UTC (permalink / raw)
To: Peter Chen; +Cc: shawnguo, kernel, linux-arm-kernel, linux-imx
Peter,
Thank you for this patch, I was out so I will test it early next week
and report (together with the USB HSIC driver fixes).
Cheers,
Andre'
On Mon, 2019-10-14 at 11:26 +0800, Peter Chen wrote:
> Otherwise, the system will hang if USB driver try to access
> portsc register.
>
> Cc: André Draszik <git@andred.net>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> arch/arm/boot/dts/imx7s.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index c1a4fff5ceda..a5b380f530f8 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -658,6 +658,12 @@
> reg = <1>;
> power-supply = <®_1p0d>;
> };
> +
> + pgc_hsic_phy: power-domain@2 {
> + #power-domain-cells = <0>;
> + reg = <2>;
> + power-supply = <®_1p2>;
> + };
> };
> };
> };
> @@ -1101,6 +1107,7 @@
> compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> reg = <0x30b30000 0x200>;
> interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&pgc_hsic_phy>;
> clocks = <&clks IMX7D_USB_CTRL_CLK>;
> fsl,usbphy = <&usbphynop3>;
> fsl,usbmisc = <&usbmisc3 0>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC
2019-10-14 3:26 [PATCH 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC Peter Chen
2019-10-18 15:12 ` André Draszik
@ 2019-10-31 2:18 ` Peter Chen
2019-10-31 8:43 ` André Draszik
1 sibling, 1 reply; 4+ messages in thread
From: Peter Chen @ 2019-10-31 2:18 UTC (permalink / raw)
To: shawnguo; +Cc: André Draszik, kernel, linux-arm-kernel, dl-linux-imx
On 19-10-14 11:26:28, Peter Chen wrote:
> Otherwise, the system will hang if USB driver try to access
> portsc register.
>
> Cc: André Draszik <git@andred.net>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> arch/arm/boot/dts/imx7s.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index c1a4fff5ceda..a5b380f530f8 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -658,6 +658,12 @@
> reg = <1>;
> power-supply = <®_1p0d>;
> };
> +
> + pgc_hsic_phy: power-domain@2 {
> + #power-domain-cells = <0>;
> + reg = <2>;
> + power-supply = <®_1p2>;
> + };
> };
> };
> };
> @@ -1101,6 +1107,7 @@
> compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> reg = <0x30b30000 0x200>;
> interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&pgc_hsic_phy>;
> clocks = <&clks IMX7D_USB_CTRL_CLK>;
> fsl,usbphy = <&usbphynop3>;
> fsl,usbmisc = <&usbmisc3 0>;
> --
> 2.17.1
>
Gentle ping...
--
Thanks,
Peter Chen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC
2019-10-31 2:18 ` Peter Chen
@ 2019-10-31 8:43 ` André Draszik
0 siblings, 0 replies; 4+ messages in thread
From: André Draszik @ 2019-10-31 8:43 UTC (permalink / raw)
To: Peter Chen, shawnguo; +Cc: kernel, linux-arm-kernel, dl-linux-imx
Hi Peter,
On Thu, 2019-10-31 at 02:18 +0000, Peter Chen wrote:
> On 19-10-14 11:26:28, Peter Chen wrote:
> > Otherwise, the system will hang if USB driver try to access
> > portsc register.
> >
> > Cc: André Draszik <git@andred.net>
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > ---
> > arch/arm/boot/dts/imx7s.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> > index c1a4fff5ceda..a5b380f530f8 100644
> > --- a/arch/arm/boot/dts/imx7s.dtsi
> > +++ b/arch/arm/boot/dts/imx7s.dtsi
> > @@ -658,6 +658,12 @@
> > reg = <1>;
> > power-supply = <®_1p0d>;
> > };
> > +
> > + pgc_hsic_phy: power-domain@2 {
> > + #power-domain-cells = <0>;
> > + reg = <2>;
> > + power-supply = <®_1p2>;
> > + };
> > };
> > };
> > };
> > @@ -1101,6 +1107,7 @@
> > compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> > reg = <0x30b30000 0x200>;
> > interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> > + power-domains = <&pgc_hsic_phy>;
> > clocks = <&clks IMX7D_USB_CTRL_CLK>;
> > fsl,usbphy = <&usbphynop3>;
> > fsl,usbmisc = <&usbmisc3 0>;
> > --
> > 2.17.1
> >
>
> Gentle ping...
Sorry for the delay. The kernel hangs even with this extra patch, I suppose
when initialising the USB. I haven't had time to look into it, though. But
I assume some additional clock might need to be enabled...
Cheers,
Andre'
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-31 8:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-14 3:26 [PATCH 1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC Peter Chen
2019-10-18 15:12 ` André Draszik
2019-10-31 2:18 ` Peter Chen
2019-10-31 8:43 ` André Draszik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.