* [PATCH 2/2] kasan: add test for invalid size in memmove
@ 2019-10-14 10:36 ` Walter Wu
0 siblings, 0 replies; 11+ messages in thread
From: Walter Wu @ 2019-10-14 10:36 UTC (permalink / raw)
To: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov, Matthias Brugger
Cc: Walter Wu, wsd_upstream, linux-kernel, kasan-dev, linux-mm,
linux-mediatek, linux-arm-kernel
Test size is negative numbers in memmove in order to verify
whether it correctly get KASAN report.
Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
---
lib/test_kasan.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index 49cc4d570a40..06942cf585cc 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c
@@ -283,6 +283,23 @@ static noinline void __init kmalloc_oob_in_memset(void)
kfree(ptr);
}
+static noinline void __init kmalloc_memmove_invalid_size(void)
+{
+ char *ptr;
+ size_t size = 64;
+
+ pr_info("invalid size in memmove\n");
+ ptr = kmalloc(size, GFP_KERNEL);
+ if (!ptr) {
+ pr_err("Allocation failed\n");
+ return;
+ }
+
+ memset((char *)ptr, 0, 64);
+ memmove((char *)ptr, (char *)ptr + 4, -2);
+ kfree(ptr);
+}
+
static noinline void __init kmalloc_uaf(void)
{
char *ptr;
@@ -773,6 +790,7 @@ static int __init kmalloc_tests_init(void)
kmalloc_oob_memset_4();
kmalloc_oob_memset_8();
kmalloc_oob_memset_16();
+ kmalloc_memmove_invalid_size();
kmalloc_uaf();
kmalloc_uaf_memset();
kmalloc_uaf2();
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/2] kasan: add test for invalid size in memmove
@ 2019-10-14 10:36 ` Walter Wu
0 siblings, 0 replies; 11+ messages in thread
From: Walter Wu @ 2019-10-14 10:36 UTC (permalink / raw)
To: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov, Matthias Brugger
Cc: kasan-dev, linux-mm, linux-kernel, linux-arm-kernel,
linux-mediatek, wsd_upstream, Walter Wu
Test size is negative numbers in memmove in order to verify
whether it correctly get KASAN report.
Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
---
lib/test_kasan.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index 49cc4d570a40..06942cf585cc 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c
@@ -283,6 +283,23 @@ static noinline void __init kmalloc_oob_in_memset(void)
kfree(ptr);
}
+static noinline void __init kmalloc_memmove_invalid_size(void)
+{
+ char *ptr;
+ size_t size = 64;
+
+ pr_info("invalid size in memmove\n");
+ ptr = kmalloc(size, GFP_KERNEL);
+ if (!ptr) {
+ pr_err("Allocation failed\n");
+ return;
+ }
+
+ memset((char *)ptr, 0, 64);
+ memmove((char *)ptr, (char *)ptr + 4, -2);
+ kfree(ptr);
+}
+
static noinline void __init kmalloc_uaf(void)
{
char *ptr;
@@ -773,6 +790,7 @@ static int __init kmalloc_tests_init(void)
kmalloc_oob_memset_4();
kmalloc_oob_memset_8();
kmalloc_oob_memset_16();
+ kmalloc_memmove_invalid_size();
kmalloc_uaf();
kmalloc_uaf_memset();
kmalloc_uaf2();
--
2.18.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/2] kasan: add test for invalid size in memmove
2019-10-14 10:36 ` Walter Wu
(?)
@ 2019-10-14 10:41 ` Dmitry Vyukov
-1 siblings, 0 replies; 11+ messages in thread
From: Dmitry Vyukov @ 2019-10-14 10:41 UTC (permalink / raw)
To: Walter Wu
Cc: Andrey Ryabinin, Alexander Potapenko, Matthias Brugger,
kasan-dev, Linux-MM, LKML, Linux ARM, linux-mediatek,
wsd_upstream
On Mon, Oct 14, 2019 at 12:37 PM Walter Wu <walter-zh.wu@mediatek.com> wrote:
>
> Test size is negative numbers in memmove in order to verify
> whether it correctly get KASAN report.
>
> Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Thanks!
> ---
> lib/test_kasan.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index 49cc4d570a40..06942cf585cc 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -283,6 +283,23 @@ static noinline void __init kmalloc_oob_in_memset(void)
> kfree(ptr);
> }
>
> +static noinline void __init kmalloc_memmove_invalid_size(void)
> +{
> + char *ptr;
> + size_t size = 64;
> +
> + pr_info("invalid size in memmove\n");
> + ptr = kmalloc(size, GFP_KERNEL);
> + if (!ptr) {
> + pr_err("Allocation failed\n");
> + return;
> + }
> +
> + memset((char *)ptr, 0, 64);
> + memmove((char *)ptr, (char *)ptr + 4, -2);
> + kfree(ptr);
> +}
> +
> static noinline void __init kmalloc_uaf(void)
> {
> char *ptr;
> @@ -773,6 +790,7 @@ static int __init kmalloc_tests_init(void)
> kmalloc_oob_memset_4();
> kmalloc_oob_memset_8();
> kmalloc_oob_memset_16();
> + kmalloc_memmove_invalid_size();
> kmalloc_uaf();
> kmalloc_uaf_memset();
> kmalloc_uaf2();
> --
> 2.18.0
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20191014103654.17982-1-walter-zh.wu%40mediatek.com.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 2/2] kasan: add test for invalid size in memmove
@ 2019-10-14 10:41 ` Dmitry Vyukov
0 siblings, 0 replies; 11+ messages in thread
From: Dmitry Vyukov @ 2019-10-14 10:41 UTC (permalink / raw)
To: Walter Wu
Cc: wsd_upstream, linux-mediatek, LKML, kasan-dev, Linux-MM,
Alexander Potapenko, Matthias Brugger, Andrey Ryabinin,
Linux ARM
On Mon, Oct 14, 2019 at 12:37 PM Walter Wu <walter-zh.wu@mediatek.com> wrote:
>
> Test size is negative numbers in memmove in order to verify
> whether it correctly get KASAN report.
>
> Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Thanks!
> ---
> lib/test_kasan.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index 49cc4d570a40..06942cf585cc 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -283,6 +283,23 @@ static noinline void __init kmalloc_oob_in_memset(void)
> kfree(ptr);
> }
>
> +static noinline void __init kmalloc_memmove_invalid_size(void)
> +{
> + char *ptr;
> + size_t size = 64;
> +
> + pr_info("invalid size in memmove\n");
> + ptr = kmalloc(size, GFP_KERNEL);
> + if (!ptr) {
> + pr_err("Allocation failed\n");
> + return;
> + }
> +
> + memset((char *)ptr, 0, 64);
> + memmove((char *)ptr, (char *)ptr + 4, -2);
> + kfree(ptr);
> +}
> +
> static noinline void __init kmalloc_uaf(void)
> {
> char *ptr;
> @@ -773,6 +790,7 @@ static int __init kmalloc_tests_init(void)
> kmalloc_oob_memset_4();
> kmalloc_oob_memset_8();
> kmalloc_oob_memset_16();
> + kmalloc_memmove_invalid_size();
> kmalloc_uaf();
> kmalloc_uaf_memset();
> kmalloc_uaf2();
> --
> 2.18.0
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20191014103654.17982-1-walter-zh.wu%40mediatek.com.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 2/2] kasan: add test for invalid size in memmove
@ 2019-10-14 10:41 ` Dmitry Vyukov
0 siblings, 0 replies; 11+ messages in thread
From: Dmitry Vyukov @ 2019-10-14 10:41 UTC (permalink / raw)
To: Walter Wu
Cc: Andrey Ryabinin, Alexander Potapenko, Matthias Brugger,
kasan-dev, Linux-MM, LKML, Linux ARM, linux-mediatek,
wsd_upstream
On Mon, Oct 14, 2019 at 12:37 PM Walter Wu <walter-zh.wu@mediatek.com> wrote:
>
> Test size is negative numbers in memmove in order to verify
> whether it correctly get KASAN report.
>
> Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Thanks!
> ---
> lib/test_kasan.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index 49cc4d570a40..06942cf585cc 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -283,6 +283,23 @@ static noinline void __init kmalloc_oob_in_memset(void)
> kfree(ptr);
> }
>
> +static noinline void __init kmalloc_memmove_invalid_size(void)
> +{
> + char *ptr;
> + size_t size = 64;
> +
> + pr_info("invalid size in memmove\n");
> + ptr = kmalloc(size, GFP_KERNEL);
> + if (!ptr) {
> + pr_err("Allocation failed\n");
> + return;
> + }
> +
> + memset((char *)ptr, 0, 64);
> + memmove((char *)ptr, (char *)ptr + 4, -2);
> + kfree(ptr);
> +}
> +
> static noinline void __init kmalloc_uaf(void)
> {
> char *ptr;
> @@ -773,6 +790,7 @@ static int __init kmalloc_tests_init(void)
> kmalloc_oob_memset_4();
> kmalloc_oob_memset_8();
> kmalloc_oob_memset_16();
> + kmalloc_memmove_invalid_size();
> kmalloc_uaf();
> kmalloc_uaf_memset();
> kmalloc_uaf2();
> --
> 2.18.0
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20191014103654.17982-1-walter-zh.wu%40mediatek.com.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] kasan: add test for invalid size in memmove
2019-10-14 10:36 ` Walter Wu
@ 2019-10-14 15:07 ` Matthew Wilcox
-1 siblings, 0 replies; 11+ messages in thread
From: Matthew Wilcox @ 2019-10-14 15:07 UTC (permalink / raw)
To: Walter Wu
Cc: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov,
Matthias Brugger, kasan-dev, linux-mm, linux-kernel,
linux-arm-kernel, linux-mediatek, wsd_upstream
On Mon, Oct 14, 2019 at 06:36:54PM +0800, Walter Wu wrote:
> Test size is negative numbers in memmove in order to verify
> whether it correctly get KASAN report.
You're not testing negative numbers, though. memmove() takes an unsigned
type, so you're testing a very large number.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] kasan: add test for invalid size in memmove
@ 2019-10-14 15:07 ` Matthew Wilcox
0 siblings, 0 replies; 11+ messages in thread
From: Matthew Wilcox @ 2019-10-14 15:07 UTC (permalink / raw)
To: Walter Wu
Cc: wsd_upstream, linux-mediatek, linux-kernel, kasan-dev, linux-mm,
Alexander Potapenko, linux-arm-kernel, Matthias Brugger,
Andrey Ryabinin, Dmitry Vyukov
On Mon, Oct 14, 2019 at 06:36:54PM +0800, Walter Wu wrote:
> Test size is negative numbers in memmove in order to verify
> whether it correctly get KASAN report.
You're not testing negative numbers, though. memmove() takes an unsigned
type, so you're testing a very large number.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] kasan: add test for invalid size in memmove
2019-10-14 15:07 ` Matthew Wilcox
(?)
@ 2019-10-14 15:57 ` Walter Wu
-1 siblings, 0 replies; 11+ messages in thread
From: Walter Wu @ 2019-10-14 15:57 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov,
Matthias Brugger, kasan-dev, linux-mm, linux-kernel,
linux-arm-kernel, linux-mediatek, wsd_upstream
On Mon, 2019-10-14 at 08:07 -0700, Matthew Wilcox wrote:
> On Mon, Oct 14, 2019 at 06:36:54PM +0800, Walter Wu wrote:
> > Test size is negative numbers in memmove in order to verify
> > whether it correctly get KASAN report.
>
> You're not testing negative numbers, though. memmove() takes an unsigned
> type, so you're testing a very large number.
>
Casting negative numbers to size_t would indeed turn up as a "large"
size_t and its value will be larger than ULONG_MAX/2. We mainly want to
express this case. Maybe we can add some descriptions. Thanks for your
reminder.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] kasan: add test for invalid size in memmove
@ 2019-10-14 15:57 ` Walter Wu
0 siblings, 0 replies; 11+ messages in thread
From: Walter Wu @ 2019-10-14 15:57 UTC (permalink / raw)
To: Matthew Wilcox
Cc: wsd_upstream, linux-mediatek, linux-kernel, kasan-dev, linux-mm,
Alexander Potapenko, linux-arm-kernel, Matthias Brugger,
Andrey Ryabinin, Dmitry Vyukov
On Mon, 2019-10-14 at 08:07 -0700, Matthew Wilcox wrote:
> On Mon, Oct 14, 2019 at 06:36:54PM +0800, Walter Wu wrote:
> > Test size is negative numbers in memmove in order to verify
> > whether it correctly get KASAN report.
>
> You're not testing negative numbers, though. memmove() takes an unsigned
> type, so you're testing a very large number.
>
Casting negative numbers to size_t would indeed turn up as a "large"
size_t and its value will be larger than ULONG_MAX/2. We mainly want to
express this case. Maybe we can add some descriptions. Thanks for your
reminder.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] kasan: add test for invalid size in memmove
@ 2019-10-14 15:57 ` Walter Wu
0 siblings, 0 replies; 11+ messages in thread
From: Walter Wu @ 2019-10-14 15:57 UTC (permalink / raw)
To: Matthew Wilcox
Cc: wsd_upstream, linux-mediatek, linux-kernel, kasan-dev, linux-mm,
Alexander Potapenko, linux-arm-kernel, Matthias Brugger,
Andrey Ryabinin, Dmitry Vyukov
On Mon, 2019-10-14 at 08:07 -0700, Matthew Wilcox wrote:
> On Mon, Oct 14, 2019 at 06:36:54PM +0800, Walter Wu wrote:
> > Test size is negative numbers in memmove in order to verify
> > whether it correctly get KASAN report.
>
> You're not testing negative numbers, though. memmove() takes an unsigned
> type, so you're testing a very large number.
>
Casting negative numbers to size_t would indeed turn up as a "large"
size_t and its value will be larger than ULONG_MAX/2. We mainly want to
express this case. Maybe we can add some descriptions. Thanks for your
reminder.
^ permalink raw reply [flat|nested] 11+ messages in thread