* [PATCH 1/1] ARM: dts: imx6ul-14x14-evk.dtsi: configure USBOTG1 ID pinctrl
@ 2019-10-16 8:31 Peter Chen
2019-10-26 12:05 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Peter Chen @ 2019-10-16 8:31 UTC (permalink / raw)
To: shawnguo
Cc: devicetree, Peter Chen, robh+dt, linux-imx, kernel, linux-arm-kernel
Without configuring this pinctrl, the ID value can't be got correctly,
then, the dual-role switch can't work well.
Reviewed-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
index c2a9dd57e56a..ed3d993c25f7 100644
--- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
+++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
@@ -266,6 +266,8 @@
&usbotg1 {
dr_mode = "otg";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usb_otg1>;
status = "okay";
};
@@ -499,6 +501,12 @@
>;
};
+ pinctrl_usb_otg1: usbotg1grp {
+ fsl,pins = <
+ MX6UL_PAD_GPIO1_IO00__ANATOP_OTG1_ID 0x17059
+ >;
+ };
+
pinctrl_usdhc1: usdhc1grp {
fsl,pins = <
MX6UL_PAD_SD1_CMD__USDHC1_CMD 0x17059
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ARM: dts: imx6ul-14x14-evk.dtsi: configure USBOTG1 ID pinctrl
2019-10-16 8:31 [PATCH 1/1] ARM: dts: imx6ul-14x14-evk.dtsi: configure USBOTG1 ID pinctrl Peter Chen
@ 2019-10-26 12:05 ` Shawn Guo
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-10-26 12:05 UTC (permalink / raw)
To: Peter Chen; +Cc: linux-arm-kernel, kernel, devicetree, robh+dt, linux-imx
On Wed, Oct 16, 2019 at 04:31:05PM +0800, Peter Chen wrote:
> Without configuring this pinctrl, the ID value can't be got correctly,
> then, the dual-role switch can't work well.
>
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
Reviewed-by should generally go after Signed-off-by, as you create patch
first and then people review it.
I flipped the order and applied the patch.
Shawn
> ---
> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> index c2a9dd57e56a..ed3d993c25f7 100644
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> @@ -266,6 +266,8 @@
>
> &usbotg1 {
> dr_mode = "otg";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb_otg1>;
> status = "okay";
> };
>
> @@ -499,6 +501,12 @@
> >;
> };
>
> + pinctrl_usb_otg1: usbotg1grp {
> + fsl,pins = <
> + MX6UL_PAD_GPIO1_IO00__ANATOP_OTG1_ID 0x17059
> + >;
> + };
> +
> pinctrl_usdhc1: usdhc1grp {
> fsl,pins = <
> MX6UL_PAD_SD1_CMD__USDHC1_CMD 0x17059
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ARM: dts: imx6ul-14x14-evk.dtsi: configure USBOTG1 ID pinctrl
@ 2019-10-26 12:05 ` Shawn Guo
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-10-26 12:05 UTC (permalink / raw)
To: Peter Chen; +Cc: devicetree, robh+dt, kernel, linux-arm-kernel, linux-imx
On Wed, Oct 16, 2019 at 04:31:05PM +0800, Peter Chen wrote:
> Without configuring this pinctrl, the ID value can't be got correctly,
> then, the dual-role switch can't work well.
>
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
Reviewed-by should generally go after Signed-off-by, as you create patch
first and then people review it.
I flipped the order and applied the patch.
Shawn
> ---
> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> index c2a9dd57e56a..ed3d993c25f7 100644
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> @@ -266,6 +266,8 @@
>
> &usbotg1 {
> dr_mode = "otg";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb_otg1>;
> status = "okay";
> };
>
> @@ -499,6 +501,12 @@
> >;
> };
>
> + pinctrl_usb_otg1: usbotg1grp {
> + fsl,pins = <
> + MX6UL_PAD_GPIO1_IO00__ANATOP_OTG1_ID 0x17059
> + >;
> + };
> +
> pinctrl_usdhc1: usdhc1grp {
> fsl,pins = <
> MX6UL_PAD_SD1_CMD__USDHC1_CMD 0x17059
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-26 12:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 8:31 [PATCH 1/1] ARM: dts: imx6ul-14x14-evk.dtsi: configure USBOTG1 ID pinctrl Peter Chen
2019-10-26 12:05 ` Shawn Guo
2019-10-26 12:05 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.