* [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks
@ 2019-10-25 14:30 Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_fb: Declare format conversions explicitly Ville Syrjala
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Ville Syrjala @ 2019-10-25 14:30 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Define PIXMAN_rgba_float the same way newer pixman releases do it.
This allows us to compile the code against an old pixman version
while still running it against a more recent release. A similar hack
is already used for cairo.
Suggested-by: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_fb.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 6b674c1bcd02..87228cca7936 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -81,7 +81,15 @@
#endif
#if PIXMAN_VERSION < PIXMAN_VERSION_ENCODE(0, 36, 0)
-#define PIXMAN_rgba_float PIXMAN_invalid
+#define PIXMAN_FORMAT_BYTE(bpp,type,a,r,g,b) \
+ (((bpp >> 3) << 24) | \
+ (3 << 22) | ((type) << 16) | \
+ ((a >> 3) << 12) | \
+ ((r >> 3) << 8) | \
+ ((g >> 3) << 4) | \
+ ((b >> 3)))
+#define PIXMAN_TYPE_RGBA_FLOAT 11
+#define PIXMAN_rgba_float PIXMAN_FORMAT_BYTE(128, PIXMAN_TYPE_RGBA_FLOAT,32,32,32,32)
#endif
/* drm fourcc/cairo format maps */
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 2/4] lib/igt_fb: Declare format conversions explicitly
2019-10-25 14:30 [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Ville Syrjala
@ 2019-10-25 14:30 ` Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_fb: Don't skip the entire subtest when cairo/pixman is too old Ville Syrjala
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjala @ 2019-10-25 14:30 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Instead of deducing the conversion cairo format from the
drm_format using potentially fragile code let's just declare
the appropriate cairo format, and our need to use conversion,
explicitly.
We are left with one special case: CAIRO_FORMAT_RGB96F
for which we haven't defined a fake drm format, and so need
to keep pretending that it's the same as CAIRO_FORMAT_RGBA128F
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_fb.c | 137 ++++++++++++++++++++++-----------------------------
1 file changed, 60 insertions(+), 77 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 87228cca7936..9ed53d056735 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -103,21 +103,22 @@ static const struct format_desc_struct {
int plane_bpp[4];
uint8_t hsub;
uint8_t vsub;
+ bool convert;
} format_desc[] = {
{ .name = "ARGB1555", .depth = -1, .drm_id = DRM_FORMAT_ARGB1555,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_ARGB32, .convert = true,
.pixman_id = PIXMAN_a1r5g5b5,
.num_planes = 1, .plane_bpp = { 16, },
.hsub = 1, .vsub = 1,
},
{ .name = "C8", .depth = -1, .drm_id = DRM_FORMAT_C8,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.pixman_id = PIXMAN_r3g3b2,
.num_planes = 1, .plane_bpp = { 8, },
.hsub = 1, .vsub = 1,
},
{ .name = "XRGB1555", .depth = -1, .drm_id = DRM_FORMAT_XRGB1555,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.pixman_id = PIXMAN_x1r5g5b5,
.num_planes = 1, .plane_bpp = { 16, },
.hsub = 1, .vsub = 1,
@@ -129,25 +130,25 @@ static const struct format_desc_struct {
.hsub = 1, .vsub = 1,
},
{ .name = "BGR565", .depth = -1, .drm_id = DRM_FORMAT_BGR565,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGB16_565, .convert = true,
.pixman_id = PIXMAN_b5g6r5,
.num_planes = 1, .plane_bpp = { 16, },
.hsub = 1, .vsub = 1,
},
{ .name = "BGR888", .depth = -1, .drm_id = DRM_FORMAT_BGR888,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.pixman_id = PIXMAN_b8g8r8,
.num_planes = 1, .plane_bpp = { 24, },
.hsub = 1, .vsub = 1,
},
{ .name = "RGB888", .depth = -1, .drm_id = DRM_FORMAT_RGB888,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.pixman_id = PIXMAN_r8g8b8,
.num_planes = 1, .plane_bpp = { 24, },
.hsub = 1, .vsub = 1,
},
{ .name = "XYUV8888", .depth = -1, .drm_id = DRM_FORMAT_XYUV8888,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 1, .vsub = 1,
},
@@ -158,7 +159,7 @@ static const struct format_desc_struct {
.hsub = 1, .vsub = 1,
},
{ .name = "XBGR8888", .depth = -1, .drm_id = DRM_FORMAT_XBGR8888,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.pixman_id = PIXMAN_x8b8g8r8,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 1, .vsub = 1,
@@ -170,7 +171,7 @@ static const struct format_desc_struct {
.hsub = 1, .vsub = 1,
},
{ .name = "XBGR2101010", .depth = -1, .drm_id = DRM_FORMAT_XBGR2101010,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGB30, .convert = true,
.pixman_id = PIXMAN_x2b10g10r10,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 1, .vsub = 1,
@@ -182,161 +183,161 @@ static const struct format_desc_struct {
.hsub = 1, .vsub = 1,
},
{ .name = "ABGR8888", .depth = -1, .drm_id = DRM_FORMAT_ABGR8888,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_ARGB32, .convert = true,
.pixman_id = PIXMAN_a8b8g8r8,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 1, .vsub = 1,
},
{ .name = "ARGB2101010", .depth = 30, .drm_id = DRM_FORMAT_ARGB2101010,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGBA128F, .convert = true,
.pixman_id = PIXMAN_a2r10g10b10,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 1, .vsub = 1,
},
{ .name = "ABGR2101010", .depth = -1, .drm_id = DRM_FORMAT_ABGR2101010,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGBA128F, .convert = true,
.pixman_id = PIXMAN_a2b10g10r10,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 1, .vsub = 1,
},
{ .name = "XRGB16161616F", .depth = -1, .drm_id = DRM_FORMAT_XRGB16161616F,
- .cairo_id = CAIRO_FORMAT_RGBA128F,
+ .cairo_id = CAIRO_FORMAT_RGBA128F, .convert = true,
.num_planes = 1, .plane_bpp = { 64, },
},
{ .name = "ARGB16161616F", .depth = -1, .drm_id = DRM_FORMAT_ARGB16161616F,
- .cairo_id = CAIRO_FORMAT_RGBA128F,
+ .cairo_id = CAIRO_FORMAT_RGBA128F, .convert = true,
.num_planes = 1, .plane_bpp = { 64, },
},
{ .name = "XBGR16161616F", .depth = -1, .drm_id = DRM_FORMAT_XBGR16161616F,
- .cairo_id = CAIRO_FORMAT_RGBA128F,
+ .cairo_id = CAIRO_FORMAT_RGBA128F, .convert = true,
.num_planes = 1, .plane_bpp = { 64, },
},
{ .name = "ABGR16161616F", .depth = -1, .drm_id = DRM_FORMAT_ABGR16161616F,
- .cairo_id = CAIRO_FORMAT_RGBA128F,
+ .cairo_id = CAIRO_FORMAT_RGBA128F, .convert = true,
.num_planes = 1, .plane_bpp = { 64, },
},
{ .name = "NV12", .depth = -1, .drm_id = DRM_FORMAT_NV12,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 2, .plane_bpp = { 8, 16, },
.hsub = 2, .vsub = 2,
},
{ .name = "NV16", .depth = -1, .drm_id = DRM_FORMAT_NV16,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 2, .plane_bpp = { 8, 16, },
.hsub = 2, .vsub = 1,
},
{ .name = "NV21", .depth = -1, .drm_id = DRM_FORMAT_NV21,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 2, .plane_bpp = { 8, 16, },
.hsub = 2, .vsub = 2,
},
{ .name = "NV61", .depth = -1, .drm_id = DRM_FORMAT_NV61,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 2, .plane_bpp = { 8, 16, },
.hsub = 2, .vsub = 1,
},
{ .name = "YUYV", .depth = -1, .drm_id = DRM_FORMAT_YUYV,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 1, .plane_bpp = { 16, },
.hsub = 2, .vsub = 1,
},
{ .name = "YVYU", .depth = -1, .drm_id = DRM_FORMAT_YVYU,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 1, .plane_bpp = { 16, },
.hsub = 2, .vsub = 1,
},
{ .name = "UYVY", .depth = -1, .drm_id = DRM_FORMAT_UYVY,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 1, .plane_bpp = { 16, },
.hsub = 2, .vsub = 1,
},
{ .name = "VYUY", .depth = -1, .drm_id = DRM_FORMAT_VYUY,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 1, .plane_bpp = { 16, },
.hsub = 2, .vsub = 1,
},
{ .name = "YU12", .depth = -1, .drm_id = DRM_FORMAT_YUV420,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 3, .plane_bpp = { 8, 8, 8, },
.hsub = 2, .vsub = 2,
},
{ .name = "YU16", .depth = -1, .drm_id = DRM_FORMAT_YUV422,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 3, .plane_bpp = { 8, 8, 8, },
.hsub = 2, .vsub = 1,
},
{ .name = "YV12", .depth = -1, .drm_id = DRM_FORMAT_YVU420,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 3, .plane_bpp = { 8, 8, 8, },
.hsub = 2, .vsub = 2,
},
{ .name = "YV16", .depth = -1, .drm_id = DRM_FORMAT_YVU422,
- .cairo_id = CAIRO_FORMAT_RGB24,
+ .cairo_id = CAIRO_FORMAT_RGB24, .convert = true,
.num_planes = 3, .plane_bpp = { 8, 8, 8, },
.hsub = 2, .vsub = 1,
},
{ .name = "Y410", .depth = -1, .drm_id = DRM_FORMAT_Y410,
- .cairo_id = CAIRO_FORMAT_RGBA128F,
+ .cairo_id = CAIRO_FORMAT_RGBA128F, .convert = true,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 1, .vsub = 1,
},
{ .name = "Y412", .depth = -1, .drm_id = DRM_FORMAT_Y412,
- .cairo_id = CAIRO_FORMAT_RGBA128F,
+ .cairo_id = CAIRO_FORMAT_RGBA128F, .convert = true,
.num_planes = 1, .plane_bpp = { 64, },
.hsub = 1, .vsub = 1,
},
{ .name = "Y416", .depth = -1, .drm_id = DRM_FORMAT_Y416,
- .cairo_id = CAIRO_FORMAT_RGBA128F,
+ .cairo_id = CAIRO_FORMAT_RGBA128F, .convert = true,
.num_planes = 1, .plane_bpp = { 64, },
.hsub = 1, .vsub = 1,
},
{ .name = "XV30", .depth = -1, .drm_id = DRM_FORMAT_XVYU2101010,
- .cairo_id = CAIRO_FORMAT_RGB96F,
+ .cairo_id = CAIRO_FORMAT_RGB96F, .convert = true,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 1, .vsub = 1,
},
{ .name = "XV36", .depth = -1, .drm_id = DRM_FORMAT_XVYU12_16161616,
- .cairo_id = CAIRO_FORMAT_RGB96F,
+ .cairo_id = CAIRO_FORMAT_RGB96F, .convert = true,
.num_planes = 1, .plane_bpp = { 64, },
.hsub = 1, .vsub = 1,
},
{ .name = "XV48", .depth = -1, .drm_id = DRM_FORMAT_XVYU16161616,
- .cairo_id = CAIRO_FORMAT_RGB96F,
+ .cairo_id = CAIRO_FORMAT_RGB96F, .convert = true,
.num_planes = 1, .plane_bpp = { 64, },
.hsub = 1, .vsub = 1,
},
{ .name = "P010", .depth = -1, .drm_id = DRM_FORMAT_P010,
- .cairo_id = CAIRO_FORMAT_RGB96F,
+ .cairo_id = CAIRO_FORMAT_RGB96F, .convert = true,
.num_planes = 2, .plane_bpp = { 16, 32 },
.vsub = 2, .hsub = 2,
},
{ .name = "P012", .depth = -1, .drm_id = DRM_FORMAT_P012,
- .cairo_id = CAIRO_FORMAT_RGB96F,
+ .cairo_id = CAIRO_FORMAT_RGB96F, .convert = true,
.num_planes = 2, .plane_bpp = { 16, 32 },
.vsub = 2, .hsub = 2,
},
{ .name = "P016", .depth = -1, .drm_id = DRM_FORMAT_P016,
- .cairo_id = CAIRO_FORMAT_RGB96F,
+ .cairo_id = CAIRO_FORMAT_RGB96F, .convert = true,
.num_planes = 2, .plane_bpp = { 16, 32 },
.vsub = 2, .hsub = 2,
},
{ .name = "Y210", .depth = -1, .drm_id = DRM_FORMAT_Y210,
- .cairo_id = CAIRO_FORMAT_RGB96F,
+ .cairo_id = CAIRO_FORMAT_RGB96F, .convert = true,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 2, .vsub = 1,
},
{ .name = "Y212", .depth = -1, .drm_id = DRM_FORMAT_Y212,
- .cairo_id = CAIRO_FORMAT_RGB96F,
+ .cairo_id = CAIRO_FORMAT_RGB96F, .convert = true,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 2, .vsub = 1,
},
{ .name = "Y216", .depth = -1, .drm_id = DRM_FORMAT_Y216,
- .cairo_id = CAIRO_FORMAT_RGB96F,
+ .cairo_id = CAIRO_FORMAT_RGB96F, .convert = true,
.num_planes = 1, .plane_bpp = { 32, },
.hsub = 2, .vsub = 1,
},
{ .name = "IGT-FLOAT", .depth = -1, .drm_id = IGT_FORMAT_FLOAT,
- .cairo_id = CAIRO_FORMAT_INVALID,
+ .cairo_id = CAIRO_FORMAT_RGBA128F,
.pixman_id = PIXMAN_rgba_float,
.num_planes = 1, .plane_bpp = { 128 },
},
@@ -1817,6 +1818,21 @@ static cairo_format_t drm_format_to_cairo(uint32_t drm_format)
drm_format, igt_format_str(drm_format));
}
+static uint32_t cairo_format_to_drm_format(cairo_format_t cairo_format)
+{
+ const struct format_desc_struct *f;
+
+ if (cairo_format == CAIRO_FORMAT_RGB96F)
+ cairo_format = CAIRO_FORMAT_RGBA128F;
+
+ for_each_format(f)
+ if (f->cairo_id == cairo_format && !f->convert)
+ return f->drm_id;
+
+ igt_assert_f(0, "can't find a drm format for cairo format %u\n",
+ cairo_format);
+}
+
struct fb_blit_linear {
struct igt_fb fb;
uint8_t *map;
@@ -3118,37 +3134,7 @@ static void create_cairo_surface__convert(int fd, struct igt_fb *fb)
struct fb_convert_blit_upload *blit = calloc(1, sizeof(*blit));
struct fb_convert cvt = { };
const struct format_desc_struct *f = lookup_drm_format(fb->drm_format);
- unsigned drm_format;
- cairo_format_t cairo_id;
-
- if (f->cairo_id != CAIRO_FORMAT_INVALID) {
- cairo_id = f->cairo_id;
-
- switch (f->cairo_id) {
- case CAIRO_FORMAT_RGB96F:
- case CAIRO_FORMAT_RGBA128F:
- drm_format = IGT_FORMAT_FLOAT;
- break;
- case CAIRO_FORMAT_RGB24:
- drm_format = DRM_FORMAT_XRGB8888;
- break;
- default:
- igt_assert_f(0, "Unsupported format %u", f->cairo_id);
- }
- } else if (PIXMAN_FORMAT_A(f->pixman_id) &&
- PIXMAN_FORMAT_R(f->pixman_id) > 8) {
- cairo_id = CAIRO_FORMAT_RGBA128F;
- drm_format = IGT_FORMAT_FLOAT;
- } else if (PIXMAN_FORMAT_A(f->pixman_id)) {
- cairo_id = CAIRO_FORMAT_ARGB32;
- drm_format = DRM_FORMAT_ARGB8888;
- } else if (PIXMAN_FORMAT_R(f->pixman_id) > 8) {
- cairo_id = CAIRO_FORMAT_RGB30;
- drm_format = DRM_FORMAT_XRGB2101010;
- } else {
- cairo_id = CAIRO_FORMAT_RGB24;
- drm_format = DRM_FORMAT_XRGB8888;
- }
+ unsigned drm_format = cairo_format_to_drm_format(f->cairo_id);
igt_assert(blit);
@@ -3181,7 +3167,7 @@ static void create_cairo_surface__convert(int fd, struct igt_fb *fb)
fb->cairo_surface =
cairo_image_surface_create_for_data(blit->shadow_ptr,
- cairo_id,
+ f->cairo_id,
fb->width, fb->height,
blit->shadow_fb.strides[0]);
@@ -3225,10 +3211,7 @@ static bool use_convert(const struct igt_fb *fb)
{
const struct format_desc_struct *f = lookup_drm_format(fb->drm_format);
- return igt_format_is_yuv(fb->drm_format) ||
- igt_format_is_fp16(fb->drm_format) ||
- (f->cairo_id == CAIRO_FORMAT_INVALID &&
- f->pixman_id != PIXMAN_invalid);
+ return f->convert;
}
/**
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 3/4] lib/igt_fb: Don't skip the entire subtest when cairo/pixman is too old
2019-10-25 14:30 [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_fb: Declare format conversions explicitly Ville Syrjala
@ 2019-10-25 14:30 ` Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: Pimp "no conversion specified" assert Ville Syrjala
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjala @ 2019-10-25 14:30 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Just skip the specific pixel format instead of the whole subtest
when cairo/pixman is too old to support it. Let's us at least
test all the other formats.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_fb.c | 41 +++++++++++++++++++----------------------
1 file changed, 19 insertions(+), 22 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 9ed53d056735..aaeca7955418 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -3227,8 +3227,6 @@ static bool use_convert(const struct igt_fb *fb)
*/
cairo_surface_t *igt_get_cairo_surface(int fd, struct igt_fb *fb)
{
- const struct format_desc_struct *f = lookup_drm_format(fb->drm_format);
-
if (fb->cairo_surface == NULL) {
if (use_convert(fb))
create_cairo_surface__convert(fd, fb);
@@ -3236,21 +3234,6 @@ cairo_surface_t *igt_get_cairo_surface(int fd, struct igt_fb *fb)
create_cairo_surface__gpu(fd, fb);
else
create_cairo_surface__gtt(fd, fb);
-
- if (f->cairo_id == CAIRO_FORMAT_RGB96F ||
- f->cairo_id == CAIRO_FORMAT_RGBA128F) {
- cairo_status_t status = cairo_surface_status(fb->cairo_surface);
-
- igt_skip_on_f(status == CAIRO_STATUS_INVALID_FORMAT &&
- cairo_version() < CAIRO_VERSION_ENCODE(1, 17, 2),
- "Cairo version too old, need 1.17.2, have %s\n",
- cairo_version_string());
-
- igt_skip_on_f(status == CAIRO_STATUS_NO_MEMORY &&
- pixman_version() < PIXMAN_VERSION_ENCODE(0, 36, 0),
- "Pixman version too old, need 0.36.0, have %s\n",
- pixman_version_string());
- }
}
igt_assert(cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS);
@@ -3474,12 +3457,26 @@ bool igt_fb_supported_format(uint32_t drm_format)
if (drm_format == DRM_FORMAT_C8)
return false;
- for_each_format(f)
- if (f->drm_id == drm_format)
- return (f->cairo_id != CAIRO_FORMAT_INVALID) ||
- (f->pixman_id != PIXMAN_invalid);
+ f = lookup_drm_format(drm_format);
+ if (!f)
+ return false;
+
+ if ((f->cairo_id == CAIRO_FORMAT_RGB96F ||
+ f->cairo_id == CAIRO_FORMAT_RGBA128F) &&
+ cairo_version() < CAIRO_VERSION_ENCODE(1, 17, 2)) {
+ igt_info("Cairo version too old for " IGT_FORMAT_FMT ", need 1.17.2, have %s\n",
+ IGT_FORMAT_ARGS(drm_format), cairo_version_string());
+ return false;
+ }
- return false;
+ if (f->pixman_id == PIXMAN_rgba_float &&
+ pixman_version() < PIXMAN_VERSION_ENCODE(0, 36, 0)) {
+ igt_info("Pixman version too old for " IGT_FORMAT_FMT ", need 0.36.0, have %s\n",
+ IGT_FORMAT_ARGS(drm_format), pixman_version_string());
+ return false;
+ }
+
+ return true;
}
/**
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: Pimp "no conversion specified" assert
2019-10-25 14:30 [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_fb: Declare format conversions explicitly Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_fb: Don't skip the entire subtest when cairo/pixman is too old Ville Syrjala
@ 2019-10-25 14:30 ` Ville Syrjala
2019-10-25 15:27 ` Chris Wilson
2019-10-25 15:45 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Patchwork
` (2 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjala @ 2019-10-25 14:30 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Decode the fourccs to make things a bit more human readable
if the assertion trips.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index aaeca7955418..4adca9672f33 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -3096,8 +3096,10 @@ static void fb_convert(struct fb_convert *cvt)
}
igt_assert_f(false,
- "Conversion not implemented (from format 0x%x to 0x%x)\n",
- cvt->src.fb->drm_format, cvt->dst.fb->drm_format);
+ "Conversion not implemented (from format "
+ IGT_FORMAT_FMT " to " IGT_FORMAT_FMT ")\n",
+ IGT_FORMAT_ARGS(cvt->src.fb->drm_format),
+ IGT_FORMAT_ARGS(cvt->dst.fb->drm_format));
}
static void destroy_cairo_surface__convert(void *arg)
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: Pimp "no conversion specified" assert
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: Pimp "no conversion specified" assert Ville Syrjala
@ 2019-10-25 15:27 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2019-10-25 15:27 UTC (permalink / raw)
To: Ville Syrjala, igt-dev
Quoting Ville Syrjala (2019-10-25 15:30:50)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Decode the fourccs to make things a bit more human readable
> if the assertion trips.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Series looks good, all
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks
2019-10-25 14:30 [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Ville Syrjala
` (2 preceding siblings ...)
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: Pimp "no conversion specified" assert Ville Syrjala
@ 2019-10-25 15:45 ` Patchwork
2019-10-25 18:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks (rev2) Patchwork
2019-10-27 9:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-10-25 15:45 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks
URL : https://patchwork.freedesktop.org/series/68574/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7186 -> IGTPW_3612
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3612 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3612, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3612:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
Known issues
------------
Here are the changes found in IGTPW_3612 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-icl-u3/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/fi-icl-u3/igt@gem_exec_suspend@basic-s3.html
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-7500u: [PASS][5] -> [WARN][6] ([fdo#109483])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
#### Possible fixes ####
* {igt@i915_selftest@live_gt_heartbeat}:
- fi-byt-n2820: [DMESG-FAIL][7] ([fdo#112096]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-byt-n2820/igt@i915_selftest@live_gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/fi-byt-n2820/igt@i915_selftest@live_gt_heartbeat.html
* igt@kms_busy@basic-flip-a:
- {fi-tgl-u2}: [DMESG-WARN][9] ([fdo#111600]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111407]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@prime_vgem@basic-wait-default:
- fi-icl-u3: [DMESG-WARN][13] ([fdo#107724]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
Participating hosts (49 -> 43)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5241 -> IGTPW_3612
CI-20190529: 20190529
CI_DRM_7186: ce03ec86789ef8fc41a56176e5f2a9251182183c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3612: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/index.html
IGT_5241: 17b87c378fa155390b13a43f141371fd899d567b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3612/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks (rev2)
2019-10-25 14:30 [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Ville Syrjala
` (3 preceding siblings ...)
2019-10-25 15:45 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Patchwork
@ 2019-10-25 18:50 ` Patchwork
2019-10-27 9:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-10-25 18:50 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks (rev2)
URL : https://patchwork.freedesktop.org/series/68574/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7187 -> IGTPW_3615
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/index.html
Known issues
------------
Here are the changes found in IGTPW_3615 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: [PASS][3] -> [DMESG-WARN][4] ([fdo#105128] / [fdo#107139])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
* igt@gem_ringfill@basic-default-interruptible:
- fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-icl-u3/igt@gem_ringfill@basic-default-interruptible.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/fi-icl-u3/igt@gem_ringfill@basic-default-interruptible.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-icl-u3/igt@gem_exec_suspend@basic-s4-devices.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/fi-icl-u3/igt@gem_exec_suspend@basic-s4-devices.html
* {igt@i915_selftest@live_gt_heartbeat}:
- {fi-icl-dsi}: [DMESG-FAIL][9] ([fdo#112096]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-icl-dsi/igt@i915_selftest@live_gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/fi-icl-dsi/igt@i915_selftest@live_gt_heartbeat.html
- fi-cml-u2: [DMESG-FAIL][11] ([fdo#112096]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-cml-u2/igt@i915_selftest@live_gt_heartbeat.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/fi-cml-u2/igt@i915_selftest@live_gt_heartbeat.html
* igt@i915_selftest@live_hangcheck:
- {fi-tgl-u}: [INCOMPLETE][13] ([fdo#111747]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-tgl-u/igt@i915_selftest@live_hangcheck.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/fi-tgl-u/igt@i915_selftest@live_hangcheck.html
* igt@kms_busy@basic-flip-a:
- {fi-tgl-u2}: [DMESG-WARN][15] ([fdo#111600]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105128]: https://bugs.freedesktop.org/show_bug.cgi?id=105128
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
Participating hosts (49 -> 43)
------------------------------
Additional (1): fi-pnv-d510
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5241 -> IGTPW_3615
CI-20190529: 20190529
CI_DRM_7187: 9df5aeba240a65ea80008020d3027484bc6055b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3615: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/index.html
IGT_5241: 17b87c378fa155390b13a43f141371fd899d567b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks (rev2)
2019-10-25 14:30 [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Ville Syrjala
` (4 preceding siblings ...)
2019-10-25 18:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks (rev2) Patchwork
@ 2019-10-27 9:37 ` Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-10-27 9:37 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks (rev2)
URL : https://patchwork.freedesktop.org/series/68574/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7187_full -> IGTPW_3615_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3615_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- {shard-tglb}: [SKIP][1] ([fdo#109506]) -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb3/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-tglb2/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
Known issues
------------
Here are the changes found in IGTPW_3615_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-dirty-switch:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb2/igt@gem_ctx_isolation@vcs1-dirty-switch.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb5/igt@gem_ctx_isolation@vcs1-dirty-switch.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [PASS][7] -> [DMESG-WARN][8] ([fdo#111870])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@i915_selftest@mock_requests:
- shard-glk: [PASS][9] -> [INCOMPLETE][10] ([fdo#103359] / [k.org#198133])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-glk4/igt@i915_selftest@mock_requests.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-glk4/igt@i915_selftest@mock_requests.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge:
- shard-snb: [PASS][13] -> [SKIP][14] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-snb2/igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-snb5/igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-hsw: [PASS][15] -> [FAIL][16] ([fdo#103355])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][17] -> [FAIL][18] ([fdo#105363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-glk6/igt@kms_flip@flip-vs-expired-vblank.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-glk7/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip_tiling@flip-changes-tiling:
- shard-hsw: [PASS][19] -> [INCOMPLETE][20] ([fdo#103540])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-hsw2/igt@kms_flip_tiling@flip-changes-tiling.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-hsw4/igt@kms_flip_tiling@flip-changes-tiling.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#103167]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][23] -> [DMESG-WARN][24] ([fdo#108566]) +5 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb1/igt@kms_psr@psr2_cursor_plane_move.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#112080]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb4/igt@perf_pmu@busy-vcs1.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb5/igt@perf_pmu@busy-vcs1.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109276]) +12 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb1/igt@prime_busy@hang-bsd2.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb5/igt@prime_busy@hang-bsd2.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][31] ([fdo#112080]) -> [PASS][32] +11 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@gem_busy@busy-vcs1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb2/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][33] ([fdo#109276] / [fdo#112080]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@gem_ctx_isolation@vcs1-none.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb4/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_exec_blt@dumb-buf-max:
- shard-apl: [INCOMPLETE][35] ([fdo#103927]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-apl4/igt@gem_exec_blt@dumb-buf-max.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-apl3/igt@gem_exec_blt@dumb-buf-max.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][37] ([fdo#111325]) -> [PASS][38] +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [SKIP][39] ([fdo#109276]) -> [PASS][40] +8 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-hsw: [FAIL][41] ([fdo#112037]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-hsw8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-hsw4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [DMESG-WARN][43] ([fdo#111870]) -> [PASS][44] +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-hsw2/igt@gem_userptr_blits@sync-unmap-after-close.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-hsw4/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][45] ([fdo#111870]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][47] ([fdo#108566]) -> [PASS][48] +4 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_selftest@live_hangcheck:
- {shard-tglb}: [INCOMPLETE][49] ([fdo#111747]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb1/igt@i915_selftest@live_hangcheck.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-tglb2/igt@i915_selftest@live_hangcheck.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [INCOMPLETE][51] ([fdo#103665]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
- shard-iclb: [INCOMPLETE][53] ([fdo#107713]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@pipe-c-single-bo:
- {shard-tglb}: [INCOMPLETE][55] ([fdo#111747] / [fdo#112035 ]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb3/igt@kms_cursor_legacy@pipe-c-single-bo.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-tglb8/igt@kms_cursor_legacy@pipe-c-single-bo.html
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [INCOMPLETE][57] ([fdo#105411]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-snb1/igt@kms_flip@flip-vs-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-snb7/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- {shard-tglb}: [FAIL][59] ([fdo#103167]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-iclb: [FAIL][61] ([fdo#103167]) -> [PASS][62] +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [FAIL][63] ([fdo#103167] / [fdo#110378]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt:
- {shard-tglb}: [INCOMPLETE][65] -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb8/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-WARN][67] ([fdo#108566]) -> [PASS][68] +4 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][69] ([fdo#109642] / [fdo#111068]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@kms_psr2_su@frontbuffer.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- {shard-tglb}: [INCOMPLETE][73] ([fdo#111850]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb8/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-tglb3/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][75] ([fdo#111329]) -> [SKIP][76] ([fdo#109276] / [fdo#112080])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [DMESG-WARN][77] ([fdo#111870]) -> [DMESG-WARN][78] ([fdo#110789] / [fdo#111870])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111780 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111780
[fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111855]: https://bugs.freedesktop.org/show_bug.cgi?id=111855
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
[fdo#112035 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112035
[fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-hsw-4770r
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5241 -> IGTPW_3615
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_7187: 9df5aeba240a65ea80008020d3027484bc6055b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3615: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/index.html
IGT_5241: 17b87c378fa155390b13a43f141371fd899d567b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3615/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-10-27 9:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 14:30 [igt-dev] [PATCH i-g-t 1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_fb: Declare format conversions explicitly Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_fb: Don't skip the entire subtest when cairo/pixman is too old Ville Syrjala
2019-10-25 14:30 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_fb: Pimp "no conversion specified" assert Ville Syrjala
2019-10-25 15:27 ` Chris Wilson
2019-10-25 15:45 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks Patchwork
2019-10-25 18:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_fb: Adjust < pixman-0.36.0 float hacks (rev2) Patchwork
2019-10-27 9:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.