* [PATCH] uprobes/x86: fix arch_uprobe_analyze_insn() comment
@ 2019-10-23 7:40 Yi Wang
2019-10-27 8:05 ` [tip: x86/cleanups] x86/apic, x86/uprobes: Correct parameter names in kernel-doc comments tip-bot2 for Yi Wang
0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2019-10-23 7:40 UTC (permalink / raw)
To: tglx
Cc: mingo, bp, hpa, x86, ebiederm, gregkh, gustavo, me, linux-kernel,
xue.zhihong, wang.yi59, up2wing, wang.liang82
Fix parameter name in comment and adjust the order.
No functional change.
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
arch/x86/kernel/uprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/uprobes.c b/arch/x86/kernel/uprobes.c
index 8cd745e..15e5aad 100644
--- a/arch/x86/kernel/uprobes.c
+++ b/arch/x86/kernel/uprobes.c
@@ -842,8 +842,8 @@ static int push_setup_xol_ops(struct arch_uprobe *auprobe, struct insn *insn)
/**
* arch_uprobe_analyze_insn - instruction analysis including validity and fixups.
+ * @auprobe: the probepoint information.
* @mm: the probed address space.
- * @arch_uprobe: the probepoint information.
* @addr: virtual address at which to install the probepoint
* Return 0 on success or a -ve number on error.
*/
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: x86/cleanups] x86/apic, x86/uprobes: Correct parameter names in kernel-doc comments
2019-10-23 7:40 [PATCH] uprobes/x86: fix arch_uprobe_analyze_insn() comment Yi Wang
@ 2019-10-27 8:05 ` tip-bot2 for Yi Wang
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Yi Wang @ 2019-10-27 8:05 UTC (permalink / raw)
To: linux-tip-commits
Cc: Yi Wang, Borislav Petkov, H. Peter Anvin, Ingo Molnar,
Thomas Gleixner, x86-ml, Ingo Molnar, Borislav Petkov,
linux-kernel
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 44eb5a7e5dc6f23d04c05c15f91bc279e0dc700d
Gitweb: https://git.kernel.org/tip/44eb5a7e5dc6f23d04c05c15f91bc279e0dc700d
Author: Yi Wang <wang.yi59@zte.com.cn>
AuthorDate: Sun, 27 Oct 2019 08:55:39 +01:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Sun, 27 Oct 2019 09:00:28 +01:00
x86/apic, x86/uprobes: Correct parameter names in kernel-doc comments
Rename parameter names to the correct ones used in the function. No
functional changes.
[ bp: Merge two patches into a single one. ]
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/1571816442-22494-1-git-send-email-wang.yi59@zte.com.cn
---
arch/x86/kernel/apic/apic.c | 2 +-
arch/x86/kernel/uprobes.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 9e2dd2b..8147106 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -2335,7 +2335,7 @@ static int cpuid_to_apicid[] = {
#ifdef CONFIG_SMP
/**
* apic_id_is_primary_thread - Check whether APIC ID belongs to a primary thread
- * @id: APIC ID to check
+ * @apicid: APIC ID to check
*/
bool apic_id_is_primary_thread(unsigned int apicid)
{
diff --git a/arch/x86/kernel/uprobes.c b/arch/x86/kernel/uprobes.c
index 8cd745e..15e5aad 100644
--- a/arch/x86/kernel/uprobes.c
+++ b/arch/x86/kernel/uprobes.c
@@ -842,8 +842,8 @@ static int push_setup_xol_ops(struct arch_uprobe *auprobe, struct insn *insn)
/**
* arch_uprobe_analyze_insn - instruction analysis including validity and fixups.
+ * @auprobe: the probepoint information.
* @mm: the probed address space.
- * @arch_uprobe: the probepoint information.
* @addr: virtual address at which to install the probepoint
* Return 0 on success or a -ve number on error.
*/
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-27 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 7:40 [PATCH] uprobes/x86: fix arch_uprobe_analyze_insn() comment Yi Wang
2019-10-27 8:05 ` [tip: x86/cleanups] x86/apic, x86/uprobes: Correct parameter names in kernel-doc comments tip-bot2 for Yi Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.