From: David Howells <dhowells@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: dhowells@redhat.com, mmarek@suse.cz, d.kasatkin@samsung.com,
rusty@rustcorp.com.au, keyrings@linux-nfs.org,
linux-security-module@vger.kernel.org, zohar@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] X.509: Extract both parts of the AuthorityKeyIdentifier
Date: Mon, 24 Nov 2014 13:35:45 +0000 [thread overview]
Message-ID: <15723.1416836145@warthog.procyon.org.uk> (raw)
In-Reply-To: <20141121144245.GA22306@redhat.com>
Vivek Goyal <vgoyal@redhat.com> wrote:
> A very minor nit. It might help if we put additional comment to explain what
> auth_id and auth_skid are composed of (like other key ids).
I thought it better to show what they match - ie. auth_id matches id and
auth_skid matches skid from the same structure. The id and skid members show
their composition (and I should fix the comment on id so that the bits are the
right way round).
David
next prev parent reply other threads:[~2014-11-24 13:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 16:53 [PATCH 0/5] MODSIGN: Use PKCS#7 for module signatures David Howells
2014-11-20 16:54 ` [PATCH 1/5] X.509: Extract both parts of the AuthorityKeyIdentifier David Howells
2014-11-21 14:42 ` Vivek Goyal
2014-12-04 12:24 ` Dmitry Kasatkin
2014-12-04 13:02 ` David Howells
2014-11-24 13:35 ` David Howells [this message]
2014-11-20 16:54 ` [PATCH 2/5] X.509: Support X.509 lookup by Issuer+Serial form AuthorityKeyIdentifier David Howells
2014-11-21 15:33 ` Vivek Goyal
2014-11-24 0:00 ` Mimi Zohar
2014-11-24 11:58 ` [Keyrings] " Mimi Zohar
2014-11-24 16:55 ` David Howells
2014-11-24 17:12 ` Mimi Zohar
2014-11-24 16:58 ` David Howells
2014-11-24 17:33 ` Mimi Zohar
2014-11-24 19:36 ` David Howells
2014-11-20 16:54 ` [PATCH 3/5] PKCS#7: Allow detached data to be supplied for signature checking purposes David Howells
2014-11-24 11:52 ` Mimi Zohar
2014-11-24 12:48 ` David Howells
2014-11-24 13:43 ` Mimi Zohar
2014-11-24 14:41 ` David Howells
2014-11-24 14:59 ` Mimi Zohar
2014-11-24 15:14 ` David Howells
2014-11-20 16:54 ` [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module David Howells
2014-11-20 16:54 ` [PATCH 5/5] MODSIGN: Use PKCS#7 messages as module signatures David Howells
2014-11-24 14:06 ` Mimi Zohar
2014-11-21 12:59 ` [PATCH 0/5] MODSIGN: Use PKCS#7 for " Dmitry Kasatkin
2014-11-24 9:19 ` Dmitry Kasatkin
2014-11-24 12:52 ` David Howells
2014-11-24 16:13 ` David Howells
2014-11-24 17:14 ` Mimi Zohar
2014-11-24 12:33 ` Dmitry Kasatkin
2014-11-24 12:51 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15723.1416836145@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=d.kasatkin@samsung.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
--cc=vgoyal@redhat.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.