All of lore.kernel.org
 help / color / mirror / Atom feed
* [alsa-devel] [PATCH] ASoC: Intel: bxt_da7219_max98357a: update dai_link platform name
@ 2019-10-29  3:35 mac.chiang
  2019-10-29 14:04 ` Pierre-Louis Bossart
  0 siblings, 1 reply; 2+ messages in thread
From: mac.chiang @ 2019-10-29  3:35 UTC (permalink / raw)
  To: alsa-devel
  Cc: sathya.prakash.m.r, naveen.m, mac.chiang, broonie, pierre-louis.bossart

From: Mac Chiang <mac.chiang@intel.com>

redefine soc platform name "0000:00:1f.3" if cml core

Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.prakash.m.r@intel.com>
---
 sound/soc/intel/boards/bxt_da7219_max98357a.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c
index ac1dea5..38b7dbe 100644
--- a/sound/soc/intel/boards/bxt_da7219_max98357a.c
+++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c
@@ -40,6 +40,13 @@ struct bxt_card_private {
 	struct list_head hdmi_pcm_list;
 };
 
+static struct snd_soc_dai_link_component platform_component[] = {
+	{
+		/* name might be overridden during probe */
+		.name = "0000:00:1f.3"
+	}
+};
+
 enum {
 	BXT_DPCM_AUDIO_PB = 0,
 	BXT_DPCM_AUDIO_CP,
@@ -708,6 +715,7 @@ static int broxton_audio_probe(struct platform_device *pdev)
 				broxton_dais[i].name = "SSP0-Codec";
 				broxton_dais[i].cpus->dai_name = "SSP0 Pin";
 			}
+			broxton_dais[i].platforms = platform_component;
 		}
 	}
 
-- 
2.7.4

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [alsa-devel] [PATCH] ASoC: Intel: bxt_da7219_max98357a: update dai_link platform name
  2019-10-29  3:35 [alsa-devel] [PATCH] ASoC: Intel: bxt_da7219_max98357a: update dai_link platform name mac.chiang
@ 2019-10-29 14:04 ` Pierre-Louis Bossart
  0 siblings, 0 replies; 2+ messages in thread
From: Pierre-Louis Bossart @ 2019-10-29 14:04 UTC (permalink / raw)
  To: mac.chiang, alsa-devel; +Cc: sathya.prakash.m.r, naveen.m, broonie



On 10/28/19 10:35 PM, mac.chiang@intel.com wrote:
> From: Mac Chiang <mac.chiang@intel.com>
> 
> redefine soc platform name "0000:00:1f.3" if cml core

we already have code that can update the platform name:

	/* override plaform name, if required */
	mach = (&pdev->dev)->platform_data;
	platform_name = mach->mach_params.platform;

	ret = snd_soc_fixup_dai_links_platform_name(&broxton_audio_card,
						    platform_name);

Are you sure this additional assignment is required?

> 
> Signed-off-by: Mac Chiang <mac.chiang@intel.com>
> Signed-off-by: Sathya Prakash M R <sathya.prakash.m.r@intel.com>
> ---
>   sound/soc/intel/boards/bxt_da7219_max98357a.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c
> index ac1dea5..38b7dbe 100644
> --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c
> +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c
> @@ -40,6 +40,13 @@ struct bxt_card_private {
>   	struct list_head hdmi_pcm_list;
>   };
>   
> +static struct snd_soc_dai_link_component platform_component[] = {
> +	{
> +		/* name might be overridden during probe */
> +		.name = "0000:00:1f.3"
> +	}
> +};
> +
>   enum {
>   	BXT_DPCM_AUDIO_PB = 0,
>   	BXT_DPCM_AUDIO_CP,
> @@ -708,6 +715,7 @@ static int broxton_audio_probe(struct platform_device *pdev)
>   				broxton_dais[i].name = "SSP0-Codec";
>   				broxton_dais[i].cpus->dai_name = "SSP0 Pin";
>   			}
> +			broxton_dais[i].platforms = platform_component;
>   		}
>   	}
>   
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-29 14:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29  3:35 [alsa-devel] [PATCH] ASoC: Intel: bxt_da7219_max98357a: update dai_link platform name mac.chiang
2019-10-29 14:04 ` Pierre-Louis Bossart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.