All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
@ 2019-11-05  1:49 ` Anson Huang
  0 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2019-11-05  1:49 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

Add "clock-frequency" property to avoid below warning on i.MX7ULP:

[    0.011762] /cpus/cpu@0 missing clock-frequency property

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx7ulp.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index d37a192..87b2237 100644
--- a/arch/arm/boot/dts/imx7ulp.dtsi
+++ b/arch/arm/boot/dts/imx7ulp.dtsi
@@ -41,6 +41,7 @@
 			compatible = "arm,cortex-a7";
 			device_type = "cpu";
 			reg = <0>;
+			clock-frequency = <500210526>;
 		};
 	};
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
@ 2019-11-05  1:49 ` Anson Huang
  0 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2019-11-05  1:49 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

Add "clock-frequency" property to avoid below warning on i.MX7ULP:

[    0.011762] /cpus/cpu@0 missing clock-frequency property

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx7ulp.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index d37a192..87b2237 100644
--- a/arch/arm/boot/dts/imx7ulp.dtsi
+++ b/arch/arm/boot/dts/imx7ulp.dtsi
@@ -41,6 +41,7 @@
 			compatible = "arm,cortex-a7";
 			device_type = "cpu";
 			reg = <0>;
+			clock-frequency = <500210526>;
 		};
 	};
 
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
  2019-11-05  1:49 ` Anson Huang
@ 2019-12-02 13:47   ` Shawn Guo
  -1 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-12-02 13:47 UTC (permalink / raw)
  To: Anson Huang
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, devicetree,
	linux-arm-kernel, linux-kernel, Linux-imx

On Tue, Nov 05, 2019 at 09:49:38AM +0800, Anson Huang wrote:
> Add "clock-frequency" property to avoid below warning on i.MX7ULP:
> 
> [    0.011762] /cpus/cpu@0 missing clock-frequency property
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  arch/arm/boot/dts/imx7ulp.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
> index d37a192..87b2237 100644
> --- a/arch/arm/boot/dts/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> @@ -41,6 +41,7 @@
>  			compatible = "arm,cortex-a7";
>  			device_type = "cpu";
>  			reg = <0>;
> +			clock-frequency = <500210526>;

I cannot find the binding doc for this property.  What is the
definition of it, the maximum frequency that the cpu could possibly run
at?

Shawn

>  		};
>  	};
>  
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
@ 2019-12-02 13:47   ` Shawn Guo
  0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-12-02 13:47 UTC (permalink / raw)
  To: Anson Huang
  Cc: mark.rutland, devicetree, s.hauer, linux-kernel, robh+dt,
	Linux-imx, kernel, festevam, linux-arm-kernel

On Tue, Nov 05, 2019 at 09:49:38AM +0800, Anson Huang wrote:
> Add "clock-frequency" property to avoid below warning on i.MX7ULP:
> 
> [    0.011762] /cpus/cpu@0 missing clock-frequency property
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  arch/arm/boot/dts/imx7ulp.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
> index d37a192..87b2237 100644
> --- a/arch/arm/boot/dts/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> @@ -41,6 +41,7 @@
>  			compatible = "arm,cortex-a7";
>  			device_type = "cpu";
>  			reg = <0>;
> +			clock-frequency = <500210526>;

I cannot find the binding doc for this property.  What is the
definition of it, the maximum frequency that the cpu could possibly run
at?

Shawn

>  		};
>  	};
>  
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
  2019-12-02 13:47   ` Shawn Guo
@ 2019-12-03  1:09     ` Anson Huang
  -1 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2019-12-03  1:09 UTC (permalink / raw)
  To: Shawn Guo
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, devicetree,
	linux-arm-kernel, linux-kernel, dl-linux-imx


> Subject: Re: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
> 
> On Tue, Nov 05, 2019 at 09:49:38AM +0800, Anson Huang wrote:
> > Add "clock-frequency" property to avoid below warning on i.MX7ULP:
> >
> > [    0.011762] /cpus/cpu@0 missing clock-frequency property
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> >  arch/arm/boot/dts/imx7ulp.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > b/arch/arm/boot/dts/imx7ulp.dtsi index d37a192..87b2237 100644
> > --- a/arch/arm/boot/dts/imx7ulp.dtsi
> > +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> > @@ -41,6 +41,7 @@
> >  			compatible = "arm,cortex-a7";
> >  			device_type = "cpu";
> >  			reg = <0>;
> > +			clock-frequency = <500210526>;
> 
> I cannot find the binding doc for this property.  What is the definition of it,
> the maximum frequency that the cpu could possibly run at?


The code is as below, maybe the property is missing from the beginning of this code,
this property should mean the current frequency of CPU running at I think:

arch/arm/kernel/topology.c

122                 rate = of_get_property(cn, "clock-frequency", &len);
123                 if (!rate || len != 4) {
124                         pr_err("%pOF missing clock-frequency property\n", cn);
125                         continue;
126                 }

Thanks,
Anson

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
@ 2019-12-03  1:09     ` Anson Huang
  0 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2019-12-03  1:09 UTC (permalink / raw)
  To: Shawn Guo
  Cc: mark.rutland, devicetree, s.hauer, linux-kernel, robh+dt,
	dl-linux-imx, kernel, festevam, linux-arm-kernel


> Subject: Re: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
> 
> On Tue, Nov 05, 2019 at 09:49:38AM +0800, Anson Huang wrote:
> > Add "clock-frequency" property to avoid below warning on i.MX7ULP:
> >
> > [    0.011762] /cpus/cpu@0 missing clock-frequency property
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> >  arch/arm/boot/dts/imx7ulp.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > b/arch/arm/boot/dts/imx7ulp.dtsi index d37a192..87b2237 100644
> > --- a/arch/arm/boot/dts/imx7ulp.dtsi
> > +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> > @@ -41,6 +41,7 @@
> >  			compatible = "arm,cortex-a7";
> >  			device_type = "cpu";
> >  			reg = <0>;
> > +			clock-frequency = <500210526>;
> 
> I cannot find the binding doc for this property.  What is the definition of it,
> the maximum frequency that the cpu could possibly run at?


The code is as below, maybe the property is missing from the beginning of this code,
this property should mean the current frequency of CPU running at I think:

arch/arm/kernel/topology.c

122                 rate = of_get_property(cn, "clock-frequency", &len);
123                 if (!rate || len != 4) {
124                         pr_err("%pOF missing clock-frequency property\n", cn);
125                         continue;
126                 }

Thanks,
Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
  2019-12-03  1:09     ` Anson Huang
@ 2019-12-04  2:02       ` Shawn Guo
  -1 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-12-04  2:02 UTC (permalink / raw)
  To: Anson Huang, Vincent Guittot
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, devicetree,
	linux-arm-kernel, linux-kernel, dl-linux-imx

+ Vincent

On Tue, Dec 03, 2019 at 01:09:22AM +0000, Anson Huang wrote:
> 
> > Subject: Re: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
> > 
> > On Tue, Nov 05, 2019 at 09:49:38AM +0800, Anson Huang wrote:
> > > Add "clock-frequency" property to avoid below warning on i.MX7ULP:
> > >
> > > [    0.011762] /cpus/cpu@0 missing clock-frequency property
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > >  arch/arm/boot/dts/imx7ulp.dtsi | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > > b/arch/arm/boot/dts/imx7ulp.dtsi index d37a192..87b2237 100644
> > > --- a/arch/arm/boot/dts/imx7ulp.dtsi
> > > +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> > > @@ -41,6 +41,7 @@
> > >  			compatible = "arm,cortex-a7";
> > >  			device_type = "cpu";
> > >  			reg = <0>;
> > > +			clock-frequency = <500210526>;
> > 
> > I cannot find the binding doc for this property.  What is the definition of it,
> > the maximum frequency that the cpu could possibly run at?
> 
> 
> The code is as below, maybe the property is missing from the beginning of this code,
> this property should mean the current frequency of CPU running at I think:
> 
> arch/arm/kernel/topology.c
> 
> 122                 rate = of_get_property(cn, "clock-frequency", &len);
> 123                 if (!rate || len != 4) {
> 124                         pr_err("%pOF missing clock-frequency property\n", cn);
> 125                         continue;
> 126                 }

Yes, I can find the code, but not bindings for it.  Considering
frequency of a CPU can be scaled in a quite wide range, we need
a clear understanding on this property.  IIUIC, the property is used to
calculate the capacity of CPU, it should be the maximum frequency the
CPU could possibly scale to?

Shawn

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
@ 2019-12-04  2:02       ` Shawn Guo
  0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-12-04  2:02 UTC (permalink / raw)
  To: Anson Huang, Vincent Guittot
  Cc: mark.rutland, devicetree, s.hauer, linux-kernel, robh+dt,
	dl-linux-imx, kernel, festevam, linux-arm-kernel

+ Vincent

On Tue, Dec 03, 2019 at 01:09:22AM +0000, Anson Huang wrote:
> 
> > Subject: Re: [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property
> > 
> > On Tue, Nov 05, 2019 at 09:49:38AM +0800, Anson Huang wrote:
> > > Add "clock-frequency" property to avoid below warning on i.MX7ULP:
> > >
> > > [    0.011762] /cpus/cpu@0 missing clock-frequency property
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > >  arch/arm/boot/dts/imx7ulp.dtsi | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > > b/arch/arm/boot/dts/imx7ulp.dtsi index d37a192..87b2237 100644
> > > --- a/arch/arm/boot/dts/imx7ulp.dtsi
> > > +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> > > @@ -41,6 +41,7 @@
> > >  			compatible = "arm,cortex-a7";
> > >  			device_type = "cpu";
> > >  			reg = <0>;
> > > +			clock-frequency = <500210526>;
> > 
> > I cannot find the binding doc for this property.  What is the definition of it,
> > the maximum frequency that the cpu could possibly run at?
> 
> 
> The code is as below, maybe the property is missing from the beginning of this code,
> this property should mean the current frequency of CPU running at I think:
> 
> arch/arm/kernel/topology.c
> 
> 122                 rate = of_get_property(cn, "clock-frequency", &len);
> 123                 if (!rate || len != 4) {
> 124                         pr_err("%pOF missing clock-frequency property\n", cn);
> 125                         continue;
> 126                 }

Yes, I can find the code, but not bindings for it.  Considering
frequency of a CPU can be scaled in a quite wide range, we need
a clear understanding on this property.  IIUIC, the property is used to
calculate the capacity of CPU, it should be the maximum frequency the
CPU could possibly scale to?

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-12-04  2:02 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05  1:49 [PATCH] ARM: dts: imx7ulp: Add cpu clock-frequency property Anson Huang
2019-11-05  1:49 ` Anson Huang
2019-12-02 13:47 ` Shawn Guo
2019-12-02 13:47   ` Shawn Guo
2019-12-03  1:09   ` Anson Huang
2019-12-03  1:09     ` Anson Huang
2019-12-04  2:02     ` Shawn Guo
2019-12-04  2:02       ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.