[PATCH] drm/i915: Don't select BROKEN

[PATCH] drm/i915: Don't select BROKEN

[Daniel Vetter]

It's broken.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
Note: Probably best to apply this directly onto drm-next to avoid
having drm-next dropped from linux-next until the next pull request.
-Daniel
---
 drivers/gpu/drm/i915/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index ef123eb29168..d2ba8f7e5e50 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -44,7 +44,6 @@ config DRM_I915_DEBUG
 	select DRM_I915_SELFTEST
 	select DRM_I915_DEBUG_RUNTIME_PM
 	select DRM_I915_DEBUG_MMIO
-	select BROKEN # for prototype uAPI
 	default n
 	help
 	  Choose this option to turn on extra driver debugging that may affect
-- 
2.24.0.rc2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915: Don't select BROKEN

[Daniel Vetter]

It's broken.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
Note: Probably best to apply this directly onto drm-next to avoid
having drm-next dropped from linux-next until the next pull request.
-Daniel
---
 drivers/gpu/drm/i915/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index ef123eb29168..d2ba8f7e5e50 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -44,7 +44,6 @@ config DRM_I915_DEBUG
 	select DRM_I915_SELFTEST
 	select DRM_I915_DEBUG_RUNTIME_PM
 	select DRM_I915_DEBUG_MMIO
-	select BROKEN # for prototype uAPI
 	default n
 	help
 	  Choose this option to turn on extra driver debugging that may affect
-- 
2.24.0.rc2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Daniel Vetter]

It's broken.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
Note: Probably best to apply this directly onto drm-next to avoid
having drm-next dropped from linux-next until the next pull request.
-Daniel
---
 drivers/gpu/drm/i915/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index ef123eb29168..d2ba8f7e5e50 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -44,7 +44,6 @@ config DRM_I915_DEBUG
 	select DRM_I915_SELFTEST
 	select DRM_I915_DEBUG_RUNTIME_PM
 	select DRM_I915_DEBUG_MMIO
-	select BROKEN # for prototype uAPI
 	default n
 	help
 	  Choose this option to turn on extra driver debugging that may affect
-- 
2.24.0.rc2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Don't select BROKEN

[Patchwork]

== Series Details ==

Series: drm/i915: Don't select BROKEN
URL   : https://patchwork.freedesktop.org/series/69013/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
49373d3c2935 drm/i915: Don't select BROKEN
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9: 
References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html

-:23: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Don't select BROKEN

[Patchwork]

== Series Details ==

Series: drm/i915: Don't select BROKEN
URL   : https://patchwork.freedesktop.org/series/69013/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
49373d3c2935 drm/i915: Don't select BROKEN
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9: 
References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html

-:23: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 2 warnings, 0 checks, 7 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 19:38:29)
> It's broken.

So is the code that depends on it. Which is the entire point.

Don't select it then.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 19:38:29)
> It's broken.

So is the code that depends on it. Which is the entire point.

Don't select it then.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 19:38:29)
> It's broken.

So is the code that depends on it. Which is the entire point.

Don't select it then.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Don't select BROKEN

[Daniel Vetter]

On Tue, Nov 5, 2019 at 9:34 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Daniel Vetter (2019-11-05 19:38:29)
> > It's broken.
>
> So is the code that depends on it. Which is the entire point.
>
> Don't select it then.

See the mail from Stephen, it breaks autobuilders. So we need to do
this explicitly, i.e. if you want to set this, you need to explicitly
enable CONFIG_BROKEN first. Auto-enabling CONFIG_BROKEN also somewhat
defeats the point of this debug option, since it doesn't force users
to do the multi-step thing anymore.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Daniel Vetter]

On Tue, Nov 5, 2019 at 9:34 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Daniel Vetter (2019-11-05 19:38:29)
> > It's broken.
>
> So is the code that depends on it. Which is the entire point.
>
> Don't select it then.

See the mail from Stephen, it breaks autobuilders. So we need to do
this explicitly, i.e. if you want to set this, you need to explicitly
enable CONFIG_BROKEN first. Auto-enabling CONFIG_BROKEN also somewhat
defeats the point of this debug option, since it doesn't force users
to do the multi-step thing anymore.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Daniel Vetter]

On Tue, Nov 5, 2019 at 9:34 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Daniel Vetter (2019-11-05 19:38:29)
> > It's broken.
>
> So is the code that depends on it. Which is the entire point.
>
> Don't select it then.

See the mail from Stephen, it breaks autobuilders. So we need to do
this explicitly, i.e. if you want to set this, you need to explicitly
enable CONFIG_BROKEN first. Auto-enabling CONFIG_BROKEN also somewhat
defeats the point of this debug option, since it doesn't force users
to do the multi-step thing anymore.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 19:38:29)
> It's broken.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Note: Probably best to apply this directly onto drm-next to avoid
> having drm-next dropped from linux-next until the next pull request.
> -Daniel
> ---
>  drivers/gpu/drm/i915/Kconfig.debug | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index ef123eb29168..d2ba8f7e5e50 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
>         select DRM_I915_SELFTEST
>         select DRM_I915_DEBUG_RUNTIME_PM
>         select DRM_I915_DEBUG_MMIO
> -       select BROKEN # for prototype uAPI

You have to replace it with another secret bool as you cannot otherwise
enable CONFIG_BROKEN in .config.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 19:38:29)
> It's broken.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Note: Probably best to apply this directly onto drm-next to avoid
> having drm-next dropped from linux-next until the next pull request.
> -Daniel
> ---
>  drivers/gpu/drm/i915/Kconfig.debug | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index ef123eb29168..d2ba8f7e5e50 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
>         select DRM_I915_SELFTEST
>         select DRM_I915_DEBUG_RUNTIME_PM
>         select DRM_I915_DEBUG_MMIO
> -       select BROKEN # for prototype uAPI

You have to replace it with another secret bool as you cannot otherwise
enable CONFIG_BROKEN in .config.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 19:38:29)
> It's broken.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Note: Probably best to apply this directly onto drm-next to avoid
> having drm-next dropped from linux-next until the next pull request.
> -Daniel
> ---
>  drivers/gpu/drm/i915/Kconfig.debug | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index ef123eb29168..d2ba8f7e5e50 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
>         select DRM_I915_SELFTEST
>         select DRM_I915_DEBUG_RUNTIME_PM
>         select DRM_I915_DEBUG_MMIO
> -       select BROKEN # for prototype uAPI

You have to replace it with another secret bool as you cannot otherwise
enable CONFIG_BROKEN in .config.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: Don't select BROKEN

[Patchwork]

== Series Details ==

Series: drm/i915: Don't select BROKEN
URL   : https://patchwork.freedesktop.org/series/69013/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7262 -> Patchwork_15137
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/index.html

Known issues
------------

  Here are the changes found in Patchwork_15137 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_busy@busy-all:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@gem_busy@busy-all.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/fi-icl-u3/igt@gem_busy@busy-all.html

  
#### Possible fixes ####

  * igt@gem_exec_parallel@basic:
    - {fi-tgl-u}:         [INCOMPLETE][3] ([fdo#111887]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-tgl-u/igt@gem_exec_parallel@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/fi-tgl-u/igt@gem_exec_parallel@basic.html

  * igt@gem_flink_basic@double-flink:
    - fi-icl-u3:          [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@gem_flink_basic@double-flink.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/fi-icl-u3/igt@gem_flink_basic@double-flink.html

  * igt@i915_pm_rpm@module-reload:
    - fi-icl-u3:          [DMESG-WARN][7] ([fdo#106107]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@i915_pm_rpm@module-reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/fi-icl-u3/igt@i915_pm_rpm@module-reload.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#111887]: https://bugs.freedesktop.org/show_bug.cgi?id=111887


Participating hosts (51 -> 42)
------------------------------

  Additional (1): fi-cml-u2 
  Missing    (10): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-whl-u fi-gdg-551 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7262 -> Patchwork_15137

  CI-20190529: 20190529
  CI_DRM_7262: 6d9033858175fc0e1ef5f77d6bd60356e6b70ee4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15137: 49373d3c2935230c2732430b837c409a7b4cadcb @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

49373d3c2935 drm/i915: Don't select BROKEN

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't select BROKEN

[Patchwork]

== Series Details ==

Series: drm/i915: Don't select BROKEN
URL   : https://patchwork.freedesktop.org/series/69013/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7262 -> Patchwork_15137
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/index.html

Known issues
------------

  Here are the changes found in Patchwork_15137 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_busy@busy-all:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@gem_busy@busy-all.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/fi-icl-u3/igt@gem_busy@busy-all.html

  
#### Possible fixes ####

  * igt@gem_exec_parallel@basic:
    - {fi-tgl-u}:         [INCOMPLETE][3] ([fdo#111887]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-tgl-u/igt@gem_exec_parallel@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/fi-tgl-u/igt@gem_exec_parallel@basic.html

  * igt@gem_flink_basic@double-flink:
    - fi-icl-u3:          [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@gem_flink_basic@double-flink.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/fi-icl-u3/igt@gem_flink_basic@double-flink.html

  * igt@i915_pm_rpm@module-reload:
    - fi-icl-u3:          [DMESG-WARN][7] ([fdo#106107]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7262/fi-icl-u3/igt@i915_pm_rpm@module-reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/fi-icl-u3/igt@i915_pm_rpm@module-reload.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#111887]: https://bugs.freedesktop.org/show_bug.cgi?id=111887


Participating hosts (51 -> 42)
------------------------------

  Additional (1): fi-cml-u2 
  Missing    (10): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-whl-u fi-gdg-551 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7262 -> Patchwork_15137

  CI-20190529: 20190529
  CI_DRM_7262: 6d9033858175fc0e1ef5f77d6bd60356e6b70ee4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15137: 49373d3c2935230c2732430b837c409a7b4cadcb @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

49373d3c2935 drm/i915: Don't select BROKEN

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15137/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Daniel Vetter]

On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Daniel Vetter (2019-11-05 19:38:29)
> > It's broken.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > Note: Probably best to apply this directly onto drm-next to avoid
> > having drm-next dropped from linux-next until the next pull request.
> > -Daniel
> > ---
> >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > index ef123eb29168..d2ba8f7e5e50 100644
> > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> >         select DRM_I915_SELFTEST
> >         select DRM_I915_DEBUG_RUNTIME_PM
> >         select DRM_I915_DEBUG_MMIO
> > -       select BROKEN # for prototype uAPI
>
> You have to replace it with another secret bool as you cannot otherwise
> enable CONFIG_BROKEN in .config.

Or this:

diff --git a/init/Kconfig b/init/Kconfig
index b4daad2bac23..4dbea1b9e6bb 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -75,6 +75,7 @@ menu "General setup"

 config BROKEN
        bool
+       default y

 config BROKEN_ON_SMP
        bool

Either way it needs to be in topic/core-for-CI, not in any official
tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
matter how well hidden, they'll all break. You can also just revert my
patch that Dave pushed to drm-next (to get us back into the linux-next
club).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Daniel Vetter]

On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Daniel Vetter (2019-11-05 19:38:29)
> > It's broken.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > Note: Probably best to apply this directly onto drm-next to avoid
> > having drm-next dropped from linux-next until the next pull request.
> > -Daniel
> > ---
> >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > index ef123eb29168..d2ba8f7e5e50 100644
> > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> >         select DRM_I915_SELFTEST
> >         select DRM_I915_DEBUG_RUNTIME_PM
> >         select DRM_I915_DEBUG_MMIO
> > -       select BROKEN # for prototype uAPI
>
> You have to replace it with another secret bool as you cannot otherwise
> enable CONFIG_BROKEN in .config.

Or this:

diff --git a/init/Kconfig b/init/Kconfig
index b4daad2bac23..4dbea1b9e6bb 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -75,6 +75,7 @@ menu "General setup"

 config BROKEN
        bool
+       default y

 config BROKEN_ON_SMP
        bool

Either way it needs to be in topic/core-for-CI, not in any official
tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
matter how well hidden, they'll all break. You can also just revert my
patch that Dave pushed to drm-next (to get us back into the linux-next
club).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 20:58:25)
> On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > It's broken.
> > >
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > ---
> > > Note: Probably best to apply this directly onto drm-next to avoid
> > > having drm-next dropped from linux-next until the next pull request.
> > > -Daniel
> > > ---
> > >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > > index ef123eb29168..d2ba8f7e5e50 100644
> > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> > >         select DRM_I915_SELFTEST
> > >         select DRM_I915_DEBUG_RUNTIME_PM
> > >         select DRM_I915_DEBUG_MMIO
> > > -       select BROKEN # for prototype uAPI
> >
> > You have to replace it with another secret bool as you cannot otherwise
> > enable CONFIG_BROKEN in .config.
> 
> Or this:
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index b4daad2bac23..4dbea1b9e6bb 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -75,6 +75,7 @@ menu "General setup"
> 
>  config BROKEN
>         bool
> +       default y
> 
>  config BROKEN_ON_SMP
>         bool
> 
> Either way it needs to be in topic/core-for-CI, not in any official
> tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
> matter how well hidden, they'll all break. You can also just revert my
> patch that Dave pushed to drm-next (to get us back into the linux-next
> club).

But we've explicitly tried to stop autobuilders from selecting it in the
first place. That I think is a problem all of its own.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 20:58:25)
> On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > It's broken.
> > >
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > ---
> > > Note: Probably best to apply this directly onto drm-next to avoid
> > > having drm-next dropped from linux-next until the next pull request.
> > > -Daniel
> > > ---
> > >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > > index ef123eb29168..d2ba8f7e5e50 100644
> > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> > >         select DRM_I915_SELFTEST
> > >         select DRM_I915_DEBUG_RUNTIME_PM
> > >         select DRM_I915_DEBUG_MMIO
> > > -       select BROKEN # for prototype uAPI
> >
> > You have to replace it with another secret bool as you cannot otherwise
> > enable CONFIG_BROKEN in .config.
> 
> Or this:
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index b4daad2bac23..4dbea1b9e6bb 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -75,6 +75,7 @@ menu "General setup"
> 
>  config BROKEN
>         bool
> +       default y
> 
>  config BROKEN_ON_SMP
>         bool
> 
> Either way it needs to be in topic/core-for-CI, not in any official
> tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
> matter how well hidden, they'll all break. You can also just revert my
> patch that Dave pushed to drm-next (to get us back into the linux-next
> club).

But we've explicitly tried to stop autobuilders from selecting it in the
first place. That I think is a problem all of its own.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 20:58:25)
> On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > It's broken.
> > >
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > ---
> > > Note: Probably best to apply this directly onto drm-next to avoid
> > > having drm-next dropped from linux-next until the next pull request.
> > > -Daniel
> > > ---
> > >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > > index ef123eb29168..d2ba8f7e5e50 100644
> > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> > >         select DRM_I915_SELFTEST
> > >         select DRM_I915_DEBUG_RUNTIME_PM
> > >         select DRM_I915_DEBUG_MMIO
> > > -       select BROKEN # for prototype uAPI
> >
> > You have to replace it with another secret bool as you cannot otherwise
> > enable CONFIG_BROKEN in .config.
> 
> Or this:
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index b4daad2bac23..4dbea1b9e6bb 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -75,6 +75,7 @@ menu "General setup"
> 
>  config BROKEN
>         bool
> +       default y
> 
>  config BROKEN_ON_SMP
>         bool
> 
> Either way it needs to be in topic/core-for-CI, not in any official
> tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
> matter how well hidden, they'll all break. You can also just revert my
> patch that Dave pushed to drm-next (to get us back into the linux-next
> club).

Fwiw, I think the revert in core-for-CI is reasonable, as that gives
devs the ability to toggle on the hidden menus, while at the same time
requiring them to have the minimal debug setup.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 20:58:25)
> On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > It's broken.
> > >
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > ---
> > > Note: Probably best to apply this directly onto drm-next to avoid
> > > having drm-next dropped from linux-next until the next pull request.
> > > -Daniel
> > > ---
> > >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > > index ef123eb29168..d2ba8f7e5e50 100644
> > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> > >         select DRM_I915_SELFTEST
> > >         select DRM_I915_DEBUG_RUNTIME_PM
> > >         select DRM_I915_DEBUG_MMIO
> > > -       select BROKEN # for prototype uAPI
> >
> > You have to replace it with another secret bool as you cannot otherwise
> > enable CONFIG_BROKEN in .config.
> 
> Or this:
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index b4daad2bac23..4dbea1b9e6bb 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -75,6 +75,7 @@ menu "General setup"
> 
>  config BROKEN
>         bool
> +       default y
> 
>  config BROKEN_ON_SMP
>         bool
> 
> Either way it needs to be in topic/core-for-CI, not in any official
> tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
> matter how well hidden, they'll all break. You can also just revert my
> patch that Dave pushed to drm-next (to get us back into the linux-next
> club).

Fwiw, I think the revert in core-for-CI is reasonable, as that gives
devs the ability to toggle on the hidden menus, while at the same time
requiring them to have the minimal debug setup.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Chris Wilson]

Quoting Daniel Vetter (2019-11-05 20:58:25)
> On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > It's broken.
> > >
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > ---
> > > Note: Probably best to apply this directly onto drm-next to avoid
> > > having drm-next dropped from linux-next until the next pull request.
> > > -Daniel
> > > ---
> > >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > > index ef123eb29168..d2ba8f7e5e50 100644
> > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> > >         select DRM_I915_SELFTEST
> > >         select DRM_I915_DEBUG_RUNTIME_PM
> > >         select DRM_I915_DEBUG_MMIO
> > > -       select BROKEN # for prototype uAPI
> >
> > You have to replace it with another secret bool as you cannot otherwise
> > enable CONFIG_BROKEN in .config.
> 
> Or this:
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index b4daad2bac23..4dbea1b9e6bb 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -75,6 +75,7 @@ menu "General setup"
> 
>  config BROKEN
>         bool
> +       default y
> 
>  config BROKEN_ON_SMP
>         bool
> 
> Either way it needs to be in topic/core-for-CI, not in any official
> tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
> matter how well hidden, they'll all break. You can also just revert my
> patch that Dave pushed to drm-next (to get us back into the linux-next
> club).

Fwiw, I think the revert in core-for-CI is reasonable, as that gives
devs the ability to toggle on the hidden menus, while at the same time
requiring them to have the minimal debug setup.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BUILD: failure for drm/i915: Don't select BROKEN (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: Don't select BROKEN (rev2)
URL   : https://patchwork.freedesktop.org/series/69013/
State : failure

== Summary ==

Applying: drm/i915: Don't select BROKEN
error: patch failed: init/Kconfig:75
error: init/Kconfig: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Using index info to reconstruct a base tree...
Patch failed at 0001 drm/i915: Don't select BROKEN
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Don't select BROKEN (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: Don't select BROKEN (rev2)
URL   : https://patchwork.freedesktop.org/series/69013/
State : failure

== Summary ==

Applying: drm/i915: Don't select BROKEN
error: patch failed: init/Kconfig:75
error: init/Kconfig: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Using index info to reconstruct a base tree...
Patch failed at 0001 drm/i915: Don't select BROKEN
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Joonas Lahtinen]

Quoting Chris Wilson (2019-11-05 23:13:36)
> Quoting Daniel Vetter (2019-11-05 20:58:25)
> > On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > > It's broken.
> > > >
> > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > ---
> > > > Note: Probably best to apply this directly onto drm-next to avoid
> > > > having drm-next dropped from linux-next until the next pull request.
> > > > -Daniel
> > > > ---
> > > >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > > > index ef123eb29168..d2ba8f7e5e50 100644
> > > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> > > >         select DRM_I915_SELFTEST
> > > >         select DRM_I915_DEBUG_RUNTIME_PM
> > > >         select DRM_I915_DEBUG_MMIO
> > > > -       select BROKEN # for prototype uAPI
> > >
> > > You have to replace it with another secret bool as you cannot otherwise
> > > enable CONFIG_BROKEN in .config.
> > 
> > Or this:
> > 
> > diff --git a/init/Kconfig b/init/Kconfig
> > index b4daad2bac23..4dbea1b9e6bb 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -75,6 +75,7 @@ menu "General setup"
> > 
> >  config BROKEN
> >         bool
> > +       default y
> > 
> >  config BROKEN_ON_SMP
> >         bool
> > 
> > Either way it needs to be in topic/core-for-CI, not in any official
> > tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
> > matter how well hidden, they'll all break. You can also just revert my
> > patch that Dave pushed to drm-next (to get us back into the linux-next
> > club).
> 
> Fwiw, I think the revert in core-for-CI is reasonable, as that gives
> devs the ability to toggle on the hidden menus, while at the same time
> requiring them to have the minimal debug setup.

I've now reverted this in core-for-CI.

Regards, Joonas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

[Joonas Lahtinen]

Quoting Chris Wilson (2019-11-05 23:13:36)
> Quoting Daniel Vetter (2019-11-05 20:58:25)
> > On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > > It's broken.
> > > >
> > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > ---
> > > > Note: Probably best to apply this directly onto drm-next to avoid
> > > > having drm-next dropped from linux-next until the next pull request.
> > > > -Daniel
> > > > ---
> > > >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > > > index ef123eb29168..d2ba8f7e5e50 100644
> > > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> > > >         select DRM_I915_SELFTEST
> > > >         select DRM_I915_DEBUG_RUNTIME_PM
> > > >         select DRM_I915_DEBUG_MMIO
> > > > -       select BROKEN # for prototype uAPI
> > >
> > > You have to replace it with another secret bool as you cannot otherwise
> > > enable CONFIG_BROKEN in .config.
> > 
> > Or this:
> > 
> > diff --git a/init/Kconfig b/init/Kconfig
> > index b4daad2bac23..4dbea1b9e6bb 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -75,6 +75,7 @@ menu "General setup"
> > 
> >  config BROKEN
> >         bool
> > +       default y
> > 
> >  config BROKEN_ON_SMP
> >         bool
> > 
> > Either way it needs to be in topic/core-for-CI, not in any official
> > tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
> > matter how well hidden, they'll all break. You can also just revert my
> > patch that Dave pushed to drm-next (to get us back into the linux-next
> > club).
> 
> Fwiw, I think the revert in core-for-CI is reasonable, as that gives
> devs the ability to toggle on the hidden menus, while at the same time
> requiring them to have the minimal debug setup.

I've now reverted this in core-for-CI.

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx