* [PATCH] drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-06 6:47 ` Lucas De Marchi
0 siblings, 0 replies; 16+ messages in thread
From: Lucas De Marchi @ 2019-11-06 6:47 UTC (permalink / raw)
To: intel-gfx
Prefer using intel_encoder and pass the base where needed rather than
keeping both encoder and intel_encoder variables around.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 56 ++++++++++++------------
1 file changed, 27 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index c91521bcf06a..dcc6085cb937 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4687,8 +4687,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
struct ddi_vbt_port_info *port_info =
&dev_priv->vbt.ddi_port_info[port];
struct intel_digital_port *intel_dig_port;
- struct intel_encoder *intel_encoder;
- struct drm_encoder *encoder;
+ struct intel_encoder *encoder;
bool init_hdmi, init_dp, init_lspcon = false;
enum phy phy = intel_port_to_phy(dev_priv, port);
@@ -4717,31 +4716,29 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
if (!intel_dig_port)
return;
- intel_encoder = &intel_dig_port->base;
- encoder = &intel_encoder->base;
-
- drm_encoder_init(&dev_priv->drm, encoder, &intel_ddi_funcs,
+ drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
DRM_MODE_ENCODER_TMDS, "DDI %c", port_name(port));
- intel_encoder->hotplug = intel_ddi_hotplug;
- intel_encoder->compute_output_type = intel_ddi_compute_output_type;
- intel_encoder->compute_config = intel_ddi_compute_config;
- intel_encoder->enable = intel_enable_ddi;
- intel_encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
- intel_encoder->post_pll_disable = intel_ddi_post_pll_disable;
- intel_encoder->pre_enable = intel_ddi_pre_enable;
- intel_encoder->disable = intel_disable_ddi;
- intel_encoder->post_disable = intel_ddi_post_disable;
- intel_encoder->update_pipe = intel_ddi_update_pipe;
- intel_encoder->get_hw_state = intel_ddi_get_hw_state;
- intel_encoder->get_config = intel_ddi_get_config;
- intel_encoder->suspend = intel_dp_encoder_suspend;
- intel_encoder->get_power_domains = intel_ddi_get_power_domains;
- intel_encoder->type = INTEL_OUTPUT_DDI;
- intel_encoder->power_domain = intel_port_to_power_domain(port);
- intel_encoder->port = port;
- intel_encoder->cloneable = 0;
- intel_encoder->pipe_mask = ~0;
+ encoder->hotplug = intel_ddi_hotplug;
+ encoder->compute_output_type = intel_ddi_compute_output_type;
+ encoder->compute_config = intel_ddi_compute_config;
+ encoder->enable = intel_enable_ddi;
+ encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
+ encoder->post_pll_disable = intel_ddi_post_pll_disable;
+ encoder->pre_enable = intel_ddi_pre_enable;
+ encoder->disable = intel_disable_ddi;
+ encoder->post_disable = intel_ddi_post_disable;
+ encoder->update_pipe = intel_ddi_update_pipe;
+ encoder->get_hw_state = intel_ddi_get_hw_state;
+ encoder->get_config = intel_ddi_get_config;
+ encoder->suspend = intel_dp_encoder_suspend;
+ encoder->get_power_domains = intel_ddi_get_power_domains;
+
+ encoder->type = INTEL_OUTPUT_DDI;
+ encoder->power_domain = intel_port_to_power_domain(port);
+ encoder->port = port;
+ encoder->cloneable = 0;
+ encoder->pipe_mask = ~0;
if (INTEL_GEN(dev_priv) >= 11)
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
@@ -4749,6 +4746,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
else
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
(DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
+
intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
intel_dig_port->max_lanes = intel_ddi_max_lanes(intel_dig_port);
intel_dig_port->aux_ch = intel_bios_port_aux_ch(dev_priv, port);
@@ -4759,8 +4757,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_tc_port_init(intel_dig_port, is_legacy);
- intel_encoder->update_prepare = intel_ddi_update_prepare;
- intel_encoder->update_complete = intel_ddi_update_complete;
+ encoder->update_prepare = intel_ddi_update_prepare;
+ encoder->update_complete = intel_ddi_update_complete;
}
WARN_ON(port > PORT_I);
@@ -4776,7 +4774,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
/* In theory we don't need the encoder->type check, but leave it just in
* case we have some really bad VBTs... */
- if (intel_encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
+ if (encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
if (!intel_ddi_init_hdmi_connector(intel_dig_port))
goto err;
}
@@ -4800,6 +4798,6 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
return;
err:
- drm_encoder_cleanup(encoder);
+ drm_encoder_cleanup(&encoder->base);
kfree(intel_dig_port);
}
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-06 6:47 ` Lucas De Marchi
0 siblings, 0 replies; 16+ messages in thread
From: Lucas De Marchi @ 2019-11-06 6:47 UTC (permalink / raw)
To: intel-gfx
Prefer using intel_encoder and pass the base where needed rather than
keeping both encoder and intel_encoder variables around.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 56 ++++++++++++------------
1 file changed, 27 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index c91521bcf06a..dcc6085cb937 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4687,8 +4687,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
struct ddi_vbt_port_info *port_info =
&dev_priv->vbt.ddi_port_info[port];
struct intel_digital_port *intel_dig_port;
- struct intel_encoder *intel_encoder;
- struct drm_encoder *encoder;
+ struct intel_encoder *encoder;
bool init_hdmi, init_dp, init_lspcon = false;
enum phy phy = intel_port_to_phy(dev_priv, port);
@@ -4717,31 +4716,29 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
if (!intel_dig_port)
return;
- intel_encoder = &intel_dig_port->base;
- encoder = &intel_encoder->base;
-
- drm_encoder_init(&dev_priv->drm, encoder, &intel_ddi_funcs,
+ drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
DRM_MODE_ENCODER_TMDS, "DDI %c", port_name(port));
- intel_encoder->hotplug = intel_ddi_hotplug;
- intel_encoder->compute_output_type = intel_ddi_compute_output_type;
- intel_encoder->compute_config = intel_ddi_compute_config;
- intel_encoder->enable = intel_enable_ddi;
- intel_encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
- intel_encoder->post_pll_disable = intel_ddi_post_pll_disable;
- intel_encoder->pre_enable = intel_ddi_pre_enable;
- intel_encoder->disable = intel_disable_ddi;
- intel_encoder->post_disable = intel_ddi_post_disable;
- intel_encoder->update_pipe = intel_ddi_update_pipe;
- intel_encoder->get_hw_state = intel_ddi_get_hw_state;
- intel_encoder->get_config = intel_ddi_get_config;
- intel_encoder->suspend = intel_dp_encoder_suspend;
- intel_encoder->get_power_domains = intel_ddi_get_power_domains;
- intel_encoder->type = INTEL_OUTPUT_DDI;
- intel_encoder->power_domain = intel_port_to_power_domain(port);
- intel_encoder->port = port;
- intel_encoder->cloneable = 0;
- intel_encoder->pipe_mask = ~0;
+ encoder->hotplug = intel_ddi_hotplug;
+ encoder->compute_output_type = intel_ddi_compute_output_type;
+ encoder->compute_config = intel_ddi_compute_config;
+ encoder->enable = intel_enable_ddi;
+ encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
+ encoder->post_pll_disable = intel_ddi_post_pll_disable;
+ encoder->pre_enable = intel_ddi_pre_enable;
+ encoder->disable = intel_disable_ddi;
+ encoder->post_disable = intel_ddi_post_disable;
+ encoder->update_pipe = intel_ddi_update_pipe;
+ encoder->get_hw_state = intel_ddi_get_hw_state;
+ encoder->get_config = intel_ddi_get_config;
+ encoder->suspend = intel_dp_encoder_suspend;
+ encoder->get_power_domains = intel_ddi_get_power_domains;
+
+ encoder->type = INTEL_OUTPUT_DDI;
+ encoder->power_domain = intel_port_to_power_domain(port);
+ encoder->port = port;
+ encoder->cloneable = 0;
+ encoder->pipe_mask = ~0;
if (INTEL_GEN(dev_priv) >= 11)
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
@@ -4749,6 +4746,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
else
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
(DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
+
intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
intel_dig_port->max_lanes = intel_ddi_max_lanes(intel_dig_port);
intel_dig_port->aux_ch = intel_bios_port_aux_ch(dev_priv, port);
@@ -4759,8 +4757,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_tc_port_init(intel_dig_port, is_legacy);
- intel_encoder->update_prepare = intel_ddi_update_prepare;
- intel_encoder->update_complete = intel_ddi_update_complete;
+ encoder->update_prepare = intel_ddi_update_prepare;
+ encoder->update_complete = intel_ddi_update_complete;
}
WARN_ON(port > PORT_I);
@@ -4776,7 +4774,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
/* In theory we don't need the encoder->type check, but leave it just in
* case we have some really bad VBTs... */
- if (intel_encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
+ if (encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
if (!intel_ddi_init_hdmi_connector(intel_dig_port))
goto err;
}
@@ -4800,6 +4798,6 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
return;
err:
- drm_encoder_cleanup(encoder);
+ drm_encoder_cleanup(&encoder->base);
kfree(intel_dig_port);
}
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-06 7:08 ` Patchwork
0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-06 7:08 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: switch intel_ddi_init() to intel types
URL : https://patchwork.freedesktop.org/series/69031/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7264 -> Patchwork_15143
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15143 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15143, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15143/index.html
Known issues
------------
Here are the changes found in Patchwork_15143 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([fdo# 111542])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15143/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
Participating hosts (51 -> 12)
------------------------------
ERROR: It appears as if the changes made in Patchwork_15143 prevented too many machines from booting.
Missing (39): fi-kbl-soraka fi-skl-6770hq fi-bdw-gvtdvm fi-icl-u2 fi-apl-guc fi-icl-u3 fi-icl-y fi-skl-lmem fi-icl-guc fi-icl-dsi fi-skl-6600u fi-cml-u2 fi-icl-u4 fi-bxt-dsi fi-bdw-5557u fi-cml-s fi-glk-dsi fi-bwr-2160 fi-kbl-7500u fi-ctg-p8600 fi-hsw-4770 fi-gdg-551 fi-skl-6700k2 fi-kbl-r fi-ilk-m540 fi-skl-guc fi-cfl-8700k fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-cfl-guc fi-kbl-guc fi-whl-u fi-kbl-x1275 fi-cfl-8109u fi-kbl-8809g fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7264 -> Patchwork_15143
CI-20190529: 20190529
CI_DRM_7264: f5cfd96ad87b58bf3b5dfa5365f8beb8bac15a38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15143: 5e926fe5e0303939e8cd3c2985f6a1549ed85a23 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5e926fe5e030 drm/i915: switch intel_ddi_init() to intel types
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15143/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-06 7:08 ` Patchwork
0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-06 7:08 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: switch intel_ddi_init() to intel types
URL : https://patchwork.freedesktop.org/series/69031/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7264 -> Patchwork_15143
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15143 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15143, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15143/index.html
Known issues
------------
Here are the changes found in Patchwork_15143 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([fdo# 111542])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15143/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
Participating hosts (51 -> 12)
------------------------------
ERROR: It appears as if the changes made in Patchwork_15143 prevented too many machines from booting.
Missing (39): fi-kbl-soraka fi-skl-6770hq fi-bdw-gvtdvm fi-icl-u2 fi-apl-guc fi-icl-u3 fi-icl-y fi-skl-lmem fi-icl-guc fi-icl-dsi fi-skl-6600u fi-cml-u2 fi-icl-u4 fi-bxt-dsi fi-bdw-5557u fi-cml-s fi-glk-dsi fi-bwr-2160 fi-kbl-7500u fi-ctg-p8600 fi-hsw-4770 fi-gdg-551 fi-skl-6700k2 fi-kbl-r fi-ilk-m540 fi-skl-guc fi-cfl-8700k fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-cfl-guc fi-kbl-guc fi-whl-u fi-kbl-x1275 fi-cfl-8109u fi-kbl-8809g fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7264 -> Patchwork_15143
CI-20190529: 20190529
CI_DRM_7264: f5cfd96ad87b58bf3b5dfa5365f8beb8bac15a38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15143: 5e926fe5e0303939e8cd3c2985f6a1549ed85a23 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5e926fe5e030 drm/i915: switch intel_ddi_init() to intel types
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15143/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-06 7:17 ` Lucas De Marchi
0 siblings, 0 replies; 16+ messages in thread
From: Lucas De Marchi @ 2019-11-06 7:17 UTC (permalink / raw)
To: intel-gfx
Prefer using intel_encoder and pass the base where needed rather than
keeping both encoder and intel_encoder variables around.
v2: actually add all changes to the patch
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 56 ++++++++++++------------
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index c91521bcf06a..398c6f054a6e 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4687,8 +4687,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
struct ddi_vbt_port_info *port_info =
&dev_priv->vbt.ddi_port_info[port];
struct intel_digital_port *intel_dig_port;
- struct intel_encoder *intel_encoder;
- struct drm_encoder *encoder;
+ struct intel_encoder *encoder;
bool init_hdmi, init_dp, init_lspcon = false;
enum phy phy = intel_port_to_phy(dev_priv, port);
@@ -4717,31 +4716,31 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
if (!intel_dig_port)
return;
- intel_encoder = &intel_dig_port->base;
- encoder = &intel_encoder->base;
+ encoder = &intel_dig_port->base;
- drm_encoder_init(&dev_priv->drm, encoder, &intel_ddi_funcs,
+ drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
DRM_MODE_ENCODER_TMDS, "DDI %c", port_name(port));
- intel_encoder->hotplug = intel_ddi_hotplug;
- intel_encoder->compute_output_type = intel_ddi_compute_output_type;
- intel_encoder->compute_config = intel_ddi_compute_config;
- intel_encoder->enable = intel_enable_ddi;
- intel_encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
- intel_encoder->post_pll_disable = intel_ddi_post_pll_disable;
- intel_encoder->pre_enable = intel_ddi_pre_enable;
- intel_encoder->disable = intel_disable_ddi;
- intel_encoder->post_disable = intel_ddi_post_disable;
- intel_encoder->update_pipe = intel_ddi_update_pipe;
- intel_encoder->get_hw_state = intel_ddi_get_hw_state;
- intel_encoder->get_config = intel_ddi_get_config;
- intel_encoder->suspend = intel_dp_encoder_suspend;
- intel_encoder->get_power_domains = intel_ddi_get_power_domains;
- intel_encoder->type = INTEL_OUTPUT_DDI;
- intel_encoder->power_domain = intel_port_to_power_domain(port);
- intel_encoder->port = port;
- intel_encoder->cloneable = 0;
- intel_encoder->pipe_mask = ~0;
+ encoder->hotplug = intel_ddi_hotplug;
+ encoder->compute_output_type = intel_ddi_compute_output_type;
+ encoder->compute_config = intel_ddi_compute_config;
+ encoder->enable = intel_enable_ddi;
+ encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
+ encoder->post_pll_disable = intel_ddi_post_pll_disable;
+ encoder->pre_enable = intel_ddi_pre_enable;
+ encoder->disable = intel_disable_ddi;
+ encoder->post_disable = intel_ddi_post_disable;
+ encoder->update_pipe = intel_ddi_update_pipe;
+ encoder->get_hw_state = intel_ddi_get_hw_state;
+ encoder->get_config = intel_ddi_get_config;
+ encoder->suspend = intel_dp_encoder_suspend;
+ encoder->get_power_domains = intel_ddi_get_power_domains;
+
+ encoder->type = INTEL_OUTPUT_DDI;
+ encoder->power_domain = intel_port_to_power_domain(port);
+ encoder->port = port;
+ encoder->cloneable = 0;
+ encoder->pipe_mask = ~0;
if (INTEL_GEN(dev_priv) >= 11)
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
@@ -4749,6 +4748,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
else
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
(DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
+
intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
intel_dig_port->max_lanes = intel_ddi_max_lanes(intel_dig_port);
intel_dig_port->aux_ch = intel_bios_port_aux_ch(dev_priv, port);
@@ -4759,8 +4759,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_tc_port_init(intel_dig_port, is_legacy);
- intel_encoder->update_prepare = intel_ddi_update_prepare;
- intel_encoder->update_complete = intel_ddi_update_complete;
+ encoder->update_prepare = intel_ddi_update_prepare;
+ encoder->update_complete = intel_ddi_update_complete;
}
WARN_ON(port > PORT_I);
@@ -4776,7 +4776,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
/* In theory we don't need the encoder->type check, but leave it just in
* case we have some really bad VBTs... */
- if (intel_encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
+ if (encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
if (!intel_ddi_init_hdmi_connector(intel_dig_port))
goto err;
}
@@ -4800,6 +4800,6 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
return;
err:
- drm_encoder_cleanup(encoder);
+ drm_encoder_cleanup(&encoder->base);
kfree(intel_dig_port);
}
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-06 7:17 ` Lucas De Marchi
0 siblings, 0 replies; 16+ messages in thread
From: Lucas De Marchi @ 2019-11-06 7:17 UTC (permalink / raw)
To: intel-gfx
Prefer using intel_encoder and pass the base where needed rather than
keeping both encoder and intel_encoder variables around.
v2: actually add all changes to the patch
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 56 ++++++++++++------------
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index c91521bcf06a..398c6f054a6e 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4687,8 +4687,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
struct ddi_vbt_port_info *port_info =
&dev_priv->vbt.ddi_port_info[port];
struct intel_digital_port *intel_dig_port;
- struct intel_encoder *intel_encoder;
- struct drm_encoder *encoder;
+ struct intel_encoder *encoder;
bool init_hdmi, init_dp, init_lspcon = false;
enum phy phy = intel_port_to_phy(dev_priv, port);
@@ -4717,31 +4716,31 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
if (!intel_dig_port)
return;
- intel_encoder = &intel_dig_port->base;
- encoder = &intel_encoder->base;
+ encoder = &intel_dig_port->base;
- drm_encoder_init(&dev_priv->drm, encoder, &intel_ddi_funcs,
+ drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
DRM_MODE_ENCODER_TMDS, "DDI %c", port_name(port));
- intel_encoder->hotplug = intel_ddi_hotplug;
- intel_encoder->compute_output_type = intel_ddi_compute_output_type;
- intel_encoder->compute_config = intel_ddi_compute_config;
- intel_encoder->enable = intel_enable_ddi;
- intel_encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
- intel_encoder->post_pll_disable = intel_ddi_post_pll_disable;
- intel_encoder->pre_enable = intel_ddi_pre_enable;
- intel_encoder->disable = intel_disable_ddi;
- intel_encoder->post_disable = intel_ddi_post_disable;
- intel_encoder->update_pipe = intel_ddi_update_pipe;
- intel_encoder->get_hw_state = intel_ddi_get_hw_state;
- intel_encoder->get_config = intel_ddi_get_config;
- intel_encoder->suspend = intel_dp_encoder_suspend;
- intel_encoder->get_power_domains = intel_ddi_get_power_domains;
- intel_encoder->type = INTEL_OUTPUT_DDI;
- intel_encoder->power_domain = intel_port_to_power_domain(port);
- intel_encoder->port = port;
- intel_encoder->cloneable = 0;
- intel_encoder->pipe_mask = ~0;
+ encoder->hotplug = intel_ddi_hotplug;
+ encoder->compute_output_type = intel_ddi_compute_output_type;
+ encoder->compute_config = intel_ddi_compute_config;
+ encoder->enable = intel_enable_ddi;
+ encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
+ encoder->post_pll_disable = intel_ddi_post_pll_disable;
+ encoder->pre_enable = intel_ddi_pre_enable;
+ encoder->disable = intel_disable_ddi;
+ encoder->post_disable = intel_ddi_post_disable;
+ encoder->update_pipe = intel_ddi_update_pipe;
+ encoder->get_hw_state = intel_ddi_get_hw_state;
+ encoder->get_config = intel_ddi_get_config;
+ encoder->suspend = intel_dp_encoder_suspend;
+ encoder->get_power_domains = intel_ddi_get_power_domains;
+
+ encoder->type = INTEL_OUTPUT_DDI;
+ encoder->power_domain = intel_port_to_power_domain(port);
+ encoder->port = port;
+ encoder->cloneable = 0;
+ encoder->pipe_mask = ~0;
if (INTEL_GEN(dev_priv) >= 11)
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
@@ -4749,6 +4748,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
else
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
(DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
+
intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
intel_dig_port->max_lanes = intel_ddi_max_lanes(intel_dig_port);
intel_dig_port->aux_ch = intel_bios_port_aux_ch(dev_priv, port);
@@ -4759,8 +4759,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_tc_port_init(intel_dig_port, is_legacy);
- intel_encoder->update_prepare = intel_ddi_update_prepare;
- intel_encoder->update_complete = intel_ddi_update_complete;
+ encoder->update_prepare = intel_ddi_update_prepare;
+ encoder->update_complete = intel_ddi_update_complete;
}
WARN_ON(port > PORT_I);
@@ -4776,7 +4776,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
/* In theory we don't need the encoder->type check, but leave it just in
* case we have some really bad VBTs... */
- if (intel_encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
+ if (encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
if (!intel_ddi_init_hdmi_connector(intel_dig_port))
goto err;
}
@@ -4800,6 +4800,6 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
return;
err:
- drm_encoder_cleanup(encoder);
+ drm_encoder_cleanup(&encoder->base);
kfree(intel_dig_port);
}
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: switch intel_ddi_init() to intel types (rev2)
@ 2019-11-06 8:20 ` Patchwork
0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-06 8:20 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: switch intel_ddi_init() to intel types (rev2)
URL : https://patchwork.freedesktop.org/series/69031/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7264 -> Patchwork_15145
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/index.html
Known issues
------------
Here are the changes found in Patchwork_15145 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([fdo# 111542])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
* igt@prime_vgem@basic-fence-flip:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
#### Possible fixes ####
* igt@gem_mmap_gtt@basic-write-cpu-read-gtt:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-icl-u3/igt@gem_mmap_gtt@basic-write-cpu-read-gtt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-icl-u3/igt@gem_mmap_gtt@basic-write-cpu-read-gtt.html
* igt@i915_module_load@reload:
- {fi-icl-dsi}: [INCOMPLETE][7] ([fdo#107713]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-icl-dsi/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-icl-dsi/igt@i915_module_load@reload.html
* igt@kms_chamelium@hdmi-edid-read:
- {fi-icl-u4}: [FAIL][9] ([fdo#111045]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
#### Warnings ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [SKIP][11] ([fdo#109271]) -> [FAIL][12] ([fdo#110829])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#110829]: https://bugs.freedesktop.org/show_bug.cgi?id=110829
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111049]: https://bugs.freedesktop.org/show_bug.cgi?id=111049
Participating hosts (51 -> 42)
------------------------------
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-gdg-551 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7264 -> Patchwork_15145
CI-20190529: 20190529
CI_DRM_7264: f5cfd96ad87b58bf3b5dfa5365f8beb8bac15a38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15145: 6b54101d28731759f8723726aace39cffdd4d494 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
6b54101d2873 drm/i915: switch intel_ddi_init() to intel types
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: switch intel_ddi_init() to intel types (rev2)
@ 2019-11-06 8:20 ` Patchwork
0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-06 8:20 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: switch intel_ddi_init() to intel types (rev2)
URL : https://patchwork.freedesktop.org/series/69031/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7264 -> Patchwork_15145
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/index.html
Known issues
------------
Here are the changes found in Patchwork_15145 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([fdo# 111542])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
* igt@prime_vgem@basic-fence-flip:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
#### Possible fixes ####
* igt@gem_mmap_gtt@basic-write-cpu-read-gtt:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-icl-u3/igt@gem_mmap_gtt@basic-write-cpu-read-gtt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-icl-u3/igt@gem_mmap_gtt@basic-write-cpu-read-gtt.html
* igt@i915_module_load@reload:
- {fi-icl-dsi}: [INCOMPLETE][7] ([fdo#107713]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-icl-dsi/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-icl-dsi/igt@i915_module_load@reload.html
* igt@kms_chamelium@hdmi-edid-read:
- {fi-icl-u4}: [FAIL][9] ([fdo#111045]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
#### Warnings ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [SKIP][11] ([fdo#109271]) -> [FAIL][12] ([fdo#110829])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#110829]: https://bugs.freedesktop.org/show_bug.cgi?id=110829
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111049]: https://bugs.freedesktop.org/show_bug.cgi?id=111049
Participating hosts (51 -> 42)
------------------------------
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-gdg-551 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7264 -> Patchwork_15145
CI-20190529: 20190529
CI_DRM_7264: f5cfd96ad87b58bf3b5dfa5365f8beb8bac15a38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15145: 6b54101d28731759f8723726aace39cffdd4d494 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
6b54101d2873 drm/i915: switch intel_ddi_init() to intel types
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-06 13:31 ` Ville Syrjälä
0 siblings, 0 replies; 16+ messages in thread
From: Ville Syrjälä @ 2019-11-06 13:31 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Tue, Nov 05, 2019 at 11:17:17PM -0800, Lucas De Marchi wrote:
> Prefer using intel_encoder and pass the base where needed rather than
> keeping both encoder and intel_encoder variables around.
>
> v2: actually add all changes to the patch
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 56 ++++++++++++------------
> 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index c91521bcf06a..398c6f054a6e 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -4687,8 +4687,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> struct ddi_vbt_port_info *port_info =
> &dev_priv->vbt.ddi_port_info[port];
> struct intel_digital_port *intel_dig_port;
> - struct intel_encoder *intel_encoder;
> - struct drm_encoder *encoder;
> + struct intel_encoder *encoder;
> bool init_hdmi, init_dp, init_lspcon = false;
> enum phy phy = intel_port_to_phy(dev_priv, port);
>
> @@ -4717,31 +4716,31 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> if (!intel_dig_port)
> return;
>
> - intel_encoder = &intel_dig_port->base;
> - encoder = &intel_encoder->base;
> + encoder = &intel_dig_port->base;
>
> - drm_encoder_init(&dev_priv->drm, encoder, &intel_ddi_funcs,
> + drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
> DRM_MODE_ENCODER_TMDS, "DDI %c", port_name(port));
>
> - intel_encoder->hotplug = intel_ddi_hotplug;
> - intel_encoder->compute_output_type = intel_ddi_compute_output_type;
> - intel_encoder->compute_config = intel_ddi_compute_config;
> - intel_encoder->enable = intel_enable_ddi;
> - intel_encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
> - intel_encoder->post_pll_disable = intel_ddi_post_pll_disable;
> - intel_encoder->pre_enable = intel_ddi_pre_enable;
> - intel_encoder->disable = intel_disable_ddi;
> - intel_encoder->post_disable = intel_ddi_post_disable;
> - intel_encoder->update_pipe = intel_ddi_update_pipe;
> - intel_encoder->get_hw_state = intel_ddi_get_hw_state;
> - intel_encoder->get_config = intel_ddi_get_config;
> - intel_encoder->suspend = intel_dp_encoder_suspend;
> - intel_encoder->get_power_domains = intel_ddi_get_power_domains;
> - intel_encoder->type = INTEL_OUTPUT_DDI;
> - intel_encoder->power_domain = intel_port_to_power_domain(port);
> - intel_encoder->port = port;
> - intel_encoder->cloneable = 0;
> - intel_encoder->pipe_mask = ~0;
> + encoder->hotplug = intel_ddi_hotplug;
> + encoder->compute_output_type = intel_ddi_compute_output_type;
> + encoder->compute_config = intel_ddi_compute_config;
> + encoder->enable = intel_enable_ddi;
> + encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
> + encoder->post_pll_disable = intel_ddi_post_pll_disable;
> + encoder->pre_enable = intel_ddi_pre_enable;
> + encoder->disable = intel_disable_ddi;
> + encoder->post_disable = intel_ddi_post_disable;
> + encoder->update_pipe = intel_ddi_update_pipe;
> + encoder->get_hw_state = intel_ddi_get_hw_state;
> + encoder->get_config = intel_ddi_get_config;
> + encoder->suspend = intel_dp_encoder_suspend;
> + encoder->get_power_domains = intel_ddi_get_power_domains;
> +
> + encoder->type = INTEL_OUTPUT_DDI;
> + encoder->power_domain = intel_port_to_power_domain(port);
> + encoder->port = port;
> + encoder->cloneable = 0;
> + encoder->pipe_mask = ~0;
>
> if (INTEL_GEN(dev_priv) >= 11)
> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> @@ -4749,6 +4748,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> else
> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> (DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
> +
> intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
> intel_dig_port->max_lanes = intel_ddi_max_lanes(intel_dig_port);
> intel_dig_port->aux_ch = intel_bios_port_aux_ch(dev_priv, port);
> @@ -4759,8 +4759,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>
> intel_tc_port_init(intel_dig_port, is_legacy);
>
> - intel_encoder->update_prepare = intel_ddi_update_prepare;
> - intel_encoder->update_complete = intel_ddi_update_complete;
> + encoder->update_prepare = intel_ddi_update_prepare;
> + encoder->update_complete = intel_ddi_update_complete;
> }
>
> WARN_ON(port > PORT_I);
> @@ -4776,7 +4776,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>
> /* In theory we don't need the encoder->type check, but leave it just in
> * case we have some really bad VBTs... */
> - if (intel_encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
> + if (encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
> if (!intel_ddi_init_hdmi_connector(intel_dig_port))
> goto err;
> }
> @@ -4800,6 +4800,6 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> return;
>
> err:
> - drm_encoder_cleanup(encoder);
> + drm_encoder_cleanup(&encoder->base);
> kfree(intel_dig_port);
> }
> --
> 2.23.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-06 13:31 ` Ville Syrjälä
0 siblings, 0 replies; 16+ messages in thread
From: Ville Syrjälä @ 2019-11-06 13:31 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Tue, Nov 05, 2019 at 11:17:17PM -0800, Lucas De Marchi wrote:
> Prefer using intel_encoder and pass the base where needed rather than
> keeping both encoder and intel_encoder variables around.
>
> v2: actually add all changes to the patch
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 56 ++++++++++++------------
> 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index c91521bcf06a..398c6f054a6e 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -4687,8 +4687,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> struct ddi_vbt_port_info *port_info =
> &dev_priv->vbt.ddi_port_info[port];
> struct intel_digital_port *intel_dig_port;
> - struct intel_encoder *intel_encoder;
> - struct drm_encoder *encoder;
> + struct intel_encoder *encoder;
> bool init_hdmi, init_dp, init_lspcon = false;
> enum phy phy = intel_port_to_phy(dev_priv, port);
>
> @@ -4717,31 +4716,31 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> if (!intel_dig_port)
> return;
>
> - intel_encoder = &intel_dig_port->base;
> - encoder = &intel_encoder->base;
> + encoder = &intel_dig_port->base;
>
> - drm_encoder_init(&dev_priv->drm, encoder, &intel_ddi_funcs,
> + drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
> DRM_MODE_ENCODER_TMDS, "DDI %c", port_name(port));
>
> - intel_encoder->hotplug = intel_ddi_hotplug;
> - intel_encoder->compute_output_type = intel_ddi_compute_output_type;
> - intel_encoder->compute_config = intel_ddi_compute_config;
> - intel_encoder->enable = intel_enable_ddi;
> - intel_encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
> - intel_encoder->post_pll_disable = intel_ddi_post_pll_disable;
> - intel_encoder->pre_enable = intel_ddi_pre_enable;
> - intel_encoder->disable = intel_disable_ddi;
> - intel_encoder->post_disable = intel_ddi_post_disable;
> - intel_encoder->update_pipe = intel_ddi_update_pipe;
> - intel_encoder->get_hw_state = intel_ddi_get_hw_state;
> - intel_encoder->get_config = intel_ddi_get_config;
> - intel_encoder->suspend = intel_dp_encoder_suspend;
> - intel_encoder->get_power_domains = intel_ddi_get_power_domains;
> - intel_encoder->type = INTEL_OUTPUT_DDI;
> - intel_encoder->power_domain = intel_port_to_power_domain(port);
> - intel_encoder->port = port;
> - intel_encoder->cloneable = 0;
> - intel_encoder->pipe_mask = ~0;
> + encoder->hotplug = intel_ddi_hotplug;
> + encoder->compute_output_type = intel_ddi_compute_output_type;
> + encoder->compute_config = intel_ddi_compute_config;
> + encoder->enable = intel_enable_ddi;
> + encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
> + encoder->post_pll_disable = intel_ddi_post_pll_disable;
> + encoder->pre_enable = intel_ddi_pre_enable;
> + encoder->disable = intel_disable_ddi;
> + encoder->post_disable = intel_ddi_post_disable;
> + encoder->update_pipe = intel_ddi_update_pipe;
> + encoder->get_hw_state = intel_ddi_get_hw_state;
> + encoder->get_config = intel_ddi_get_config;
> + encoder->suspend = intel_dp_encoder_suspend;
> + encoder->get_power_domains = intel_ddi_get_power_domains;
> +
> + encoder->type = INTEL_OUTPUT_DDI;
> + encoder->power_domain = intel_port_to_power_domain(port);
> + encoder->port = port;
> + encoder->cloneable = 0;
> + encoder->pipe_mask = ~0;
>
> if (INTEL_GEN(dev_priv) >= 11)
> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> @@ -4749,6 +4748,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> else
> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> (DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
> +
> intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
> intel_dig_port->max_lanes = intel_ddi_max_lanes(intel_dig_port);
> intel_dig_port->aux_ch = intel_bios_port_aux_ch(dev_priv, port);
> @@ -4759,8 +4759,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>
> intel_tc_port_init(intel_dig_port, is_legacy);
>
> - intel_encoder->update_prepare = intel_ddi_update_prepare;
> - intel_encoder->update_complete = intel_ddi_update_complete;
> + encoder->update_prepare = intel_ddi_update_prepare;
> + encoder->update_complete = intel_ddi_update_complete;
> }
>
> WARN_ON(port > PORT_I);
> @@ -4776,7 +4776,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>
> /* In theory we don't need the encoder->type check, but leave it just in
> * case we have some really bad VBTs... */
> - if (intel_encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
> + if (encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
> if (!intel_ddi_init_hdmi_connector(intel_dig_port))
> goto err;
> }
> @@ -4800,6 +4800,6 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> return;
>
> err:
> - drm_encoder_cleanup(encoder);
> + drm_encoder_cleanup(&encoder->base);
> kfree(intel_dig_port);
> }
> --
> 2.23.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-07 0:22 ` Lucas De Marchi
0 siblings, 0 replies; 16+ messages in thread
From: Lucas De Marchi @ 2019-11-07 0:22 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, Nov 06, 2019 at 03:31:04PM +0200, Ville Syrjälä wrote:
>On Tue, Nov 05, 2019 at 11:17:17PM -0800, Lucas De Marchi wrote:
>> Prefer using intel_encoder and pass the base where needed rather than
>> keeping both encoder and intel_encoder variables around.
>>
>> v2: actually add all changes to the patch
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>lgtm
>Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
pushed, thanks
Lucas De Marchi
>
>> ---
>> drivers/gpu/drm/i915/display/intel_ddi.c | 56 ++++++++++++------------
>> 1 file changed, 28 insertions(+), 28 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
>> index c91521bcf06a..398c6f054a6e 100644
>> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
>> @@ -4687,8 +4687,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> struct ddi_vbt_port_info *port_info =
>> &dev_priv->vbt.ddi_port_info[port];
>> struct intel_digital_port *intel_dig_port;
>> - struct intel_encoder *intel_encoder;
>> - struct drm_encoder *encoder;
>> + struct intel_encoder *encoder;
>> bool init_hdmi, init_dp, init_lspcon = false;
>> enum phy phy = intel_port_to_phy(dev_priv, port);
>>
>> @@ -4717,31 +4716,31 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> if (!intel_dig_port)
>> return;
>>
>> - intel_encoder = &intel_dig_port->base;
>> - encoder = &intel_encoder->base;
>> + encoder = &intel_dig_port->base;
>>
>> - drm_encoder_init(&dev_priv->drm, encoder, &intel_ddi_funcs,
>> + drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
>> DRM_MODE_ENCODER_TMDS, "DDI %c", port_name(port));
>>
>> - intel_encoder->hotplug = intel_ddi_hotplug;
>> - intel_encoder->compute_output_type = intel_ddi_compute_output_type;
>> - intel_encoder->compute_config = intel_ddi_compute_config;
>> - intel_encoder->enable = intel_enable_ddi;
>> - intel_encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
>> - intel_encoder->post_pll_disable = intel_ddi_post_pll_disable;
>> - intel_encoder->pre_enable = intel_ddi_pre_enable;
>> - intel_encoder->disable = intel_disable_ddi;
>> - intel_encoder->post_disable = intel_ddi_post_disable;
>> - intel_encoder->update_pipe = intel_ddi_update_pipe;
>> - intel_encoder->get_hw_state = intel_ddi_get_hw_state;
>> - intel_encoder->get_config = intel_ddi_get_config;
>> - intel_encoder->suspend = intel_dp_encoder_suspend;
>> - intel_encoder->get_power_domains = intel_ddi_get_power_domains;
>> - intel_encoder->type = INTEL_OUTPUT_DDI;
>> - intel_encoder->power_domain = intel_port_to_power_domain(port);
>> - intel_encoder->port = port;
>> - intel_encoder->cloneable = 0;
>> - intel_encoder->pipe_mask = ~0;
>> + encoder->hotplug = intel_ddi_hotplug;
>> + encoder->compute_output_type = intel_ddi_compute_output_type;
>> + encoder->compute_config = intel_ddi_compute_config;
>> + encoder->enable = intel_enable_ddi;
>> + encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
>> + encoder->post_pll_disable = intel_ddi_post_pll_disable;
>> + encoder->pre_enable = intel_ddi_pre_enable;
>> + encoder->disable = intel_disable_ddi;
>> + encoder->post_disable = intel_ddi_post_disable;
>> + encoder->update_pipe = intel_ddi_update_pipe;
>> + encoder->get_hw_state = intel_ddi_get_hw_state;
>> + encoder->get_config = intel_ddi_get_config;
>> + encoder->suspend = intel_dp_encoder_suspend;
>> + encoder->get_power_domains = intel_ddi_get_power_domains;
>> +
>> + encoder->type = INTEL_OUTPUT_DDI;
>> + encoder->power_domain = intel_port_to_power_domain(port);
>> + encoder->port = port;
>> + encoder->cloneable = 0;
>> + encoder->pipe_mask = ~0;
>>
>> if (INTEL_GEN(dev_priv) >= 11)
>> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
>> @@ -4749,6 +4748,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> else
>> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
>> (DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
>> +
>> intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
>> intel_dig_port->max_lanes = intel_ddi_max_lanes(intel_dig_port);
>> intel_dig_port->aux_ch = intel_bios_port_aux_ch(dev_priv, port);
>> @@ -4759,8 +4759,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>>
>> intel_tc_port_init(intel_dig_port, is_legacy);
>>
>> - intel_encoder->update_prepare = intel_ddi_update_prepare;
>> - intel_encoder->update_complete = intel_ddi_update_complete;
>> + encoder->update_prepare = intel_ddi_update_prepare;
>> + encoder->update_complete = intel_ddi_update_complete;
>> }
>>
>> WARN_ON(port > PORT_I);
>> @@ -4776,7 +4776,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>>
>> /* In theory we don't need the encoder->type check, but leave it just in
>> * case we have some really bad VBTs... */
>> - if (intel_encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
>> + if (encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
>> if (!intel_ddi_init_hdmi_connector(intel_dig_port))
>> goto err;
>> }
>> @@ -4800,6 +4800,6 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> return;
>>
>> err:
>> - drm_encoder_cleanup(encoder);
>> + drm_encoder_cleanup(&encoder->base);
>> kfree(intel_dig_port);
>> }
>> --
>> 2.23.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Ville Syrjälä
>Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-07 0:22 ` Lucas De Marchi
0 siblings, 0 replies; 16+ messages in thread
From: Lucas De Marchi @ 2019-11-07 0:22 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, Nov 06, 2019 at 03:31:04PM +0200, Ville Syrjälä wrote:
>On Tue, Nov 05, 2019 at 11:17:17PM -0800, Lucas De Marchi wrote:
>> Prefer using intel_encoder and pass the base where needed rather than
>> keeping both encoder and intel_encoder variables around.
>>
>> v2: actually add all changes to the patch
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>lgtm
>Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
pushed, thanks
Lucas De Marchi
>
>> ---
>> drivers/gpu/drm/i915/display/intel_ddi.c | 56 ++++++++++++------------
>> 1 file changed, 28 insertions(+), 28 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
>> index c91521bcf06a..398c6f054a6e 100644
>> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
>> @@ -4687,8 +4687,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> struct ddi_vbt_port_info *port_info =
>> &dev_priv->vbt.ddi_port_info[port];
>> struct intel_digital_port *intel_dig_port;
>> - struct intel_encoder *intel_encoder;
>> - struct drm_encoder *encoder;
>> + struct intel_encoder *encoder;
>> bool init_hdmi, init_dp, init_lspcon = false;
>> enum phy phy = intel_port_to_phy(dev_priv, port);
>>
>> @@ -4717,31 +4716,31 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> if (!intel_dig_port)
>> return;
>>
>> - intel_encoder = &intel_dig_port->base;
>> - encoder = &intel_encoder->base;
>> + encoder = &intel_dig_port->base;
>>
>> - drm_encoder_init(&dev_priv->drm, encoder, &intel_ddi_funcs,
>> + drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
>> DRM_MODE_ENCODER_TMDS, "DDI %c", port_name(port));
>>
>> - intel_encoder->hotplug = intel_ddi_hotplug;
>> - intel_encoder->compute_output_type = intel_ddi_compute_output_type;
>> - intel_encoder->compute_config = intel_ddi_compute_config;
>> - intel_encoder->enable = intel_enable_ddi;
>> - intel_encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
>> - intel_encoder->post_pll_disable = intel_ddi_post_pll_disable;
>> - intel_encoder->pre_enable = intel_ddi_pre_enable;
>> - intel_encoder->disable = intel_disable_ddi;
>> - intel_encoder->post_disable = intel_ddi_post_disable;
>> - intel_encoder->update_pipe = intel_ddi_update_pipe;
>> - intel_encoder->get_hw_state = intel_ddi_get_hw_state;
>> - intel_encoder->get_config = intel_ddi_get_config;
>> - intel_encoder->suspend = intel_dp_encoder_suspend;
>> - intel_encoder->get_power_domains = intel_ddi_get_power_domains;
>> - intel_encoder->type = INTEL_OUTPUT_DDI;
>> - intel_encoder->power_domain = intel_port_to_power_domain(port);
>> - intel_encoder->port = port;
>> - intel_encoder->cloneable = 0;
>> - intel_encoder->pipe_mask = ~0;
>> + encoder->hotplug = intel_ddi_hotplug;
>> + encoder->compute_output_type = intel_ddi_compute_output_type;
>> + encoder->compute_config = intel_ddi_compute_config;
>> + encoder->enable = intel_enable_ddi;
>> + encoder->pre_pll_enable = intel_ddi_pre_pll_enable;
>> + encoder->post_pll_disable = intel_ddi_post_pll_disable;
>> + encoder->pre_enable = intel_ddi_pre_enable;
>> + encoder->disable = intel_disable_ddi;
>> + encoder->post_disable = intel_ddi_post_disable;
>> + encoder->update_pipe = intel_ddi_update_pipe;
>> + encoder->get_hw_state = intel_ddi_get_hw_state;
>> + encoder->get_config = intel_ddi_get_config;
>> + encoder->suspend = intel_dp_encoder_suspend;
>> + encoder->get_power_domains = intel_ddi_get_power_domains;
>> +
>> + encoder->type = INTEL_OUTPUT_DDI;
>> + encoder->power_domain = intel_port_to_power_domain(port);
>> + encoder->port = port;
>> + encoder->cloneable = 0;
>> + encoder->pipe_mask = ~0;
>>
>> if (INTEL_GEN(dev_priv) >= 11)
>> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
>> @@ -4749,6 +4748,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> else
>> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
>> (DDI_BUF_PORT_REVERSAL | DDI_A_4_LANES);
>> +
>> intel_dig_port->dp.output_reg = INVALID_MMIO_REG;
>> intel_dig_port->max_lanes = intel_ddi_max_lanes(intel_dig_port);
>> intel_dig_port->aux_ch = intel_bios_port_aux_ch(dev_priv, port);
>> @@ -4759,8 +4759,8 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>>
>> intel_tc_port_init(intel_dig_port, is_legacy);
>>
>> - intel_encoder->update_prepare = intel_ddi_update_prepare;
>> - intel_encoder->update_complete = intel_ddi_update_complete;
>> + encoder->update_prepare = intel_ddi_update_prepare;
>> + encoder->update_complete = intel_ddi_update_complete;
>> }
>>
>> WARN_ON(port > PORT_I);
>> @@ -4776,7 +4776,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>>
>> /* In theory we don't need the encoder->type check, but leave it just in
>> * case we have some really bad VBTs... */
>> - if (intel_encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
>> + if (encoder->type != INTEL_OUTPUT_EDP && init_hdmi) {
>> if (!intel_ddi_init_hdmi_connector(intel_dig_port))
>> goto err;
>> }
>> @@ -4800,6 +4800,6 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> return;
>>
>> err:
>> - drm_encoder_cleanup(encoder);
>> + drm_encoder_cleanup(&encoder->base);
>> kfree(intel_dig_port);
>> }
>> --
>> 2.23.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Ville Syrjälä
>Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: switch intel_ddi_init() to intel types (rev2)
@ 2019-11-07 2:14 ` Patchwork
0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-07 2:14 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: switch intel_ddi_init() to intel types (rev2)
URL : https://patchwork.freedesktop.org/series/69031/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15145_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15145_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15145_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15145_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@mock_requests:
- shard-glk: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-glk9/igt@i915_selftest@mock_requests.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-glk6/igt@i915_selftest@mock_requests.html
Known issues
------------
Here are the changes found in Patchwork_15145_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb4/igt@gem_ctx_isolation@vcs1-clean.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb3/igt@gem_ctx_isolation@vcs1-clean.html
* igt@gem_exec_basic@basic-vcs1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +11 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb1/igt@gem_exec_basic@basic-vcs1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb6/igt@gem_exec_basic@basic-vcs1.html
* igt@gem_exec_schedule@preempt-queue-bsd2:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +16 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd2.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd2.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb7/igt@gem_exec_schedule@reorder-wide-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#112037])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-snb1/igt@gem_userptr_blits@sync-unmap.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-snb7/igt@gem_userptr_blits@sync-unmap.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-kbl4/igt@gem_workarounds@suspend-resume-fd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-kbl6/igt@gem_workarounds@suspend-resume-fd.html
* igt@kms_draw_crc@draw-method-rgb565-blt-xtiled:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#103184] / [fdo#103232])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl8/igt@kms_draw_crc@draw-method-rgb565-blt-xtiled.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl3/igt@kms_draw_crc@draw-method-rgb565-blt-xtiled.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#103167]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([fdo#108566]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [fdo#110403])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb2/igt@kms_psr@psr2_dpms.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb5/igt@kms_psr@psr2_dpms.html
* igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([fdo#103313])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-modeset-hang.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-modeset-hang.html
* igt@perf@short-reads:
- shard-glk: [PASS][31] -> [TIMEOUT][32] ([fdo#103183])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-glk8/igt@perf@short-reads.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-glk7/igt@perf@short-reads.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [SKIP][33] ([fdo#112080]) -> [PASS][34] +9 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb6/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* {igt@gem_ctx_persistence@vcs1-mixed-process}:
- shard-iclb: [SKIP][35] ([fdo#109276] / [fdo#112080]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb7/igt@gem_ctx_persistence@vcs1-mixed-process.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][37] ([fdo#110854]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb6/igt@gem_exec_balancer@smoke.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_gttfill@basic:
- {shard-tglb}: [INCOMPLETE][39] ([fdo#111593]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb4/igt@gem_exec_gttfill@basic.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb7/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][41] ([fdo#112146]) -> [PASS][42] +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb2/igt@gem_exec_schedule@preemptive-hang-bsd.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_schedule@smoketest-all:
- {shard-tglb}: [INCOMPLETE][43] ([fdo#111855]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb3/igt@gem_exec_schedule@smoketest-all.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb9/igt@gem_exec_schedule@smoketest-all.html
* {igt@gem_exec_suspend@basic-s0}:
- {shard-tglb}: [INCOMPLETE][45] ([fdo#111832]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb1/igt@gem_exec_suspend@basic-s0.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb6/igt@gem_exec_suspend@basic-s0.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-hsw: [FAIL][47] ([fdo#112037]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-hsw8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
* {igt@i915_pm_dc@dc6-dpms}:
- shard-iclb: [FAIL][51] ([fdo#110548]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
* {igt@i915_selftest@live_gt_timelines}:
- {shard-tglb}: [INCOMPLETE][53] ([fdo#111831]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb6/igt@i915_selftest@live_gt_timelines.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb7/igt@i915_selftest@live_gt_timelines.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][55] ([fdo#108566]) -> [PASS][56] +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_fbcon_fbt@fbc-suspend:
- {shard-tglb}: [INCOMPLETE][57] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb9/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][59] ([fdo#105363]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [FAIL][61] ([fdo#100368]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl9/igt@kms_flip@plain-flip-fb-recreate.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl1/igt@kms_flip@plain-flip-fb-recreate.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [FAIL][63] ([fdo#103167]) -> [PASS][64] +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][67] ([fdo#108145] / [fdo#110403]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][69] ([fdo#108341]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb1/igt@kms_psr@no_drrs.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb7/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_gtt.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@suspend:
- {shard-tglb}: [INCOMPLETE][73] ([fdo#111832] / [fdo#111850]) -> [PASS][74] +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb4/igt@kms_psr@suspend.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb6/igt@kms_psr@suspend.html
* igt@kms_vblank@pipe-d-ts-continuation-suspend:
- {shard-tglb}: [INCOMPLETE][75] ([fdo#111850]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb9/igt@kms_vblank@pipe-d-ts-continuation-suspend.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [TIMEOUT][77] ([fdo#111732 ]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl7/igt@perf@gen8-unprivileged-single-ctx-counters.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl10/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][79] ([fdo#109276]) -> [PASS][80] +16 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb7/igt@prime_vgem@fence-wait-bsd2.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html
* igt@tools_test@tools_test:
- shard-snb: [SKIP][81] ([fdo#109271]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-snb5/igt@tools_test@tools_test.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-snb4/igt@tools_test@tools_test.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][83] ([fdo#111329]) -> [SKIP][84] ([fdo#109276] / [fdo#112080])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103183]: https://bugs.freedesktop.org/show_bug.cgi?id=103183
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111732 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111732
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
[fdo#111831]: https://bugs.freedesktop.org/show_bug.cgi?id=111831
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111855]: https://bugs.freedesktop.org/show_bug.cgi?id=111855
[fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
[fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112194]: https://bugs.freedesktop.org/show_bug.cgi?id=112194
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7264 -> Patchwork_15145
CI-20190529: 20190529
CI_DRM_7264: f5cfd96ad87b58bf3b5dfa5365f8beb8bac15a38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15145: 6b54101d28731759f8723726aace39cffdd4d494 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: switch intel_ddi_init() to intel types (rev2)
@ 2019-11-07 2:14 ` Patchwork
0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-07 2:14 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: switch intel_ddi_init() to intel types (rev2)
URL : https://patchwork.freedesktop.org/series/69031/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7264_full -> Patchwork_15145_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15145_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15145_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15145_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@mock_requests:
- shard-glk: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-glk9/igt@i915_selftest@mock_requests.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-glk6/igt@i915_selftest@mock_requests.html
Known issues
------------
Here are the changes found in Patchwork_15145_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb4/igt@gem_ctx_isolation@vcs1-clean.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb3/igt@gem_ctx_isolation@vcs1-clean.html
* igt@gem_exec_basic@basic-vcs1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +11 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb1/igt@gem_exec_basic@basic-vcs1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb6/igt@gem_exec_basic@basic-vcs1.html
* igt@gem_exec_schedule@preempt-queue-bsd2:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +16 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd2.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd2.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb7/igt@gem_exec_schedule@reorder-wide-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#112037])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-snb1/igt@gem_userptr_blits@sync-unmap.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-snb7/igt@gem_userptr_blits@sync-unmap.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-kbl4/igt@gem_workarounds@suspend-resume-fd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-kbl6/igt@gem_workarounds@suspend-resume-fd.html
* igt@kms_draw_crc@draw-method-rgb565-blt-xtiled:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#103184] / [fdo#103232])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl8/igt@kms_draw_crc@draw-method-rgb565-blt-xtiled.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl3/igt@kms_draw_crc@draw-method-rgb565-blt-xtiled.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#103167]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([fdo#108566]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [fdo#110403])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb2/igt@kms_psr@psr2_dpms.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb5/igt@kms_psr@psr2_dpms.html
* igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([fdo#103313])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-modeset-hang.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-modeset-hang.html
* igt@perf@short-reads:
- shard-glk: [PASS][31] -> [TIMEOUT][32] ([fdo#103183])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-glk8/igt@perf@short-reads.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-glk7/igt@perf@short-reads.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [SKIP][33] ([fdo#112080]) -> [PASS][34] +9 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb6/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* {igt@gem_ctx_persistence@vcs1-mixed-process}:
- shard-iclb: [SKIP][35] ([fdo#109276] / [fdo#112080]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb7/igt@gem_ctx_persistence@vcs1-mixed-process.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][37] ([fdo#110854]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb6/igt@gem_exec_balancer@smoke.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_gttfill@basic:
- {shard-tglb}: [INCOMPLETE][39] ([fdo#111593]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb4/igt@gem_exec_gttfill@basic.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb7/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][41] ([fdo#112146]) -> [PASS][42] +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb2/igt@gem_exec_schedule@preemptive-hang-bsd.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_schedule@smoketest-all:
- {shard-tglb}: [INCOMPLETE][43] ([fdo#111855]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb3/igt@gem_exec_schedule@smoketest-all.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb9/igt@gem_exec_schedule@smoketest-all.html
* {igt@gem_exec_suspend@basic-s0}:
- {shard-tglb}: [INCOMPLETE][45] ([fdo#111832]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb1/igt@gem_exec_suspend@basic-s0.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb6/igt@gem_exec_suspend@basic-s0.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-hsw: [FAIL][47] ([fdo#112037]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-hsw8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
* {igt@i915_pm_dc@dc6-dpms}:
- shard-iclb: [FAIL][51] ([fdo#110548]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
* {igt@i915_selftest@live_gt_timelines}:
- {shard-tglb}: [INCOMPLETE][53] ([fdo#111831]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb6/igt@i915_selftest@live_gt_timelines.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb7/igt@i915_selftest@live_gt_timelines.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][55] ([fdo#108566]) -> [PASS][56] +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_fbcon_fbt@fbc-suspend:
- {shard-tglb}: [INCOMPLETE][57] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb9/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][59] ([fdo#105363]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [FAIL][61] ([fdo#100368]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl9/igt@kms_flip@plain-flip-fb-recreate.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl1/igt@kms_flip@plain-flip-fb-recreate.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [FAIL][63] ([fdo#103167]) -> [PASS][64] +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][67] ([fdo#108145] / [fdo#110403]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][69] ([fdo#108341]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb1/igt@kms_psr@no_drrs.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb7/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_gtt.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@suspend:
- {shard-tglb}: [INCOMPLETE][73] ([fdo#111832] / [fdo#111850]) -> [PASS][74] +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb4/igt@kms_psr@suspend.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb6/igt@kms_psr@suspend.html
* igt@kms_vblank@pipe-d-ts-continuation-suspend:
- {shard-tglb}: [INCOMPLETE][75] ([fdo#111850]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-tglb9/igt@kms_vblank@pipe-d-ts-continuation-suspend.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [TIMEOUT][77] ([fdo#111732 ]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-skl7/igt@perf@gen8-unprivileged-single-ctx-counters.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-skl10/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][79] ([fdo#109276]) -> [PASS][80] +16 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb7/igt@prime_vgem@fence-wait-bsd2.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html
* igt@tools_test@tools_test:
- shard-snb: [SKIP][81] ([fdo#109271]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-snb5/igt@tools_test@tools_test.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-snb4/igt@tools_test@tools_test.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][83] ([fdo#111329]) -> [SKIP][84] ([fdo#109276] / [fdo#112080])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7264/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103183]: https://bugs.freedesktop.org/show_bug.cgi?id=103183
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111732 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111732
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
[fdo#111831]: https://bugs.freedesktop.org/show_bug.cgi?id=111831
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111855]: https://bugs.freedesktop.org/show_bug.cgi?id=111855
[fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
[fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112194]: https://bugs.freedesktop.org/show_bug.cgi?id=112194
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7264 -> Patchwork_15145
CI-20190529: 20190529
CI_DRM_7264: f5cfd96ad87b58bf3b5dfa5365f8beb8bac15a38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15145: 6b54101d28731759f8723726aace39cffdd4d494 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15145/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: switch intel_ddi_init() to intel types
2019-11-06 6:47 ` [Intel-gfx] " Lucas De Marchi
@ 2019-11-14 11:52 ` Dan Carpenter
-1 siblings, 0 replies; 16+ messages in thread
From: Dan Carpenter @ 2019-11-14 11:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6176 bytes --]
[ Resending with corrected From header. -dan ]
[ This does feel like potentially a bad merge... -dan ]
Hi Lucas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20191112]
[cannot apply to v5.4-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Lucas-De-Marchi/drm-i915-switch-intel_ddi_init-to-intel-types/20191108-185646
base: git://anongit.freedesktop.org/drm-intel for-linux-next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_ddi.c:4717 intel_ddi_init() error: uninitialized symbol 'encoder'.
# https://github.com/0day-ci/linux/commit/be1087a2f14d66a04a24e7cb5a7cc6a5166ff836
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout be1087a2f14d66a04a24e7cb5a7cc6a5166ff836
vim +/encoder +4717 drivers/gpu/drm/i915/display/intel_ddi.c
c39055b072f8b1 drivers/gpu/drm/i915/intel_ddi.c Ander Conselvan de Oliveira 2016-11-23 4683 void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4684 {
f6bff60e927b2f drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4685 struct ddi_vbt_port_info *port_info =
f6bff60e927b2f drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4686 &dev_priv->vbt.ddi_port_info[port];
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4687 struct intel_digital_port *intel_dig_port;
be1087a2f14d66 drivers/gpu/drm/i915/display/intel_ddi.c Lucas De Marchi 2019-11-05 4688 struct intel_encoder *encoder;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4689 bool init_hdmi, init_dp, init_lspcon = false;
d8fe2ab6bb283d drivers/gpu/drm/i915/display/intel_ddi.c Matt Roper 2019-07-09 4690 enum phy phy = intel_port_to_phy(dev_priv, port);
10e7bec38bbda4 drivers/gpu/drm/i915/intel_ddi.c Ville Syrjälä 2015-12-08 4691
f6bff60e927b2f drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4692 init_hdmi = port_info->supports_dvi || port_info->supports_hdmi;
f6bff60e927b2f drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4693 init_dp = port_info->supports_dp;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4694
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4695 if (intel_bios_is_lspcon_present(dev_priv, port)) {
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4696 /*
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4697 * Lspcon device needs to be driven with DP connector
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4698 * with special detection sequence. So make sure DP
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4699 * is initialized before lspcon.
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4700 */
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4701 init_dp = true;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4702 init_lspcon = true;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4703 init_hdmi = false;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4704 DRM_DEBUG_KMS("VBT says port %c has lspcon\n", port_name(port));
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4705 }
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4706
311a20949f047a drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2013-09-12 4707 if (!init_dp && !init_hdmi) {
500ea70d503ed9 drivers/gpu/drm/i915/intel_ddi.c Rodrigo Vivi 2015-08-07 4708 DRM_DEBUG_KMS("VBT says port %c is not DVI/HDMI/DP compatible, respect it\n",
311a20949f047a drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2013-09-12 4709 port_name(port));
500ea70d503ed9 drivers/gpu/drm/i915/intel_ddi.c Rodrigo Vivi 2015-08-07 4710 return;
311a20949f047a drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2013-09-12 4711 }
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4712
b14c5679dd2c87 drivers/gpu/drm/i915/intel_ddi.c Daniel Vetter 2013-09-19 4713 intel_dig_port = kzalloc(sizeof(*intel_dig_port), GFP_KERNEL);
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4714 if (!intel_dig_port)
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4715 return;
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4716
be1087a2f14d66 drivers/gpu/drm/i915/display/intel_ddi.c Lucas De Marchi 2019-11-05 @4717 drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: switch intel_ddi_init() to intel types
@ 2019-11-14 11:52 ` Dan Carpenter
0 siblings, 0 replies; 16+ messages in thread
From: Dan Carpenter @ 2019-11-14 11:52 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 6176 bytes --]
[ Resending with corrected From header. -dan ]
[ This does feel like potentially a bad merge... -dan ]
Hi Lucas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20191112]
[cannot apply to v5.4-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Lucas-De-Marchi/drm-i915-switch-intel_ddi_init-to-intel-types/20191108-185646
base: git://anongit.freedesktop.org/drm-intel for-linux-next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_ddi.c:4717 intel_ddi_init() error: uninitialized symbol 'encoder'.
# https://github.com/0day-ci/linux/commit/be1087a2f14d66a04a24e7cb5a7cc6a5166ff836
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout be1087a2f14d66a04a24e7cb5a7cc6a5166ff836
vim +/encoder +4717 drivers/gpu/drm/i915/display/intel_ddi.c
c39055b072f8b1 drivers/gpu/drm/i915/intel_ddi.c Ander Conselvan de Oliveira 2016-11-23 4683 void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4684 {
f6bff60e927b2f drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4685 struct ddi_vbt_port_info *port_info =
f6bff60e927b2f drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4686 &dev_priv->vbt.ddi_port_info[port];
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4687 struct intel_digital_port *intel_dig_port;
be1087a2f14d66 drivers/gpu/drm/i915/display/intel_ddi.c Lucas De Marchi 2019-11-05 4688 struct intel_encoder *encoder;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4689 bool init_hdmi, init_dp, init_lspcon = false;
d8fe2ab6bb283d drivers/gpu/drm/i915/display/intel_ddi.c Matt Roper 2019-07-09 4690 enum phy phy = intel_port_to_phy(dev_priv, port);
10e7bec38bbda4 drivers/gpu/drm/i915/intel_ddi.c Ville Syrjälä 2015-12-08 4691
f6bff60e927b2f drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4692 init_hdmi = port_info->supports_dvi || port_info->supports_hdmi;
f6bff60e927b2f drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4693 init_dp = port_info->supports_dp;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4694
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4695 if (intel_bios_is_lspcon_present(dev_priv, port)) {
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4696 /*
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4697 * Lspcon device needs to be driven with DP connector
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4698 * with special detection sequence. So make sure DP
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4699 * is initialized before lspcon.
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4700 */
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4701 init_dp = true;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4702 init_lspcon = true;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4703 init_hdmi = false;
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4704 DRM_DEBUG_KMS("VBT says port %c has lspcon\n", port_name(port));
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4705 }
ff66212415e324 drivers/gpu/drm/i915/intel_ddi.c Shashank Sharma 2016-10-14 4706
311a20949f047a drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2013-09-12 4707 if (!init_dp && !init_hdmi) {
500ea70d503ed9 drivers/gpu/drm/i915/intel_ddi.c Rodrigo Vivi 2015-08-07 4708 DRM_DEBUG_KMS("VBT says port %c is not DVI/HDMI/DP compatible, respect it\n",
311a20949f047a drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2013-09-12 4709 port_name(port));
500ea70d503ed9 drivers/gpu/drm/i915/intel_ddi.c Rodrigo Vivi 2015-08-07 4710 return;
311a20949f047a drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2013-09-12 4711 }
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4712
b14c5679dd2c87 drivers/gpu/drm/i915/intel_ddi.c Daniel Vetter 2013-09-19 4713 intel_dig_port = kzalloc(sizeof(*intel_dig_port), GFP_KERNEL);
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4714 if (!intel_dig_port)
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4715 return;
00c09d70df6b30 drivers/gpu/drm/i915/intel_ddi.c Paulo Zanoni 2012-10-26 4716
be1087a2f14d66 drivers/gpu/drm/i915/display/intel_ddi.c Lucas De Marchi 2019-11-05 @4717 drm_encoder_init(&dev_priv->drm, &encoder->base, &intel_ddi_funcs,
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-11-14 11:52 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 6:47 [PATCH] drm/i915: switch intel_ddi_init() to intel types Lucas De Marchi
2019-11-06 6:47 ` [Intel-gfx] " Lucas De Marchi
2019-11-06 7:08 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-06 7:08 ` [Intel-gfx] " Patchwork
2019-11-06 7:17 ` [PATCH] " Lucas De Marchi
2019-11-06 7:17 ` [Intel-gfx] " Lucas De Marchi
2019-11-06 13:31 ` Ville Syrjälä
2019-11-06 13:31 ` [Intel-gfx] " Ville Syrjälä
2019-11-07 0:22 ` Lucas De Marchi
2019-11-07 0:22 ` [Intel-gfx] " Lucas De Marchi
2019-11-06 8:20 ` ✓ Fi.CI.BAT: success for drm/i915: switch intel_ddi_init() to intel types (rev2) Patchwork
2019-11-06 8:20 ` [Intel-gfx] " Patchwork
2019-11-07 2:14 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-07 2:14 ` [Intel-gfx] " Patchwork
2019-11-14 11:50 ` [Intel-gfx] [PATCH] drm/i915: switch intel_ddi_init() to intel types Dan Carpenter
2019-11-14 11:52 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.