* [CI] drm/i915: Remove unwanted rcu_read_lock/unlock
@ 2019-11-06 17:24 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2019-11-06 17:24 UTC (permalink / raw)
To: intel-gfx
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
We don't need rcu read side critical section to call pid_nr(),
remove it.
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gpu_error.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index e8b67f5e521d..1f2f266f26af 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1230,10 +1230,7 @@ static void record_request(const struct i915_request *request,
erq->start = i915_ggtt_offset(request->ring->vma);
erq->head = request->head;
erq->tail = request->tail;
-
- rcu_read_lock();
erq->pid = ctx->pid ? pid_nr(ctx->pid) : 0;
- rcu_read_unlock();
}
static void engine_record_requests(struct intel_engine_cs *engine,
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] [CI] drm/i915: Remove unwanted rcu_read_lock/unlock
@ 2019-11-06 17:24 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2019-11-06 17:24 UTC (permalink / raw)
To: intel-gfx
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
We don't need rcu read side critical section to call pid_nr(),
remove it.
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gpu_error.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index e8b67f5e521d..1f2f266f26af 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1230,10 +1230,7 @@ static void record_request(const struct i915_request *request,
erq->start = i915_ggtt_offset(request->ring->vma);
erq->head = request->head;
erq->tail = request->tail;
-
- rcu_read_lock();
erq->pid = ctx->pid ? pid_nr(ctx->pid) : 0;
- rcu_read_unlock();
}
static void engine_record_requests(struct intel_engine_cs *engine,
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Remove unwanted rcu_read_lock/unlock
@ 2019-11-06 21:57 ` Patchwork
0 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-11-06 21:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unwanted rcu_read_lock/unlock
URL : https://patchwork.freedesktop.org/series/69082/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7275 -> Patchwork_15161
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15161 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15161, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15161/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15161:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_hugepages:
- fi-skl-guc: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15161/fi-skl-guc/igt@i915_selftest@live_hugepages.html
Known issues
------------
Here are the changes found in Patchwork_15161 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@dp-crc-fast:
- fi-icl-u2: [PASS][2] -> [FAIL][3] ([fdo#109635 ] / [fdo#110387])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7275/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15161/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-bsw-nick: [DMESG-FAIL][4] ([fdo#112176]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7275/fi-bsw-nick/igt@i915_selftest@live_blt.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15161/fi-bsw-nick/igt@i915_selftest@live_blt.html
* igt@kms_chamelium@hdmi-edid-read:
- {fi-icl-u4}: [FAIL][6] ([fdo#111045]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7275/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15161/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- {fi-icl-u4}: [FAIL][8] ([fdo#111045] / [fdo#111096]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7275/fi-icl-u4/igt@kms_chamelium@hdmi-hpd-fast.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15161/fi-icl-u4/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#110387]: https://bugs.freedesktop.org/show_bug.cgi?id=110387
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112176]: https://bugs.freedesktop.org/show_bug.cgi?id=112176
Participating hosts (50 -> 45)
------------------------------
Additional (2): fi-skl-guc fi-hsw-4770
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7275 -> Patchwork_15161
CI-20190529: 20190529
CI_DRM_7275: 2f95054e1e1b0f787654a44e1b6c1864e25e11cf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5264: f21213012393bd8041ad93084ce29da088ef8426 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15161: a9e7def292a7cd7c293b428ce1729691954d8b2d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a9e7def292a7 drm/i915: Remove unwanted rcu_read_lock/unlock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15161/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-06 21:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 17:24 [CI] drm/i915: Remove unwanted rcu_read_lock/unlock Chris Wilson
2019-11-06 17:24 ` [Intel-gfx] " Chris Wilson
2019-11-06 21:57 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-06 21:57 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.