All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support (rev9)
Date: Thu, 07 Nov 2019 12:05:55 -0000	[thread overview]
Message-ID: <157312835558.21753.3025649140949446926@emeril.freedesktop.org> (raw)
In-Reply-To: <20191107102225.25988-1-stanislav.lisovskiy@intel.com>

== Series Details ==

Series: Refactor Gen11+ SAGV support (rev9)
URL   : https://patchwork.freedesktop.org/series/68028/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
96e43a266578 drm/i915: Refactor intel_can_enable_sagv
-:191: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#191: FILE: drivers/gpu/drm/i915/intel_pm.c:3835:
+	for_each_new_intel_crtc_in_state(state, crtc,
+					     new_crtc_state, i) {

-:271: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#271: FILE: drivers/gpu/drm/i915/intel_pm.c:3915:
+			bool state_sagv_masked = \

-:276: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#276: FILE: drivers/gpu/drm/i915/intel_pm.c:3920:
+			bool sagv_masked = \

-:311: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#311: FILE: drivers/gpu/drm/i915/intel_pm.c:4341:
+tgl_check_pipe_fits_sagv_wm(struct intel_crtc_state *crtc_state,
+		      struct skl_ddb_allocation *ddb /* out */)

-:423: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#423: FILE: drivers/gpu/drm/i915/intel_pm.c:4991:
+		skl_compute_plane_wm(crtc_state, 0, latency,
+		     wm_params, &levels[0],

-:425: CHECK:BRACES: Unbalanced braces around else statement
#425: FILE: drivers/gpu/drm/i915/intel_pm.c:4993:
+	} else

-:427: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#427: FILE: drivers/gpu/drm/i915/intel_pm.c:4995:
+		memcpy(&plane_wm->sagv_wm0, &levels[0],
+			sizeof(struct skl_wm_level));

-:490: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#490: FILE: drivers/gpu/drm/i915/intel_pm.c:5681:
+	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
+				    new_crtc_state, i) {

-:496: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#496: FILE: drivers/gpu/drm/i915/intel_pm.c:5687:
+			struct skl_plane_wm *plane_wm = \

-:519: WARNING:LINE_SPACING: Missing a blank line after declarations
#519: FILE: drivers/gpu/drm/i915/intel_pm.c:5710:
+			int pipe_bit = BIT(crtc->pipe);
+			state->crtc_sagv_mask |= pipe_bit;

total: 0 errors, 4 warnings, 6 checks, 454 lines checked
30fbd29899ff drm/i915: Restrict qgv points which don't have enough bandwidth.
-:127: CHECK:LINE_SPACING: Please don't use multiple blank lines
#127: FILE: drivers/gpu/drm/i915/display/intel_bw.c:139:
+
+

-:233: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#233: FILE: drivers/gpu/drm/i915/display/intel_bw.c:484:
+	if (!intel_can_enable_sagv(state)) {
+

-:408: CHECK:BRACES: braces {} should be used on all arms of this statement
#408: FILE: drivers/gpu/drm/i915/display/intel_display.c:14965:
+	if (INTEL_GEN(dev_priv) < 11) {
[...]
+	} else
[...]

-:411: CHECK:BRACES: Unbalanced braces around else statement
#411: FILE: drivers/gpu/drm/i915/display/intel_display.c:14968:
+	} else

total: 0 errors, 0 warnings, 4 checks, 486 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Stanislav Lisovskiy" <stanislav.lisovskiy@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support (rev9)
Date: Thu, 07 Nov 2019 12:05:55 -0000	[thread overview]
Message-ID: <157312835558.21753.3025649140949446926@emeril.freedesktop.org> (raw)
Message-ID: <20191107120555.nNIBuxFFjhYXnEM5F9ohxUACM5b46kv3yPD0mTAI1bE@z> (raw)
In-Reply-To: <20191107102225.25988-1-stanislav.lisovskiy@intel.com>

== Series Details ==

Series: Refactor Gen11+ SAGV support (rev9)
URL   : https://patchwork.freedesktop.org/series/68028/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
96e43a266578 drm/i915: Refactor intel_can_enable_sagv
-:191: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#191: FILE: drivers/gpu/drm/i915/intel_pm.c:3835:
+	for_each_new_intel_crtc_in_state(state, crtc,
+					     new_crtc_state, i) {

-:271: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#271: FILE: drivers/gpu/drm/i915/intel_pm.c:3915:
+			bool state_sagv_masked = \

-:276: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#276: FILE: drivers/gpu/drm/i915/intel_pm.c:3920:
+			bool sagv_masked = \

-:311: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#311: FILE: drivers/gpu/drm/i915/intel_pm.c:4341:
+tgl_check_pipe_fits_sagv_wm(struct intel_crtc_state *crtc_state,
+		      struct skl_ddb_allocation *ddb /* out */)

-:423: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#423: FILE: drivers/gpu/drm/i915/intel_pm.c:4991:
+		skl_compute_plane_wm(crtc_state, 0, latency,
+		     wm_params, &levels[0],

-:425: CHECK:BRACES: Unbalanced braces around else statement
#425: FILE: drivers/gpu/drm/i915/intel_pm.c:4993:
+	} else

-:427: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#427: FILE: drivers/gpu/drm/i915/intel_pm.c:4995:
+		memcpy(&plane_wm->sagv_wm0, &levels[0],
+			sizeof(struct skl_wm_level));

-:490: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#490: FILE: drivers/gpu/drm/i915/intel_pm.c:5681:
+	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
+				    new_crtc_state, i) {

-:496: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#496: FILE: drivers/gpu/drm/i915/intel_pm.c:5687:
+			struct skl_plane_wm *plane_wm = \

-:519: WARNING:LINE_SPACING: Missing a blank line after declarations
#519: FILE: drivers/gpu/drm/i915/intel_pm.c:5710:
+			int pipe_bit = BIT(crtc->pipe);
+			state->crtc_sagv_mask |= pipe_bit;

total: 0 errors, 4 warnings, 6 checks, 454 lines checked
30fbd29899ff drm/i915: Restrict qgv points which don't have enough bandwidth.
-:127: CHECK:LINE_SPACING: Please don't use multiple blank lines
#127: FILE: drivers/gpu/drm/i915/display/intel_bw.c:139:
+
+

-:233: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#233: FILE: drivers/gpu/drm/i915/display/intel_bw.c:484:
+	if (!intel_can_enable_sagv(state)) {
+

-:408: CHECK:BRACES: braces {} should be used on all arms of this statement
#408: FILE: drivers/gpu/drm/i915/display/intel_display.c:14965:
+	if (INTEL_GEN(dev_priv) < 11) {
[...]
+	} else
[...]

-:411: CHECK:BRACES: Unbalanced braces around else statement
#411: FILE: drivers/gpu/drm/i915/display/intel_display.c:14968:
+	} else

total: 0 errors, 0 warnings, 4 checks, 486 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-07 12:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 10:22 [PATCH v10 0/2] Refactor Gen11+ SAGV support Stanislav Lisovskiy
2019-11-07 10:22 ` [Intel-gfx] " Stanislav Lisovskiy
2019-11-07 10:22 ` [PATCH v10 1/2] drm/i915: Refactor intel_can_enable_sagv Stanislav Lisovskiy
2019-11-07 10:22   ` [Intel-gfx] " Stanislav Lisovskiy
2019-11-07 10:22 ` [PATCH v10 2/2] drm/i915: Restrict qgv points which don't have enough bandwidth Stanislav Lisovskiy
2019-11-07 10:22   ` [Intel-gfx] " Stanislav Lisovskiy
2019-11-07 12:05 ` Patchwork [this message]
2019-11-07 12:05   ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support (rev9) Patchwork
2019-11-07 12:07 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-11-07 12:07   ` [Intel-gfx] " Patchwork
2019-11-07 12:30 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-11-07 12:30   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157312835558.21753.3025649140949446926@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stanislav.lisovskiy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.