* [PATCH] drm/i915: Taint the kernel on dumping the GEM ftrace buffer
@ 2019-11-07 16:13 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2019-11-07 16:13 UTC (permalink / raw)
To: intel-gfx
As the ftrace buffer is single shot, once dumped it will not update. As
such, it only provides information for the first bug and all subsequent
bugs are noise. The goal of CI is to have zero bugs, so taint the kernel
causing CI to reboot the machine; fix the bug and move on.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/i915_gem.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h
index f6f9675848b8..b321e4544f10 100644
--- a/drivers/gpu/drm/i915/i915_gem.h
+++ b/drivers/gpu/drm/i915/i915_gem.h
@@ -68,9 +68,10 @@ struct drm_i915_private;
pr_err(__VA_ARGS__); \
trace_printk(__VA_ARGS__); \
} while (0)
-#define GEM_TRACE_DUMP() ftrace_dump(DUMP_ALL)
+#define GEM_TRACE_DUMP() \
+ do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
#define GEM_TRACE_DUMP_ON(expr) \
- do { if (expr) ftrace_dump(DUMP_ALL); } while (0)
+ do { if (expr) GEM_TRACE_DUMP(); } while (0)
#else
#define GEM_TRACE(...) do { } while (0)
#define GEM_TRACE_ERR(...) do { } while (0)
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Taint the kernel on dumping the GEM ftrace buffer
@ 2019-11-07 16:13 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2019-11-07 16:13 UTC (permalink / raw)
To: intel-gfx
As the ftrace buffer is single shot, once dumped it will not update. As
such, it only provides information for the first bug and all subsequent
bugs are noise. The goal of CI is to have zero bugs, so taint the kernel
causing CI to reboot the machine; fix the bug and move on.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/i915_gem.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h
index f6f9675848b8..b321e4544f10 100644
--- a/drivers/gpu/drm/i915/i915_gem.h
+++ b/drivers/gpu/drm/i915/i915_gem.h
@@ -68,9 +68,10 @@ struct drm_i915_private;
pr_err(__VA_ARGS__); \
trace_printk(__VA_ARGS__); \
} while (0)
-#define GEM_TRACE_DUMP() ftrace_dump(DUMP_ALL)
+#define GEM_TRACE_DUMP() \
+ do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
#define GEM_TRACE_DUMP_ON(expr) \
- do { if (expr) ftrace_dump(DUMP_ALL); } while (0)
+ do { if (expr) GEM_TRACE_DUMP(); } while (0)
#else
#define GEM_TRACE(...) do { } while (0)
#define GEM_TRACE_ERR(...) do { } while (0)
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✗ Fi.CI.BUILD: failure for drm/i915: Taint the kernel on dumping the GEM ftrace buffer
@ 2019-11-07 20:30 ` Patchwork
0 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-11-07 20:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Taint the kernel on dumping the GEM ftrace buffer
URL : https://patchwork.freedesktop.org/series/69144/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
AR drivers/gpu/drm/i915/built-in.a
CC [M] drivers/gpu/drm/i915/gt/intel_context.o
In file included from ./drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from ./drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from ./drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/gt/intel_context.c:7:
drivers/gpu/drm/i915/gt/selftest_context.c: In function ‘__live_active_context’:
./drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function ‘set_taint_for_CI’; did you mean ‘add_taint_for_CI’? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro ‘GEM_TRACE_DUMP’
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
./drivers/gpu/drm/i915/i915_gem.h:72:47: error: ‘TAIN_WARN’ undeclared (first use in this function); did you mean ‘TAINT_WARN’?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro ‘GEM_TRACE_DUMP’
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
./drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro ‘GEM_TRACE_DUMP’
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
scripts/Makefile.build:265: recipe for target 'drivers/gpu/drm/i915/gt/intel_context.o' failed
make[4]: *** [drivers/gpu/drm/i915/gt/intel_context.o] Error 1
scripts/Makefile.build:509: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:509: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:509: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1649: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Taint the kernel on dumping the GEM ftrace buffer
@ 2019-11-07 20:30 ` Patchwork
0 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-11-07 20:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Taint the kernel on dumping the GEM ftrace buffer
URL : https://patchwork.freedesktop.org/series/69144/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
AR drivers/gpu/drm/i915/built-in.a
CC [M] drivers/gpu/drm/i915/gt/intel_context.o
In file included from ./drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from ./drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from ./drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/gt/intel_context.c:7:
drivers/gpu/drm/i915/gt/selftest_context.c: In function ‘__live_active_context’:
./drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function ‘set_taint_for_CI’; did you mean ‘add_taint_for_CI’? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro ‘GEM_TRACE_DUMP’
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
./drivers/gpu/drm/i915/i915_gem.h:72:47: error: ‘TAIN_WARN’ undeclared (first use in this function); did you mean ‘TAINT_WARN’?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro ‘GEM_TRACE_DUMP’
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
./drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro ‘GEM_TRACE_DUMP’
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
scripts/Makefile.build:265: recipe for target 'drivers/gpu/drm/i915/gt/intel_context.o' failed
make[4]: *** [drivers/gpu/drm/i915/gt/intel_context.o] Error 1
scripts/Makefile.build:509: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:509: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:509: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1649: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Taint the kernel on dumping the GEM ftrace buffer
@ 2019-11-09 14:33 ` kbuild test robot
0 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2019-11-09 14:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 15784 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20191108]
[cannot apply to v5.4-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Taint-the-kernel-on-dumping-the-GEM-ftrace-buffer/20191109-171107
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-b003-201944 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_gt.h:9,
from drivers/gpu/drm/i915/selftests/igt_flush_test.c:7:
drivers/gpu/drm/i915/selftests/igt_flush_test.c: In function 'igt_flush_test':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/gt/intel_context.c:7:
drivers/gpu/drm/i915/gt/selftest_context.c: In function '__live_active_context':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/gt/intel_lrc.c:136:
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_sanitycheck':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'slice_semaphore_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:416:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_timeslice_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:614:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_busywait_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:794:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:895:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_late_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:1013:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt_cancel':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:1485:2: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt_hang':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:1967:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'nop_virtual_engine':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:2476:5: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'mask_virtual_engine':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:2619:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/i915_request.h:31,
from drivers/gpu/drm/i915/i915_active.h:13,
from drivers/gpu/drm/i915/display/intel_frontbuffer.h:30,
from drivers/gpu/drm/i915/i915_drv.h:71,
from drivers/gpu/drm/i915/display/intel_display_types.h:46,
from drivers/gpu/drm/i915/gt/intel_reset.c:10:
drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function 'active_request_put':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function '__igt_reset_engines':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_hangcheck.c:881:6: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function 'igt_reset_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_hangcheck.c:1422:5: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/i915_request.c:32:
drivers/gpu/drm/i915/selftests/i915_request.c: In function '__igt_breadcrumbs_smoketest':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +72 drivers/gpu/drm/i915/i915_gem.h
64
65 #if IS_ENABLED(CONFIG_DRM_I915_TRACE_GEM)
66 #define GEM_TRACE(...) trace_printk(__VA_ARGS__)
67 #define GEM_TRACE_ERR(...) do { \
68 pr_err(__VA_ARGS__); \
69 trace_printk(__VA_ARGS__); \
70 } while (0)
71 #define GEM_TRACE_DUMP() \
> 72 do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
73 #define GEM_TRACE_DUMP_ON(expr) \
74 do { if (expr) GEM_TRACE_DUMP(); } while (0)
75 #else
76 #define GEM_TRACE(...) do { } while (0)
77 #define GEM_TRACE_ERR(...) do { } while (0)
78 #define GEM_TRACE_DUMP() do { } while (0)
79 #define GEM_TRACE_DUMP_ON(expr) BUILD_BUG_ON_INVALID(expr)
80 #endif
81
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32060 bytes --]
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Taint the kernel on dumping the GEM ftrace buffer
@ 2019-11-09 14:33 ` kbuild test robot
0 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2019-11-09 14:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 15784 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20191108]
[cannot apply to v5.4-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Taint-the-kernel-on-dumping-the-GEM-ftrace-buffer/20191109-171107
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-b003-201944 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_gt.h:9,
from drivers/gpu/drm/i915/selftests/igt_flush_test.c:7:
drivers/gpu/drm/i915/selftests/igt_flush_test.c: In function 'igt_flush_test':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/gt/intel_context.c:7:
drivers/gpu/drm/i915/gt/selftest_context.c: In function '__live_active_context':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/gt/intel_lrc.c:136:
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_sanitycheck':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'slice_semaphore_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:416:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_timeslice_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:614:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_busywait_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:794:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:895:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_late_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:1013:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt_cancel':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:1485:2: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt_hang':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:1967:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'nop_virtual_engine':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:2476:5: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'mask_virtual_engine':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:2619:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/i915_request.h:31,
from drivers/gpu/drm/i915/i915_active.h:13,
from drivers/gpu/drm/i915/display/intel_frontbuffer.h:30,
from drivers/gpu/drm/i915/i915_drv.h:71,
from drivers/gpu/drm/i915/display/intel_display_types.h:46,
from drivers/gpu/drm/i915/gt/intel_reset.c:10:
drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function 'active_request_put':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function '__igt_reset_engines':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_hangcheck.c:881:6: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function 'igt_reset_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_hangcheck.c:1422:5: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/i915_request.c:32:
drivers/gpu/drm/i915/selftests/i915_request.c: In function '__igt_breadcrumbs_smoketest':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +72 drivers/gpu/drm/i915/i915_gem.h
64
65 #if IS_ENABLED(CONFIG_DRM_I915_TRACE_GEM)
66 #define GEM_TRACE(...) trace_printk(__VA_ARGS__)
67 #define GEM_TRACE_ERR(...) do { \
68 pr_err(__VA_ARGS__); \
69 trace_printk(__VA_ARGS__); \
70 } while (0)
71 #define GEM_TRACE_DUMP() \
> 72 do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
73 #define GEM_TRACE_DUMP_ON(expr) \
74 do { if (expr) GEM_TRACE_DUMP(); } while (0)
75 #else
76 #define GEM_TRACE(...) do { } while (0)
77 #define GEM_TRACE_ERR(...) do { } while (0)
78 #define GEM_TRACE_DUMP() do { } while (0)
79 #define GEM_TRACE_DUMP_ON(expr) BUILD_BUG_ON_INVALID(expr)
80 #endif
81
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32060 bytes --]
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Taint the kernel on dumping the GEM ftrace buffer
@ 2019-11-09 14:33 ` kbuild test robot
0 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2019-11-09 14:33 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 16042 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20191108]
[cannot apply to v5.4-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Taint-the-kernel-on-dumping-the-GEM-ftrace-buffer/20191109-171107
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-b003-201944 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_gt.h:9,
from drivers/gpu/drm/i915/selftests/igt_flush_test.c:7:
drivers/gpu/drm/i915/selftests/igt_flush_test.c: In function 'igt_flush_test':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/igt_flush_test.c:28:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/gt/intel_context.c:7:
drivers/gpu/drm/i915/gt/selftest_context.c: In function '__live_active_context':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_context.c:275:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/gt/intel_lrc.c:136:
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_sanitycheck':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:84:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'slice_semaphore_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:416:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_timeslice_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:614:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_busywait_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:794:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:895:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_late_preempt':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:1013:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt_cancel':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:1485:2: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_preempt_hang':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:1967:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'nop_virtual_engine':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:2476:5: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'mask_virtual_engine':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_lrc.c:2619:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/i915_request.h:31,
from drivers/gpu/drm/i915/i915_active.h:13,
from drivers/gpu/drm/i915/display/intel_frontbuffer.h:30,
from drivers/gpu/drm/i915/i915_drv.h:71,
from drivers/gpu/drm/i915/display/intel_display_types.h:46,
from drivers/gpu/drm/i915/gt/intel_reset.c:10:
drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function 'active_request_put':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:685:3: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function '__igt_reset_engines':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_hangcheck.c:881:6: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_hangcheck.c: In function 'igt_reset_queue':
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
drivers/gpu/drm/i915/gt/selftest_hangcheck.c:1422:5: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:20:0,
from drivers/gpu/drm/i915/gt/intel_context_types.h:17,
from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:20,
from drivers/gpu/drm/i915/gem/i915_gem_context.h:10,
from drivers/gpu/drm/i915/i915_request.c:32:
drivers/gpu/drm/i915/selftests/i915_request.c: In function '__igt_breadcrumbs_smoketest':
>> drivers/gpu/drm/i915/i915_gem.h:72:30: error: implicit declaration of function 'set_taint_for_CI'; did you mean 'add_taint_for_CI'? [-Werror=implicit-function-declaration]
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_gem.h:72:47: error: 'TAIN_WARN' undeclared (first use in this function); did you mean 'TAINT_WARN'?
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_gem.h:72:47: note: each undeclared identifier is reported only once for each function it appears in
do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
^
>> drivers/gpu/drm/i915/selftests/i915_request.c:375:4: note: in expansion of macro 'GEM_TRACE_DUMP'
GEM_TRACE_DUMP();
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +72 drivers/gpu/drm/i915/i915_gem.h
64
65 #if IS_ENABLED(CONFIG_DRM_I915_TRACE_GEM)
66 #define GEM_TRACE(...) trace_printk(__VA_ARGS__)
67 #define GEM_TRACE_ERR(...) do { \
68 pr_err(__VA_ARGS__); \
69 trace_printk(__VA_ARGS__); \
70 } while (0)
71 #define GEM_TRACE_DUMP() \
> 72 do { ftrace_dump(DUMP_ALL); set_taint_for_CI(TAIN_WARN); } while (0)
73 #define GEM_TRACE_DUMP_ON(expr) \
74 do { if (expr) GEM_TRACE_DUMP(); } while (0)
75 #else
76 #define GEM_TRACE(...) do { } while (0)
77 #define GEM_TRACE_ERR(...) do { } while (0)
78 #define GEM_TRACE_DUMP() do { } while (0)
79 #define GEM_TRACE_DUMP_ON(expr) BUILD_BUG_ON_INVALID(expr)
80 #endif
81
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32060 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-09 14:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 16:13 [PATCH] drm/i915: Taint the kernel on dumping the GEM ftrace buffer Chris Wilson
2019-11-07 16:13 ` [Intel-gfx] " Chris Wilson
2019-11-07 20:30 ` ✗ Fi.CI.BUILD: failure for " Patchwork
2019-11-07 20:30 ` [Intel-gfx] " Patchwork
2019-11-09 14:33 ` [PATCH] " kbuild test robot
2019-11-09 14:33 ` [Intel-gfx] " kbuild test robot
2019-11-09 14:33 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.