* [PATCH] drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-07 21:39 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-11-07 21:39 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld
Since drm provided us with a real struct file we can use for our
anonymous internal clients (mock_file), complete our transition to using
that as the primary interface (and not the mocked up struct drm_file we
previous were using).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
.../gpu/drm/i915/gem/selftests/huge_pages.c | 4 +-
.../drm/i915/gem/selftests/i915_gem_context.c | 31 +++++++--------
.../i915/gem/selftests/i915_gem_object_blt.c | 8 ++--
.../gpu/drm/i915/gem/selftests/mock_context.c | 5 ++-
.../gpu/drm/i915/gem/selftests/mock_context.h | 2 +-
drivers/gpu/drm/i915/gt/selftest_context.c | 8 ++--
drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 16 ++++----
.../gpu/drm/i915/gt/selftest_workarounds.c | 4 +-
drivers/gpu/drm/i915/i915_drv.c | 4 --
drivers/gpu/drm/i915/selftests/i915_gem.c | 8 ++--
.../gpu/drm/i915/selftests/i915_gem_evict.c | 4 +-
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 8 ++--
drivers/gpu/drm/i915/selftests/i915_request.c | 4 +-
.../drm/i915/selftests/intel_memory_region.c | 4 +-
drivers/gpu/drm/i915/selftests/mock_drm.c | 38 -------------------
drivers/gpu/drm/i915/selftests/mock_drm.h | 15 ++++++--
16 files changed, 65 insertions(+), 98 deletions(-)
delete mode 100644 drivers/gpu/drm/i915/selftests/mock_drm.c
diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
index 2310ed9b8f89..3f992491f537 100644
--- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
+++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
@@ -1912,9 +1912,9 @@ int i915_gem_huge_page_live_selftests(struct drm_i915_private *i915)
SUBTEST(igt_ppgtt_smoke_huge),
SUBTEST(igt_ppgtt_sanity_check),
};
- struct drm_file *file;
struct i915_gem_context *ctx;
struct i915_address_space *vm;
+ struct file *file;
int err;
if (!HAS_PPGTT(i915)) {
@@ -1944,6 +1944,6 @@ int i915_gem_huge_page_live_selftests(struct drm_i915_private *i915)
err = i915_subtests(tests, ctx);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
index 47890c92534c..18ae2cfa62ed 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
@@ -33,7 +33,7 @@ static int live_nop_switch(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context **ctx;
struct igt_live_test t;
- struct drm_file *file;
+ struct file *file;
unsigned long n;
int err = -ENODEV;
@@ -149,7 +149,7 @@ static int live_nop_switch(void *arg)
}
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -255,7 +255,7 @@ static int live_parallel_switch(void *arg)
int (* const *fn)(void *arg);
struct i915_gem_context *ctx;
struct intel_context *ce;
- struct drm_file *file;
+ struct file *file;
int n, m, count;
int err = 0;
@@ -377,7 +377,7 @@ static int live_parallel_switch(void *arg)
}
kfree(data);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -502,7 +502,7 @@ static noinline int cpu_check(struct drm_i915_gem_object *obj,
return err;
}
-static int file_add_object(struct drm_file *file,
+static int file_add_object(struct file *file,
struct drm_i915_gem_object *obj)
{
int err;
@@ -510,7 +510,8 @@ static int file_add_object(struct drm_file *file,
GEM_BUG_ON(obj->base.handle_count);
/* tie the object to the drm_file for easy reaping */
- err = idr_alloc(&file->object_idr, &obj->base, 1, 0, GFP_KERNEL);
+ err = idr_alloc(&to_drm_file(file)->object_idr,
+ &obj->base, 1, 0, GFP_KERNEL);
if (err < 0)
return err;
@@ -521,7 +522,7 @@ static int file_add_object(struct drm_file *file,
static struct drm_i915_gem_object *
create_test_object(struct i915_address_space *vm,
- struct drm_file *file,
+ struct file *file,
struct list_head *objects)
{
struct drm_i915_gem_object *obj;
@@ -621,9 +622,9 @@ static int igt_ctx_exec(void *arg)
unsigned long ncontexts, ndwords, dw;
struct i915_request *tq[5] = {};
struct igt_live_test t;
- struct drm_file *file;
IGT_TIMEOUT(end_time);
LIST_HEAD(objects);
+ struct file *file;
if (!intel_engine_can_store_dword(engine))
continue;
@@ -716,7 +717,7 @@ static int igt_ctx_exec(void *arg)
if (igt_live_test_end(&t))
err = -EIO;
- mock_file_put(file);
+ fput(file);
if (err)
return err;
@@ -733,7 +734,7 @@ static int igt_shared_ctx_exec(void *arg)
struct i915_gem_context *parent;
struct intel_engine_cs *engine;
struct igt_live_test t;
- struct drm_file *file;
+ struct file *file;
int err = 0;
/*
@@ -854,7 +855,7 @@ static int igt_shared_ctx_exec(void *arg)
if (igt_live_test_end(&t))
err = -EIO;
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -1317,10 +1318,10 @@ static int igt_ctx_readonly(void *arg)
struct i915_gem_context *ctx;
unsigned long idx, ndwords, dw;
struct igt_live_test t;
- struct drm_file *file;
I915_RND_STATE(prng);
IGT_TIMEOUT(end_time);
LIST_HEAD(objects);
+ struct file *file;
int err = -ENODEV;
/*
@@ -1426,7 +1427,7 @@ static int igt_ctx_readonly(void *arg)
if (igt_live_test_end(&t))
err = -EIO;
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -1663,9 +1664,9 @@ static int igt_vm_isolation(void *arg)
struct i915_gem_context *ctx_a, *ctx_b;
struct intel_engine_cs *engine;
struct igt_live_test t;
- struct drm_file *file;
I915_RND_STATE(prng);
unsigned long count;
+ struct file *file;
u64 vm_total;
int err;
@@ -1750,7 +1751,7 @@ static int igt_vm_isolation(void *arg)
out_file:
if (igt_live_test_end(&t))
err = -EIO;
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index d9fdfddb7091..dd43ea0c9025 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -198,7 +198,7 @@ static int igt_fill_blt_thread(void *arg)
struct drm_i915_gem_object *obj;
struct i915_gem_context *ctx;
struct intel_context *ce;
- struct drm_file *file;
+ struct file *file;
unsigned int prio;
IGT_TIMEOUT(end);
int err;
@@ -301,7 +301,7 @@ static int igt_fill_blt_thread(void *arg)
intel_context_put(ce);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -313,7 +313,7 @@ static int igt_copy_blt_thread(void *arg)
struct drm_i915_gem_object *src, *dst;
struct i915_gem_context *ctx;
struct intel_context *ce;
- struct drm_file *file;
+ struct file *file;
unsigned int prio;
IGT_TIMEOUT(end);
int err;
@@ -432,7 +432,7 @@ static int igt_copy_blt_thread(void *arg)
intel_context_put(ce);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
index 29b8984f0e47..cdcb006321a7 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
@@ -5,6 +5,7 @@
*/
#include "mock_context.h"
+#include "selftests/mock_drm.h"
#include "selftests/mock_gtt.h"
struct i915_gem_context *
@@ -74,7 +75,7 @@ void mock_init_contexts(struct drm_i915_private *i915)
}
struct i915_gem_context *
-live_context(struct drm_i915_private *i915, struct drm_file *file)
+live_context(struct drm_i915_private *i915, struct file *file)
{
struct i915_gem_context *ctx;
int err;
@@ -83,7 +84,7 @@ live_context(struct drm_i915_private *i915, struct drm_file *file)
if (IS_ERR(ctx))
return ctx;
- err = gem_context_register(ctx, file->driver_priv);
+ err = gem_context_register(ctx, to_drm_file(file)->driver_priv);
if (err < 0)
goto err_ctx;
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.h b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
index 0b926653914f..8e6af91d82ae 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.h
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
@@ -16,7 +16,7 @@ mock_context(struct drm_i915_private *i915,
void mock_context_close(struct i915_gem_context *ctx);
struct i915_gem_context *
-live_context(struct drm_i915_private *i915, struct drm_file *file);
+live_context(struct drm_i915_private *i915, struct file *file);
struct i915_gem_context *kernel_context(struct drm_i915_private *i915);
void kernel_context_close(struct i915_gem_context *ctx);
diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c
index a5688f7d9073..14ba6ceb9177 100644
--- a/drivers/gpu/drm/i915/gt/selftest_context.c
+++ b/drivers/gpu/drm/i915/gt/selftest_context.c
@@ -289,7 +289,7 @@ static int live_active_context(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context *fixme;
enum intel_engine_id id;
- struct drm_file *file;
+ struct file *file;
int err = 0;
file = mock_file(gt->i915);
@@ -313,7 +313,7 @@ static int live_active_context(void *arg)
}
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -399,7 +399,7 @@ static int live_remote_context(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context *fixme;
enum intel_engine_id id;
- struct drm_file *file;
+ struct file *file;
int err = 0;
file = mock_file(gt->i915);
@@ -423,7 +423,7 @@ static int live_remote_context(void *arg)
}
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
index cdaaee4432b2..d155c9374453 100644
--- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
+++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
@@ -380,8 +380,8 @@ static int igt_reset_nop(void *arg)
struct i915_gem_context *ctx;
unsigned int reset_count, count;
enum intel_engine_id id;
- struct drm_file *file;
IGT_TIMEOUT(end_time);
+ struct file *file;
int err = 0;
/* Check that we can reset during non-user portions of requests */
@@ -439,7 +439,7 @@ static int igt_reset_nop(void *arg)
err = igt_flush_test(gt->i915);
out:
- mock_file_put(file);
+ fput(file);
if (intel_gt_is_wedged(gt))
err = -EIO;
return err;
@@ -452,7 +452,7 @@ static int igt_reset_nop_engine(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context *ctx;
enum intel_engine_id id;
- struct drm_file *file;
+ struct file *file;
int err = 0;
/* Check that we can engine-reset during non-user portions */
@@ -535,7 +535,7 @@ static int igt_reset_nop_engine(void *arg)
err = igt_flush_test(gt->i915);
out:
- mock_file_put(file);
+ fput(file);
if (intel_gt_is_wedged(gt))
err = -EIO;
return err;
@@ -700,8 +700,8 @@ static int active_engine(void *data)
struct intel_engine_cs *engine = arg->engine;
struct i915_request *rq[8] = {};
struct i915_gem_context *ctx[ARRAY_SIZE(rq)];
- struct drm_file *file;
unsigned long count = 0;
+ struct file *file;
int err = 0;
file = mock_file(engine->i915);
@@ -752,7 +752,7 @@ static int active_engine(void *data)
}
err_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -1302,7 +1302,7 @@ static int igt_reset_evict_ppgtt(void *arg)
struct intel_gt *gt = arg;
struct i915_gem_context *ctx;
struct i915_address_space *vm;
- struct drm_file *file;
+ struct file *file;
int err;
file = mock_file(gt->i915);
@@ -1325,7 +1325,7 @@ static int igt_reset_evict_ppgtt(void *arg)
i915_vm_put(vm);
out:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gt/selftest_workarounds.c b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
index 5c69ec5c5ef9..d5d1e1a32187 100644
--- a/drivers/gpu/drm/i915/gt/selftest_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
@@ -711,7 +711,7 @@ static int live_dirty_whitelist(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context *ctx;
enum intel_engine_id id;
- struct drm_file *file;
+ struct file *file;
int err = 0;
/* Can the user write to the whitelisted registers? */
@@ -739,7 +739,7 @@ static int live_dirty_whitelist(void *arg)
}
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 82e4e6bf08c3..64f8ba3449ed 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -2781,7 +2781,3 @@ static struct drm_driver driver = {
.minor = DRIVER_MINOR,
.patchlevel = DRIVER_PATCHLEVEL,
};
-
-#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
-#include "selftests/mock_drm.c"
-#endif
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c
index aa6282adfd09..657e23a8dd11 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem.c
@@ -136,7 +136,7 @@ static int igt_gem_suspend(void *arg)
{
struct drm_i915_private *i915 = arg;
struct i915_gem_context *ctx;
- struct drm_file *file;
+ struct file *file;
int err;
file = mock_file(i915);
@@ -163,7 +163,7 @@ static int igt_gem_suspend(void *arg)
err = switch_to_context(ctx);
out:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -171,7 +171,7 @@ static int igt_gem_hibernate(void *arg)
{
struct drm_i915_private *i915 = arg;
struct i915_gem_context *ctx;
- struct drm_file *file;
+ struct file *file;
int err;
file = mock_file(i915);
@@ -198,7 +198,7 @@ static int igt_gem_hibernate(void *arg)
err = switch_to_context(ctx);
out:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
index 41092dcea5b1..5f133d177212 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
@@ -466,7 +466,7 @@ static int igt_evict_contexts(void *arg)
/* Overfill the GGTT with context objects and so try to evict one. */
for_each_engine(engine, gt, id) {
struct i915_sw_fence fence;
- struct drm_file *file;
+ struct file *file;
file = mock_file(i915);
if (IS_ERR(file)) {
@@ -515,7 +515,7 @@ static int igt_evict_contexts(void *arg)
pr_info("Submitted %lu contexts/requests on %s\n",
count, engine->name);
- mock_file_put(file);
+ fput(file);
if (err)
break;
}
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index c3e0d63c4d0c..d94db487c4dd 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -1001,9 +1001,9 @@ static int exercise_ppgtt(struct drm_i915_private *dev_priv,
u64 hole_start, u64 hole_end,
unsigned long end_time))
{
- struct drm_file *file;
struct i915_ppgtt *ppgtt;
IGT_TIMEOUT(end_time);
+ struct file *file;
int err;
if (!HAS_FULL_PPGTT(dev_priv))
@@ -1026,7 +1026,7 @@ static int exercise_ppgtt(struct drm_i915_private *dev_priv,
i915_vm_put(&ppgtt->vm);
out_free:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -1782,9 +1782,9 @@ static int igt_cs_tlb(void *arg)
struct i915_address_space *vm;
struct i915_gem_context *ctx;
struct intel_context *ce;
- struct drm_file *file;
struct i915_vma *vma;
I915_RND_STATE(prng);
+ struct file *file;
unsigned int i;
u32 *result;
u32 *batch;
@@ -2022,7 +2022,7 @@ static int igt_cs_tlb(void *arg)
out_vm:
i915_vm_put(vm);
out_unlock:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
index 7c56ee38cc5b..50cc7ca9afba 100644
--- a/drivers/gpu/drm/i915/selftests/i915_request.c
+++ b/drivers/gpu/drm/i915/selftests/i915_request.c
@@ -1306,9 +1306,9 @@ static int live_breadcrumbs_smoketest(void *arg)
struct task_struct **threads;
struct igt_live_test live;
intel_wakeref_t wakeref;
- struct drm_file *file;
struct smoketest *smoke;
unsigned int n, idx;
+ struct file *file;
int ret = 0;
/*
@@ -1430,7 +1430,7 @@ static int live_breadcrumbs_smoketest(void *arg)
out_smoke:
kfree(smoke);
out_file:
- mock_file_put(file);
+ fput(file);
out_rpm:
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
index f8497ad90f53..b60916561462 100644
--- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
@@ -404,7 +404,7 @@ static int igt_lmem_write_gpu(void *arg)
struct drm_i915_private *i915 = arg;
struct drm_i915_gem_object *obj;
struct i915_gem_context *ctx;
- struct drm_file *file;
+ struct file *file;
I915_RND_STATE(prng);
u32 sz;
int err;
@@ -439,7 +439,7 @@ static int igt_lmem_write_gpu(void *arg)
out_put:
i915_gem_object_put(obj);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/selftests/mock_drm.c b/drivers/gpu/drm/i915/selftests/mock_drm.c
deleted file mode 100644
index c100c3efe239..000000000000
--- a/drivers/gpu/drm/i915/selftests/mock_drm.c
+++ /dev/null
@@ -1,38 +0,0 @@
-/*
- * Copyright © 2017 Intel Corporation
- *
- * Permission is hereby granted, free of charge, to any person obtaining a
- * copy of this software and associated documentation files (the "Software"),
- * to deal in the Software without restriction, including without limitation
- * the rights to use, copy, modify, merge, publish, distribute, sublicense,
- * and/or sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice (including the next
- * paragraph) shall be included in all copies or substantial portions of the
- * Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
- * IN THE SOFTWARE.
- *
- */
-
-#include <drm/drm_file.h>
-
-#include "mock_drm.h"
-
-struct drm_file *mock_file(struct drm_i915_private *i915)
-{
- struct file *file;
-
- file = mock_drm_getfile(i915->drm.primary, O_RDWR);
- if (IS_ERR(file))
- return ERR_CAST(file);
-
- return file->private_data;
-}
diff --git a/drivers/gpu/drm/i915/selftests/mock_drm.h b/drivers/gpu/drm/i915/selftests/mock_drm.h
index dc4190bd3f5a..d7f49e149f0c 100644
--- a/drivers/gpu/drm/i915/selftests/mock_drm.h
+++ b/drivers/gpu/drm/i915/selftests/mock_drm.h
@@ -25,13 +25,20 @@
#ifndef __MOCK_DRM_H
#define __MOCK_DRM_H
-struct drm_file;
+#include <drm/drm_file.h>
+
struct drm_i915_private;
+struct drm_file;
+struct file;
+
+static inline struct file *mock_file(struct drm_i915_private *i915)
+{
+ return mock_drm_getfile(i915->drm.primary, O_RDWR);
+}
-struct drm_file *mock_file(struct drm_i915_private *i915);
-static inline void mock_file_put(struct drm_file *file)
+static inline struct drm_file *to_drm_file(struct file *f)
{
- fput(file->filp);
+ return f->private_data;
}
#endif /* !__MOCK_DRM_H */
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-07 21:39 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-11-07 21:39 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld
Since drm provided us with a real struct file we can use for our
anonymous internal clients (mock_file), complete our transition to using
that as the primary interface (and not the mocked up struct drm_file we
previous were using).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
.../gpu/drm/i915/gem/selftests/huge_pages.c | 4 +-
.../drm/i915/gem/selftests/i915_gem_context.c | 31 +++++++--------
.../i915/gem/selftests/i915_gem_object_blt.c | 8 ++--
.../gpu/drm/i915/gem/selftests/mock_context.c | 5 ++-
.../gpu/drm/i915/gem/selftests/mock_context.h | 2 +-
drivers/gpu/drm/i915/gt/selftest_context.c | 8 ++--
drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 16 ++++----
.../gpu/drm/i915/gt/selftest_workarounds.c | 4 +-
drivers/gpu/drm/i915/i915_drv.c | 4 --
drivers/gpu/drm/i915/selftests/i915_gem.c | 8 ++--
.../gpu/drm/i915/selftests/i915_gem_evict.c | 4 +-
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 8 ++--
drivers/gpu/drm/i915/selftests/i915_request.c | 4 +-
.../drm/i915/selftests/intel_memory_region.c | 4 +-
drivers/gpu/drm/i915/selftests/mock_drm.c | 38 -------------------
drivers/gpu/drm/i915/selftests/mock_drm.h | 15 ++++++--
16 files changed, 65 insertions(+), 98 deletions(-)
delete mode 100644 drivers/gpu/drm/i915/selftests/mock_drm.c
diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
index 2310ed9b8f89..3f992491f537 100644
--- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
+++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
@@ -1912,9 +1912,9 @@ int i915_gem_huge_page_live_selftests(struct drm_i915_private *i915)
SUBTEST(igt_ppgtt_smoke_huge),
SUBTEST(igt_ppgtt_sanity_check),
};
- struct drm_file *file;
struct i915_gem_context *ctx;
struct i915_address_space *vm;
+ struct file *file;
int err;
if (!HAS_PPGTT(i915)) {
@@ -1944,6 +1944,6 @@ int i915_gem_huge_page_live_selftests(struct drm_i915_private *i915)
err = i915_subtests(tests, ctx);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
index 47890c92534c..18ae2cfa62ed 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
@@ -33,7 +33,7 @@ static int live_nop_switch(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context **ctx;
struct igt_live_test t;
- struct drm_file *file;
+ struct file *file;
unsigned long n;
int err = -ENODEV;
@@ -149,7 +149,7 @@ static int live_nop_switch(void *arg)
}
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -255,7 +255,7 @@ static int live_parallel_switch(void *arg)
int (* const *fn)(void *arg);
struct i915_gem_context *ctx;
struct intel_context *ce;
- struct drm_file *file;
+ struct file *file;
int n, m, count;
int err = 0;
@@ -377,7 +377,7 @@ static int live_parallel_switch(void *arg)
}
kfree(data);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -502,7 +502,7 @@ static noinline int cpu_check(struct drm_i915_gem_object *obj,
return err;
}
-static int file_add_object(struct drm_file *file,
+static int file_add_object(struct file *file,
struct drm_i915_gem_object *obj)
{
int err;
@@ -510,7 +510,8 @@ static int file_add_object(struct drm_file *file,
GEM_BUG_ON(obj->base.handle_count);
/* tie the object to the drm_file for easy reaping */
- err = idr_alloc(&file->object_idr, &obj->base, 1, 0, GFP_KERNEL);
+ err = idr_alloc(&to_drm_file(file)->object_idr,
+ &obj->base, 1, 0, GFP_KERNEL);
if (err < 0)
return err;
@@ -521,7 +522,7 @@ static int file_add_object(struct drm_file *file,
static struct drm_i915_gem_object *
create_test_object(struct i915_address_space *vm,
- struct drm_file *file,
+ struct file *file,
struct list_head *objects)
{
struct drm_i915_gem_object *obj;
@@ -621,9 +622,9 @@ static int igt_ctx_exec(void *arg)
unsigned long ncontexts, ndwords, dw;
struct i915_request *tq[5] = {};
struct igt_live_test t;
- struct drm_file *file;
IGT_TIMEOUT(end_time);
LIST_HEAD(objects);
+ struct file *file;
if (!intel_engine_can_store_dword(engine))
continue;
@@ -716,7 +717,7 @@ static int igt_ctx_exec(void *arg)
if (igt_live_test_end(&t))
err = -EIO;
- mock_file_put(file);
+ fput(file);
if (err)
return err;
@@ -733,7 +734,7 @@ static int igt_shared_ctx_exec(void *arg)
struct i915_gem_context *parent;
struct intel_engine_cs *engine;
struct igt_live_test t;
- struct drm_file *file;
+ struct file *file;
int err = 0;
/*
@@ -854,7 +855,7 @@ static int igt_shared_ctx_exec(void *arg)
if (igt_live_test_end(&t))
err = -EIO;
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -1317,10 +1318,10 @@ static int igt_ctx_readonly(void *arg)
struct i915_gem_context *ctx;
unsigned long idx, ndwords, dw;
struct igt_live_test t;
- struct drm_file *file;
I915_RND_STATE(prng);
IGT_TIMEOUT(end_time);
LIST_HEAD(objects);
+ struct file *file;
int err = -ENODEV;
/*
@@ -1426,7 +1427,7 @@ static int igt_ctx_readonly(void *arg)
if (igt_live_test_end(&t))
err = -EIO;
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -1663,9 +1664,9 @@ static int igt_vm_isolation(void *arg)
struct i915_gem_context *ctx_a, *ctx_b;
struct intel_engine_cs *engine;
struct igt_live_test t;
- struct drm_file *file;
I915_RND_STATE(prng);
unsigned long count;
+ struct file *file;
u64 vm_total;
int err;
@@ -1750,7 +1751,7 @@ static int igt_vm_isolation(void *arg)
out_file:
if (igt_live_test_end(&t))
err = -EIO;
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index d9fdfddb7091..dd43ea0c9025 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -198,7 +198,7 @@ static int igt_fill_blt_thread(void *arg)
struct drm_i915_gem_object *obj;
struct i915_gem_context *ctx;
struct intel_context *ce;
- struct drm_file *file;
+ struct file *file;
unsigned int prio;
IGT_TIMEOUT(end);
int err;
@@ -301,7 +301,7 @@ static int igt_fill_blt_thread(void *arg)
intel_context_put(ce);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -313,7 +313,7 @@ static int igt_copy_blt_thread(void *arg)
struct drm_i915_gem_object *src, *dst;
struct i915_gem_context *ctx;
struct intel_context *ce;
- struct drm_file *file;
+ struct file *file;
unsigned int prio;
IGT_TIMEOUT(end);
int err;
@@ -432,7 +432,7 @@ static int igt_copy_blt_thread(void *arg)
intel_context_put(ce);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
index 29b8984f0e47..cdcb006321a7 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
@@ -5,6 +5,7 @@
*/
#include "mock_context.h"
+#include "selftests/mock_drm.h"
#include "selftests/mock_gtt.h"
struct i915_gem_context *
@@ -74,7 +75,7 @@ void mock_init_contexts(struct drm_i915_private *i915)
}
struct i915_gem_context *
-live_context(struct drm_i915_private *i915, struct drm_file *file)
+live_context(struct drm_i915_private *i915, struct file *file)
{
struct i915_gem_context *ctx;
int err;
@@ -83,7 +84,7 @@ live_context(struct drm_i915_private *i915, struct drm_file *file)
if (IS_ERR(ctx))
return ctx;
- err = gem_context_register(ctx, file->driver_priv);
+ err = gem_context_register(ctx, to_drm_file(file)->driver_priv);
if (err < 0)
goto err_ctx;
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.h b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
index 0b926653914f..8e6af91d82ae 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.h
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
@@ -16,7 +16,7 @@ mock_context(struct drm_i915_private *i915,
void mock_context_close(struct i915_gem_context *ctx);
struct i915_gem_context *
-live_context(struct drm_i915_private *i915, struct drm_file *file);
+live_context(struct drm_i915_private *i915, struct file *file);
struct i915_gem_context *kernel_context(struct drm_i915_private *i915);
void kernel_context_close(struct i915_gem_context *ctx);
diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c
index a5688f7d9073..14ba6ceb9177 100644
--- a/drivers/gpu/drm/i915/gt/selftest_context.c
+++ b/drivers/gpu/drm/i915/gt/selftest_context.c
@@ -289,7 +289,7 @@ static int live_active_context(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context *fixme;
enum intel_engine_id id;
- struct drm_file *file;
+ struct file *file;
int err = 0;
file = mock_file(gt->i915);
@@ -313,7 +313,7 @@ static int live_active_context(void *arg)
}
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -399,7 +399,7 @@ static int live_remote_context(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context *fixme;
enum intel_engine_id id;
- struct drm_file *file;
+ struct file *file;
int err = 0;
file = mock_file(gt->i915);
@@ -423,7 +423,7 @@ static int live_remote_context(void *arg)
}
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
index cdaaee4432b2..d155c9374453 100644
--- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
+++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
@@ -380,8 +380,8 @@ static int igt_reset_nop(void *arg)
struct i915_gem_context *ctx;
unsigned int reset_count, count;
enum intel_engine_id id;
- struct drm_file *file;
IGT_TIMEOUT(end_time);
+ struct file *file;
int err = 0;
/* Check that we can reset during non-user portions of requests */
@@ -439,7 +439,7 @@ static int igt_reset_nop(void *arg)
err = igt_flush_test(gt->i915);
out:
- mock_file_put(file);
+ fput(file);
if (intel_gt_is_wedged(gt))
err = -EIO;
return err;
@@ -452,7 +452,7 @@ static int igt_reset_nop_engine(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context *ctx;
enum intel_engine_id id;
- struct drm_file *file;
+ struct file *file;
int err = 0;
/* Check that we can engine-reset during non-user portions */
@@ -535,7 +535,7 @@ static int igt_reset_nop_engine(void *arg)
err = igt_flush_test(gt->i915);
out:
- mock_file_put(file);
+ fput(file);
if (intel_gt_is_wedged(gt))
err = -EIO;
return err;
@@ -700,8 +700,8 @@ static int active_engine(void *data)
struct intel_engine_cs *engine = arg->engine;
struct i915_request *rq[8] = {};
struct i915_gem_context *ctx[ARRAY_SIZE(rq)];
- struct drm_file *file;
unsigned long count = 0;
+ struct file *file;
int err = 0;
file = mock_file(engine->i915);
@@ -752,7 +752,7 @@ static int active_engine(void *data)
}
err_file:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -1302,7 +1302,7 @@ static int igt_reset_evict_ppgtt(void *arg)
struct intel_gt *gt = arg;
struct i915_gem_context *ctx;
struct i915_address_space *vm;
- struct drm_file *file;
+ struct file *file;
int err;
file = mock_file(gt->i915);
@@ -1325,7 +1325,7 @@ static int igt_reset_evict_ppgtt(void *arg)
i915_vm_put(vm);
out:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/gt/selftest_workarounds.c b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
index 5c69ec5c5ef9..d5d1e1a32187 100644
--- a/drivers/gpu/drm/i915/gt/selftest_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
@@ -711,7 +711,7 @@ static int live_dirty_whitelist(void *arg)
struct intel_engine_cs *engine;
struct i915_gem_context *ctx;
enum intel_engine_id id;
- struct drm_file *file;
+ struct file *file;
int err = 0;
/* Can the user write to the whitelisted registers? */
@@ -739,7 +739,7 @@ static int live_dirty_whitelist(void *arg)
}
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 82e4e6bf08c3..64f8ba3449ed 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -2781,7 +2781,3 @@ static struct drm_driver driver = {
.minor = DRIVER_MINOR,
.patchlevel = DRIVER_PATCHLEVEL,
};
-
-#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
-#include "selftests/mock_drm.c"
-#endif
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c
index aa6282adfd09..657e23a8dd11 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem.c
@@ -136,7 +136,7 @@ static int igt_gem_suspend(void *arg)
{
struct drm_i915_private *i915 = arg;
struct i915_gem_context *ctx;
- struct drm_file *file;
+ struct file *file;
int err;
file = mock_file(i915);
@@ -163,7 +163,7 @@ static int igt_gem_suspend(void *arg)
err = switch_to_context(ctx);
out:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -171,7 +171,7 @@ static int igt_gem_hibernate(void *arg)
{
struct drm_i915_private *i915 = arg;
struct i915_gem_context *ctx;
- struct drm_file *file;
+ struct file *file;
int err;
file = mock_file(i915);
@@ -198,7 +198,7 @@ static int igt_gem_hibernate(void *arg)
err = switch_to_context(ctx);
out:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
index 41092dcea5b1..5f133d177212 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
@@ -466,7 +466,7 @@ static int igt_evict_contexts(void *arg)
/* Overfill the GGTT with context objects and so try to evict one. */
for_each_engine(engine, gt, id) {
struct i915_sw_fence fence;
- struct drm_file *file;
+ struct file *file;
file = mock_file(i915);
if (IS_ERR(file)) {
@@ -515,7 +515,7 @@ static int igt_evict_contexts(void *arg)
pr_info("Submitted %lu contexts/requests on %s\n",
count, engine->name);
- mock_file_put(file);
+ fput(file);
if (err)
break;
}
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index c3e0d63c4d0c..d94db487c4dd 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -1001,9 +1001,9 @@ static int exercise_ppgtt(struct drm_i915_private *dev_priv,
u64 hole_start, u64 hole_end,
unsigned long end_time))
{
- struct drm_file *file;
struct i915_ppgtt *ppgtt;
IGT_TIMEOUT(end_time);
+ struct file *file;
int err;
if (!HAS_FULL_PPGTT(dev_priv))
@@ -1026,7 +1026,7 @@ static int exercise_ppgtt(struct drm_i915_private *dev_priv,
i915_vm_put(&ppgtt->vm);
out_free:
- mock_file_put(file);
+ fput(file);
return err;
}
@@ -1782,9 +1782,9 @@ static int igt_cs_tlb(void *arg)
struct i915_address_space *vm;
struct i915_gem_context *ctx;
struct intel_context *ce;
- struct drm_file *file;
struct i915_vma *vma;
I915_RND_STATE(prng);
+ struct file *file;
unsigned int i;
u32 *result;
u32 *batch;
@@ -2022,7 +2022,7 @@ static int igt_cs_tlb(void *arg)
out_vm:
i915_vm_put(vm);
out_unlock:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
index 7c56ee38cc5b..50cc7ca9afba 100644
--- a/drivers/gpu/drm/i915/selftests/i915_request.c
+++ b/drivers/gpu/drm/i915/selftests/i915_request.c
@@ -1306,9 +1306,9 @@ static int live_breadcrumbs_smoketest(void *arg)
struct task_struct **threads;
struct igt_live_test live;
intel_wakeref_t wakeref;
- struct drm_file *file;
struct smoketest *smoke;
unsigned int n, idx;
+ struct file *file;
int ret = 0;
/*
@@ -1430,7 +1430,7 @@ static int live_breadcrumbs_smoketest(void *arg)
out_smoke:
kfree(smoke);
out_file:
- mock_file_put(file);
+ fput(file);
out_rpm:
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
index f8497ad90f53..b60916561462 100644
--- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
@@ -404,7 +404,7 @@ static int igt_lmem_write_gpu(void *arg)
struct drm_i915_private *i915 = arg;
struct drm_i915_gem_object *obj;
struct i915_gem_context *ctx;
- struct drm_file *file;
+ struct file *file;
I915_RND_STATE(prng);
u32 sz;
int err;
@@ -439,7 +439,7 @@ static int igt_lmem_write_gpu(void *arg)
out_put:
i915_gem_object_put(obj);
out_file:
- mock_file_put(file);
+ fput(file);
return err;
}
diff --git a/drivers/gpu/drm/i915/selftests/mock_drm.c b/drivers/gpu/drm/i915/selftests/mock_drm.c
deleted file mode 100644
index c100c3efe239..000000000000
--- a/drivers/gpu/drm/i915/selftests/mock_drm.c
+++ /dev/null
@@ -1,38 +0,0 @@
-/*
- * Copyright © 2017 Intel Corporation
- *
- * Permission is hereby granted, free of charge, to any person obtaining a
- * copy of this software and associated documentation files (the "Software"),
- * to deal in the Software without restriction, including without limitation
- * the rights to use, copy, modify, merge, publish, distribute, sublicense,
- * and/or sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice (including the next
- * paragraph) shall be included in all copies or substantial portions of the
- * Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
- * IN THE SOFTWARE.
- *
- */
-
-#include <drm/drm_file.h>
-
-#include "mock_drm.h"
-
-struct drm_file *mock_file(struct drm_i915_private *i915)
-{
- struct file *file;
-
- file = mock_drm_getfile(i915->drm.primary, O_RDWR);
- if (IS_ERR(file))
- return ERR_CAST(file);
-
- return file->private_data;
-}
diff --git a/drivers/gpu/drm/i915/selftests/mock_drm.h b/drivers/gpu/drm/i915/selftests/mock_drm.h
index dc4190bd3f5a..d7f49e149f0c 100644
--- a/drivers/gpu/drm/i915/selftests/mock_drm.h
+++ b/drivers/gpu/drm/i915/selftests/mock_drm.h
@@ -25,13 +25,20 @@
#ifndef __MOCK_DRM_H
#define __MOCK_DRM_H
-struct drm_file;
+#include <drm/drm_file.h>
+
struct drm_i915_private;
+struct drm_file;
+struct file;
+
+static inline struct file *mock_file(struct drm_i915_private *i915)
+{
+ return mock_drm_getfile(i915->drm.primary, O_RDWR);
+}
-struct drm_file *mock_file(struct drm_i915_private *i915);
-static inline void mock_file_put(struct drm_file *file)
+static inline struct drm_file *to_drm_file(struct file *f)
{
- fput(file->filp);
+ return f->private_data;
}
#endif /* !__MOCK_DRM_H */
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-08 0:09 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-11-08 0:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Complete transition to a real struct file mock
URL : https://patchwork.freedesktop.org/series/69159/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7013ed43c85d drm/i915/selftests: Complete transition to a real struct file mock
-:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#84: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:506:
+static int file_add_object(struct file *file,
struct drm_i915_gem_object *obj)
-:573: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#573:
deleted file mode 100644
total: 0 errors, 1 warnings, 1 checks, 467 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-08 0:09 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-11-08 0:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Complete transition to a real struct file mock
URL : https://patchwork.freedesktop.org/series/69159/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7013ed43c85d drm/i915/selftests: Complete transition to a real struct file mock
-:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#84: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:506:
+static int file_add_object(struct file *file,
struct drm_i915_gem_object *obj)
-:573: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#573:
deleted file mode 100644
total: 0 errors, 1 warnings, 1 checks, 467 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-08 0:31 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-11-08 0:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Complete transition to a real struct file mock
URL : https://patchwork.freedesktop.org/series/69159/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15186
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/index.html
Known issues
------------
Here are the changes found in Patchwork_15186 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][1] -> [FAIL][2] ([fdo#111045] / [fdo#111096])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][3] ([fdo#108511]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
Participating hosts (50 -> 45)
------------------------------
Additional (1): fi-hsw-4770r
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-whl-u fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7290 -> Patchwork_15186
CI-20190529: 20190529
CI_DRM_7290: 869abae66a356231cfa6645cf491adde3590cba8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5266: 60a67653613c87a69ebecf12cf00aa362ac87597 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15186: 7013ed43c85d401ab86bc97918b5db358bea01f6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7013ed43c85d drm/i915/selftests: Complete transition to a real struct file mock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-08 0:31 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-11-08 0:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Complete transition to a real struct file mock
URL : https://patchwork.freedesktop.org/series/69159/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290 -> Patchwork_15186
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/index.html
Known issues
------------
Here are the changes found in Patchwork_15186 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][1] -> [FAIL][2] ([fdo#111045] / [fdo#111096])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][3] ([fdo#108511]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
Participating hosts (50 -> 45)
------------------------------
Additional (1): fi-hsw-4770r
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-whl-u fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7290 -> Patchwork_15186
CI-20190529: 20190529
CI_DRM_7290: 869abae66a356231cfa6645cf491adde3590cba8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5266: 60a67653613c87a69ebecf12cf00aa362ac87597 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15186: 7013ed43c85d401ab86bc97918b5db358bea01f6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7013ed43c85d drm/i915/selftests: Complete transition to a real struct file mock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-08 9:31 ` Matthew Auld
0 siblings, 0 replies; 10+ messages in thread
From: Matthew Auld @ 2019-11-08 9:31 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 07/11/2019 21:39, Chris Wilson wrote:
> Since drm provided us with a real struct file we can use for our
> anonymous internal clients (mock_file), complete our transition to using
> that as the primary interface (and not the mocked up struct drm_file we
> previous were using).
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-08 9:31 ` Matthew Auld
0 siblings, 0 replies; 10+ messages in thread
From: Matthew Auld @ 2019-11-08 9:31 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 07/11/2019 21:39, Chris Wilson wrote:
> Since drm provided us with a real struct file we can use for our
> anonymous internal clients (mock_file), complete our transition to using
> that as the primary interface (and not the mocked up struct drm_file we
> previous were using).
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-09 9:48 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-11-09 9:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Complete transition to a real struct file mock
URL : https://patchwork.freedesktop.org/series/69159/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290_full -> Patchwork_15186_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15186_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2] ([fdo#111832]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb7/igt@gem_ctx_isolation@bcs0-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb2/igt@gem_ctx_isolation@vcs1-dirty-create.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb8/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_ctx_switch@all-light:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111672])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb9/igt@gem_ctx_switch@all-light.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb6/igt@gem_ctx_switch@all-light.html
* igt@gem_ctx_switch@vcs1-heavy:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112080]) +5 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb2/igt@gem_ctx_switch@vcs1-heavy.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb5/igt@gem_ctx_switch@vcs1-heavy.html
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-kbl3/igt@gem_eio@in-flight-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-kbl4/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@suspend:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111850])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb3/igt@gem_eio@suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb1/igt@gem_eio@suspend.html
* igt@gem_exec_parallel@basic:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111887])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb1/igt@gem_exec_parallel@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb6/igt@gem_exec_parallel@basic.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109276]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb7/igt@gem_exec_schedule@reorder-wide-bsd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#111736] / [fdo#111850])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb4/igt@gem_exec_suspend@basic-s3.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb1/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [PASS][21] -> [TIMEOUT][22] ([fdo#112068 ])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb8/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb7/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][23] -> [DMESG-WARN][24] ([fdo#111870])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [PASS][25] -> [DMESG-WARN][26] ([fdo#111870])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][27] -> [DMESG-WARN][28] ([fdo#108566])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_draw_crc@draw-method-rgb565-render-untiled:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#103184] / [fdo#103232])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#100368])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl2/igt@kms_flip@plain-flip-ts-check-interruptible.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl8/igt@kms_flip@plain-flip-ts-check-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move:
- shard-tglb: [PASS][35] -> [FAIL][36] ([fdo#103167]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][39] -> [FAIL][40] ([fdo#99912])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-apl4/igt@kms_setmode@basic.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-apl4/igt@kms_setmode@basic.html
- shard-kbl: [PASS][41] -> [FAIL][42] ([fdo#99912])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-kbl2/igt@kms_setmode@basic.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-kbl7/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-tglb: [PASS][43] -> [INCOMPLETE][44] ([fdo#111832] / [fdo#111850])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb9/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [PASS][45] -> [INCOMPLETE][46] ([fdo#104108])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl1/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl10/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-c-wait-idle:
- shard-hsw: [PASS][47] -> [INCOMPLETE][48] ([fdo#103540])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw6/igt@kms_vblank@pipe-c-wait-idle.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-hsw4/igt@kms_vblank@pipe-c-wait-idle.html
#### Possible fixes ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][49] ([fdo#109276] / [fdo#112080]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb3/igt@gem_ctx_persistence@vcs1-queued.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_exec_nop@basic-series:
- shard-tglb: [INCOMPLETE][51] ([fdo#111747]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb6/igt@gem_exec_nop@basic-series.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb2/igt@gem_exec_nop@basic-series.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][53] ([fdo#112080]) -> [PASS][54] +11 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][55] ([fdo#112146]) -> [PASS][56] +4 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_mmap_gtt@hang:
- shard-snb: [INCOMPLETE][57] ([fdo#105411]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb2/igt@gem_mmap_gtt@hang.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-snb1/igt@gem_mmap_gtt@hang.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][59] ([fdo#110789] / [fdo#111870]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-hsw: [DMESG-WARN][61] ([fdo#110789] / [fdo#111870]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-tglb: [INCOMPLETE][63] ([fdo#111832] / [fdo#111850]) -> [PASS][64] +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb8/igt@i915_pm_rpm@system-suspend-execbuf.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb5/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][65] ([fdo#108566]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][67] ([fdo#108566]) -> [PASS][68] +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
- shard-skl: [INCOMPLETE][69] ([fdo#110741]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled:
- shard-skl: [FAIL][71] ([fdo#103184] / [fdo#103232]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][73] ([fdo#105363]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl4/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][75] ([fdo#103167]) -> [PASS][76] +5 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-iclb: [FAIL][77] ([fdo#103167] / [fdo#110378]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +3 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][81] ([fdo#108145] / [fdo#110403]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][83] ([fdo#109441]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@kms_psr@psr2_primary_blt.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][85] ([fdo#99912]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-glk1/igt@kms_setmode@basic.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-glk3/igt@kms_setmode@basic.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][87] ([fdo#109276]) -> [PASS][88] +17 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb3/igt@prime_busy@hang-bsd2.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][89] ([fdo# 112000 ] / [fdo#111781]) -> [INCOMPLETE][90] ([fdo#105411])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb1/igt@gem_eio@kms.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-snb2/igt@gem_eio@kms.html
* igt@gem_exec_schedule@deep-blt:
- shard-tglb: [INCOMPLETE][91] ([fdo#111671]) -> [FAIL][92] ([fdo#111646])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb6/igt@gem_exec_schedule@deep-blt.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb7/igt@gem_exec_schedule@deep-blt.html
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [SKIP][93] ([fdo#109276]) -> [FAIL][94] ([fdo#111330])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb3/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@gem_mocs_settings@mocs-isolation-bsd2.html
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][95] ([fdo#111330]) -> [SKIP][96] ([fdo#109276])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb8/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [DMESG-WARN][97] ([fdo#111870]) -> [DMESG-WARN][98] ([fdo#110789] / [fdo#111870])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw6/igt@gem_userptr_blits@sync-unmap-after-close.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-hsw4/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][99] ([fdo#109349]) -> [DMESG-WARN][100] ([fdo#107724])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 112000 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 112000
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
[fdo#110789]: https://bugs.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Complete transition to a real struct file mock
@ 2019-11-09 9:48 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-11-09 9:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Complete transition to a real struct file mock
URL : https://patchwork.freedesktop.org/series/69159/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7290_full -> Patchwork_15186_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15186_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2] ([fdo#111832]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb7/igt@gem_ctx_isolation@bcs0-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb2/igt@gem_ctx_isolation@vcs1-dirty-create.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb8/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_ctx_switch@all-light:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111672])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb9/igt@gem_ctx_switch@all-light.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb6/igt@gem_ctx_switch@all-light.html
* igt@gem_ctx_switch@vcs1-heavy:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112080]) +5 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb2/igt@gem_ctx_switch@vcs1-heavy.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb5/igt@gem_ctx_switch@vcs1-heavy.html
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-kbl3/igt@gem_eio@in-flight-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-kbl4/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@suspend:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111850])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb3/igt@gem_eio@suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb1/igt@gem_eio@suspend.html
* igt@gem_exec_parallel@basic:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111887])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb1/igt@gem_exec_parallel@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb6/igt@gem_exec_parallel@basic.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109276]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb7/igt@gem_exec_schedule@reorder-wide-bsd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#111736] / [fdo#111850])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb4/igt@gem_exec_suspend@basic-s3.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb1/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [PASS][21] -> [TIMEOUT][22] ([fdo#112068 ])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb8/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb7/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][23] -> [DMESG-WARN][24] ([fdo#111870])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [PASS][25] -> [DMESG-WARN][26] ([fdo#111870])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][27] -> [DMESG-WARN][28] ([fdo#108566])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_draw_crc@draw-method-rgb565-render-untiled:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#103184] / [fdo#103232])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#100368])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl2/igt@kms_flip@plain-flip-ts-check-interruptible.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl8/igt@kms_flip@plain-flip-ts-check-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move:
- shard-tglb: [PASS][35] -> [FAIL][36] ([fdo#103167]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][39] -> [FAIL][40] ([fdo#99912])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-apl4/igt@kms_setmode@basic.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-apl4/igt@kms_setmode@basic.html
- shard-kbl: [PASS][41] -> [FAIL][42] ([fdo#99912])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-kbl2/igt@kms_setmode@basic.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-kbl7/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-tglb: [PASS][43] -> [INCOMPLETE][44] ([fdo#111832] / [fdo#111850])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb9/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [PASS][45] -> [INCOMPLETE][46] ([fdo#104108])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl1/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl10/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-c-wait-idle:
- shard-hsw: [PASS][47] -> [INCOMPLETE][48] ([fdo#103540])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw6/igt@kms_vblank@pipe-c-wait-idle.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-hsw4/igt@kms_vblank@pipe-c-wait-idle.html
#### Possible fixes ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][49] ([fdo#109276] / [fdo#112080]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb3/igt@gem_ctx_persistence@vcs1-queued.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_exec_nop@basic-series:
- shard-tglb: [INCOMPLETE][51] ([fdo#111747]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb6/igt@gem_exec_nop@basic-series.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb2/igt@gem_exec_nop@basic-series.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][53] ([fdo#112080]) -> [PASS][54] +11 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][55] ([fdo#112146]) -> [PASS][56] +4 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_mmap_gtt@hang:
- shard-snb: [INCOMPLETE][57] ([fdo#105411]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb2/igt@gem_mmap_gtt@hang.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-snb1/igt@gem_mmap_gtt@hang.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][59] ([fdo#110789] / [fdo#111870]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-hsw: [DMESG-WARN][61] ([fdo#110789] / [fdo#111870]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-tglb: [INCOMPLETE][63] ([fdo#111832] / [fdo#111850]) -> [PASS][64] +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb8/igt@i915_pm_rpm@system-suspend-execbuf.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb5/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][65] ([fdo#108566]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][67] ([fdo#108566]) -> [PASS][68] +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
- shard-skl: [INCOMPLETE][69] ([fdo#110741]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled:
- shard-skl: [FAIL][71] ([fdo#103184] / [fdo#103232]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][73] ([fdo#105363]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl4/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][75] ([fdo#103167]) -> [PASS][76] +5 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-iclb: [FAIL][77] ([fdo#103167] / [fdo#110378]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +3 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][81] ([fdo#108145] / [fdo#110403]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][83] ([fdo#109441]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@kms_psr@psr2_primary_blt.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][85] ([fdo#99912]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-glk1/igt@kms_setmode@basic.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-glk3/igt@kms_setmode@basic.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][87] ([fdo#109276]) -> [PASS][88] +17 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb3/igt@prime_busy@hang-bsd2.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][89] ([fdo# 112000 ] / [fdo#111781]) -> [INCOMPLETE][90] ([fdo#105411])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-snb1/igt@gem_eio@kms.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-snb2/igt@gem_eio@kms.html
* igt@gem_exec_schedule@deep-blt:
- shard-tglb: [INCOMPLETE][91] ([fdo#111671]) -> [FAIL][92] ([fdo#111646])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-tglb6/igt@gem_exec_schedule@deep-blt.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-tglb7/igt@gem_exec_schedule@deep-blt.html
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [SKIP][93] ([fdo#109276]) -> [FAIL][94] ([fdo#111330])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb3/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb1/igt@gem_mocs_settings@mocs-isolation-bsd2.html
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][95] ([fdo#111330]) -> [SKIP][96] ([fdo#109276])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb8/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [DMESG-WARN][97] ([fdo#111870]) -> [DMESG-WARN][98] ([fdo#110789] / [fdo#111870])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-hsw6/igt@gem_userptr_blits@sync-unmap-after-close.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-hsw4/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][99] ([fdo#109349]) -> [DMESG-WARN][100] ([fdo#107724])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7290/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 112000 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 112000
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
[fdo#110789]: https://bugs.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15186/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-11-09 9:48 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 21:39 [PATCH] drm/i915/selftests: Complete transition to a real struct file mock Chris Wilson
2019-11-07 21:39 ` [Intel-gfx] " Chris Wilson
2019-11-08 0:09 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-08 0:09 ` [Intel-gfx] " Patchwork
2019-11-08 0:31 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-08 0:31 ` [Intel-gfx] " Patchwork
2019-11-08 9:31 ` [PATCH] " Matthew Auld
2019-11-08 9:31 ` [Intel-gfx] " Matthew Auld
2019-11-09 9:48 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-11-09 9:48 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.