* [PATCH 0/2] Improve error handling on DSB
@ 2019-11-11 20:50 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-11 20:50 UTC (permalink / raw)
To: intel-gfx
I was debugging a problem that got fixed by a096883dda2c ("drm/i915/dsb:
Remove PIN_MAPPABLE from the DSB object VMA"). While that specific
problem is already fixed, others may pop up in future. This series
is tested by temporarily reverting that commit and ensuring we have
only a error message in the log, with graceful degradation to
"pass-through writes" like on platforms that don't support DSB.
Lucas De Marchi (2):
drm/i915/dsb: remove atomic operations
drm/i915/dsb: fix extra warning on error path handling
drivers/gpu/drm/i915/display/intel_dsb.c | 27 +++++++++++++++---------
drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
2 files changed, 18 insertions(+), 11 deletions(-)
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [Intel-gfx] [PATCH 0/2] Improve error handling on DSB
@ 2019-11-11 20:50 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-11 20:50 UTC (permalink / raw)
To: intel-gfx
I was debugging a problem that got fixed by a096883dda2c ("drm/i915/dsb:
Remove PIN_MAPPABLE from the DSB object VMA"). While that specific
problem is already fixed, others may pop up in future. This series
is tested by temporarily reverting that commit and ensuring we have
only a error message in the log, with graceful degradation to
"pass-through writes" like on platforms that don't support DSB.
Lucas De Marchi (2):
drm/i915/dsb: remove atomic operations
drm/i915/dsb: fix extra warning on error path handling
drivers/gpu/drm/i915/display/intel_dsb.c | 27 +++++++++++++++---------
drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
2 files changed, 18 insertions(+), 11 deletions(-)
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 1/2] drm/i915/dsb: remove atomic operations
@ 2019-11-11 20:50 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-11 20:50 UTC (permalink / raw)
To: intel-gfx
The current dsb API is not really prepared to handle multithread access.
I was debugging an issue that ended up fixed by commit a096883dda2c
("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
puzzled how these atomic operations were guaranteeing atomicity.
if (atomic_add_return(1, &dsb->refcount) != 1)
return dsb;
Thread A could still be initializing dsb struct (and even fail in the
middle) while thread B would take a reference and use it (even
derefencing a NULL cmd_buf).
I don't think the atomic operations here will help much if this were
to support multithreaded scenario in future, so just remove them to
avoid confusion.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index d8ad5fe1efef..4feebbeb0b0c 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
if (!HAS_DSB(i915))
return dsb;
- if (atomic_add_return(1, &dsb->refcount) != 1)
+ if (++dsb->refcount != 1)
return dsb;
dsb->id = DSB1;
@@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
if (IS_ERR(vma)) {
DRM_ERROR("Vma creation failed\n");
i915_gem_object_put(obj);
- atomic_dec(&dsb->refcount);
+ dsb->refcount--;
goto err;
}
@@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
DRM_ERROR("Command buffer creation failed\n");
i915_vma_unpin_and_release(&vma, 0);
dsb->cmd_buf = NULL;
- atomic_dec(&dsb->refcount);
+ dsb->refcount--;
goto err;
}
dsb->vma = vma;
@@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
if (!HAS_DSB(i915))
return;
- if (WARN_ON(atomic_read(&dsb->refcount) == 0))
+ if (WARN_ON(dsb->refcount == 0))
return;
- if (atomic_dec_and_test(&dsb->refcount)) {
+ if (--dsb->refcount == 0) {
i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
dsb->cmd_buf = NULL;
dsb->free_pos = 0;
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
index 6f95c8e909e6..395ef9ce558e 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.h
+++ b/drivers/gpu/drm/i915/display/intel_dsb.h
@@ -22,7 +22,7 @@ enum dsb_id {
};
struct intel_dsb {
- atomic_t refcount;
+ long refcount;
enum dsb_id id;
u32 *cmd_buf;
struct i915_vma *vma;
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915/dsb: remove atomic operations
@ 2019-11-11 20:50 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-11 20:50 UTC (permalink / raw)
To: intel-gfx
The current dsb API is not really prepared to handle multithread access.
I was debugging an issue that ended up fixed by commit a096883dda2c
("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
puzzled how these atomic operations were guaranteeing atomicity.
if (atomic_add_return(1, &dsb->refcount) != 1)
return dsb;
Thread A could still be initializing dsb struct (and even fail in the
middle) while thread B would take a reference and use it (even
derefencing a NULL cmd_buf).
I don't think the atomic operations here will help much if this were
to support multithreaded scenario in future, so just remove them to
avoid confusion.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index d8ad5fe1efef..4feebbeb0b0c 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
if (!HAS_DSB(i915))
return dsb;
- if (atomic_add_return(1, &dsb->refcount) != 1)
+ if (++dsb->refcount != 1)
return dsb;
dsb->id = DSB1;
@@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
if (IS_ERR(vma)) {
DRM_ERROR("Vma creation failed\n");
i915_gem_object_put(obj);
- atomic_dec(&dsb->refcount);
+ dsb->refcount--;
goto err;
}
@@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
DRM_ERROR("Command buffer creation failed\n");
i915_vma_unpin_and_release(&vma, 0);
dsb->cmd_buf = NULL;
- atomic_dec(&dsb->refcount);
+ dsb->refcount--;
goto err;
}
dsb->vma = vma;
@@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
if (!HAS_DSB(i915))
return;
- if (WARN_ON(atomic_read(&dsb->refcount) == 0))
+ if (WARN_ON(dsb->refcount == 0))
return;
- if (atomic_dec_and_test(&dsb->refcount)) {
+ if (--dsb->refcount == 0) {
i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
dsb->cmd_buf = NULL;
dsb->free_pos = 0;
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
index 6f95c8e909e6..395ef9ce558e 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.h
+++ b/drivers/gpu/drm/i915/display/intel_dsb.h
@@ -22,7 +22,7 @@ enum dsb_id {
};
struct intel_dsb {
- atomic_t refcount;
+ long refcount;
enum dsb_id id;
u32 *cmd_buf;
struct i915_vma *vma;
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 2/2] drm/i915/dsb: fix extra warning on error path handling
@ 2019-11-11 20:50 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-11 20:50 UTC (permalink / raw)
To: intel-gfx
When we call intel_dsb_get(), the dsb initialization may fail for
various reasons. We already log the error message in that path, making
it unnecessary to trigger a warning that refcount == 0 when calling
intel_dsb_put().
So here we simplify the logic and do lazy shutdown: leaving the extra
refcount alive so when we call intel_dsb_put() we end up calling
i915_vma_unpin_and_release().
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 4feebbeb0b0c..858af6be9c36 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -102,6 +102,7 @@ intel_dsb_get(struct intel_crtc *crtc)
struct intel_dsb *dsb = &crtc->dsb;
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
+ u32 *buf;
intel_wakeref_t wakeref;
if (!HAS_DSB(i915))
@@ -110,7 +111,6 @@ intel_dsb_get(struct intel_crtc *crtc)
if (++dsb->refcount != 1)
return dsb;
- dsb->id = DSB1;
wakeref = intel_runtime_pm_get(&i915->runtime_pm);
obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
@@ -123,22 +123,29 @@ intel_dsb_get(struct intel_crtc *crtc)
if (IS_ERR(vma)) {
DRM_ERROR("Vma creation failed\n");
i915_gem_object_put(obj);
- dsb->refcount--;
goto err;
}
- dsb->cmd_buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
- if (IS_ERR(dsb->cmd_buf)) {
+ buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
+ if (IS_ERR(buf)) {
DRM_ERROR("Command buffer creation failed\n");
- i915_vma_unpin_and_release(&vma, 0);
- dsb->cmd_buf = NULL;
- dsb->refcount--;
goto err;
}
+
+ dsb->id = DSB1;
dsb->vma = vma;
+ dsb->cmd_buf = buf;
err:
+ /*
+ * Set cmd_buf to NULL so the writes pass-through, but leave the
+ * dangling refcount to be removed later by the corresponding
+ * intel_dsb_put(): the important error message will already be
+ * logged above.
+ */
+ dsb->cmd_buf = NULL;
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
+
return dsb;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/dsb: fix extra warning on error path handling
@ 2019-11-11 20:50 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-11 20:50 UTC (permalink / raw)
To: intel-gfx
When we call intel_dsb_get(), the dsb initialization may fail for
various reasons. We already log the error message in that path, making
it unnecessary to trigger a warning that refcount == 0 when calling
intel_dsb_put().
So here we simplify the logic and do lazy shutdown: leaving the extra
refcount alive so when we call intel_dsb_put() we end up calling
i915_vma_unpin_and_release().
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 4feebbeb0b0c..858af6be9c36 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -102,6 +102,7 @@ intel_dsb_get(struct intel_crtc *crtc)
struct intel_dsb *dsb = &crtc->dsb;
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
+ u32 *buf;
intel_wakeref_t wakeref;
if (!HAS_DSB(i915))
@@ -110,7 +111,6 @@ intel_dsb_get(struct intel_crtc *crtc)
if (++dsb->refcount != 1)
return dsb;
- dsb->id = DSB1;
wakeref = intel_runtime_pm_get(&i915->runtime_pm);
obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
@@ -123,22 +123,29 @@ intel_dsb_get(struct intel_crtc *crtc)
if (IS_ERR(vma)) {
DRM_ERROR("Vma creation failed\n");
i915_gem_object_put(obj);
- dsb->refcount--;
goto err;
}
- dsb->cmd_buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
- if (IS_ERR(dsb->cmd_buf)) {
+ buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
+ if (IS_ERR(buf)) {
DRM_ERROR("Command buffer creation failed\n");
- i915_vma_unpin_and_release(&vma, 0);
- dsb->cmd_buf = NULL;
- dsb->refcount--;
goto err;
}
+
+ dsb->id = DSB1;
dsb->vma = vma;
+ dsb->cmd_buf = buf;
err:
+ /*
+ * Set cmd_buf to NULL so the writes pass-through, but leave the
+ * dangling refcount to be removed later by the corresponding
+ * intel_dsb_put(): the important error message will already be
+ * logged above.
+ */
+ dsb->cmd_buf = NULL;
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
+
return dsb;
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 34+ messages in thread
* ✓ Fi.CI.BAT: success for Improve error handling on DSB
@ 2019-11-11 22:13 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-11 22:13 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7311 -> Patchwork_15225
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/index.html
Known issues
------------
Here are the changes found in Patchwork_15225 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: [PASS][1] -> [DMESG-WARN][2] ([fdo#107139])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_gem_contexts:
- fi-skl-lmem: [PASS][3] -> [INCOMPLETE][4] ([fdo#111700])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-skl-6770hq: [PASS][5] -> [FAIL][6] ([fdo#109495])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][7] ([fdo#108511]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-skl-6770hq: [WARN][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u4: [FAIL][11] ([fdo#111045]) -> [FAIL][12] ([fdo#111045] / [fdo#111096])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-icl-u4/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-icl-u4/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109495]: https://bugs.freedesktop.org/show_bug.cgi?id=109495
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111700]: https://bugs.freedesktop.org/show_bug.cgi?id=111700
Participating hosts (52 -> 45)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7311 -> Patchwork_15225
CI-20190529: 20190529
CI_DRM_7311: 36d31f70111ea87432ee8a8981943c5b20e36213 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5271: 05f0400c50af843df301efb5475e9f5e2d16a098 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15225: 76c10ea10e25611547bb738b26e3995b876d566c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
76c10ea10e25 drm/i915/dsb: fix extra warning on error path handling
fcfb85ae691d drm/i915/dsb: remove atomic operations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Improve error handling on DSB
@ 2019-11-11 22:13 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-11 22:13 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7311 -> Patchwork_15225
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/index.html
Known issues
------------
Here are the changes found in Patchwork_15225 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: [PASS][1] -> [DMESG-WARN][2] ([fdo#107139])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_gem_contexts:
- fi-skl-lmem: [PASS][3] -> [INCOMPLETE][4] ([fdo#111700])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-skl-6770hq: [PASS][5] -> [FAIL][6] ([fdo#109495])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][7] ([fdo#108511]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-skl-6770hq: [WARN][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u4: [FAIL][11] ([fdo#111045]) -> [FAIL][12] ([fdo#111045] / [fdo#111096])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-icl-u4/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/fi-icl-u4/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109495]: https://bugs.freedesktop.org/show_bug.cgi?id=109495
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111700]: https://bugs.freedesktop.org/show_bug.cgi?id=111700
Participating hosts (52 -> 45)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7311 -> Patchwork_15225
CI-20190529: 20190529
CI_DRM_7311: 36d31f70111ea87432ee8a8981943c5b20e36213 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5271: 05f0400c50af843df301efb5475e9f5e2d16a098 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15225: 76c10ea10e25611547bb738b26e3995b876d566c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
76c10ea10e25 drm/i915/dsb: fix extra warning on error path handling
fcfb85ae691d drm/i915/dsb: remove atomic operations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* ✗ Fi.CI.IGT: failure for Improve error handling on DSB
@ 2019-11-12 9:16 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-12 9:16 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB
URL : https://patchwork.freedesktop.org/series/69319/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7311_full -> Patchwork_15225_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15225_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15225_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15225_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_schedule@preempt-other-chain-render:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb4/igt@gem_exec_schedule@preempt-other-chain-render.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@gem_exec_schedule@preempt-other-chain-render.html
Known issues
------------
Here are the changes found in Patchwork_15225_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb7/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_switch@vcs1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_ctx_switch@vcs1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb6/igt@gem_ctx_switch@vcs1.html
* igt@gem_exec_nop@basic-sequential:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([fdo#111747])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb1/igt@gem_exec_nop@basic-sequential.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@gem_exec_nop@basic-sequential.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +13 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb7/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112146]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb5/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb4/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111606] / [fdo#111677])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb8/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
* igt@gem_sync@basic-store-each:
- shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111647] / [fdo#111747])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb4/igt@gem_sync@basic-store-each.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@gem_sync@basic-store-each.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [PASS][17] -> [DMESG-WARN][18] ([fdo#111870])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#111830 ])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb7/igt@i915_pm_dc@dc6-dpms.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@system-suspend:
- shard-tglb: [PASS][21] -> [INCOMPLETE][22] ([fdo#111747] / [fdo#111850])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb9/igt@i915_pm_rpm@system-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb1/igt@i915_pm_rpm@system-suspend.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111832] / [fdo#111850]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb2/igt@i915_suspend@sysfs-reader.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb2/igt@i915_suspend@sysfs-reader.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [PASS][25] -> [DMESG-WARN][26] ([fdo#106107])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl8/igt@kms_color@pipe-a-ctm-0-5.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl5/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [PASS][27] -> [INCOMPLETE][28] ([fdo#105411])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb6/igt@kms_flip@flip-vs-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-tglb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][35] -> [DMESG-WARN][36] ([fdo#108566]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][37] -> [FAIL][38] ([fdo#108145])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#108145] / [fdo#110403])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][43] -> [FAIL][44] ([fdo#99912])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-apl7/igt@kms_setmode@basic.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-apl4/igt@kms_setmode@basic.html
- shard-hsw: [PASS][45] -> [FAIL][46] ([fdo#99912])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-hsw7/igt@kms_setmode@basic.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-hsw5/igt@kms_setmode@basic.html
* igt@perf@oa-exponents:
- shard-hsw: [PASS][47] -> [FAIL][48] ([fdo#105483])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-hsw5/igt@perf@oa-exponents.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-hsw5/igt@perf@oa-exponents.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-iclb: [DMESG-WARN][49] ([fdo#111764]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb5/igt@gem_ctx_isolation@bcs0-s3.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@gem_ctx_isolation@bcs0-s3.html
- shard-kbl: [DMESG-WARN][51] ([fdo#108566]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-kbl1/igt@gem_ctx_isolation@bcs0-s3.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-kbl3/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [SKIP][53] ([fdo#109276] / [fdo#112080]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb3/igt@gem_ctx_persistence@vcs1-mixed.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][55] ([fdo#110841]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_eio@in-flight-10ms:
- shard-snb: [FAIL][57] ([fdo#111946]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb4/igt@gem_eio@in-flight-10ms.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb5/igt@gem_eio@in-flight-10ms.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][59] ([fdo#110854]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb3/igt@gem_exec_balancer@smoke.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_create@madvise:
- shard-tglb: [INCOMPLETE][61] ([fdo#111747]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb6/igt@gem_exec_create@madvise.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb7/igt@gem_exec_create@madvise.html
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [SKIP][63] ([fdo#109276]) -> [PASS][64] +11 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb7/igt@gem_exec_schedule@out-order-bsd2.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@gem_exec_schedule@out-order-bsd2.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][65] ([fdo#112146]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb6/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_exec_suspend@basic-s3-devices:
- shard-tglb: [INCOMPLETE][67] ([fdo#111832] / [fdo#111850]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb3/igt@gem_exec_suspend@basic-s3-devices.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb9/igt@gem_exec_suspend@basic-s3-devices.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-iclb: [TIMEOUT][69] ([fdo#112068 ]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-hsw: [FAIL][71] ([fdo#112037]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-hsw5/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-hsw4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* igt@gem_softpin@softpin:
- shard-hsw: [INCOMPLETE][73] ([fdo#103540]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-hsw7/igt@gem_softpin@softpin.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-hsw4/igt@gem_softpin@softpin.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][75] ([fdo#111870]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@kms_color@pipe-b-ctm-0-25:
- shard-skl: [DMESG-WARN][77] ([fdo#106107]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl6/igt@kms_color@pipe-b-ctm-0-25.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl2/igt@kms_color@pipe-b-ctm-0-25.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][79] ([fdo#108566]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-tglb: [FAIL][81] ([fdo#103167]) -> [PASS][82] +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
- shard-iclb: [FAIL][83] ([fdo#103167]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
- shard-skl: [FAIL][85] ([fdo#103167]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][87] ([fdo#108145]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][89] ([fdo#108341]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@kms_psr@no_drrs.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][91] ([fdo#109441]) -> [PASS][92] +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@kms_psr@psr2_basic.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@kms_psr@psr2_basic.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-skl: [INCOMPLETE][93] ([fdo#104108]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl4/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl1/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [SKIP][95] ([fdo#112080]) -> [PASS][96] +8 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb6/igt@perf_pmu@busy-vcs1.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb1/igt@perf_pmu@busy-vcs1.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][97] ([fdo#109276] / [fdo#112080]) -> [FAIL][98] ([fdo#111329])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [FAIL][99] ([fdo#111329]) -> [SKIP][100] ([fdo#109276] / [fdo#112080])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_ctx_isolation@vcs2-nonpriv:
- shard-tglb: [SKIP][101] ([fdo#112080]) -> [SKIP][102] ([fdo#111912] / [fdo#112080])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb9/igt@gem_ctx_isolation@vcs2-nonpriv.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb1/igt@gem_ctx_isolation@vcs2-nonpriv.html
* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][103] ([fdo# 112000 ] / [fdo#111781]) -> [INCOMPLETE][104] ([fdo#105411])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb6/igt@gem_eio@kms.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb1/igt@gem_eio@kms.html
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [FAIL][105] ([fdo#111330]) -> [SKIP][106] ([fdo#109276])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb2/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb6/igt@gem_mocs_settings@mocs-isolation-bs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Improve error handling on DSB
@ 2019-11-12 9:16 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-12 9:16 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB
URL : https://patchwork.freedesktop.org/series/69319/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7311_full -> Patchwork_15225_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15225_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15225_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15225_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_schedule@preempt-other-chain-render:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb4/igt@gem_exec_schedule@preempt-other-chain-render.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@gem_exec_schedule@preempt-other-chain-render.html
Known issues
------------
Here are the changes found in Patchwork_15225_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb7/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_switch@vcs1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_ctx_switch@vcs1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb6/igt@gem_ctx_switch@vcs1.html
* igt@gem_exec_nop@basic-sequential:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([fdo#111747])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb1/igt@gem_exec_nop@basic-sequential.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@gem_exec_nop@basic-sequential.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +13 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb7/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112146]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb5/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb4/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111606] / [fdo#111677])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb8/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
* igt@gem_sync@basic-store-each:
- shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111647] / [fdo#111747])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb4/igt@gem_sync@basic-store-each.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@gem_sync@basic-store-each.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [PASS][17] -> [DMESG-WARN][18] ([fdo#111870])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#111830 ])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb7/igt@i915_pm_dc@dc6-dpms.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@system-suspend:
- shard-tglb: [PASS][21] -> [INCOMPLETE][22] ([fdo#111747] / [fdo#111850])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb9/igt@i915_pm_rpm@system-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb1/igt@i915_pm_rpm@system-suspend.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111832] / [fdo#111850]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb2/igt@i915_suspend@sysfs-reader.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb2/igt@i915_suspend@sysfs-reader.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [PASS][25] -> [DMESG-WARN][26] ([fdo#106107])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl8/igt@kms_color@pipe-a-ctm-0-5.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl5/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [PASS][27] -> [INCOMPLETE][28] ([fdo#105411])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb6/igt@kms_flip@flip-vs-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-tglb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][35] -> [DMESG-WARN][36] ([fdo#108566]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][37] -> [FAIL][38] ([fdo#108145])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#108145] / [fdo#110403])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][43] -> [FAIL][44] ([fdo#99912])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-apl7/igt@kms_setmode@basic.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-apl4/igt@kms_setmode@basic.html
- shard-hsw: [PASS][45] -> [FAIL][46] ([fdo#99912])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-hsw7/igt@kms_setmode@basic.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-hsw5/igt@kms_setmode@basic.html
* igt@perf@oa-exponents:
- shard-hsw: [PASS][47] -> [FAIL][48] ([fdo#105483])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-hsw5/igt@perf@oa-exponents.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-hsw5/igt@perf@oa-exponents.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-iclb: [DMESG-WARN][49] ([fdo#111764]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb5/igt@gem_ctx_isolation@bcs0-s3.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@gem_ctx_isolation@bcs0-s3.html
- shard-kbl: [DMESG-WARN][51] ([fdo#108566]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-kbl1/igt@gem_ctx_isolation@bcs0-s3.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-kbl3/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [SKIP][53] ([fdo#109276] / [fdo#112080]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb3/igt@gem_ctx_persistence@vcs1-mixed.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][55] ([fdo#110841]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_eio@in-flight-10ms:
- shard-snb: [FAIL][57] ([fdo#111946]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb4/igt@gem_eio@in-flight-10ms.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb5/igt@gem_eio@in-flight-10ms.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][59] ([fdo#110854]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb3/igt@gem_exec_balancer@smoke.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_create@madvise:
- shard-tglb: [INCOMPLETE][61] ([fdo#111747]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb6/igt@gem_exec_create@madvise.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb7/igt@gem_exec_create@madvise.html
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [SKIP][63] ([fdo#109276]) -> [PASS][64] +11 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb7/igt@gem_exec_schedule@out-order-bsd2.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@gem_exec_schedule@out-order-bsd2.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][65] ([fdo#112146]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb6/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_exec_suspend@basic-s3-devices:
- shard-tglb: [INCOMPLETE][67] ([fdo#111832] / [fdo#111850]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb3/igt@gem_exec_suspend@basic-s3-devices.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb9/igt@gem_exec_suspend@basic-s3-devices.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-iclb: [TIMEOUT][69] ([fdo#112068 ]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-hsw: [FAIL][71] ([fdo#112037]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-hsw5/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-hsw4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* igt@gem_softpin@softpin:
- shard-hsw: [INCOMPLETE][73] ([fdo#103540]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-hsw7/igt@gem_softpin@softpin.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-hsw4/igt@gem_softpin@softpin.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][75] ([fdo#111870]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@kms_color@pipe-b-ctm-0-25:
- shard-skl: [DMESG-WARN][77] ([fdo#106107]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl6/igt@kms_color@pipe-b-ctm-0-25.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl2/igt@kms_color@pipe-b-ctm-0-25.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][79] ([fdo#108566]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-tglb: [FAIL][81] ([fdo#103167]) -> [PASS][82] +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
- shard-iclb: [FAIL][83] ([fdo#103167]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
- shard-skl: [FAIL][85] ([fdo#103167]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][87] ([fdo#108145]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][89] ([fdo#108341]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@kms_psr@no_drrs.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][91] ([fdo#109441]) -> [PASS][92] +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@kms_psr@psr2_basic.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb2/igt@kms_psr@psr2_basic.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-skl: [INCOMPLETE][93] ([fdo#104108]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-skl4/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-skl1/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [SKIP][95] ([fdo#112080]) -> [PASS][96] +8 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb6/igt@perf_pmu@busy-vcs1.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb1/igt@perf_pmu@busy-vcs1.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][97] ([fdo#109276] / [fdo#112080]) -> [FAIL][98] ([fdo#111329])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [FAIL][99] ([fdo#111329]) -> [SKIP][100] ([fdo#109276] / [fdo#112080])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_ctx_isolation@vcs2-nonpriv:
- shard-tglb: [SKIP][101] ([fdo#112080]) -> [SKIP][102] ([fdo#111912] / [fdo#112080])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-tglb9/igt@gem_ctx_isolation@vcs2-nonpriv.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-tglb1/igt@gem_ctx_isolation@vcs2-nonpriv.html
* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][103] ([fdo# 112000 ] / [fdo#111781]) -> [INCOMPLETE][104] ([fdo#105411])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-snb6/igt@gem_eio@kms.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-snb1/igt@gem_eio@kms.html
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [FAIL][105] ([fdo#111330]) -> [SKIP][106] ([fdo#109276])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/shard-iclb2/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/shard-iclb6/igt@gem_mocs_settings@mocs-isolation-bs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15225/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* ✓ Fi.CI.BAT: success for Improve error handling on DSB (rev2)
@ 2019-11-15 2:35 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-15 2:35 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev2)
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7348 -> Patchwork_15272
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/index.html
Known issues
------------
Here are the changes found in Patchwork_15272 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([fdo#105876])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-bsw-n3050/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/fi-bsw-n3050/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_selftest@live_gt_heartbeat:
- fi-skl-guc: [PASS][3] -> [DMESG-FAIL][4] ([fdo#112096])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-skl-guc/igt@i915_selftest@live_gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/fi-skl-guc/igt@i915_selftest@live_gt_heartbeat.html
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-icl-dsi: [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-icl-dsi/igt@i915_selftest@live_execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/fi-icl-dsi/igt@i915_selftest@live_execlists.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [DMESG-WARN][7] ([fdo#105541]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#110343]: https://bugs.freedesktop.org/show_bug.cgi?id=110343
[fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
[fdo#112260]: https://bugs.freedesktop.org/show_bug.cgi?id=112260
Participating hosts (48 -> 45)
------------------------------
Additional (1): fi-byt-j1900
Missing (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7348 -> Patchwork_15272
CI-20190529: 20190529
CI_DRM_7348: 70e2f594be151db66cf74acd86b5d5155c311780 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5287: 9e57f8a51d59b3ffe4002d761fe0315d733bd66e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15272: 7092221ce8ec289a8db94229eb2c78c8ea3c68cf @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7092221ce8ec drm/i915/dsb: fix extra warning on error path handling
8b674b56da2e drm/i915/dsb: remove atomic operations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Improve error handling on DSB (rev2)
@ 2019-11-15 2:35 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-15 2:35 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev2)
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7348 -> Patchwork_15272
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/index.html
Known issues
------------
Here are the changes found in Patchwork_15272 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([fdo#105876])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-bsw-n3050/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/fi-bsw-n3050/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_selftest@live_gt_heartbeat:
- fi-skl-guc: [PASS][3] -> [DMESG-FAIL][4] ([fdo#112096])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-skl-guc/igt@i915_selftest@live_gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/fi-skl-guc/igt@i915_selftest@live_gt_heartbeat.html
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-icl-dsi: [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-icl-dsi/igt@i915_selftest@live_execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/fi-icl-dsi/igt@i915_selftest@live_execlists.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [DMESG-WARN][7] ([fdo#105541]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#110343]: https://bugs.freedesktop.org/show_bug.cgi?id=110343
[fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
[fdo#112260]: https://bugs.freedesktop.org/show_bug.cgi?id=112260
Participating hosts (48 -> 45)
------------------------------
Additional (1): fi-byt-j1900
Missing (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7348 -> Patchwork_15272
CI-20190529: 20190529
CI_DRM_7348: 70e2f594be151db66cf74acd86b5d5155c311780 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5287: 9e57f8a51d59b3ffe4002d761fe0315d733bd66e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15272: 7092221ce8ec289a8db94229eb2c78c8ea3c68cf @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7092221ce8ec drm/i915/dsb: fix extra warning on error path handling
8b674b56da2e drm/i915/dsb: remove atomic operations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 1/2] drm/i915/dsb: remove atomic operations
@ 2019-11-15 20:29 ` Matt Roper
0 siblings, 0 replies; 34+ messages in thread
From: Matt Roper @ 2019-11-15 20:29 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Mon, Nov 11, 2019 at 12:50:24PM -0800, Lucas De Marchi wrote:
> The current dsb API is not really prepared to handle multithread access.
> I was debugging an issue that ended up fixed by commit a096883dda2c
> ("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
> puzzled how these atomic operations were guaranteeing atomicity.
>
> if (atomic_add_return(1, &dsb->refcount) != 1)
> return dsb;
>
> Thread A could still be initializing dsb struct (and even fail in the
> middle) while thread B would take a reference and use it (even
> derefencing a NULL cmd_buf).
>
> I don't think the atomic operations here will help much if this were
> to support multithreaded scenario in future, so just remove them to
> avoid confusion.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Agreed; the synchronization here doesn't appear to make sense. But
also I believe everywhere this would get called is on the atomic commit
path and we already hold the CRTC lock at that point which will prevent
concurrent threads calling this. So
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
> drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index d8ad5fe1efef..4feebbeb0b0c 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> if (!HAS_DSB(i915))
> return dsb;
>
> - if (atomic_add_return(1, &dsb->refcount) != 1)
> + if (++dsb->refcount != 1)
> return dsb;
>
> dsb->id = DSB1;
> @@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> if (IS_ERR(vma)) {
> DRM_ERROR("Vma creation failed\n");
> i915_gem_object_put(obj);
> - atomic_dec(&dsb->refcount);
> + dsb->refcount--;
> goto err;
> }
>
> @@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> DRM_ERROR("Command buffer creation failed\n");
> i915_vma_unpin_and_release(&vma, 0);
> dsb->cmd_buf = NULL;
> - atomic_dec(&dsb->refcount);
> + dsb->refcount--;
> goto err;
> }
> dsb->vma = vma;
> @@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
> if (!HAS_DSB(i915))
> return;
>
> - if (WARN_ON(atomic_read(&dsb->refcount) == 0))
> + if (WARN_ON(dsb->refcount == 0))
> return;
>
> - if (atomic_dec_and_test(&dsb->refcount)) {
> + if (--dsb->refcount == 0) {
> i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
> dsb->cmd_buf = NULL;
> dsb->free_pos = 0;
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
> index 6f95c8e909e6..395ef9ce558e 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.h
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.h
> @@ -22,7 +22,7 @@ enum dsb_id {
> };
>
> struct intel_dsb {
> - atomic_t refcount;
> + long refcount;
> enum dsb_id id;
> u32 *cmd_buf;
> struct i915_vma *vma;
> --
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsb: remove atomic operations
@ 2019-11-15 20:29 ` Matt Roper
0 siblings, 0 replies; 34+ messages in thread
From: Matt Roper @ 2019-11-15 20:29 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Mon, Nov 11, 2019 at 12:50:24PM -0800, Lucas De Marchi wrote:
> The current dsb API is not really prepared to handle multithread access.
> I was debugging an issue that ended up fixed by commit a096883dda2c
> ("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
> puzzled how these atomic operations were guaranteeing atomicity.
>
> if (atomic_add_return(1, &dsb->refcount) != 1)
> return dsb;
>
> Thread A could still be initializing dsb struct (and even fail in the
> middle) while thread B would take a reference and use it (even
> derefencing a NULL cmd_buf).
>
> I don't think the atomic operations here will help much if this were
> to support multithreaded scenario in future, so just remove them to
> avoid confusion.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Agreed; the synchronization here doesn't appear to make sense. But
also I believe everywhere this would get called is on the atomic commit
path and we already hold the CRTC lock at that point which will prevent
concurrent threads calling this. So
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
> drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index d8ad5fe1efef..4feebbeb0b0c 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> if (!HAS_DSB(i915))
> return dsb;
>
> - if (atomic_add_return(1, &dsb->refcount) != 1)
> + if (++dsb->refcount != 1)
> return dsb;
>
> dsb->id = DSB1;
> @@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> if (IS_ERR(vma)) {
> DRM_ERROR("Vma creation failed\n");
> i915_gem_object_put(obj);
> - atomic_dec(&dsb->refcount);
> + dsb->refcount--;
> goto err;
> }
>
> @@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> DRM_ERROR("Command buffer creation failed\n");
> i915_vma_unpin_and_release(&vma, 0);
> dsb->cmd_buf = NULL;
> - atomic_dec(&dsb->refcount);
> + dsb->refcount--;
> goto err;
> }
> dsb->vma = vma;
> @@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
> if (!HAS_DSB(i915))
> return;
>
> - if (WARN_ON(atomic_read(&dsb->refcount) == 0))
> + if (WARN_ON(dsb->refcount == 0))
> return;
>
> - if (atomic_dec_and_test(&dsb->refcount)) {
> + if (--dsb->refcount == 0) {
> i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
> dsb->cmd_buf = NULL;
> dsb->free_pos = 0;
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
> index 6f95c8e909e6..395ef9ce558e 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.h
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.h
> @@ -22,7 +22,7 @@ enum dsb_id {
> };
>
> struct intel_dsb {
> - atomic_t refcount;
> + long refcount;
> enum dsb_id id;
> u32 *cmd_buf;
> struct i915_vma *vma;
> --
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 2/2] drm/i915/dsb: fix extra warning on error path handling
@ 2019-11-15 20:52 ` Matt Roper
0 siblings, 0 replies; 34+ messages in thread
From: Matt Roper @ 2019-11-15 20:52 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Mon, Nov 11, 2019 at 12:50:25PM -0800, Lucas De Marchi wrote:
> When we call intel_dsb_get(), the dsb initialization may fail for
> various reasons. We already log the error message in that path, making
> it unnecessary to trigger a warning that refcount == 0 when calling
> intel_dsb_put().
>
> So here we simplify the logic and do lazy shutdown: leaving the extra
> refcount alive so when we call intel_dsb_put() we end up calling
> i915_vma_unpin_and_release().
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Due to the lack of any actual concurrency, it seems like we could
eventually get rid of the whole get/put design and just allocate the
buffer once (and pin it during the prepare step). But this seems good
enough for now.
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 4feebbeb0b0c..858af6be9c36 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -102,6 +102,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> struct intel_dsb *dsb = &crtc->dsb;
> struct drm_i915_gem_object *obj;
> struct i915_vma *vma;
> + u32 *buf;
> intel_wakeref_t wakeref;
>
> if (!HAS_DSB(i915))
> @@ -110,7 +111,6 @@ intel_dsb_get(struct intel_crtc *crtc)
> if (++dsb->refcount != 1)
> return dsb;
>
> - dsb->id = DSB1;
> wakeref = intel_runtime_pm_get(&i915->runtime_pm);
>
> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
> @@ -123,22 +123,29 @@ intel_dsb_get(struct intel_crtc *crtc)
> if (IS_ERR(vma)) {
> DRM_ERROR("Vma creation failed\n");
> i915_gem_object_put(obj);
> - dsb->refcount--;
> goto err;
> }
>
> - dsb->cmd_buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
> - if (IS_ERR(dsb->cmd_buf)) {
> + buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
> + if (IS_ERR(buf)) {
> DRM_ERROR("Command buffer creation failed\n");
> - i915_vma_unpin_and_release(&vma, 0);
> - dsb->cmd_buf = NULL;
> - dsb->refcount--;
> goto err;
> }
> +
> + dsb->id = DSB1;
> dsb->vma = vma;
> + dsb->cmd_buf = buf;
>
> err:
> + /*
> + * Set cmd_buf to NULL so the writes pass-through, but leave the
> + * dangling refcount to be removed later by the corresponding
> + * intel_dsb_put(): the important error message will already be
> + * logged above.
> + */
> + dsb->cmd_buf = NULL;
> intel_runtime_pm_put(&i915->runtime_pm, wakeref);
> +
> return dsb;
> }
>
> --
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsb: fix extra warning on error path handling
@ 2019-11-15 20:52 ` Matt Roper
0 siblings, 0 replies; 34+ messages in thread
From: Matt Roper @ 2019-11-15 20:52 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Mon, Nov 11, 2019 at 12:50:25PM -0800, Lucas De Marchi wrote:
> When we call intel_dsb_get(), the dsb initialization may fail for
> various reasons. We already log the error message in that path, making
> it unnecessary to trigger a warning that refcount == 0 when calling
> intel_dsb_put().
>
> So here we simplify the logic and do lazy shutdown: leaving the extra
> refcount alive so when we call intel_dsb_put() we end up calling
> i915_vma_unpin_and_release().
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Due to the lack of any actual concurrency, it seems like we could
eventually get rid of the whole get/put design and just allocate the
buffer once (and pin it during the prepare step). But this seems good
enough for now.
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 4feebbeb0b0c..858af6be9c36 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -102,6 +102,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> struct intel_dsb *dsb = &crtc->dsb;
> struct drm_i915_gem_object *obj;
> struct i915_vma *vma;
> + u32 *buf;
> intel_wakeref_t wakeref;
>
> if (!HAS_DSB(i915))
> @@ -110,7 +111,6 @@ intel_dsb_get(struct intel_crtc *crtc)
> if (++dsb->refcount != 1)
> return dsb;
>
> - dsb->id = DSB1;
> wakeref = intel_runtime_pm_get(&i915->runtime_pm);
>
> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
> @@ -123,22 +123,29 @@ intel_dsb_get(struct intel_crtc *crtc)
> if (IS_ERR(vma)) {
> DRM_ERROR("Vma creation failed\n");
> i915_gem_object_put(obj);
> - dsb->refcount--;
> goto err;
> }
>
> - dsb->cmd_buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
> - if (IS_ERR(dsb->cmd_buf)) {
> + buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
> + if (IS_ERR(buf)) {
> DRM_ERROR("Command buffer creation failed\n");
> - i915_vma_unpin_and_release(&vma, 0);
> - dsb->cmd_buf = NULL;
> - dsb->refcount--;
> goto err;
> }
> +
> + dsb->id = DSB1;
> dsb->vma = vma;
> + dsb->cmd_buf = buf;
>
> err:
> + /*
> + * Set cmd_buf to NULL so the writes pass-through, but leave the
> + * dangling refcount to be removed later by the corresponding
> + * intel_dsb_put(): the important error message will already be
> + * logged above.
> + */
> + dsb->cmd_buf = NULL;
> intel_runtime_pm_put(&i915->runtime_pm, wakeref);
> +
> return dsb;
> }
>
> --
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 1/2] drm/i915/dsb: remove atomic operations
@ 2019-11-15 21:09 ` Ville Syrjälä
0 siblings, 0 replies; 34+ messages in thread
From: Ville Syrjälä @ 2019-11-15 21:09 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx, Lucas De Marchi
On Fri, Nov 15, 2019 at 12:29:38PM -0800, Matt Roper wrote:
> On Mon, Nov 11, 2019 at 12:50:24PM -0800, Lucas De Marchi wrote:
> > The current dsb API is not really prepared to handle multithread access.
> > I was debugging an issue that ended up fixed by commit a096883dda2c
> > ("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
> > puzzled how these atomic operations were guaranteeing atomicity.
> >
> > if (atomic_add_return(1, &dsb->refcount) != 1)
> > return dsb;
> >
> > Thread A could still be initializing dsb struct (and even fail in the
> > middle) while thread B would take a reference and use it (even
> > derefencing a NULL cmd_buf).
> >
> > I don't think the atomic operations here will help much if this were
> > to support multithreaded scenario in future, so just remove them to
> > avoid confusion.
> >
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Agreed; the synchronization here doesn't appear to make sense. But
> also I believe everywhere this would get called is on the atomic commit
> path and we already hold the CRTC lock at that point which will prevent
> concurrent threads calling this. So
Nonblocking commits are unlocked. And I'm thinking we should make
blocking commits unlocked as well. However commits for a specific
crtc are serialized so assuming this dsb stuff is per-crtc we should
probably be fine.
This whole refcount stuff seems a bit overkill tbh. We have a
fixed number of dsbs per pipe and fixed roles we could assign
to them. So I have a feeling all of this should just go away.
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
> > ---
> > drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
> > drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> > index d8ad5fe1efef..4feebbeb0b0c 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> > @@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> > if (!HAS_DSB(i915))
> > return dsb;
> >
> > - if (atomic_add_return(1, &dsb->refcount) != 1)
> > + if (++dsb->refcount != 1)
The usual pattern my brain is accustomed to is
if (ref++ == 0)
enable();
if (--ref == 0)
disabble();
> > return dsb;
> >
> > dsb->id = DSB1;
> > @@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> > if (IS_ERR(vma)) {
> > DRM_ERROR("Vma creation failed\n");
> > i915_gem_object_put(obj);
> > - atomic_dec(&dsb->refcount);
> > + dsb->refcount--;
> > goto err;
> > }
> >
> > @@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> > DRM_ERROR("Command buffer creation failed\n");
> > i915_vma_unpin_and_release(&vma, 0);
> > dsb->cmd_buf = NULL;
> > - atomic_dec(&dsb->refcount);
> > + dsb->refcount--;
> > goto err;
> > }
> > dsb->vma = vma;
> > @@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
> > if (!HAS_DSB(i915))
> > return;
> >
> > - if (WARN_ON(atomic_read(&dsb->refcount) == 0))
> > + if (WARN_ON(dsb->refcount == 0))
> > return;
> >
> > - if (atomic_dec_and_test(&dsb->refcount)) {
> > + if (--dsb->refcount == 0) {
> > i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
> > dsb->cmd_buf = NULL;
> > dsb->free_pos = 0;
> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
> > index 6f95c8e909e6..395ef9ce558e 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dsb.h
> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.h
> > @@ -22,7 +22,7 @@ enum dsb_id {
> > };
> >
> > struct intel_dsb {
> > - atomic_t refcount;
> > + long refcount;
> > enum dsb_id id;
> > u32 *cmd_buf;
> > struct i915_vma *vma;
> > --
> > 2.24.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Matt Roper
> Graphics Software Engineer
> VTT-OSGC Platform Enablement
> Intel Corporation
> (916) 356-2795
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsb: remove atomic operations
@ 2019-11-15 21:09 ` Ville Syrjälä
0 siblings, 0 replies; 34+ messages in thread
From: Ville Syrjälä @ 2019-11-15 21:09 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx, Lucas De Marchi
On Fri, Nov 15, 2019 at 12:29:38PM -0800, Matt Roper wrote:
> On Mon, Nov 11, 2019 at 12:50:24PM -0800, Lucas De Marchi wrote:
> > The current dsb API is not really prepared to handle multithread access.
> > I was debugging an issue that ended up fixed by commit a096883dda2c
> > ("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
> > puzzled how these atomic operations were guaranteeing atomicity.
> >
> > if (atomic_add_return(1, &dsb->refcount) != 1)
> > return dsb;
> >
> > Thread A could still be initializing dsb struct (and even fail in the
> > middle) while thread B would take a reference and use it (even
> > derefencing a NULL cmd_buf).
> >
> > I don't think the atomic operations here will help much if this were
> > to support multithreaded scenario in future, so just remove them to
> > avoid confusion.
> >
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Agreed; the synchronization here doesn't appear to make sense. But
> also I believe everywhere this would get called is on the atomic commit
> path and we already hold the CRTC lock at that point which will prevent
> concurrent threads calling this. So
Nonblocking commits are unlocked. And I'm thinking we should make
blocking commits unlocked as well. However commits for a specific
crtc are serialized so assuming this dsb stuff is per-crtc we should
probably be fine.
This whole refcount stuff seems a bit overkill tbh. We have a
fixed number of dsbs per pipe and fixed roles we could assign
to them. So I have a feeling all of this should just go away.
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
> > ---
> > drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
> > drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> > index d8ad5fe1efef..4feebbeb0b0c 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> > @@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> > if (!HAS_DSB(i915))
> > return dsb;
> >
> > - if (atomic_add_return(1, &dsb->refcount) != 1)
> > + if (++dsb->refcount != 1)
The usual pattern my brain is accustomed to is
if (ref++ == 0)
enable();
if (--ref == 0)
disabble();
> > return dsb;
> >
> > dsb->id = DSB1;
> > @@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> > if (IS_ERR(vma)) {
> > DRM_ERROR("Vma creation failed\n");
> > i915_gem_object_put(obj);
> > - atomic_dec(&dsb->refcount);
> > + dsb->refcount--;
> > goto err;
> > }
> >
> > @@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
> > DRM_ERROR("Command buffer creation failed\n");
> > i915_vma_unpin_and_release(&vma, 0);
> > dsb->cmd_buf = NULL;
> > - atomic_dec(&dsb->refcount);
> > + dsb->refcount--;
> > goto err;
> > }
> > dsb->vma = vma;
> > @@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
> > if (!HAS_DSB(i915))
> > return;
> >
> > - if (WARN_ON(atomic_read(&dsb->refcount) == 0))
> > + if (WARN_ON(dsb->refcount == 0))
> > return;
> >
> > - if (atomic_dec_and_test(&dsb->refcount)) {
> > + if (--dsb->refcount == 0) {
> > i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
> > dsb->cmd_buf = NULL;
> > dsb->free_pos = 0;
> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
> > index 6f95c8e909e6..395ef9ce558e 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dsb.h
> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.h
> > @@ -22,7 +22,7 @@ enum dsb_id {
> > };
> >
> > struct intel_dsb {
> > - atomic_t refcount;
> > + long refcount;
> > enum dsb_id id;
> > u32 *cmd_buf;
> > struct i915_vma *vma;
> > --
> > 2.24.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Matt Roper
> Graphics Software Engineer
> VTT-OSGC Platform Enablement
> Intel Corporation
> (916) 356-2795
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 1/2] drm/i915/dsb: remove atomic operations
@ 2019-11-15 23:01 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-15 23:01 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Fri, Nov 15, 2019 at 11:09:43PM +0200, Ville Syrjälä wrote:
>On Fri, Nov 15, 2019 at 12:29:38PM -0800, Matt Roper wrote:
>> On Mon, Nov 11, 2019 at 12:50:24PM -0800, Lucas De Marchi wrote:
>> > The current dsb API is not really prepared to handle multithread access.
>> > I was debugging an issue that ended up fixed by commit a096883dda2c
>> > ("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
>> > puzzled how these atomic operations were guaranteeing atomicity.
>> >
>> > if (atomic_add_return(1, &dsb->refcount) != 1)
>> > return dsb;
>> >
>> > Thread A could still be initializing dsb struct (and even fail in the
>> > middle) while thread B would take a reference and use it (even
>> > derefencing a NULL cmd_buf).
>> >
>> > I don't think the atomic operations here will help much if this were
>> > to support multithreaded scenario in future, so just remove them to
>> > avoid confusion.
>> >
>> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>
>> Agreed; the synchronization here doesn't appear to make sense. But
>> also I believe everywhere this would get called is on the atomic commit
>> path and we already hold the CRTC lock at that point which will prevent
>> concurrent threads calling this. So
>
>Nonblocking commits are unlocked. And I'm thinking we should make
>blocking commits unlocked as well. However commits for a specific
>crtc are serialized so assuming this dsb stuff is per-crtc we should
>probably be fine.
>
>This whole refcount stuff seems a bit overkill tbh. We have a
I agree
>fixed number of dsbs per pipe and fixed roles we could assign
>to them. So I have a feeling all of this should just go away.
I think this was actually thought to protect reentrance rather than
concurrency, i.e. multiple calls to intel_dsb_get() before the _put().
>
>>
>> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
>> > drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
>> > 2 files changed, 6 insertions(+), 6 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
>> > index d8ad5fe1efef..4feebbeb0b0c 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dsb.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
>> > @@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>> > if (!HAS_DSB(i915))
>> > return dsb;
>> >
>> > - if (atomic_add_return(1, &dsb->refcount) != 1)
>> > + if (++dsb->refcount != 1)
>
>The usual pattern my brain is accustomed to is
>
>if (ref++ == 0)
> enable();
>
>if (--ref == 0)
> disabble();
ok
thanks
Lucas De Marchi
>
>> > return dsb;
>> >
>> > dsb->id = DSB1;
>> > @@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>> > if (IS_ERR(vma)) {
>> > DRM_ERROR("Vma creation failed\n");
>> > i915_gem_object_put(obj);
>> > - atomic_dec(&dsb->refcount);
>> > + dsb->refcount--;
>> > goto err;
>> > }
>> >
>> > @@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>> > DRM_ERROR("Command buffer creation failed\n");
>> > i915_vma_unpin_and_release(&vma, 0);
>> > dsb->cmd_buf = NULL;
>> > - atomic_dec(&dsb->refcount);
>> > + dsb->refcount--;
>> > goto err;
>> > }
>> > dsb->vma = vma;
>> > @@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
>> > if (!HAS_DSB(i915))
>> > return;
>> >
>> > - if (WARN_ON(atomic_read(&dsb->refcount) == 0))
>> > + if (WARN_ON(dsb->refcount == 0))
>> > return;
>> >
>> > - if (atomic_dec_and_test(&dsb->refcount)) {
>> > + if (--dsb->refcount == 0) {
>> > i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
>> > dsb->cmd_buf = NULL;
>> > dsb->free_pos = 0;
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
>> > index 6f95c8e909e6..395ef9ce558e 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dsb.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.h
>> > @@ -22,7 +22,7 @@ enum dsb_id {
>> > };
>> >
>> > struct intel_dsb {
>> > - atomic_t refcount;
>> > + long refcount;
>> > enum dsb_id id;
>> > u32 *cmd_buf;
>> > struct i915_vma *vma;
>> > --
>> > 2.24.0
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>> --
>> Matt Roper
>> Graphics Software Engineer
>> VTT-OSGC Platform Enablement
>> Intel Corporation
>> (916) 356-2795
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Ville Syrjälä
>Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsb: remove atomic operations
@ 2019-11-15 23:01 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-15 23:01 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Fri, Nov 15, 2019 at 11:09:43PM +0200, Ville Syrjälä wrote:
>On Fri, Nov 15, 2019 at 12:29:38PM -0800, Matt Roper wrote:
>> On Mon, Nov 11, 2019 at 12:50:24PM -0800, Lucas De Marchi wrote:
>> > The current dsb API is not really prepared to handle multithread access.
>> > I was debugging an issue that ended up fixed by commit a096883dda2c
>> > ("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
>> > puzzled how these atomic operations were guaranteeing atomicity.
>> >
>> > if (atomic_add_return(1, &dsb->refcount) != 1)
>> > return dsb;
>> >
>> > Thread A could still be initializing dsb struct (and even fail in the
>> > middle) while thread B would take a reference and use it (even
>> > derefencing a NULL cmd_buf).
>> >
>> > I don't think the atomic operations here will help much if this were
>> > to support multithreaded scenario in future, so just remove them to
>> > avoid confusion.
>> >
>> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>
>> Agreed; the synchronization here doesn't appear to make sense. But
>> also I believe everywhere this would get called is on the atomic commit
>> path and we already hold the CRTC lock at that point which will prevent
>> concurrent threads calling this. So
>
>Nonblocking commits are unlocked. And I'm thinking we should make
>blocking commits unlocked as well. However commits for a specific
>crtc are serialized so assuming this dsb stuff is per-crtc we should
>probably be fine.
>
>This whole refcount stuff seems a bit overkill tbh. We have a
I agree
>fixed number of dsbs per pipe and fixed roles we could assign
>to them. So I have a feeling all of this should just go away.
I think this was actually thought to protect reentrance rather than
concurrency, i.e. multiple calls to intel_dsb_get() before the _put().
>
>>
>> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
>> > drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
>> > 2 files changed, 6 insertions(+), 6 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
>> > index d8ad5fe1efef..4feebbeb0b0c 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dsb.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
>> > @@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>> > if (!HAS_DSB(i915))
>> > return dsb;
>> >
>> > - if (atomic_add_return(1, &dsb->refcount) != 1)
>> > + if (++dsb->refcount != 1)
>
>The usual pattern my brain is accustomed to is
>
>if (ref++ == 0)
> enable();
>
>if (--ref == 0)
> disabble();
ok
thanks
Lucas De Marchi
>
>> > return dsb;
>> >
>> > dsb->id = DSB1;
>> > @@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>> > if (IS_ERR(vma)) {
>> > DRM_ERROR("Vma creation failed\n");
>> > i915_gem_object_put(obj);
>> > - atomic_dec(&dsb->refcount);
>> > + dsb->refcount--;
>> > goto err;
>> > }
>> >
>> > @@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>> > DRM_ERROR("Command buffer creation failed\n");
>> > i915_vma_unpin_and_release(&vma, 0);
>> > dsb->cmd_buf = NULL;
>> > - atomic_dec(&dsb->refcount);
>> > + dsb->refcount--;
>> > goto err;
>> > }
>> > dsb->vma = vma;
>> > @@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
>> > if (!HAS_DSB(i915))
>> > return;
>> >
>> > - if (WARN_ON(atomic_read(&dsb->refcount) == 0))
>> > + if (WARN_ON(dsb->refcount == 0))
>> > return;
>> >
>> > - if (atomic_dec_and_test(&dsb->refcount)) {
>> > + if (--dsb->refcount == 0) {
>> > i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
>> > dsb->cmd_buf = NULL;
>> > dsb->free_pos = 0;
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
>> > index 6f95c8e909e6..395ef9ce558e 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dsb.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.h
>> > @@ -22,7 +22,7 @@ enum dsb_id {
>> > };
>> >
>> > struct intel_dsb {
>> > - atomic_t refcount;
>> > + long refcount;
>> > enum dsb_id id;
>> > u32 *cmd_buf;
>> > struct i915_vma *vma;
>> > --
>> > 2.24.0
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>> --
>> Matt Roper
>> Graphics Software Engineer
>> VTT-OSGC Platform Enablement
>> Intel Corporation
>> (916) 356-2795
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Ville Syrjälä
>Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 2/2] drm/i915/dsb: fix extra warning on error path handling
@ 2019-11-15 23:04 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-15 23:04 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Nov 15, 2019 at 12:52:49PM -0800, Matt Roper wrote:
>On Mon, Nov 11, 2019 at 12:50:25PM -0800, Lucas De Marchi wrote:
>> When we call intel_dsb_get(), the dsb initialization may fail for
>> various reasons. We already log the error message in that path, making
>> it unnecessary to trigger a warning that refcount == 0 when calling
>> intel_dsb_put().
>>
>> So here we simplify the logic and do lazy shutdown: leaving the extra
>> refcount alive so when we call intel_dsb_put() we end up calling
>> i915_vma_unpin_and_release().
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>Due to the lack of any actual concurrency, it seems like we could
>eventually get rid of the whole get/put design and just allocate the
>buffer once (and pin it during the prepare step). But this seems good
I assumed this was designed to accept the pattern
intel_dsb_get();
intel_dsb_get();
intel_dsb_put();
intel_dsb_put();
>enough for now.
>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
thanks
Lucas De Marchi
>
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dsb.c | 21 ++++++++++++++-------
>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
>> index 4feebbeb0b0c..858af6be9c36 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
>> @@ -102,6 +102,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>> struct intel_dsb *dsb = &crtc->dsb;
>> struct drm_i915_gem_object *obj;
>> struct i915_vma *vma;
>> + u32 *buf;
>> intel_wakeref_t wakeref;
>>
>> if (!HAS_DSB(i915))
>> @@ -110,7 +111,6 @@ intel_dsb_get(struct intel_crtc *crtc)
>> if (++dsb->refcount != 1)
>> return dsb;
>>
>> - dsb->id = DSB1;
>> wakeref = intel_runtime_pm_get(&i915->runtime_pm);
>>
>> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
>> @@ -123,22 +123,29 @@ intel_dsb_get(struct intel_crtc *crtc)
>> if (IS_ERR(vma)) {
>> DRM_ERROR("Vma creation failed\n");
>> i915_gem_object_put(obj);
>> - dsb->refcount--;
>> goto err;
>> }
>>
>> - dsb->cmd_buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
>> - if (IS_ERR(dsb->cmd_buf)) {
>> + buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
>> + if (IS_ERR(buf)) {
>> DRM_ERROR("Command buffer creation failed\n");
>> - i915_vma_unpin_and_release(&vma, 0);
>> - dsb->cmd_buf = NULL;
>> - dsb->refcount--;
>> goto err;
>> }
>> +
>> + dsb->id = DSB1;
>> dsb->vma = vma;
>> + dsb->cmd_buf = buf;
>>
>> err:
>> + /*
>> + * Set cmd_buf to NULL so the writes pass-through, but leave the
>> + * dangling refcount to be removed later by the corresponding
>> + * intel_dsb_put(): the important error message will already be
>> + * logged above.
>> + */
>> + dsb->cmd_buf = NULL;
>> intel_runtime_pm_put(&i915->runtime_pm, wakeref);
>> +
>> return dsb;
>> }
>>
>> --
>> 2.24.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsb: fix extra warning on error path handling
@ 2019-11-15 23:04 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-15 23:04 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Nov 15, 2019 at 12:52:49PM -0800, Matt Roper wrote:
>On Mon, Nov 11, 2019 at 12:50:25PM -0800, Lucas De Marchi wrote:
>> When we call intel_dsb_get(), the dsb initialization may fail for
>> various reasons. We already log the error message in that path, making
>> it unnecessary to trigger a warning that refcount == 0 when calling
>> intel_dsb_put().
>>
>> So here we simplify the logic and do lazy shutdown: leaving the extra
>> refcount alive so when we call intel_dsb_put() we end up calling
>> i915_vma_unpin_and_release().
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>Due to the lack of any actual concurrency, it seems like we could
>eventually get rid of the whole get/put design and just allocate the
>buffer once (and pin it during the prepare step). But this seems good
I assumed this was designed to accept the pattern
intel_dsb_get();
intel_dsb_get();
intel_dsb_put();
intel_dsb_put();
>enough for now.
>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
thanks
Lucas De Marchi
>
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dsb.c | 21 ++++++++++++++-------
>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
>> index 4feebbeb0b0c..858af6be9c36 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
>> @@ -102,6 +102,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>> struct intel_dsb *dsb = &crtc->dsb;
>> struct drm_i915_gem_object *obj;
>> struct i915_vma *vma;
>> + u32 *buf;
>> intel_wakeref_t wakeref;
>>
>> if (!HAS_DSB(i915))
>> @@ -110,7 +111,6 @@ intel_dsb_get(struct intel_crtc *crtc)
>> if (++dsb->refcount != 1)
>> return dsb;
>>
>> - dsb->id = DSB1;
>> wakeref = intel_runtime_pm_get(&i915->runtime_pm);
>>
>> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
>> @@ -123,22 +123,29 @@ intel_dsb_get(struct intel_crtc *crtc)
>> if (IS_ERR(vma)) {
>> DRM_ERROR("Vma creation failed\n");
>> i915_gem_object_put(obj);
>> - dsb->refcount--;
>> goto err;
>> }
>>
>> - dsb->cmd_buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
>> - if (IS_ERR(dsb->cmd_buf)) {
>> + buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
>> + if (IS_ERR(buf)) {
>> DRM_ERROR("Command buffer creation failed\n");
>> - i915_vma_unpin_and_release(&vma, 0);
>> - dsb->cmd_buf = NULL;
>> - dsb->refcount--;
>> goto err;
>> }
>> +
>> + dsb->id = DSB1;
>> dsb->vma = vma;
>> + dsb->cmd_buf = buf;
>>
>> err:
>> + /*
>> + * Set cmd_buf to NULL so the writes pass-through, but leave the
>> + * dangling refcount to be removed later by the corresponding
>> + * intel_dsb_put(): the important error message will already be
>> + * logged above.
>> + */
>> + dsb->cmd_buf = NULL;
>> intel_runtime_pm_put(&i915->runtime_pm, wakeref);
>> +
>> return dsb;
>> }
>>
>> --
>> 2.24.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v2] drm/i915/dsb: remove atomic operations
@ 2019-11-16 1:15 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-16 1:15 UTC (permalink / raw)
To: intel-gfx
The current dsb API is not really prepared to handle multithread access.
I was debugging an issue that ended up fixed by commit a096883dda2c
("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
puzzled how these atomic operations were guaranteeing atomicity.
if (atomic_add_return(1, &dsb->refcount) != 1)
return dsb;
Thread A could still be initializing dsb struct (and even fail in the
middle) while thread B would take a reference and use it (even
derefencing a NULL cmd_buf).
I don't think the atomic operations here will help much if this were
to support multithreaded scenario in future, so just remove them to
avoid confusion.
v2: Use refcount++ != 0 instead of ++refcount != 1 (from Ville)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191111205024.22853-2-lucas.demarchi@intel.com
---
drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index d8ad5fe1efef..50c4d98c0020 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
if (!HAS_DSB(i915))
return dsb;
- if (atomic_add_return(1, &dsb->refcount) != 1)
+ if (dsb->refcount++ != 0)
return dsb;
dsb->id = DSB1;
@@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
if (IS_ERR(vma)) {
DRM_ERROR("Vma creation failed\n");
i915_gem_object_put(obj);
- atomic_dec(&dsb->refcount);
+ dsb->refcount--;
goto err;
}
@@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
DRM_ERROR("Command buffer creation failed\n");
i915_vma_unpin_and_release(&vma, 0);
dsb->cmd_buf = NULL;
- atomic_dec(&dsb->refcount);
+ dsb->refcount--;
goto err;
}
dsb->vma = vma;
@@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
if (!HAS_DSB(i915))
return;
- if (WARN_ON(atomic_read(&dsb->refcount) == 0))
+ if (WARN_ON(dsb->refcount == 0))
return;
- if (atomic_dec_and_test(&dsb->refcount)) {
+ if (--dsb->refcount == 0) {
i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
dsb->cmd_buf = NULL;
dsb->free_pos = 0;
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
index 6f95c8e909e6..395ef9ce558e 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.h
+++ b/drivers/gpu/drm/i915/display/intel_dsb.h
@@ -22,7 +22,7 @@ enum dsb_id {
};
struct intel_dsb {
- atomic_t refcount;
+ long refcount;
enum dsb_id id;
u32 *cmd_buf;
struct i915_vma *vma;
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/dsb: remove atomic operations
@ 2019-11-16 1:15 ` Lucas De Marchi
0 siblings, 0 replies; 34+ messages in thread
From: Lucas De Marchi @ 2019-11-16 1:15 UTC (permalink / raw)
To: intel-gfx
The current dsb API is not really prepared to handle multithread access.
I was debugging an issue that ended up fixed by commit a096883dda2c
("drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA") and was
puzzled how these atomic operations were guaranteeing atomicity.
if (atomic_add_return(1, &dsb->refcount) != 1)
return dsb;
Thread A could still be initializing dsb struct (and even fail in the
middle) while thread B would take a reference and use it (even
derefencing a NULL cmd_buf).
I don't think the atomic operations here will help much if this were
to support multithreaded scenario in future, so just remove them to
avoid confusion.
v2: Use refcount++ != 0 instead of ++refcount != 1 (from Ville)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191111205024.22853-2-lucas.demarchi@intel.com
---
drivers/gpu/drm/i915/display/intel_dsb.c | 10 +++++-----
drivers/gpu/drm/i915/display/intel_dsb.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index d8ad5fe1efef..50c4d98c0020 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -107,7 +107,7 @@ intel_dsb_get(struct intel_crtc *crtc)
if (!HAS_DSB(i915))
return dsb;
- if (atomic_add_return(1, &dsb->refcount) != 1)
+ if (dsb->refcount++ != 0)
return dsb;
dsb->id = DSB1;
@@ -123,7 +123,7 @@ intel_dsb_get(struct intel_crtc *crtc)
if (IS_ERR(vma)) {
DRM_ERROR("Vma creation failed\n");
i915_gem_object_put(obj);
- atomic_dec(&dsb->refcount);
+ dsb->refcount--;
goto err;
}
@@ -132,7 +132,7 @@ intel_dsb_get(struct intel_crtc *crtc)
DRM_ERROR("Command buffer creation failed\n");
i915_vma_unpin_and_release(&vma, 0);
dsb->cmd_buf = NULL;
- atomic_dec(&dsb->refcount);
+ dsb->refcount--;
goto err;
}
dsb->vma = vma;
@@ -158,10 +158,10 @@ void intel_dsb_put(struct intel_dsb *dsb)
if (!HAS_DSB(i915))
return;
- if (WARN_ON(atomic_read(&dsb->refcount) == 0))
+ if (WARN_ON(dsb->refcount == 0))
return;
- if (atomic_dec_and_test(&dsb->refcount)) {
+ if (--dsb->refcount == 0) {
i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
dsb->cmd_buf = NULL;
dsb->free_pos = 0;
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
index 6f95c8e909e6..395ef9ce558e 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.h
+++ b/drivers/gpu/drm/i915/display/intel_dsb.h
@@ -22,7 +22,7 @@ enum dsb_id {
};
struct intel_dsb {
- atomic_t refcount;
+ long refcount;
enum dsb_id id;
u32 *cmd_buf;
struct i915_vma *vma;
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 34+ messages in thread
* ✓ Fi.CI.BAT: success for Improve error handling on DSB (rev3)
@ 2019-11-16 2:40 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-16 2:40 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev3)
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7357 -> Patchwork_15303
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/index.html
Known issues
------------
Here are the changes found in Patchwork_15303 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][1] -> [FAIL][2] ([fdo#108511])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][3] -> [DMESG-WARN][4] ([fdo#105541])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-skl-6770hq: [PASS][5] -> [WARN][6] ([fdo#112252])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][7] ([fdo#112261]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][9] ([fdo#109635 ]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][11] ([fdo#102614]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#112252]: https://bugs.freedesktop.org/show_bug.cgi?id=112252
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (51 -> 42)
------------------------------
Missing (9): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-bsw-cyan fi-kbl-7500u fi-ctg-p8600 fi-ivb-3770 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7357 -> Patchwork_15303
CI-20190529: 20190529
CI_DRM_7357: 315d68345bfe8da7b034123352106c6edbcc380d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5288: ff4551e36cd8e573ceb1e450d17a12e3298dc04c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15303: 237c46d0cde2e58051bf8b633ff2a0db4bff7c71 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
237c46d0cde2 drm/i915/dsb: fix extra warning on error path handling
3b675d5939d9 drm/i915/dsb: remove atomic operations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Improve error handling on DSB (rev3)
@ 2019-11-16 2:40 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-16 2:40 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev3)
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7357 -> Patchwork_15303
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/index.html
Known issues
------------
Here are the changes found in Patchwork_15303 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][1] -> [FAIL][2] ([fdo#108511])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][3] -> [DMESG-WARN][4] ([fdo#105541])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-skl-6770hq: [PASS][5] -> [WARN][6] ([fdo#112252])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][7] ([fdo#112261]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][9] ([fdo#109635 ]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][11] ([fdo#102614]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7357/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#112252]: https://bugs.freedesktop.org/show_bug.cgi?id=112252
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (51 -> 42)
------------------------------
Missing (9): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-bsw-cyan fi-kbl-7500u fi-ctg-p8600 fi-ivb-3770 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7357 -> Patchwork_15303
CI-20190529: 20190529
CI_DRM_7357: 315d68345bfe8da7b034123352106c6edbcc380d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5288: ff4551e36cd8e573ceb1e450d17a12e3298dc04c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15303: 237c46d0cde2e58051bf8b633ff2a0db4bff7c71 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
237c46d0cde2 drm/i915/dsb: fix extra warning on error path handling
3b675d5939d9 drm/i915/dsb: remove atomic operations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15303/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* ✗ Fi.CI.IGT: failure for Improve error handling on DSB (rev2)
@ 2019-11-16 11:05 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-16 11:05 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev2)
URL : https://patchwork.freedesktop.org/series/69319/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7348_full -> Patchwork_15272_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15272_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15272_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15272_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-apl: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-apl4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_exec_parse_blt@batch-without-end}:
- shard-tglb: NOTRUN -> [SKIP][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb1/igt@gem_exec_parse_blt@batch-without-end.html
- shard-iclb: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb5/igt@gem_exec_parse_blt@batch-without-end.html
* {igt@gem_exec_reloc@basic-spin-blt}:
- shard-glk: NOTRUN -> [TIMEOUT][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-glk4/igt@gem_exec_reloc@basic-spin-blt.html
Known issues
------------
Here are the changes found in Patchwork_15272_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276] / [fdo#112080]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb7/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_switch@all-light:
- shard-tglb: [PASS][8] -> [INCOMPLETE][9] ([fdo#111672])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@gem_ctx_switch@all-light.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb6/igt@gem_ctx_switch@all-light.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#112080]) +7 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#112146]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][14] -> [SKIP][15] ([fdo#109276]) +15 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb5/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [PASS][16] -> [FAIL][17] ([fdo#112037]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-snb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][18] -> [DMESG-WARN][19] ([fdo#108566])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-apl8/igt@gem_softpin@noreloc-s3.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-apl1/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][20] -> [DMESG-WARN][21] ([fdo#111870]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [PASS][22] -> [DMESG-WARN][23] ([fdo#111870])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [PASS][24] -> [DMESG-WARN][25] ([fdo#110789] / [fdo#111870])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_selftest@live_hangcheck:
- shard-iclb: [PASS][26] -> [DMESG-FAIL][27] ([fdo#111144] / [fdo#111678])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@i915_selftest@live_hangcheck.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb6/igt@i915_selftest@live_hangcheck.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][28] -> [INCOMPLETE][29] ([fdo#103665])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-tglb: [PASS][30] -> [INCOMPLETE][31] ([fdo#111832] / [fdo#111850]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb9/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][32] -> [FAIL][33] ([fdo#105363])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip_tiling@flip-changes-tiling:
- shard-skl: [PASS][34] -> [FAIL][35] ([fdo#108303])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl3/igt@kms_flip_tiling@flip-changes-tiling.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-skl4/igt@kms_flip_tiling@flip-changes-tiling.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [PASS][36] -> [FAIL][37] ([fdo#103167]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
- shard-tglb: [PASS][38] -> [FAIL][39] ([fdo#103167]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][40] -> [DMESG-WARN][41] ([fdo#108566]) +6 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-tglb: [PASS][42] -> [INCOMPLETE][43] ([fdo#111850])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][44] -> [FAIL][45] ([fdo#108145] / [fdo#110403])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][46] -> [FAIL][47] ([fdo#103166])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][48] -> [SKIP][49] ([fdo#109441])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][50] ([fdo#112080]) -> [PASS][51] +13 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb6/igt@gem_busy@busy-vcs1.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [SKIP][52] ([fdo#109276] / [fdo#112080]) -> [PASS][53] +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@gem_ctx_isolation@vcs1-dirty-create.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_ctx_isolation@vcs1-s3:
- shard-tglb: [INCOMPLETE][54] ([fdo#111832]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb4/igt@gem_ctx_isolation@vcs1-s3.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb1/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_eio@in-flight-suspend:
- shard-tglb: [INCOMPLETE][56] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb3/igt@gem_eio@in-flight-suspend.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb6/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_parallel@fds:
- shard-tglb: [INCOMPLETE][58] ([fdo#111867]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_parallel@fds.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb8/igt@gem_exec_parallel@fds.html
* igt@gem_exec_reuse@single:
- shard-tglb: [INCOMPLETE][60] ([fdo#111747]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb4/igt@gem_exec_reuse@single.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb3/igt@gem_exec_reuse@single.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][62] ([fdo#112146]) -> [PASS][63] +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-blt:
- shard-tglb: [INCOMPLETE][64] ([fdo#111677]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_schedule@preempt-queue-blt.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb4/igt@gem_exec_schedule@preempt-queue-blt.html
* igt@gem_exec_schedule@preempt-queue-chain-render:
- shard-tglb: [INCOMPLETE][66] ([fdo#111606] / [fdo#111677]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-render.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb7/igt@gem_exec_schedule@preempt-queue-chain-render.html
* igt@gem_sync@basic-store-all:
- shard-tglb: [INCOMPLETE][68] ([fdo#111647]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_sync@basic-store-all.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb7/igt@gem_sync@basic-store-all.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [DMESG-WARN][70] ([fdo#110789] / [fdo#111870]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [DMESG-WARN][72] ([fdo#111870]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][74] ([fdo#111830 ]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb6/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-kbl: [INCOMPLETE][76] ([fdo#103665] / [fdo#107807]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl2/igt@i915_pm_rpm@system-suspend-execbuf.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-kbl1/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [DMESG-WARN][78] ([fdo#108566]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl3/igt@i915_suspend@debugfs-reader.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-kbl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][80] ([fdo#105363]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][82] ([fdo#103540]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-tglb: [FAIL][84] ([fdo#103167]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: [FAIL][86] ([fdo#103167]) -> [PASS][87] +4 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][88] ([fdo#108341]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@kms_psr@no_drrs.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb4/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][90] ([fdo#109441]) -> [PASS][91] +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-tglb: [INCOMPLETE][92] ([fdo#111832] / [fdo#111850]) -> [PASS][93] +4 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][94] ([fdo#111850]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb7/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][96] ([fdo#109276]) -> [PASS][97] +17 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@prime_busy@hang-bsd2.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@prime_busy@hang-bsd2.html
* igt@prime_vgem@sync-render:
- shard-tglb: [INCOMPLETE][98] ([fdo#111612]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb5/igt@prime_vgem@sync-render.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb4/igt@prime_vgem@sync-render.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs2-s3:
- shard-tglb: [SKIP][100] ([fdo#112080]) -> [SKIP][101] ([fdo#111912] / [fdo#112080])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb9/igt@gem_ctx_isolation@vcs2-s3.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb8/igt@gem_ctx_isolation@vcs2-s3.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [DMESG-WARN][102] ([fdo#107724]) -> [SKIP][103] ([fdo#109441])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@kms_psr@psr2_suspend.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb4/igt@kms_psr@p
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Improve error handling on DSB (rev2)
@ 2019-11-16 11:05 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-16 11:05 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev2)
URL : https://patchwork.freedesktop.org/series/69319/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7348_full -> Patchwork_15272_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15272_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15272_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15272_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-apl: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-apl4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_exec_parse_blt@batch-without-end}:
- shard-tglb: NOTRUN -> [SKIP][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb1/igt@gem_exec_parse_blt@batch-without-end.html
- shard-iclb: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb5/igt@gem_exec_parse_blt@batch-without-end.html
* {igt@gem_exec_reloc@basic-spin-blt}:
- shard-glk: NOTRUN -> [TIMEOUT][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-glk4/igt@gem_exec_reloc@basic-spin-blt.html
Known issues
------------
Here are the changes found in Patchwork_15272_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276] / [fdo#112080]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb7/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_switch@all-light:
- shard-tglb: [PASS][8] -> [INCOMPLETE][9] ([fdo#111672])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@gem_ctx_switch@all-light.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb6/igt@gem_ctx_switch@all-light.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#112080]) +7 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#112146]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][14] -> [SKIP][15] ([fdo#109276]) +15 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb5/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [PASS][16] -> [FAIL][17] ([fdo#112037]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-snb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][18] -> [DMESG-WARN][19] ([fdo#108566])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-apl8/igt@gem_softpin@noreloc-s3.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-apl1/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][20] -> [DMESG-WARN][21] ([fdo#111870]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [PASS][22] -> [DMESG-WARN][23] ([fdo#111870])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [PASS][24] -> [DMESG-WARN][25] ([fdo#110789] / [fdo#111870])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_selftest@live_hangcheck:
- shard-iclb: [PASS][26] -> [DMESG-FAIL][27] ([fdo#111144] / [fdo#111678])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@i915_selftest@live_hangcheck.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb6/igt@i915_selftest@live_hangcheck.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][28] -> [INCOMPLETE][29] ([fdo#103665])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-tglb: [PASS][30] -> [INCOMPLETE][31] ([fdo#111832] / [fdo#111850]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb9/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][32] -> [FAIL][33] ([fdo#105363])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip_tiling@flip-changes-tiling:
- shard-skl: [PASS][34] -> [FAIL][35] ([fdo#108303])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl3/igt@kms_flip_tiling@flip-changes-tiling.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-skl4/igt@kms_flip_tiling@flip-changes-tiling.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [PASS][36] -> [FAIL][37] ([fdo#103167]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
- shard-tglb: [PASS][38] -> [FAIL][39] ([fdo#103167]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][40] -> [DMESG-WARN][41] ([fdo#108566]) +6 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-tglb: [PASS][42] -> [INCOMPLETE][43] ([fdo#111850])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][44] -> [FAIL][45] ([fdo#108145] / [fdo#110403])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][46] -> [FAIL][47] ([fdo#103166])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][48] -> [SKIP][49] ([fdo#109441])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][50] ([fdo#112080]) -> [PASS][51] +13 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb6/igt@gem_busy@busy-vcs1.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [SKIP][52] ([fdo#109276] / [fdo#112080]) -> [PASS][53] +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@gem_ctx_isolation@vcs1-dirty-create.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_ctx_isolation@vcs1-s3:
- shard-tglb: [INCOMPLETE][54] ([fdo#111832]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb4/igt@gem_ctx_isolation@vcs1-s3.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb1/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_eio@in-flight-suspend:
- shard-tglb: [INCOMPLETE][56] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb3/igt@gem_eio@in-flight-suspend.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb6/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_parallel@fds:
- shard-tglb: [INCOMPLETE][58] ([fdo#111867]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_parallel@fds.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb8/igt@gem_exec_parallel@fds.html
* igt@gem_exec_reuse@single:
- shard-tglb: [INCOMPLETE][60] ([fdo#111747]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb4/igt@gem_exec_reuse@single.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb3/igt@gem_exec_reuse@single.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][62] ([fdo#112146]) -> [PASS][63] +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-blt:
- shard-tglb: [INCOMPLETE][64] ([fdo#111677]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_schedule@preempt-queue-blt.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb4/igt@gem_exec_schedule@preempt-queue-blt.html
* igt@gem_exec_schedule@preempt-queue-chain-render:
- shard-tglb: [INCOMPLETE][66] ([fdo#111606] / [fdo#111677]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-render.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb7/igt@gem_exec_schedule@preempt-queue-chain-render.html
* igt@gem_sync@basic-store-all:
- shard-tglb: [INCOMPLETE][68] ([fdo#111647]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb6/igt@gem_sync@basic-store-all.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb7/igt@gem_sync@basic-store-all.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [DMESG-WARN][70] ([fdo#110789] / [fdo#111870]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [DMESG-WARN][72] ([fdo#111870]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][74] ([fdo#111830 ]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb6/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-kbl: [INCOMPLETE][76] ([fdo#103665] / [fdo#107807]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl2/igt@i915_pm_rpm@system-suspend-execbuf.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-kbl1/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [DMESG-WARN][78] ([fdo#108566]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-kbl3/igt@i915_suspend@debugfs-reader.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-kbl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][80] ([fdo#105363]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][82] ([fdo#103540]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-tglb: [FAIL][84] ([fdo#103167]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: [FAIL][86] ([fdo#103167]) -> [PASS][87] +4 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][88] ([fdo#108341]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb1/igt@kms_psr@no_drrs.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb4/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][90] ([fdo#109441]) -> [PASS][91] +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-tglb: [INCOMPLETE][92] ([fdo#111832] / [fdo#111850]) -> [PASS][93] +4 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][94] ([fdo#111850]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb1/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb7/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][96] ([fdo#109276]) -> [PASS][97] +17 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb3/igt@prime_busy@hang-bsd2.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb1/igt@prime_busy@hang-bsd2.html
* igt@prime_vgem@sync-render:
- shard-tglb: [INCOMPLETE][98] ([fdo#111612]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb5/igt@prime_vgem@sync-render.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb4/igt@prime_vgem@sync-render.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs2-s3:
- shard-tglb: [SKIP][100] ([fdo#112080]) -> [SKIP][101] ([fdo#111912] / [fdo#112080])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-tglb9/igt@gem_ctx_isolation@vcs2-s3.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-tglb8/igt@gem_ctx_isolation@vcs2-s3.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [DMESG-WARN][102] ([fdo#107724]) -> [SKIP][103] ([fdo#109441])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7348/shard-iclb2/igt@kms_psr@psr2_suspend.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/shard-iclb4/igt@kms_psr@p
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15272/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* ✓ Fi.CI.BAT: success for Improve error handling on DSB (rev4)
@ 2019-11-16 16:47 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-16 16:47 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev4)
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7358 -> Patchwork_15304
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/index.html
Known issues
------------
Here are the changes found in Patchwork_15304 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-icl-guc: [PASS][1] -> [DMESG-WARN][2] ([fdo#106107])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-icl-guc/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-icl-guc/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][3] -> [DMESG-WARN][4] ([fdo#105541])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
#### Possible fixes ####
* igt@i915_module_load@reload-with-fault-injection:
- {fi-kbl-7560u}: [INCOMPLETE][5] ([fdo#109964] / [fdo#112298]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [DMESG-WARN][7] ([fdo#112261]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-skl-6770hq: [FAIL][9] ([fdo#109495]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#109495]: https://bugs.freedesktop.org/show_bug.cgi?id=109495
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (50 -> 45)
------------------------------
Additional (2): fi-kbl-7500u fi-bsw-n3050
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7358 -> Patchwork_15304
CI-20190529: 20190529
CI_DRM_7358: 3ff71899c56c5ebe182c84edf0567280863e553e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5290: 14d19371610fabafa0ee5a21160373b90ada0a30 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15304: 3a0a02ec64bc8dc23d7eab362abf498ef444d9ab @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3a0a02ec64bc drm/i915/dsb: fix extra warning on error path handling
f47cb187bbfc drm/i915/dsb: remove atomic operations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Improve error handling on DSB (rev4)
@ 2019-11-16 16:47 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-16 16:47 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev4)
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7358 -> Patchwork_15304
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/index.html
Known issues
------------
Here are the changes found in Patchwork_15304 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-icl-guc: [PASS][1] -> [DMESG-WARN][2] ([fdo#106107])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-icl-guc/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-icl-guc/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][3] -> [DMESG-WARN][4] ([fdo#105541])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
#### Possible fixes ####
* igt@i915_module_load@reload-with-fault-injection:
- {fi-kbl-7560u}: [INCOMPLETE][5] ([fdo#109964] / [fdo#112298]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [DMESG-WARN][7] ([fdo#112261]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-skl-6770hq: [FAIL][9] ([fdo#109495]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/fi-skl-6770hq/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#109495]: https://bugs.freedesktop.org/show_bug.cgi?id=109495
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (50 -> 45)
------------------------------
Additional (2): fi-kbl-7500u fi-bsw-n3050
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7358 -> Patchwork_15304
CI-20190529: 20190529
CI_DRM_7358: 3ff71899c56c5ebe182c84edf0567280863e553e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5290: 14d19371610fabafa0ee5a21160373b90ada0a30 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15304: 3a0a02ec64bc8dc23d7eab362abf498ef444d9ab @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3a0a02ec64bc drm/i915/dsb: fix extra warning on error path handling
f47cb187bbfc drm/i915/dsb: remove atomic operations
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* ✓ Fi.CI.IGT: success for Improve error handling on DSB (rev4)
@ 2019-11-17 22:59 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-17 22:59 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev4)
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7358_full -> Patchwork_15304_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_15304_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15304_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15304_full:
### IGT changes ###
#### Warnings ####
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
- shard-apl: [TIMEOUT][1] ([fdo#112113]) -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
Known issues
------------
Here are the changes found in Patchwork_15304_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-kbl1/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [fdo#112080]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb2/igt@gem_ctx_isolation@vcs1-clean.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb7/igt@gem_ctx_isolation@vcs1-clean.html
* igt@gem_ctx_isolation@vecs0-s3:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([fdo#111832])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb5/igt@gem_ctx_isolation@vecs0-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb4/igt@gem_ctx_isolation@vecs0-s3.html
- shard-skl: [PASS][9] -> [INCOMPLETE][10] ([fdo#104108]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl5/igt@gem_ctx_isolation@vecs0-s3.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl4/igt@gem_ctx_isolation@vecs0-s3.html
* igt@gem_ctx_switch@vcs1-heavy:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112080]) +11 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb3/igt@gem_ctx_switch@vcs1-heavy.html
* igt@gem_eio@suspend:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111850])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb6/igt@gem_eio@suspend.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb5/igt@gem_eio@suspend.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#112146]) +6 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111736] / [fdo#111850])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb6/igt@gem_exec_suspend@basic-s3.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_pipe_control_store_loop@reused-buffer:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#111998])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb1/igt@gem_pipe_control_store_loop@reused-buffer.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb6/igt@gem_pipe_control_store_loop@reused-buffer.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][21] -> [DMESG-WARN][22] ([fdo#111870])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-snb4/igt@gem_userptr_blits@sync-unmap.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-snb1/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_selftest@mock_requests:
- shard-skl: [PASS][23] -> [DMESG-WARN][24] ([fdo#111086])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl7/igt@i915_selftest@mock_requests.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl10/igt@i915_selftest@mock_requests.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [PASS][25] -> [INCOMPLETE][26] ([fdo#111832] / [fdo#111850]) +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb4/igt@i915_suspend@sysfs-reader.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb5/igt@i915_suspend@sysfs-reader.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-tglb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +5 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-apl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109276]) +17 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb5/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_persistence@vcs1-hostile-preempt:
- shard-iclb: [SKIP][39] ([fdo#109276] / [fdo#112080]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb2/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
* igt@gem_exec_parallel@fds:
- shard-tglb: [INCOMPLETE][41] ([fdo#111867]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb6/igt@gem_exec_parallel@fds.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb8/igt@gem_exec_parallel@fds.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][43] ([fdo#112146]) -> [PASS][44] +5 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd2:
- shard-iclb: [SKIP][45] ([fdo#109276]) -> [PASS][46] +18 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd2.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd2.html
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-apl: [TIMEOUT][47] ([fdo#112113]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-apl2/igt@gem_persistent_relocs@forked-thrash-inactive.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-apl2/igt@gem_persistent_relocs@forked-thrash-inactive.html
* igt@gem_sync@basic-store-each:
- shard-tglb: [INCOMPLETE][49] ([fdo#111647] / [fdo#111747]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb4/igt@gem_sync@basic-store-each.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb7/igt@gem_sync@basic-store-each.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-snb7/igt@gem_userptr_blits@sync-unmap-after-close.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-snb1/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][53] ([fdo#111830 ]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-tglb: [INCOMPLETE][55] ([fdo#111832] / [fdo#111850]) -> [PASS][56] +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb7/igt@i915_suspend@fence-restore-tiled2untiled.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb2/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][57] ([fdo#108566]) -> [PASS][58] +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][59] ([fdo#105363]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][61] ([fdo#108566]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][63] ([fdo#103167]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-tglb: [FAIL][65] ([fdo#103167]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-tglb: [INCOMPLETE][67] ([fdo#111850]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][69] ([fdo#108145] / [fdo#110403]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping:
- shard-iclb: [INCOMPLETE][71] ([fdo#107713] / [fdo#110041]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb7/igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb6/igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][73] ([fdo#109642] / [fdo#111068]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@kms_psr2_su@page_flip.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_setmode@basic:
- shard-hsw: [FAIL][77] ([fdo#99912]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-hsw1/igt@kms_setmode@basic.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-hsw1/igt@kms_setmode@basic.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [TIMEOUT][79] ([fdo#111732 ]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl6/igt@perf@gen8-unprivileged-single-ctx-counters.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl2/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@perf_pmu@init-busy-vcs1:
- shard-iclb: [SKIP][81] ([fdo#112080]) -> [PASS][82] +12 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb5/igt@perf_pmu@init-busy-vcs1.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb1/igt@perf_pmu@init-busy-vcs1.html
* igt@syncobj_basic@create-signaled:
- shard-hsw: [INCOMPLETE][83] ([fdo#103540]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-hsw6/igt@syncobj_basic@create-signaled.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-hsw6/igt@syncobj_basic@create-signaled.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][85] ([fdo#109276] / [fdo#112080]) -> [FAIL][86] ([fdo#111329])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [FAIL][87] ([fdo#111329]) -> [SKIP][88] ([fdo#109276] / [fdo#112080])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_ctx_isolation@vcs2-clean:
- shard-tglb: [SKIP][89] ([fdo#112080]) -> [SKIP][90] ([fdo#111912] / [fdo#112080])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb9/igt@gem_ctx_isolation@vcs2-clean.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb2/igt@gem_ctx_isolation@vcs2-clean.html
* igt@gem_exec_schedule@deep-blt:
- shard-tglb: [FAIL][91] ([fdo#111646]) -> [INCOMPLETE][92] ([fdo#111671])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb7/igt@gem_exec_schedule@deep-blt.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb8/igt@gem_exec_schedule@deep-blt.html
* igt@gem_exec_schedule@deep-bsd2:
- shard-tglb: [INCOMPLETE][93] ([fdo#111671]) -> [FAIL][94] ([fdo#111646])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb3/igt@gem_exec_schedule@deep-bsd2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb9/igt@gem_exec_schedule@deep-bsd2.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][95] ([fdo#107724]) -> [SKIP][96] ([fdo#109349])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110041]: https://bugs.freedesktop.org/show_bug.cgi?id=110041
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111086]: https://bugs.freedesktop.org/show_bug.cgi?id=111086
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111647]: https://bugs.freedesktop.org/show_bug.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Improve error handling on DSB (rev4)
@ 2019-11-17 22:59 ` Patchwork
0 siblings, 0 replies; 34+ messages in thread
From: Patchwork @ 2019-11-17 22:59 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Improve error handling on DSB (rev4)
URL : https://patchwork.freedesktop.org/series/69319/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7358_full -> Patchwork_15304_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_15304_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15304_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15304_full:
### IGT changes ###
#### Warnings ####
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
- shard-apl: [TIMEOUT][1] ([fdo#112113]) -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
Known issues
------------
Here are the changes found in Patchwork_15304_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-kbl1/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [fdo#112080]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb2/igt@gem_ctx_isolation@vcs1-clean.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb7/igt@gem_ctx_isolation@vcs1-clean.html
* igt@gem_ctx_isolation@vecs0-s3:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([fdo#111832])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb5/igt@gem_ctx_isolation@vecs0-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb4/igt@gem_ctx_isolation@vecs0-s3.html
- shard-skl: [PASS][9] -> [INCOMPLETE][10] ([fdo#104108]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl5/igt@gem_ctx_isolation@vecs0-s3.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl4/igt@gem_ctx_isolation@vecs0-s3.html
* igt@gem_ctx_switch@vcs1-heavy:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112080]) +11 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb3/igt@gem_ctx_switch@vcs1-heavy.html
* igt@gem_eio@suspend:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111850])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb6/igt@gem_eio@suspend.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb5/igt@gem_eio@suspend.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#112146]) +6 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111736] / [fdo#111850])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb6/igt@gem_exec_suspend@basic-s3.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_pipe_control_store_loop@reused-buffer:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#111998])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb1/igt@gem_pipe_control_store_loop@reused-buffer.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb6/igt@gem_pipe_control_store_loop@reused-buffer.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][21] -> [DMESG-WARN][22] ([fdo#111870])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-snb4/igt@gem_userptr_blits@sync-unmap.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-snb1/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_selftest@mock_requests:
- shard-skl: [PASS][23] -> [DMESG-WARN][24] ([fdo#111086])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl7/igt@i915_selftest@mock_requests.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl10/igt@i915_selftest@mock_requests.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [PASS][25] -> [INCOMPLETE][26] ([fdo#111832] / [fdo#111850]) +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb4/igt@i915_suspend@sysfs-reader.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb5/igt@i915_suspend@sysfs-reader.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-tglb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +5 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-apl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109276]) +17 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb5/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_persistence@vcs1-hostile-preempt:
- shard-iclb: [SKIP][39] ([fdo#109276] / [fdo#112080]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb2/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
* igt@gem_exec_parallel@fds:
- shard-tglb: [INCOMPLETE][41] ([fdo#111867]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb6/igt@gem_exec_parallel@fds.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb8/igt@gem_exec_parallel@fds.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][43] ([fdo#112146]) -> [PASS][44] +5 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd2:
- shard-iclb: [SKIP][45] ([fdo#109276]) -> [PASS][46] +18 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd2.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd2.html
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-apl: [TIMEOUT][47] ([fdo#112113]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-apl2/igt@gem_persistent_relocs@forked-thrash-inactive.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-apl2/igt@gem_persistent_relocs@forked-thrash-inactive.html
* igt@gem_sync@basic-store-each:
- shard-tglb: [INCOMPLETE][49] ([fdo#111647] / [fdo#111747]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb4/igt@gem_sync@basic-store-each.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb7/igt@gem_sync@basic-store-each.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-snb7/igt@gem_userptr_blits@sync-unmap-after-close.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-snb1/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][53] ([fdo#111830 ]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-tglb: [INCOMPLETE][55] ([fdo#111832] / [fdo#111850]) -> [PASS][56] +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb7/igt@i915_suspend@fence-restore-tiled2untiled.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb2/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][57] ([fdo#108566]) -> [PASS][58] +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][59] ([fdo#105363]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][61] ([fdo#108566]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][63] ([fdo#103167]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-tglb: [FAIL][65] ([fdo#103167]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-tglb: [INCOMPLETE][67] ([fdo#111850]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][69] ([fdo#108145] / [fdo#110403]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping:
- shard-iclb: [INCOMPLETE][71] ([fdo#107713] / [fdo#110041]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb7/igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb6/igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][73] ([fdo#109642] / [fdo#111068]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@kms_psr2_su@page_flip.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_setmode@basic:
- shard-hsw: [FAIL][77] ([fdo#99912]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-hsw1/igt@kms_setmode@basic.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-hsw1/igt@kms_setmode@basic.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [TIMEOUT][79] ([fdo#111732 ]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-skl6/igt@perf@gen8-unprivileged-single-ctx-counters.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-skl2/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@perf_pmu@init-busy-vcs1:
- shard-iclb: [SKIP][81] ([fdo#112080]) -> [PASS][82] +12 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb5/igt@perf_pmu@init-busy-vcs1.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb1/igt@perf_pmu@init-busy-vcs1.html
* igt@syncobj_basic@create-signaled:
- shard-hsw: [INCOMPLETE][83] ([fdo#103540]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-hsw6/igt@syncobj_basic@create-signaled.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-hsw6/igt@syncobj_basic@create-signaled.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][85] ([fdo#109276] / [fdo#112080]) -> [FAIL][86] ([fdo#111329])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [FAIL][87] ([fdo#111329]) -> [SKIP][88] ([fdo#109276] / [fdo#112080])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_ctx_isolation@vcs2-clean:
- shard-tglb: [SKIP][89] ([fdo#112080]) -> [SKIP][90] ([fdo#111912] / [fdo#112080])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb9/igt@gem_ctx_isolation@vcs2-clean.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb2/igt@gem_ctx_isolation@vcs2-clean.html
* igt@gem_exec_schedule@deep-blt:
- shard-tglb: [FAIL][91] ([fdo#111646]) -> [INCOMPLETE][92] ([fdo#111671])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb7/igt@gem_exec_schedule@deep-blt.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb8/igt@gem_exec_schedule@deep-blt.html
* igt@gem_exec_schedule@deep-bsd2:
- shard-tglb: [INCOMPLETE][93] ([fdo#111671]) -> [FAIL][94] ([fdo#111646])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-tglb3/igt@gem_exec_schedule@deep-bsd2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-tglb9/igt@gem_exec_schedule@deep-bsd2.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][95] ([fdo#107724]) -> [SKIP][96] ([fdo#109349])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7358/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110041]: https://bugs.freedesktop.org/show_bug.cgi?id=110041
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111086]: https://bugs.freedesktop.org/show_bug.cgi?id=111086
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111647]: https://bugs.freedesktop.org/show_bug.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15304/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 2/2] drm/i915/dsb: fix extra warning on error path handling
@ 2019-11-18 16:07 ` Jani Nikula
0 siblings, 0 replies; 34+ messages in thread
From: Jani Nikula @ 2019-11-18 16:07 UTC (permalink / raw)
To: Lucas De Marchi, Matt Roper; +Cc: intel-gfx
On Fri, 15 Nov 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Fri, Nov 15, 2019 at 12:52:49PM -0800, Matt Roper wrote:
>>On Mon, Nov 11, 2019 at 12:50:25PM -0800, Lucas De Marchi wrote:
>>> When we call intel_dsb_get(), the dsb initialization may fail for
>>> various reasons. We already log the error message in that path, making
>>> it unnecessary to trigger a warning that refcount == 0 when calling
>>> intel_dsb_put().
>>>
>>> So here we simplify the logic and do lazy shutdown: leaving the extra
>>> refcount alive so when we call intel_dsb_put() we end up calling
>>> i915_vma_unpin_and_release().
>>>
>>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>
>>Due to the lack of any actual concurrency, it seems like we could
>>eventually get rid of the whole get/put design and just allocate the
>>buffer once (and pin it during the prepare step). But this seems good
>
> I assumed this was designed to accept the pattern
>
> intel_dsb_get();
> intel_dsb_get();
> intel_dsb_put();
> intel_dsb_put();
Yeah it wasn't necessarily for concurrency. More to ensure the buffer
doesn't vanish under the engine.
BR,
Jani.
>
>>enough for now.
>>
>>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
> thanks
> Lucas De Marchi
>
>>
>>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_dsb.c | 21 ++++++++++++++-------
>>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
>>> index 4feebbeb0b0c..858af6be9c36 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
>>> @@ -102,6 +102,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>>> struct intel_dsb *dsb = &crtc->dsb;
>>> struct drm_i915_gem_object *obj;
>>> struct i915_vma *vma;
>>> + u32 *buf;
>>> intel_wakeref_t wakeref;
>>>
>>> if (!HAS_DSB(i915))
>>> @@ -110,7 +111,6 @@ intel_dsb_get(struct intel_crtc *crtc)
>>> if (++dsb->refcount != 1)
>>> return dsb;
>>>
>>> - dsb->id = DSB1;
>>> wakeref = intel_runtime_pm_get(&i915->runtime_pm);
>>>
>>> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
>>> @@ -123,22 +123,29 @@ intel_dsb_get(struct intel_crtc *crtc)
>>> if (IS_ERR(vma)) {
>>> DRM_ERROR("Vma creation failed\n");
>>> i915_gem_object_put(obj);
>>> - dsb->refcount--;
>>> goto err;
>>> }
>>>
>>> - dsb->cmd_buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
>>> - if (IS_ERR(dsb->cmd_buf)) {
>>> + buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
>>> + if (IS_ERR(buf)) {
>>> DRM_ERROR("Command buffer creation failed\n");
>>> - i915_vma_unpin_and_release(&vma, 0);
>>> - dsb->cmd_buf = NULL;
>>> - dsb->refcount--;
>>> goto err;
>>> }
>>> +
>>> + dsb->id = DSB1;
>>> dsb->vma = vma;
>>> + dsb->cmd_buf = buf;
>>>
>>> err:
>>> + /*
>>> + * Set cmd_buf to NULL so the writes pass-through, but leave the
>>> + * dangling refcount to be removed later by the corresponding
>>> + * intel_dsb_put(): the important error message will already be
>>> + * logged above.
>>> + */
>>> + dsb->cmd_buf = NULL;
>>> intel_runtime_pm_put(&i915->runtime_pm, wakeref);
>>> +
>>> return dsb;
>>> }
>>>
>>> --
>>> 2.24.0
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>>--
>>Matt Roper
>>Graphics Software Engineer
>>VTT-OSGC Platform Enablement
>>Intel Corporation
>>(916) 356-2795
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsb: fix extra warning on error path handling
@ 2019-11-18 16:07 ` Jani Nikula
0 siblings, 0 replies; 34+ messages in thread
From: Jani Nikula @ 2019-11-18 16:07 UTC (permalink / raw)
To: Lucas De Marchi, Matt Roper; +Cc: intel-gfx
On Fri, 15 Nov 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Fri, Nov 15, 2019 at 12:52:49PM -0800, Matt Roper wrote:
>>On Mon, Nov 11, 2019 at 12:50:25PM -0800, Lucas De Marchi wrote:
>>> When we call intel_dsb_get(), the dsb initialization may fail for
>>> various reasons. We already log the error message in that path, making
>>> it unnecessary to trigger a warning that refcount == 0 when calling
>>> intel_dsb_put().
>>>
>>> So here we simplify the logic and do lazy shutdown: leaving the extra
>>> refcount alive so when we call intel_dsb_put() we end up calling
>>> i915_vma_unpin_and_release().
>>>
>>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>
>>Due to the lack of any actual concurrency, it seems like we could
>>eventually get rid of the whole get/put design and just allocate the
>>buffer once (and pin it during the prepare step). But this seems good
>
> I assumed this was designed to accept the pattern
>
> intel_dsb_get();
> intel_dsb_get();
> intel_dsb_put();
> intel_dsb_put();
Yeah it wasn't necessarily for concurrency. More to ensure the buffer
doesn't vanish under the engine.
BR,
Jani.
>
>>enough for now.
>>
>>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
> thanks
> Lucas De Marchi
>
>>
>>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_dsb.c | 21 ++++++++++++++-------
>>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
>>> index 4feebbeb0b0c..858af6be9c36 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
>>> @@ -102,6 +102,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>>> struct intel_dsb *dsb = &crtc->dsb;
>>> struct drm_i915_gem_object *obj;
>>> struct i915_vma *vma;
>>> + u32 *buf;
>>> intel_wakeref_t wakeref;
>>>
>>> if (!HAS_DSB(i915))
>>> @@ -110,7 +111,6 @@ intel_dsb_get(struct intel_crtc *crtc)
>>> if (++dsb->refcount != 1)
>>> return dsb;
>>>
>>> - dsb->id = DSB1;
>>> wakeref = intel_runtime_pm_get(&i915->runtime_pm);
>>>
>>> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
>>> @@ -123,22 +123,29 @@ intel_dsb_get(struct intel_crtc *crtc)
>>> if (IS_ERR(vma)) {
>>> DRM_ERROR("Vma creation failed\n");
>>> i915_gem_object_put(obj);
>>> - dsb->refcount--;
>>> goto err;
>>> }
>>>
>>> - dsb->cmd_buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
>>> - if (IS_ERR(dsb->cmd_buf)) {
>>> + buf = i915_gem_object_pin_map(vma->obj, I915_MAP_WC);
>>> + if (IS_ERR(buf)) {
>>> DRM_ERROR("Command buffer creation failed\n");
>>> - i915_vma_unpin_and_release(&vma, 0);
>>> - dsb->cmd_buf = NULL;
>>> - dsb->refcount--;
>>> goto err;
>>> }
>>> +
>>> + dsb->id = DSB1;
>>> dsb->vma = vma;
>>> + dsb->cmd_buf = buf;
>>>
>>> err:
>>> + /*
>>> + * Set cmd_buf to NULL so the writes pass-through, but leave the
>>> + * dangling refcount to be removed later by the corresponding
>>> + * intel_dsb_put(): the important error message will already be
>>> + * logged above.
>>> + */
>>> + dsb->cmd_buf = NULL;
>>> intel_runtime_pm_put(&i915->runtime_pm, wakeref);
>>> +
>>> return dsb;
>>> }
>>>
>>> --
>>> 2.24.0
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>>--
>>Matt Roper
>>Graphics Software Engineer
>>VTT-OSGC Platform Enablement
>>Intel Corporation
>>(916) 356-2795
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 34+ messages in thread
end of thread, other threads:[~2019-11-18 16:07 UTC | newest]
Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 20:50 [PATCH 0/2] Improve error handling on DSB Lucas De Marchi
2019-11-11 20:50 ` [Intel-gfx] " Lucas De Marchi
2019-11-11 20:50 ` [PATCH 1/2] drm/i915/dsb: remove atomic operations Lucas De Marchi
2019-11-11 20:50 ` [Intel-gfx] " Lucas De Marchi
2019-11-15 20:29 ` Matt Roper
2019-11-15 20:29 ` [Intel-gfx] " Matt Roper
2019-11-15 21:09 ` Ville Syrjälä
2019-11-15 21:09 ` [Intel-gfx] " Ville Syrjälä
2019-11-15 23:01 ` Lucas De Marchi
2019-11-15 23:01 ` [Intel-gfx] " Lucas De Marchi
2019-11-16 1:15 ` [PATCH v2] " Lucas De Marchi
2019-11-16 1:15 ` [Intel-gfx] " Lucas De Marchi
2019-11-11 20:50 ` [PATCH 2/2] drm/i915/dsb: fix extra warning on error path handling Lucas De Marchi
2019-11-11 20:50 ` [Intel-gfx] " Lucas De Marchi
2019-11-15 20:52 ` Matt Roper
2019-11-15 20:52 ` [Intel-gfx] " Matt Roper
2019-11-15 23:04 ` Lucas De Marchi
2019-11-15 23:04 ` [Intel-gfx] " Lucas De Marchi
2019-11-18 16:07 ` Jani Nikula
2019-11-18 16:07 ` [Intel-gfx] " Jani Nikula
2019-11-11 22:13 ` ✓ Fi.CI.BAT: success for Improve error handling on DSB Patchwork
2019-11-11 22:13 ` [Intel-gfx] " Patchwork
2019-11-12 9:16 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-12 9:16 ` [Intel-gfx] " Patchwork
2019-11-15 2:35 ` ✓ Fi.CI.BAT: success for Improve error handling on DSB (rev2) Patchwork
2019-11-15 2:35 ` [Intel-gfx] " Patchwork
2019-11-16 2:40 ` ✓ Fi.CI.BAT: success for Improve error handling on DSB (rev3) Patchwork
2019-11-16 2:40 ` [Intel-gfx] " Patchwork
2019-11-16 11:05 ` ✗ Fi.CI.IGT: failure for Improve error handling on DSB (rev2) Patchwork
2019-11-16 11:05 ` [Intel-gfx] " Patchwork
2019-11-16 16:47 ` ✓ Fi.CI.BAT: success for Improve error handling on DSB (rev4) Patchwork
2019-11-16 16:47 ` [Intel-gfx] " Patchwork
2019-11-17 22:59 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-17 22:59 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.