All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/tgl: MOCS table fixes
@ 2019-11-11 19:07 ` Matt Roper
  0 siblings, 0 replies; 16+ messages in thread
From: Matt Roper @ 2019-11-11 19:07 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

The bspec was just updated with a couple corrections to the TGL MOCS
table.  Entries 16 and 17 are marked as reserved (overriding the value
we inherit from GEN11_MOCS_ENTRIES) and entry 61 shouldn't have the
LE_SCF bit applied.

Note that since we're intentionally/explicitly overriding table entries
from GEN11_MOCS_ENTRIES we should suppress the 'override-init' compiler
warnings for this file.

Bspec: 45101
Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
Cc: Tomasz Lis <tomasz.lis@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/Makefile        | 1 +
 drivers/gpu/drm/i915/gt/intel_mocs.c | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index e0fd10c0cfb8..8c6b5fa43473 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -27,6 +27,7 @@ subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
 # Fine grained warnings disable
 CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
 CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
+CFLAGS_gt/intel_mocs.o = $(call cc-disable-warning, override-init)
 
 subdir-ccflags-y += \
 	$(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)
diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
index 6e881c735b20..cd72235553aa 100644
--- a/drivers/gpu/drm/i915/gt/intel_mocs.c
+++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
@@ -249,6 +249,10 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
 
 	GEN11_MOCS_ENTRIES,
 
+	/* Reserved (overrides values from GEN11_MOCS_ENTRIES) */
+	MOCS_ENTRY(16, 0x0, 0x0),
+	MOCS_ENTRY(17, 0x0, 0x0),
+
 	/* Implicitly enable L1 - HDC:L1 + L3 + LLC */
 	MOCS_ENTRY(48,
 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3),
@@ -271,7 +275,7 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
 		   L3_1_UC),
 	/* HW Special Case (Displayable) */
 	MOCS_ENTRY(61,
-		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
+		   LE_1_UC | LE_TC_1_LLC,
 		   L3_3_WB),
 };
 
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/tgl: MOCS table fixes
@ 2019-11-11 19:07 ` Matt Roper
  0 siblings, 0 replies; 16+ messages in thread
From: Matt Roper @ 2019-11-11 19:07 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

The bspec was just updated with a couple corrections to the TGL MOCS
table.  Entries 16 and 17 are marked as reserved (overriding the value
we inherit from GEN11_MOCS_ENTRIES) and entry 61 shouldn't have the
LE_SCF bit applied.

Note that since we're intentionally/explicitly overriding table entries
from GEN11_MOCS_ENTRIES we should suppress the 'override-init' compiler
warnings for this file.

Bspec: 45101
Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
Cc: Tomasz Lis <tomasz.lis@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/Makefile        | 1 +
 drivers/gpu/drm/i915/gt/intel_mocs.c | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index e0fd10c0cfb8..8c6b5fa43473 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -27,6 +27,7 @@ subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
 # Fine grained warnings disable
 CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
 CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
+CFLAGS_gt/intel_mocs.o = $(call cc-disable-warning, override-init)
 
 subdir-ccflags-y += \
 	$(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)
diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
index 6e881c735b20..cd72235553aa 100644
--- a/drivers/gpu/drm/i915/gt/intel_mocs.c
+++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
@@ -249,6 +249,10 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
 
 	GEN11_MOCS_ENTRIES,
 
+	/* Reserved (overrides values from GEN11_MOCS_ENTRIES) */
+	MOCS_ENTRY(16, 0x0, 0x0),
+	MOCS_ENTRY(17, 0x0, 0x0),
+
 	/* Implicitly enable L1 - HDC:L1 + L3 + LLC */
 	MOCS_ENTRY(48,
 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3),
@@ -271,7 +275,7 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
 		   L3_1_UC),
 	/* HW Special Case (Displayable) */
 	MOCS_ENTRY(61,
-		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
+		   LE_1_UC | LE_TC_1_LLC,
 		   L3_3_WB),
 };
 
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915/tgl: MOCS table fixes
@ 2019-11-11 20:37   ` Lucas De Marchi
  0 siblings, 0 replies; 16+ messages in thread
From: Lucas De Marchi @ 2019-11-11 20:37 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

On Mon, Nov 11, 2019 at 11:07:21AM -0800, Matt Roper wrote:
>The bspec was just updated with a couple corrections to the TGL MOCS
>table.  Entries 16 and 17 are marked as reserved (overriding the value
>we inherit from GEN11_MOCS_ENTRIES) and entry 61 shouldn't have the
>LE_SCF bit applied.
>
>Note that since we're intentionally/explicitly overriding table entries
>from GEN11_MOCS_ENTRIES we should suppress the 'override-init' compiler
>warnings for this file.
>
>Bspec: 45101
>Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
>Cc: Tomasz Lis <tomasz.lis@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>---
> drivers/gpu/drm/i915/Makefile        | 1 +
> drivers/gpu/drm/i915/gt/intel_mocs.c | 6 +++++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>index e0fd10c0cfb8..8c6b5fa43473 100644
>--- a/drivers/gpu/drm/i915/Makefile
>+++ b/drivers/gpu/drm/i915/Makefile
>@@ -27,6 +27,7 @@ subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
> # Fine grained warnings disable
> CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
> CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
>+CFLAGS_gt/intel_mocs.o = $(call cc-disable-warning, override-init)

I'm pretty sure at some point I had a pragma push/pop to ignore
this warning just around the tables and nothing else. Probably it was
dropped in a patch revision, because git log doesn't show it.

It looks like we even define special macros __diag_push(), __diag_pop(),
__diag_ignore() for that, but it doesn't see much use in the kernel, not
sure why.

>
> subdir-ccflags-y += \
> 	$(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)
>diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
>index 6e881c735b20..cd72235553aa 100644
>--- a/drivers/gpu/drm/i915/gt/intel_mocs.c
>+++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
>@@ -249,6 +249,10 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
>
> 	GEN11_MOCS_ENTRIES,
>
>+	/* Reserved (overrides values from GEN11_MOCS_ENTRIES) */
>+	MOCS_ENTRY(16, 0x0, 0x0),
>+	MOCS_ENTRY(17, 0x0, 0x0),

MOCS_ENTRY implicitly define the entry to used. What I think we need is
a way to override the used field, so it's more inline with what the
bspec is telling us to do...

probably something like

#define MOCS_ENTRY_SET_UNUSED(__idx) \
	[__idx] = { \
		.used = 0, \
	}

Difference is that in tests that read back the value and check if they
make sense, they won't test values that are marked as not used. IMO what
we should be doing for these fields.

Lucas De Marchi

>+
> 	/* Implicitly enable L1 - HDC:L1 + L3 + LLC */
> 	MOCS_ENTRY(48,
> 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3),
>@@ -271,7 +275,7 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
> 		   L3_1_UC),
> 	/* HW Special Case (Displayable) */
> 	MOCS_ENTRY(61,
>-		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
>+		   LE_1_UC | LE_TC_1_LLC,
> 		   L3_3_WB),
> };
>
>-- 
>2.21.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl: MOCS table fixes
@ 2019-11-11 20:37   ` Lucas De Marchi
  0 siblings, 0 replies; 16+ messages in thread
From: Lucas De Marchi @ 2019-11-11 20:37 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

On Mon, Nov 11, 2019 at 11:07:21AM -0800, Matt Roper wrote:
>The bspec was just updated with a couple corrections to the TGL MOCS
>table.  Entries 16 and 17 are marked as reserved (overriding the value
>we inherit from GEN11_MOCS_ENTRIES) and entry 61 shouldn't have the
>LE_SCF bit applied.
>
>Note that since we're intentionally/explicitly overriding table entries
>from GEN11_MOCS_ENTRIES we should suppress the 'override-init' compiler
>warnings for this file.
>
>Bspec: 45101
>Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
>Cc: Tomasz Lis <tomasz.lis@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>---
> drivers/gpu/drm/i915/Makefile        | 1 +
> drivers/gpu/drm/i915/gt/intel_mocs.c | 6 +++++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>index e0fd10c0cfb8..8c6b5fa43473 100644
>--- a/drivers/gpu/drm/i915/Makefile
>+++ b/drivers/gpu/drm/i915/Makefile
>@@ -27,6 +27,7 @@ subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
> # Fine grained warnings disable
> CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
> CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
>+CFLAGS_gt/intel_mocs.o = $(call cc-disable-warning, override-init)

I'm pretty sure at some point I had a pragma push/pop to ignore
this warning just around the tables and nothing else. Probably it was
dropped in a patch revision, because git log doesn't show it.

It looks like we even define special macros __diag_push(), __diag_pop(),
__diag_ignore() for that, but it doesn't see much use in the kernel, not
sure why.

>
> subdir-ccflags-y += \
> 	$(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)
>diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
>index 6e881c735b20..cd72235553aa 100644
>--- a/drivers/gpu/drm/i915/gt/intel_mocs.c
>+++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
>@@ -249,6 +249,10 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
>
> 	GEN11_MOCS_ENTRIES,
>
>+	/* Reserved (overrides values from GEN11_MOCS_ENTRIES) */
>+	MOCS_ENTRY(16, 0x0, 0x0),
>+	MOCS_ENTRY(17, 0x0, 0x0),

MOCS_ENTRY implicitly define the entry to used. What I think we need is
a way to override the used field, so it's more inline with what the
bspec is telling us to do...

probably something like

#define MOCS_ENTRY_SET_UNUSED(__idx) \
	[__idx] = { \
		.used = 0, \
	}

Difference is that in tests that read back the value and check if they
make sense, they won't test values that are marked as not used. IMO what
we should be doing for these fields.

Lucas De Marchi

>+
> 	/* Implicitly enable L1 - HDC:L1 + L3 + LLC */
> 	MOCS_ENTRY(48,
> 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3),
>@@ -271,7 +275,7 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
> 		   L3_1_UC),
> 	/* HW Special Case (Displayable) */
> 	MOCS_ENTRY(61,
>-		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
>+		   LE_1_UC | LE_TC_1_LLC,
> 		   L3_3_WB),
> };
>
>-- 
>2.21.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/tgl: MOCS table fixes
@ 2019-11-11 20:44   ` Patchwork
  0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-11 20:44 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/tgl: MOCS table fixes
URL   : https://patchwork.freedesktop.org/series/69312/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7311 -> Patchwork_15224
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/index.html

Known issues
------------

  Here are the changes found in Patchwork_15224 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-guc:         [PASS][1] -> [INCOMPLETE][2] ([fdo#107807])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-guc/igt@i915_pm_rpm@module-reload.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111407])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-skl-6770hq:      [PASS][5] -> [FAIL][6] ([fdo#109495])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-6770hq/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          [PASS][7] -> [FAIL][8] ([fdo#103167])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][9] ([fdo#108511]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@kms_busy@basic-flip-pipe-b:
    - fi-skl-6770hq:      [DMESG-WARN][11] ([fdo#105541]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-skl-6770hq:      [WARN][13] -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109495]: https://bugs.freedesktop.org/show_bug.cgi?id=109495
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407


Participating hosts (52 -> 45)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7311 -> Patchwork_15224

  CI-20190529: 20190529
  CI_DRM_7311: 36d31f70111ea87432ee8a8981943c5b20e36213 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5271: 05f0400c50af843df301efb5475e9f5e2d16a098 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15224: 637133f623b2919d1261006ab55f3c2b6c9df924 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

637133f623b2 drm/i915/tgl: MOCS table fixes

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: MOCS table fixes
@ 2019-11-11 20:44   ` Patchwork
  0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-11 20:44 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/tgl: MOCS table fixes
URL   : https://patchwork.freedesktop.org/series/69312/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7311 -> Patchwork_15224
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/index.html

Known issues
------------

  Here are the changes found in Patchwork_15224 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-guc:         [PASS][1] -> [INCOMPLETE][2] ([fdo#107807])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-guc/igt@i915_pm_rpm@module-reload.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#111407])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-skl-6770hq:      [PASS][5] -> [FAIL][6] ([fdo#109495])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-6770hq/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          [PASS][7] -> [FAIL][8] ([fdo#103167])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][9] ([fdo#108511]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@kms_busy@basic-flip-pipe-b:
    - fi-skl-6770hq:      [DMESG-WARN][11] ([fdo#105541]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-skl-6770hq:      [WARN][13] -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109495]: https://bugs.freedesktop.org/show_bug.cgi?id=109495
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407


Participating hosts (52 -> 45)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7311 -> Patchwork_15224

  CI-20190529: 20190529
  CI_DRM_7311: 36d31f70111ea87432ee8a8981943c5b20e36213 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5271: 05f0400c50af843df301efb5475e9f5e2d16a098 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15224: 637133f623b2919d1261006ab55f3c2b6c9df924 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

637133f623b2 drm/i915/tgl: MOCS table fixes

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15224/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915/tgl: MOCS table fixes
@ 2019-11-11 20:57     ` Matt Roper
  0 siblings, 0 replies; 16+ messages in thread
From: Matt Roper @ 2019-11-11 20:57 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Mon, Nov 11, 2019 at 12:37:30PM -0800, Lucas De Marchi wrote:
> On Mon, Nov 11, 2019 at 11:07:21AM -0800, Matt Roper wrote:
> > The bspec was just updated with a couple corrections to the TGL MOCS
> > table.  Entries 16 and 17 are marked as reserved (overriding the value
> > we inherit from GEN11_MOCS_ENTRIES) and entry 61 shouldn't have the
> > LE_SCF bit applied.
> > 
> > Note that since we're intentionally/explicitly overriding table entries
> > from GEN11_MOCS_ENTRIES we should suppress the 'override-init' compiler
> > warnings for this file.
> > 
> > Bspec: 45101
> > Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
> > Cc: Tomasz Lis <tomasz.lis@intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> > drivers/gpu/drm/i915/Makefile        | 1 +
> > drivers/gpu/drm/i915/gt/intel_mocs.c | 6 +++++-
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> > index e0fd10c0cfb8..8c6b5fa43473 100644
> > --- a/drivers/gpu/drm/i915/Makefile
> > +++ b/drivers/gpu/drm/i915/Makefile
> > @@ -27,6 +27,7 @@ subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
> > # Fine grained warnings disable
> > CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
> > CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
> > +CFLAGS_gt/intel_mocs.o = $(call cc-disable-warning, override-init)
> 
> I'm pretty sure at some point I had a pragma push/pop to ignore
> this warning just around the tables and nothing else. Probably it was
> dropped in a patch revision, because git log doesn't show it.
> 
> It looks like we even define special macros __diag_push(), __diag_pop(),
> __diag_ignore() for that, but it doesn't see much use in the kernel, not
> sure why.
> 
> > 
> > subdir-ccflags-y += \
> > 	$(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)
> > diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
> > index 6e881c735b20..cd72235553aa 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
> > @@ -249,6 +249,10 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
> > 
> > 	GEN11_MOCS_ENTRIES,
> > 
> > +	/* Reserved (overrides values from GEN11_MOCS_ENTRIES) */
> > +	MOCS_ENTRY(16, 0x0, 0x0),
> > +	MOCS_ENTRY(17, 0x0, 0x0),
> 
> MOCS_ENTRY implicitly define the entry to used. What I think we need is
> a way to override the used field, so it's more inline with what the
> bspec is telling us to do...
> 
> probably something like
> 
> #define MOCS_ENTRY_SET_UNUSED(__idx) \
> 	[__idx] = { \
> 		.used = 0, \
> 	}
> 
> Difference is that in tests that read back the value and check if they
> make sense, they won't test values that are marked as not used. IMO what
> we should be doing for these fields.

Makes sense.  And we should probably switch the existing reserved
entries (0 and 1) over to that as well?


Matt

> 
> Lucas De Marchi
> 
> > +
> > 	/* Implicitly enable L1 - HDC:L1 + L3 + LLC */
> > 	MOCS_ENTRY(48,
> > 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3),
> > @@ -271,7 +275,7 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
> > 		   L3_1_UC),
> > 	/* HW Special Case (Displayable) */
> > 	MOCS_ENTRY(61,
> > -		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
> > +		   LE_1_UC | LE_TC_1_LLC,
> > 		   L3_3_WB),
> > };
> > 
> > -- 
> > 2.21.0
> > 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl: MOCS table fixes
@ 2019-11-11 20:57     ` Matt Roper
  0 siblings, 0 replies; 16+ messages in thread
From: Matt Roper @ 2019-11-11 20:57 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Mon, Nov 11, 2019 at 12:37:30PM -0800, Lucas De Marchi wrote:
> On Mon, Nov 11, 2019 at 11:07:21AM -0800, Matt Roper wrote:
> > The bspec was just updated with a couple corrections to the TGL MOCS
> > table.  Entries 16 and 17 are marked as reserved (overriding the value
> > we inherit from GEN11_MOCS_ENTRIES) and entry 61 shouldn't have the
> > LE_SCF bit applied.
> > 
> > Note that since we're intentionally/explicitly overriding table entries
> > from GEN11_MOCS_ENTRIES we should suppress the 'override-init' compiler
> > warnings for this file.
> > 
> > Bspec: 45101
> > Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
> > Cc: Tomasz Lis <tomasz.lis@intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> > drivers/gpu/drm/i915/Makefile        | 1 +
> > drivers/gpu/drm/i915/gt/intel_mocs.c | 6 +++++-
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> > index e0fd10c0cfb8..8c6b5fa43473 100644
> > --- a/drivers/gpu/drm/i915/Makefile
> > +++ b/drivers/gpu/drm/i915/Makefile
> > @@ -27,6 +27,7 @@ subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
> > # Fine grained warnings disable
> > CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
> > CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
> > +CFLAGS_gt/intel_mocs.o = $(call cc-disable-warning, override-init)
> 
> I'm pretty sure at some point I had a pragma push/pop to ignore
> this warning just around the tables and nothing else. Probably it was
> dropped in a patch revision, because git log doesn't show it.
> 
> It looks like we even define special macros __diag_push(), __diag_pop(),
> __diag_ignore() for that, but it doesn't see much use in the kernel, not
> sure why.
> 
> > 
> > subdir-ccflags-y += \
> > 	$(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)
> > diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
> > index 6e881c735b20..cd72235553aa 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
> > @@ -249,6 +249,10 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
> > 
> > 	GEN11_MOCS_ENTRIES,
> > 
> > +	/* Reserved (overrides values from GEN11_MOCS_ENTRIES) */
> > +	MOCS_ENTRY(16, 0x0, 0x0),
> > +	MOCS_ENTRY(17, 0x0, 0x0),
> 
> MOCS_ENTRY implicitly define the entry to used. What I think we need is
> a way to override the used field, so it's more inline with what the
> bspec is telling us to do...
> 
> probably something like
> 
> #define MOCS_ENTRY_SET_UNUSED(__idx) \
> 	[__idx] = { \
> 		.used = 0, \
> 	}
> 
> Difference is that in tests that read back the value and check if they
> make sense, they won't test values that are marked as not used. IMO what
> we should be doing for these fields.

Makes sense.  And we should probably switch the existing reserved
entries (0 and 1) over to that as well?


Matt

> 
> Lucas De Marchi
> 
> > +
> > 	/* Implicitly enable L1 - HDC:L1 + L3 + LLC */
> > 	MOCS_ENTRY(48,
> > 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3),
> > @@ -271,7 +275,7 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
> > 		   L3_1_UC),
> > 	/* HW Special Case (Displayable) */
> > 	MOCS_ENTRY(61,
> > -		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
> > +		   LE_1_UC | LE_TC_1_LLC,
> > 		   L3_3_WB),
> > };
> > 
> > -- 
> > 2.21.0
> > 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH v2] drm/i915/tgl: MOCS table fixes
@ 2019-11-11 21:59     ` Matt Roper
  0 siblings, 0 replies; 16+ messages in thread
From: Matt Roper @ 2019-11-11 21:59 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

The bspec was just updated with a couple corrections to the TGL MOCS
table.  Entries 16 and 17 are marked as reserved (overriding the value
we inherit from GEN11_MOCS_ENTRIES) and entry 61 shouldn't have the
LE_SCF bit applied.

Note that since we're intentionally/explicitly overriding table entries
from GEN11_MOCS_ENTRIES we should suppress the 'override-init' compiler
warnings for the TGL table.

v2:
 - Add a MOCS_ENTRY_UNUSED() and use it to declare the
   explicitly-reserved MOCS entries. (Lucas)
 - Move the warning suppression from the Makefile to a #pragma that only
   affects the TGL table. (Lucas)

Bspec: 45101
Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
Cc: Tomasz Lis <tomasz.lis@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_mocs.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
index 6e881c735b20..4ae07650bfcb 100644
--- a/drivers/gpu/drm/i915/gt/intel_mocs.c
+++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
@@ -91,6 +91,9 @@ struct drm_i915_mocs_table {
 		.used = 1, \
 	}
 
+#define MOCS_ENTRY_UNUSED(__idx) \
+	[__idx] = { .used = 0 }
+
 /*
  * MOCS tables
  *
@@ -241,14 +244,20 @@ static const struct drm_i915_mocs_entry broxton_mocs_table[] = {
 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3), \
 		   L3_1_UC)
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Woverride-init"
 static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
 	/* Base - Error (Reserved for Non-Use) */
-	MOCS_ENTRY(0, 0x0, 0x0),
+	MOCS_ENTRY_UNUSED(0),
 	/* Base - Reserved */
-	MOCS_ENTRY(1, 0x0, 0x0),
+	MOCS_ENTRY_UNUSED(1),
 
 	GEN11_MOCS_ENTRIES,
 
+	/* Reserved (overrides values from GEN11_MOCS_ENTRIES) */
+	MOCS_ENTRY_UNUSED(16),
+	MOCS_ENTRY_UNUSED(17),
+
 	/* Implicitly enable L1 - HDC:L1 + L3 + LLC */
 	MOCS_ENTRY(48,
 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3),
@@ -271,9 +280,10 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
 		   L3_1_UC),
 	/* HW Special Case (Displayable) */
 	MOCS_ENTRY(61,
-		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
+		   LE_1_UC | LE_TC_1_LLC,
 		   L3_3_WB),
 };
+#pragma GCC diagnostic pop
 
 static const struct drm_i915_mocs_entry icelake_mocs_table[] = {
 	/* Base - Uncached (Deprecated) */
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/tgl: MOCS table fixes
@ 2019-11-11 21:59     ` Matt Roper
  0 siblings, 0 replies; 16+ messages in thread
From: Matt Roper @ 2019-11-11 21:59 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

The bspec was just updated with a couple corrections to the TGL MOCS
table.  Entries 16 and 17 are marked as reserved (overriding the value
we inherit from GEN11_MOCS_ENTRIES) and entry 61 shouldn't have the
LE_SCF bit applied.

Note that since we're intentionally/explicitly overriding table entries
from GEN11_MOCS_ENTRIES we should suppress the 'override-init' compiler
warnings for the TGL table.

v2:
 - Add a MOCS_ENTRY_UNUSED() and use it to declare the
   explicitly-reserved MOCS entries. (Lucas)
 - Move the warning suppression from the Makefile to a #pragma that only
   affects the TGL table. (Lucas)

Bspec: 45101
Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
Cc: Tomasz Lis <tomasz.lis@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_mocs.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
index 6e881c735b20..4ae07650bfcb 100644
--- a/drivers/gpu/drm/i915/gt/intel_mocs.c
+++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
@@ -91,6 +91,9 @@ struct drm_i915_mocs_table {
 		.used = 1, \
 	}
 
+#define MOCS_ENTRY_UNUSED(__idx) \
+	[__idx] = { .used = 0 }
+
 /*
  * MOCS tables
  *
@@ -241,14 +244,20 @@ static const struct drm_i915_mocs_entry broxton_mocs_table[] = {
 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3), \
 		   L3_1_UC)
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Woverride-init"
 static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
 	/* Base - Error (Reserved for Non-Use) */
-	MOCS_ENTRY(0, 0x0, 0x0),
+	MOCS_ENTRY_UNUSED(0),
 	/* Base - Reserved */
-	MOCS_ENTRY(1, 0x0, 0x0),
+	MOCS_ENTRY_UNUSED(1),
 
 	GEN11_MOCS_ENTRIES,
 
+	/* Reserved (overrides values from GEN11_MOCS_ENTRIES) */
+	MOCS_ENTRY_UNUSED(16),
+	MOCS_ENTRY_UNUSED(17),
+
 	/* Implicitly enable L1 - HDC:L1 + L3 + LLC */
 	MOCS_ENTRY(48,
 		   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3),
@@ -271,9 +280,10 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
 		   L3_1_UC),
 	/* HW Special Case (Displayable) */
 	MOCS_ENTRY(61,
-		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
+		   LE_1_UC | LE_TC_1_LLC,
 		   L3_3_WB),
 };
+#pragma GCC diagnostic pop
 
 static const struct drm_i915_mocs_entry icelake_mocs_table[] = {
 	/* Base - Uncached (Deprecated) */
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: MOCS table fixes (rev2)
@ 2019-11-11 23:02     ` Patchwork
  0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-11 23:02 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/tgl: MOCS table fixes (rev2)
URL   : https://patchwork.freedesktop.org/series/69312/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2c5d7cbe58b9 drm/i915/tgl: MOCS table fixes
-:72: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#72: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:286:
 };
+#pragma GCC diagnostic pop

total: 0 errors, 0 warnings, 1 checks, 42 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: MOCS table fixes (rev2)
@ 2019-11-11 23:02     ` Patchwork
  0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-11 23:02 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/tgl: MOCS table fixes (rev2)
URL   : https://patchwork.freedesktop.org/series/69312/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2c5d7cbe58b9 drm/i915/tgl: MOCS table fixes
-:72: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#72: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:286:
 };
+#pragma GCC diagnostic pop

total: 0 errors, 0 warnings, 1 checks, 42 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✗ Fi.CI.SPARSE: warning for drm/i915/tgl: MOCS table fixes (rev2)
@ 2019-11-11 23:03     ` Patchwork
  0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-11 23:03 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/tgl: MOCS table fixes (rev2)
URL   : https://patchwork.freedesktop.org/series/69312/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915/tgl: MOCS table fixes
-
+drivers/gpu/drm/i915/gt/intel_mocs.c:255:9: warning: Initializer entry defined twice
+drivers/gpu/drm/i915/gt/intel_mocs.c:258:9:   also defined here

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/tgl: MOCS table fixes (rev2)
@ 2019-11-11 23:03     ` Patchwork
  0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-11 23:03 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/tgl: MOCS table fixes (rev2)
URL   : https://patchwork.freedesktop.org/series/69312/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915/tgl: MOCS table fixes
-
+drivers/gpu/drm/i915/gt/intel_mocs.c:255:9: warning: Initializer entry defined twice
+drivers/gpu/drm/i915/gt/intel_mocs.c:258:9:   also defined here

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/tgl: MOCS table fixes (rev2)
@ 2019-11-11 23:55     ` Patchwork
  0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-11 23:55 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/tgl: MOCS table fixes (rev2)
URL   : https://patchwork.freedesktop.org/series/69312/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7311 -> Patchwork_15226
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15226 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15226, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15226:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-bxt-dsi:         [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-bsw-kefka:       [PASS][3] -> [DMESG-WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html

  
Known issues
------------

  Here are the changes found in Patchwork_15226 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_blt:
    - fi-icl-u2:          [PASS][5] -> [INCOMPLETE][6] ([fdo#107713])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-icl-u2/igt@i915_selftest@live_blt.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-icl-u2/igt@i915_selftest@live_blt.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][7] ([fdo#108511]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-skl-6770hq:      [WARN][9] -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html

  
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511


Participating hosts (52 -> 45)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7311 -> Patchwork_15226

  CI-20190529: 20190529
  CI_DRM_7311: 36d31f70111ea87432ee8a8981943c5b20e36213 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5271: 05f0400c50af843df301efb5475e9f5e2d16a098 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15226: 2c5d7cbe58b99ddcb147b718b42a866ac5c91d0a @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

2c5d7cbe58b9 drm/i915/tgl: MOCS table fixes

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: MOCS table fixes (rev2)
@ 2019-11-11 23:55     ` Patchwork
  0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-11 23:55 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/tgl: MOCS table fixes (rev2)
URL   : https://patchwork.freedesktop.org/series/69312/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7311 -> Patchwork_15226
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15226 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15226, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15226:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-bxt-dsi:         [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-bsw-kefka:       [PASS][3] -> [DMESG-WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html

  
Known issues
------------

  Here are the changes found in Patchwork_15226 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_blt:
    - fi-icl-u2:          [PASS][5] -> [INCOMPLETE][6] ([fdo#107713])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-icl-u2/igt@i915_selftest@live_blt.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-icl-u2/igt@i915_selftest@live_blt.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][7] ([fdo#108511]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-skl-6770hq:      [WARN][9] -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7311/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html

  
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511


Participating hosts (52 -> 45)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7311 -> Patchwork_15226

  CI-20190529: 20190529
  CI_DRM_7311: 36d31f70111ea87432ee8a8981943c5b20e36213 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5271: 05f0400c50af843df301efb5475e9f5e2d16a098 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15226: 2c5d7cbe58b99ddcb147b718b42a866ac5c91d0a @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

2c5d7cbe58b9 drm/i915/tgl: MOCS table fixes

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15226/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-11-11 23:55 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 19:07 [PATCH] drm/i915/tgl: MOCS table fixes Matt Roper
2019-11-11 19:07 ` [Intel-gfx] " Matt Roper
2019-11-11 20:37 ` Lucas De Marchi
2019-11-11 20:37   ` [Intel-gfx] " Lucas De Marchi
2019-11-11 20:57   ` Matt Roper
2019-11-11 20:57     ` [Intel-gfx] " Matt Roper
2019-11-11 21:59   ` [PATCH v2] " Matt Roper
2019-11-11 21:59     ` [Intel-gfx] " Matt Roper
2019-11-11 23:02   ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: MOCS table fixes (rev2) Patchwork
2019-11-11 23:02     ` [Intel-gfx] " Patchwork
2019-11-11 23:03   ` ✗ Fi.CI.SPARSE: " Patchwork
2019-11-11 23:03     ` [Intel-gfx] " Patchwork
2019-11-11 23:55   ` ✗ Fi.CI.BAT: failure " Patchwork
2019-11-11 23:55     ` [Intel-gfx] " Patchwork
2019-11-11 20:44 ` ✓ Fi.CI.BAT: success for drm/i915/tgl: MOCS table fixes Patchwork
2019-11-11 20:44   ` [Intel-gfx] " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.