All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: bitbake-devel@lists.openembedded.org, toaster@yoctoproject.org
Subject: Re: [bitbake-devel] [PATCH 4/5] toaster/orm/management/commands/lsupdates.py: Use new layerindex module
Date: Fri, 04 Aug 2017 00:15:02 +0200	[thread overview]
Message-ID: <1573680.eRU8eE1tyc@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <1fcf3861-fd8e-042d-2a05-0bfe9c6aab14@windriver.com>

On Thursday, 3 August 2017 8:18:03 PM CEST Mark Hatle wrote:
> On 8/3/17 1:06 PM, Paul Eggleton wrote:
> > On Friday, 28 July 2017 5:37:21 PM CEST Mark Hatle wrote:
> >> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> > 
> > Missing a commit message - and you wrote the book on proper commit 
> > messages :p
> 
> In this case, what is wrong with the message.  The change doesn't do
> anything but use the new layer index module.  Functionality remains the 
> same.

Wouldn't you at minimum want to state exactly that last bit then? That isn't 
clear without carefully looking through the patch.

Same for the other commit, except there what is displayed by bitbake-layers 
layerindex-fetch has changed a little bit.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


WARNING: multiple messages have this Message-ID (diff)
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: bitbake-devel@lists.openembedded.org, toaster@yoctoproject.org
Subject: Re: [PATCH 4/5] toaster/orm/management/commands/lsupdates.py: Use new layerindex module
Date: Fri, 04 Aug 2017 00:15:02 +0200	[thread overview]
Message-ID: <1573680.eRU8eE1tyc@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <1fcf3861-fd8e-042d-2a05-0bfe9c6aab14@windriver.com>

On Thursday, 3 August 2017 8:18:03 PM CEST Mark Hatle wrote:
> On 8/3/17 1:06 PM, Paul Eggleton wrote:
> > On Friday, 28 July 2017 5:37:21 PM CEST Mark Hatle wrote:
> >> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> > 
> > Missing a commit message - and you wrote the book on proper commit 
> > messages :p
> 
> In this case, what is wrong with the message.  The change doesn't do
> anything but use the new layer index module.  Functionality remains the 
> same.

Wouldn't you at minimum want to state exactly that last bit then? That isn't 
clear without carefully looking through the patch.

Same for the other commit, except there what is displayed by bitbake-layers 
layerindex-fetch has changed a little bit.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2017-08-03 22:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 15:37 [PATCH 0/5] Implement a new remote layer module Mark Hatle
2017-07-28 15:37 ` [PATCH 1/5] lib/layers: Initial layer and layer index implementeation Mark Hatle
2017-08-03 18:05   ` [bitbake-devel] " Paul Eggleton
2017-08-03 18:05     ` Paul Eggleton
2017-08-03 18:17     ` [bitbake-devel] " Mark Hatle
2017-08-03 18:17       ` Mark Hatle
2017-07-28 15:37 ` [PATCH 2/5] bitbake-selftest: Add layers module tests Mark Hatle
2017-07-28 15:37 ` [PATCH 3/5] lib/bblayers: Add support for the new layer modules Mark Hatle
2017-07-28 16:04   ` [bitbake-devel] " Mark Hatle
2017-07-28 16:04     ` Mark Hatle
2017-07-28 15:37 ` [PATCH 4/5] toaster/orm/management/commands/lsupdates.py: Use new layerindex module Mark Hatle
2017-08-03 18:06   ` [bitbake-devel] " Paul Eggleton
2017-08-03 18:06     ` Paul Eggleton
2017-08-03 18:18     ` [bitbake-devel] " Mark Hatle
2017-08-03 18:18       ` Mark Hatle
2017-08-03 22:15       ` Paul Eggleton [this message]
2017-08-03 22:15         ` Paul Eggleton
2017-08-03 22:40         ` [bitbake-devel] " Mark Hatle
2017-08-03 22:40           ` Mark Hatle
2017-07-28 15:37 ` [PATCH 5/5] bitbake-layers: disable parsing for layerindex commands Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573680.eRU8eE1tyc@peggleto-mobl.ger.corp.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=mark.hatle@windriver.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.