* [PATCH] display: xlnx_dp: Provide sufficient bytes for silent audio channel
@ 2019-11-15 15:56 Sai Pavan Boddu
2019-11-15 19:29 ` Alistair Francis
2019-11-15 20:12 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Sai Pavan Boddu @ 2019-11-15 15:56 UTC (permalink / raw)
To: Alistair Francis, Edgar E. Iglesias, Peter Maydell, KONRAD Frederic
Cc: qemu-arm, qemu-devel
Fill the audio channel with required number of bytes to cover the
elapsed time. This prevents rate control reset, and avoids debug prints
like below
log:
Resetting rate control (65692 samples)
...
Resetting rate control (65721 samples)
...
Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
---
hw/display/xlnx_dp.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
index fde3b21..7058443 100644
--- a/hw/display/xlnx_dp.c
+++ b/hw/display/xlnx_dp.c
@@ -394,13 +394,18 @@ static void xlnx_dp_audio_callback(void *opaque, int avail)
written = AUD_write(s->amixer_output_stream,
&s->out_buffer[s->data_ptr], s->byte_left);
} else {
+ int len_to_copy;
/*
* There is nothing to play.. We don't have any data! Fill the
* buffer with zero's and send it.
*/
written = 0;
- memset(s->out_buffer, 0, 1024);
- AUD_write(s->amixer_output_stream, s->out_buffer, 1024);
+ while (avail) {
+ len_to_copy = MIN(AUD_CHBUF_MAX_DEPTH, avail);
+ memset(s->out_buffer, 0, len_to_copy);
+ avail -= AUD_write(s->amixer_output_stream, s->out_buffer,
+ len_to_copy);
+ }
}
} else {
written = AUD_write(s->amixer_output_stream,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] display: xlnx_dp: Provide sufficient bytes for silent audio channel
2019-11-15 15:56 [PATCH] display: xlnx_dp: Provide sufficient bytes for silent audio channel Sai Pavan Boddu
@ 2019-11-15 19:29 ` Alistair Francis
2019-11-15 20:12 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Alistair Francis @ 2019-11-15 19:29 UTC (permalink / raw)
To: Sai Pavan Boddu
Cc: Peter Maydell, Alistair Francis,
qemu-devel@nongnu.org Developers, qemu-arm, Edgar E. Iglesias,
KONRAD Frederic
On Fri, Nov 15, 2019 at 10:59 AM Sai Pavan Boddu
<sai.pavan.boddu@xilinx.com> wrote:
>
> Fill the audio channel with required number of bytes to cover the
> elapsed time. This prevents rate control reset, and avoids debug prints
> like below
>
> log:
> Resetting rate control (65692 samples)
> ...
> Resetting rate control (65721 samples)
> ...
>
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/display/xlnx_dp.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
> index fde3b21..7058443 100644
> --- a/hw/display/xlnx_dp.c
> +++ b/hw/display/xlnx_dp.c
> @@ -394,13 +394,18 @@ static void xlnx_dp_audio_callback(void *opaque, int avail)
> written = AUD_write(s->amixer_output_stream,
> &s->out_buffer[s->data_ptr], s->byte_left);
> } else {
> + int len_to_copy;
> /*
> * There is nothing to play.. We don't have any data! Fill the
> * buffer with zero's and send it.
> */
> written = 0;
> - memset(s->out_buffer, 0, 1024);
> - AUD_write(s->amixer_output_stream, s->out_buffer, 1024);
> + while (avail) {
> + len_to_copy = MIN(AUD_CHBUF_MAX_DEPTH, avail);
> + memset(s->out_buffer, 0, len_to_copy);
> + avail -= AUD_write(s->amixer_output_stream, s->out_buffer,
> + len_to_copy);
> + }
> }
> } else {
> written = AUD_write(s->amixer_output_stream,
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] display: xlnx_dp: Provide sufficient bytes for silent audio channel
2019-11-15 15:56 [PATCH] display: xlnx_dp: Provide sufficient bytes for silent audio channel Sai Pavan Boddu
2019-11-15 19:29 ` Alistair Francis
@ 2019-11-15 20:12 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-11-15 20:12 UTC (permalink / raw)
To: Sai Pavan Boddu, Alistair Francis, Edgar E. Iglesias,
Peter Maydell, KONRAD Frederic, Gerd Hoffmann
Cc: qemu-arm, qemu-devel
Cc'ing Gerd (Audio)
On 11/15/19 4:56 PM, Sai Pavan Boddu wrote:
> Fill the audio channel with required number of bytes to cover the
> elapsed time. This prevents rate control reset, and avoids debug prints
> like below
>
> log:
> Resetting rate control (65692 samples)
> ...
> Resetting rate control (65721 samples)
> ...
>
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> ---
> hw/display/xlnx_dp.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
> index fde3b21..7058443 100644
> --- a/hw/display/xlnx_dp.c
> +++ b/hw/display/xlnx_dp.c
> @@ -394,13 +394,18 @@ static void xlnx_dp_audio_callback(void *opaque, int avail)
> written = AUD_write(s->amixer_output_stream,
> &s->out_buffer[s->data_ptr], s->byte_left);
> } else {
> + int len_to_copy;
> /*
> * There is nothing to play.. We don't have any data! Fill the
> * buffer with zero's and send it.
> */
> written = 0;
> - memset(s->out_buffer, 0, 1024);
> - AUD_write(s->amixer_output_stream, s->out_buffer, 1024);
> + while (avail) {
> + len_to_copy = MIN(AUD_CHBUF_MAX_DEPTH, avail);
> + memset(s->out_buffer, 0, len_to_copy);
> + avail -= AUD_write(s->amixer_output_stream, s->out_buffer,
> + len_to_copy);
> + }
> }
> } else {
> written = AUD_write(s->amixer_output_stream,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-15 20:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 15:56 [PATCH] display: xlnx_dp: Provide sufficient bytes for silent audio channel Sai Pavan Boddu
2019-11-15 19:29 ` Alistair Francis
2019-11-15 20:12 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.