* [U-Boot] [PATCH] arm: socfpga: add kernel parameter for immediate reboot
@ 2019-11-21 15:09 Ooi, Joyce
2019-11-21 15:28 ` Simon Goldschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Ooi, Joyce @ 2019-11-21 15:09 UTC (permalink / raw)
To: u-boot
Add Linux kernel line parameters for Stratix10 U-Boot.
The "panic=-1" indicates the reset should occur immediately
(without a delay)
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
---
include/configs/socfpga_stratix10_socdk.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/socfpga_stratix10_socdk.h b/include/configs/socfpga_stratix10_socdk.h
index 8e6ecf4..09ea066 100644
--- a/include/configs/socfpga_stratix10_socdk.h
+++ b/include/configs/socfpga_stratix10_socdk.h
@@ -88,7 +88,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
* CONFIG_BOOTARGS goes into the environment value "bootargs".
* Do note the value will override also the chosen node in FDT blob.
*/
-#define CONFIG_BOOTARGS "earlycon"
+#define CONFIG_BOOTARGS "earlycon panic=-1"
#define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run linux_qspi_enable;" \
"run mmcboot"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: add kernel parameter for immediate reboot
2019-11-21 15:09 [U-Boot] [PATCH] arm: socfpga: add kernel parameter for immediate reboot Ooi, Joyce
@ 2019-11-21 15:28 ` Simon Goldschmidt
2019-11-21 15:31 ` Nguyen, Dinh
0 siblings, 1 reply; 3+ messages in thread
From: Simon Goldschmidt @ 2019-11-21 15:28 UTC (permalink / raw)
To: u-boot
On Thu, Nov 21, 2019 at 4:10 PM Ooi, Joyce <joyce.ooi@intel.com> wrote:
>
> Add Linux kernel line parameters for Stratix10 U-Boot.
> The "panic=-1" indicates the reset should occur immediately
> (without a delay)
>
> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
> Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
You might want to send socfpga patches to the U-Boot socfpga maintainers as
well...
> ---
> include/configs/socfpga_stratix10_socdk.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/socfpga_stratix10_socdk.h b/include/configs/socfpga_stratix10_socdk.h
> index 8e6ecf4..09ea066 100644
> --- a/include/configs/socfpga_stratix10_socdk.h
> +++ b/include/configs/socfpga_stratix10_socdk.h
> @@ -88,7 +88,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
> * CONFIG_BOOTARGS goes into the environment value "bootargs".
> * Do note the value will override also the chosen node in FDT blob.
> */
> -#define CONFIG_BOOTARGS "earlycon"
> +#define CONFIG_BOOTARGS "earlycon panic=-1"
That looks a bit like a hack. In my opinion, bootargs should be provided by
the boot configuration (e.g. included in devicetree), not hardcoded in the
bootloader.
I'd rather take a patch that removes this line than adding more.
Regards,
Simon
> #define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run linux_qspi_enable;" \
> "run mmcboot"
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: add kernel parameter for immediate reboot
2019-11-21 15:28 ` Simon Goldschmidt
@ 2019-11-21 15:31 ` Nguyen, Dinh
0 siblings, 0 replies; 3+ messages in thread
From: Nguyen, Dinh @ 2019-11-21 15:31 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Sent: Thursday, November 21, 2019 9:28 AM
> To: Ooi, Joyce <joyce.ooi@intel.com>
> Cc: See, Chin Liang <chin.liang.see@intel.com>; Nguyen, Dinh
> <dinh.nguyen@intel.com>; U-Boot Mailing List <u-boot@lists.denx.de>; Ang,
> Chee Hong <chee.hong.ang@intel.com>
> Subject: Re: [U-Boot] [PATCH] arm: socfpga: add kernel parameter for
> immediate reboot
>
> On Thu, Nov 21, 2019 at 4:10 PM Ooi, Joyce <joyce.ooi@intel.com> wrote:
> >
> > Add Linux kernel line parameters for Stratix10 U-Boot.
> > The "panic=-1" indicates the reset should occur immediately (without a
> > delay)
> >
> > Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
> > Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
>
> You might want to send socfpga patches to the U-Boot socfpga maintainers as
> well...
>
> > ---
> > include/configs/socfpga_stratix10_socdk.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/configs/socfpga_stratix10_socdk.h
> > b/include/configs/socfpga_stratix10_socdk.h
> > index 8e6ecf4..09ea066 100644
> > --- a/include/configs/socfpga_stratix10_socdk.h
> > +++ b/include/configs/socfpga_stratix10_socdk.h
> > @@ -88,7 +88,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
> > * CONFIG_BOOTARGS goes into the environment value "bootargs".
> > * Do note the value will override also the chosen node in FDT blob.
> > */
> > -#define CONFIG_BOOTARGS "earlycon"
> > +#define CONFIG_BOOTARGS "earlycon panic=-1"
>
> That looks a bit like a hack. In my opinion, bootargs should be provided by the
> boot configuration (e.g. included in devicetree), not hardcoded in the
> bootloader.
>
> I'd rather take a patch that removes this line than adding more.
Agreed! Also, what's the reason that you want to force an immediate reboot when a
panic happens?
Dinh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-21 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-21 15:09 [U-Boot] [PATCH] arm: socfpga: add kernel parameter for immediate reboot Ooi, Joyce
2019-11-21 15:28 ` Simon Goldschmidt
2019-11-21 15:31 ` Nguyen, Dinh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.