* [Buildroot] [PATCH v3] package/pkg-kconfig: fix reconfigure for kconfig packages
@ 2019-11-26 13:24 Angelo Compagnucci
2019-12-05 20:33 ` Thomas Petazzoni
2019-12-07 11:05 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Angelo Compagnucci @ 2019-11-26 13:24 UTC (permalink / raw)
To: buildroot
From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Commit 4b81badbcc0b25678ac6627548160702731cf393
Currently, calling foo-reconfigure for a kconfig-based package will not
re-trigger the configuration (kconfig-wise) step for the package.
was supposed to solve this problem and lately we had
Commit 05fea6e4a60a38a797d9bacbf318a2cd7dbd435f
infra/pkg-kconfig: do not rely on package's .config as a timestamp
that introduced the .stamp_dotconfig file.
For this reason, to trigger a kconfig package reconfigure is now
necessary to remove the .stamp_dotconfig file.
Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
package/pkg-kconfig.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-kconfig.mk b/package/pkg-kconfig.mk
index 86d7c14..f1931b8 100644
--- a/package/pkg-kconfig.mk
+++ b/package/pkg-kconfig.mk
@@ -175,7 +175,7 @@ $$($(2)_TARGET_CONFIGURE): $$($(2)_DIR)/.stamp_kconfig_fixup_done
$(1)-clean-for-reconfigure: $(1)-clean-kconfig-for-reconfigure
$(1)-clean-kconfig-for-reconfigure:
- rm -f $$($(2)_DIR)/.stamp_kconfig_fixup_done
+ rm -f $$($(2)_DIR)/$$($(2)_KCONFIG_STAMP_DOTCONFIG)
# Only enable the foo-*config targets when the package is actually enabled.
# Note: the variable $(2)_KCONFIG_VAR is not related to the kconfig
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v3] package/pkg-kconfig: fix reconfigure for kconfig packages
2019-11-26 13:24 [Buildroot] [PATCH v3] package/pkg-kconfig: fix reconfigure for kconfig packages Angelo Compagnucci
@ 2019-12-05 20:33 ` Thomas Petazzoni
2019-12-07 11:05 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-12-05 20:33 UTC (permalink / raw)
To: buildroot
On Tue, 26 Nov 2019 14:24:58 +0100
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>
> Commit 4b81badbcc0b25678ac6627548160702731cf393
>
> Currently, calling foo-reconfigure for a kconfig-based package will not
> re-trigger the configuration (kconfig-wise) step for the package.
>
> was supposed to solve this problem and lately we had
>
> Commit 05fea6e4a60a38a797d9bacbf318a2cd7dbd435f
>
> infra/pkg-kconfig: do not rely on package's .config as a timestamp
>
> that introduced the .stamp_dotconfig file.
>
> For this reason, to trigger a kconfig package reconfigure is now
> necessary to remove the .stamp_dotconfig file.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> package/pkg-kconfig.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v3] package/pkg-kconfig: fix reconfigure for kconfig packages
2019-11-26 13:24 [Buildroot] [PATCH v3] package/pkg-kconfig: fix reconfigure for kconfig packages Angelo Compagnucci
2019-12-05 20:33 ` Thomas Petazzoni
@ 2019-12-07 11:05 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-12-07 11:05 UTC (permalink / raw)
To: buildroot
>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
> From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> Commit 4b81badbcc0b25678ac6627548160702731cf393
> Currently, calling foo-reconfigure for a kconfig-based package will not
> re-trigger the configuration (kconfig-wise) step for the package.
> was supposed to solve this problem and lately we had
> Commit 05fea6e4a60a38a797d9bacbf318a2cd7dbd435f
> infra/pkg-kconfig: do not rely on package's .config as a timestamp
> that introduced the .stamp_dotconfig file.
> For this reason, to trigger a kconfig package reconfigure is now
> necessary to remove the .stamp_dotconfig file.
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
Committed to 2019.02.x, 2019.08.x and 2019.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-07 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 13:24 [Buildroot] [PATCH v3] package/pkg-kconfig: fix reconfigure for kconfig packages Angelo Compagnucci
2019-12-05 20:33 ` Thomas Petazzoni
2019-12-07 11:05 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.