* [Intel-gfx] [PATCH] drm/i915: Implement pps w/a #1124 for bxt+ @ 2019-12-09 21:39 Ville Syrjala 2019-12-09 23:29 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork 0 siblings, 1 reply; 2+ messages in thread From: Ville Syrjala @ 2019-12-09 21:39 UTC (permalink / raw) To: intel-gfx From: Ville Syrjälä <ville.syrjala@linux.intel.com> The panel power sequencer can get confused if we follow a PP_ON_DELAYS write with a PP_CONTROL power state target write. Apparently it can latch the old PP_ON_DELAYS value instead of the new one. Instead of mucking about with clock gating disables until we enable the power sequencer let's just do the trivial 100us+ delay. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 0f496115c345..9cb2ec91039f 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -6876,6 +6876,17 @@ intel_dp_init_panel_power_sequencer_registers(struct intel_dp *intel_dp, } else { u32 pp_ctl; + /* + * Display WA #1124: bxt,glk,cnl + * "WA: Wait at least 100us between programming + * PP_ON_DELAYS and enabling Power State Target in + * PP_CONTROL, or disable dpls clock gating before + * programming PP_ON_DELAYS and leave disabled until + * after enabling Power State Target in PP_CONTROL." + */ + if (INTEL_GEN(dev_priv) < 11) + usleep_range(100, 200); + pp_ctl = I915_READ(regs.pp_ctrl); pp_ctl &= ~BXT_POWER_CYCLE_DELAY_MASK; pp_ctl |= REG_FIELD_PREP(BXT_POWER_CYCLE_DELAY_MASK, DIV_ROUND_UP(seq->t11_t12, 1000)); -- 2.23.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Implement pps w/a #1124 for bxt+ 2019-12-09 21:39 [Intel-gfx] [PATCH] drm/i915: Implement pps w/a #1124 for bxt+ Ville Syrjala @ 2019-12-09 23:29 ` Patchwork 0 siblings, 0 replies; 2+ messages in thread From: Patchwork @ 2019-12-09 23:29 UTC (permalink / raw) To: Ville Syrjala; +Cc: intel-gfx == Series Details == Series: drm/i915: Implement pps w/a #1124 for bxt+ URL : https://patchwork.freedesktop.org/series/70655/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7523 -> Patchwork_15659 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_15659 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_15659, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_15659: ### IGT changes ### #### Possible regressions #### * igt@gem_wait@basic-busy-all: - fi-ivb-3770: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7523/fi-ivb-3770/igt@gem_wait@basic-busy-all.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/fi-ivb-3770/igt@gem_wait@basic-busy-all.html Known issues ------------ Here are the changes found in Patchwork_15659 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_sync@basic-each: - fi-tgl-y: [PASS][3] -> [INCOMPLETE][4] ([i915#707]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7523/fi-tgl-y/igt@gem_sync@basic-each.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/fi-tgl-y/igt@gem_sync@basic-each.html * igt@i915_selftest@live_gem_contexts: - fi-hsw-peppy: [PASS][5] -> [INCOMPLETE][6] ([i915#694]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7523/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html #### Possible fixes #### * igt@gem_exec_gttfill@basic: - {fi-tgl-u}: [INCOMPLETE][7] ([fdo#111593]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7523/fi-tgl-u/igt@gem_exec_gttfill@basic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/fi-tgl-u/igt@gem_exec_gttfill@basic.html * igt@i915_selftest@live_blt: - fi-ivb-3770: [DMESG-FAIL][9] ([i915#725]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7523/fi-ivb-3770/igt@i915_selftest@live_blt.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/fi-ivb-3770/igt@i915_selftest@live_blt.html - fi-hsw-4770: [DMESG-FAIL][11] -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7523/fi-hsw-4770/igt@i915_selftest@live_blt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/fi-hsw-4770/igt@i915_selftest@live_blt.html #### Warnings #### * igt@gem_exec_suspend@basic-s0: - fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7523/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html * igt@gem_exec_suspend@basic-s4-devices: - fi-kbl-x1275: [DMESG-WARN][15] ([fdo#107139] / [i915#62] / [i915#92]) -> [DMESG-WARN][16] ([fdo#107139] / [i915#62] / [i915#92] / [i915#95]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7523/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html * igt@kms_cursor_legacy@basic-flip-after-cursor-atomic: - fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92]) +3 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7523/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139 [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694 [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (52 -> 44) ------------------------------ Missing (8): fi-tgl-guc fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-whl-u fi-kbl-7560u fi-byt-clapper Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7523 -> Patchwork_15659 CI-20190529: 20190529 CI_DRM_7523: bbcf5f94e2ae795beec14cba06533ff3a9971cc0 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5341: 5fe683cdebde2d77d16ffc42c9fdf29a9f95bb82 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15659: 1a3b9aeca5bacf40843d0ca3e35ad1d174908a55 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 1a3b9aeca5ba drm/i915: Implement pps w/a #1124 for bxt+ == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15659/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-10 0:04 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-12-09 21:39 [Intel-gfx] [PATCH] drm/i915: Implement pps w/a #1124 for bxt+ Ville Syrjala 2019-12-09 23:29 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.