* [Intel-gfx] [PATCH] drm/i915/gt: Disable manual rc6 for Braswell/Baytrail
@ 2019-12-10 18:01 Chris Wilson
2019-12-11 4:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2019-12-11 21:25 ` [Intel-gfx] [PATCH] " Andi Shyti
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2019-12-10 18:01 UTC (permalink / raw)
To: intel-gfx
The initial investigated showed that while the PCU on Braswell/Baytrail
controlled RC6 itself. setting the software RC6 request made no
difference. Further testing reveals though that it causes a delay in the
PCU on enabling RC6.
Closes: https://gitlab.freedesktop.org/drm/intel/issues/763
Fixes: 730eaeb52426 ("drm/i915/gt: Manual rc6 entry upon parking")
Testcase: igt/perf/rc6-disable
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andi Shyti <andi.shyti@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/gt/intel_rc6.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
index 4dc82196b285..8ec2b7725141 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.c
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
@@ -612,6 +612,9 @@ void intel_rc6_park(struct intel_rc6 *rc6)
return;
}
+ if (!(rc6->ctl_enable & GEN6_RC_CTL_RC6_ENABLE))
+ return;
+
/* Turn off the HW timers and go directly to rc6 */
set(uncore, GEN6_RC_CONTROL, GEN6_RC_CTL_RC6_ENABLE);
set(uncore, GEN6_RC_STATE, 0x4 << RC_SW_TARGET_STATE_SHIFT);
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Disable manual rc6 for Braswell/Baytrail
2019-12-10 18:01 [Intel-gfx] [PATCH] drm/i915/gt: Disable manual rc6 for Braswell/Baytrail Chris Wilson
@ 2019-12-11 4:47 ` Patchwork
2019-12-11 21:25 ` [Intel-gfx] [PATCH] " Andi Shyti
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-12-11 4:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Disable manual rc6 for Braswell/Baytrail
URL : https://patchwork.freedesktop.org/series/70706/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7534 -> Patchwork_15678
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15678 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15678, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15678:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gt_pm:
- fi-kbl-7500u: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-kbl-7500u/igt@i915_selftest@live_gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-kbl-7500u/igt@i915_selftest@live_gt_pm.html
- fi-glk-dsi: [PASS][3] -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-glk-dsi/igt@i915_selftest@live_gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-glk-dsi/igt@i915_selftest@live_gt_pm.html
- fi-skl-6700k2: [PASS][5] -> [DMESG-FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-skl-6700k2/igt@i915_selftest@live_gt_pm.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-skl-6700k2/igt@i915_selftest@live_gt_pm.html
- fi-kbl-soraka: [PASS][7] -> [DMESG-FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-kbl-soraka/igt@i915_selftest@live_gt_pm.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-kbl-soraka/igt@i915_selftest@live_gt_pm.html
- fi-whl-u: [PASS][9] -> [DMESG-FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-whl-u/igt@i915_selftest@live_gt_pm.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-whl-u/igt@i915_selftest@live_gt_pm.html
- fi-cfl-guc: [PASS][11] -> [DMESG-FAIL][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-cfl-guc/igt@i915_selftest@live_gt_pm.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-cfl-guc/igt@i915_selftest@live_gt_pm.html
- fi-bxt-dsi: [PASS][13] -> [DMESG-FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-bxt-dsi/igt@i915_selftest@live_gt_pm.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-bxt-dsi/igt@i915_selftest@live_gt_pm.html
- fi-skl-6600u: [PASS][15] -> [DMESG-FAIL][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-skl-6600u/igt@i915_selftest@live_gt_pm.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-skl-6600u/igt@i915_selftest@live_gt_pm.html
- fi-cml-u2: [PASS][17] -> [DMESG-FAIL][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-cml-u2/igt@i915_selftest@live_gt_pm.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-cml-u2/igt@i915_selftest@live_gt_pm.html
- fi-apl-guc: [PASS][19] -> [DMESG-FAIL][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-apl-guc/igt@i915_selftest@live_gt_pm.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-apl-guc/igt@i915_selftest@live_gt_pm.html
- fi-cfl-8700k: [PASS][21] -> [DMESG-FAIL][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-cfl-8700k/igt@i915_selftest@live_gt_pm.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-cfl-8700k/igt@i915_selftest@live_gt_pm.html
- fi-kbl-r: [PASS][23] -> [DMESG-FAIL][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-kbl-r/igt@i915_selftest@live_gt_pm.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-kbl-r/igt@i915_selftest@live_gt_pm.html
- fi-kbl-x1275: NOTRUN -> [DMESG-FAIL][25]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-kbl-x1275/igt@i915_selftest@live_gt_pm.html
- fi-kbl-guc: [PASS][26] -> [DMESG-FAIL][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-kbl-guc/igt@i915_selftest@live_gt_pm.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-kbl-guc/igt@i915_selftest@live_gt_pm.html
- fi-skl-guc: [PASS][28] -> [DMESG-FAIL][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-skl-guc/igt@i915_selftest@live_gt_pm.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-skl-guc/igt@i915_selftest@live_gt_pm.html
- fi-bdw-5557u: [PASS][30] -> [DMESG-FAIL][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-bdw-5557u/igt@i915_selftest@live_gt_pm.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-bdw-5557u/igt@i915_selftest@live_gt_pm.html
- fi-skl-lmem: [PASS][32] -> [DMESG-FAIL][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-skl-lmem/igt@i915_selftest@live_gt_pm.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-skl-lmem/igt@i915_selftest@live_gt_pm.html
- fi-skl-6770hq: [PASS][34] -> [DMESG-FAIL][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-skl-6770hq/igt@i915_selftest@live_gt_pm.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-skl-6770hq/igt@i915_selftest@live_gt_pm.html
Known issues
------------
Here are the changes found in Patchwork_15678 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_requests:
- fi-hsw-4770: [PASS][36] -> [INCOMPLETE][37] ([i915#773])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-hsw-4770/igt@i915_selftest@live_requests.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-hsw-4770/igt@i915_selftest@live_requests.html
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- {fi-tgl-u}: [INCOMPLETE][38] ([fdo#111735]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-tgl-u/igt@gem_ctx_create@basic-files.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-tgl-u/igt@gem_ctx_create@basic-files.html
* igt@gem_sync@basic-each:
- fi-tgl-y: [INCOMPLETE][40] ([i915#707]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-tgl-y/igt@gem_sync@basic-each.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-tgl-y/igt@gem_sync@basic-each.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][42] ([fdo#111407]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-x1275: [DMESG-WARN][44] ([fdo#107139] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][45] ([fdo#107139] / [i915#62] / [i915#92])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_gem_contexts:
- fi-hsw-peppy: [INCOMPLETE][46] ([i915#694]) -> [DMESG-FAIL][47] ([i915#722])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-kbl-x1275: [DMESG-WARN][48] ([i915#62] / [i915#92]) -> [DMESG-WARN][49] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][50] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][51] ([i915#62] / [i915#92]) +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7534/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#773]: https://gitlab.freedesktop.org/drm/intel/issues/773
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (53 -> 47)
------------------------------
Additional (1): fi-hsw-4770r
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7534 -> Patchwork_15678
CI-20190529: 20190529
CI_DRM_7534: 66a6222c16abb82d6a4480b0a7ff8e375cc6a3a6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5342: 3e43fb3fa97ce25819444d63848439acf6e397b5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15678: 58917a3421cc18a151887fb985c595f751849c8c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
58917a3421cc drm/i915/gt: Disable manual rc6 for Braswell/Baytrail
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15678/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Disable manual rc6 for Braswell/Baytrail
2019-12-10 18:01 [Intel-gfx] [PATCH] drm/i915/gt: Disable manual rc6 for Braswell/Baytrail Chris Wilson
2019-12-11 4:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2019-12-11 21:25 ` Andi Shyti
2019-12-11 21:34 ` Chris Wilson
1 sibling, 1 reply; 4+ messages in thread
From: Andi Shyti @ 2019-12-11 21:25 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
Hi Chris,
> The initial investigated showed that while the PCU on Braswell/Baytrail
> controlled RC6 itself. setting the software RC6 request made no
> difference. Further testing reveals though that it causes a delay in the
> PCU on enabling RC6.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/763
> Fixes: 730eaeb52426 ("drm/i915/gt: Manual rc6 entry upon parking")
> Testcase: igt/perf/rc6-disable
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_rc6.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> index 4dc82196b285..8ec2b7725141 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> @@ -612,6 +612,9 @@ void intel_rc6_park(struct intel_rc6 *rc6)
> return;
> }
>
> + if (!(rc6->ctl_enable & GEN6_RC_CTL_RC6_ENABLE))
> + return;
> +
Huh? I didn't think this could be necessary! Nice catch!
Acked-by: Andi Shyti <andi.shyti@intel.com>
Thanks,
Andi
> /* Turn off the HW timers and go directly to rc6 */
> set(uncore, GEN6_RC_CONTROL, GEN6_RC_CTL_RC6_ENABLE);
> set(uncore, GEN6_RC_STATE, 0x4 << RC_SW_TARGET_STATE_SHIFT);
> --
> 2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Disable manual rc6 for Braswell/Baytrail
2019-12-11 21:25 ` [Intel-gfx] [PATCH] " Andi Shyti
@ 2019-12-11 21:34 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2019-12-11 21:34 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
Quoting Andi Shyti (2019-12-11 21:25:59)
> Hi Chris,
>
> > The initial investigated showed that while the PCU on Braswell/Baytrail
> > controlled RC6 itself. setting the software RC6 request made no
> > difference. Further testing reveals though that it causes a delay in the
> > PCU on enabling RC6.
> >
> > Closes: https://gitlab.freedesktop.org/drm/intel/issues/763
> > Fixes: 730eaeb52426 ("drm/i915/gt: Manual rc6 entry upon parking")
> > Testcase: igt/perf/rc6-disable
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Andi Shyti <andi.shyti@intel.com>
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > Cc: Imre Deak <imre.deak@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/intel_rc6.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > index 4dc82196b285..8ec2b7725141 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > @@ -612,6 +612,9 @@ void intel_rc6_park(struct intel_rc6 *rc6)
> > return;
> > }
> >
> > + if (!(rc6->ctl_enable & GEN6_RC_CTL_RC6_ENABLE))
> > + return;
> > +
>
> Huh? I didn't think this could be necessary! Nice catch!
Bah, CI takes all the credit. Stupid, stupid PCU.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-11 21:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 18:01 [Intel-gfx] [PATCH] drm/i915/gt: Disable manual rc6 for Braswell/Baytrail Chris Wilson
2019-12-11 4:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2019-12-11 21:25 ` [Intel-gfx] [PATCH] " Andi Shyti
2019-12-11 21:34 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.