All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][next] drm/i915/display: remove duplicated assignment to pointer crtc_state
@ 2019-12-10 14:45 ` Colin King
  0 siblings, 0 replies; 11+ messages in thread
From: Colin King @ 2019-12-10 14:45 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
	Daniel Vetter, Ville Syrjälä,
	intel-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Pointer crtc_state is being assigned twice, one of these is redundant
and can be removed.

Addresses-Coverity: ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 5c50b7d2db25..f3389d315b19 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -17751,7 +17751,7 @@ intel_modeset_setup_hw_state(struct drm_device *dev,
 
 	for_each_intel_crtc(&dev_priv->drm, crtc) {
 		struct intel_crtc_state *crtc_state =
-			crtc_state = to_intel_crtc_state(crtc->base.state);
+			to_intel_crtc_state(crtc->base.state);
 
 		intel_sanitize_crtc(crtc, ctx);
 		intel_dump_pipe_config(crtc_state, NULL, "[setup_hw_state]");
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2019-12-11 16:23 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 14:45 [PATCH][next] drm/i915/display: remove duplicated assignment to pointer crtc_state Colin King
2019-12-10 14:45 ` [Intel-gfx] " Colin King
2019-12-10 14:45 ` Colin King
2019-12-10 14:45 ` Colin King
2019-12-11  0:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2019-12-11  8:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: remove duplicated assignment to pointer crtc_state (rev2) Patchwork
2019-12-11 14:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2019-12-11 16:23 ` [PATCH][next] drm/i915/display: remove duplicated assignment to pointer crtc_state Ville Syrjälä
2019-12-11 16:23   ` [Intel-gfx] " Ville Syrjälä
2019-12-11 16:23   ` Ville Syrjälä
2019-12-11 16:23   ` Ville Syrjälä

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.