All of lore.kernel.org
 help / color / mirror / Atom feed
* hid-logitech-hidpp / hid-logitech-dj driver hiding inputs and breaking Logitech G700s buttons
@ 2019-12-15 19:34 Hamza Attak
  2019-12-16  0:49 ` Filipe Laíns
  0 siblings, 1 reply; 6+ messages in thread
From: Hamza Attak @ 2019-12-15 19:34 UTC (permalink / raw)
  To: nlopezcasad, benjamin.tissoires; +Cc: linux-input

Hi,

I have been facing an issue with my Logitech G700s mouse on wireless 
(id of
the receiver is 046d:c531).
Most of the buttons are not working, namely:
 G6, G7, G8, G9, G10

My testing has shown that when pressing these buttons, no input at all 
is
showing on both interfaces:
 /dev/input/by-id/usb-Logitech_USB_Receiver-if01-event-mouse
 /dev/input/by-id/usb-Logitech_USB_Receiver-if01-mouse

Further testing shown that having 'hid_logitech_dj' or 
'hid_logitech_hidpp'
module loaded is causing the issue, just one of them loaded is enough 
to create
the issue. This led me to contact you by looking at
'drivers/hid/hid-logitech-dj.c' and 'drivers/hid/hid-logitech-hidpp.c').
rmmod'ing the modules and using 'usbhid' module alone is solving the 
issue, as
Linux is now receiving correct input from the buttons.

Blacklisting the modules would do the trick for wireless on my local 
system, but
it doesn't seem right no to report this bug for others.

For info, it works perfectly wired, so I guess the issue might be with 
the dj
receiver code.

Before thinking of modifying the code myself, I am sending you this 
message and
see what would be a clean fix for the issue.

Thanks,
Hamza ATTAK.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: hid-logitech-hidpp / hid-logitech-dj driver hiding inputs and breaking Logitech G700s buttons
  2019-12-15 19:34 hid-logitech-hidpp / hid-logitech-dj driver hiding inputs and breaking Logitech G700s buttons Hamza Attak
@ 2019-12-16  0:49 ` Filipe Laíns
  2019-12-16  1:12   ` Hamza Attak
  0 siblings, 1 reply; 6+ messages in thread
From: Filipe Laíns @ 2019-12-16  0:49 UTC (permalink / raw)
  To: Hamza Attak, nlopezcasad, benjamin.tissoires; +Cc: linux-input

[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]

On Sun, 2019-12-15 at 19:34 +0000, Hamza Attak wrote:
> Hi,
> 
> I have been facing an issue with my Logitech G700s mouse on wireless 
> (id of
> the receiver is 046d:c531).
> Most of the buttons are not working, namely:
>  G6, G7, G8, G9, G10
> 
> My testing has shown that when pressing these buttons, no input at
> all 
> is
> showing on both interfaces:
>  /dev/input/by-id/usb-Logitech_USB_Receiver-if01-event-mouse
>  /dev/input/by-id/usb-Logitech_USB_Receiver-if01-mouse
> 
> Further testing shown that having 'hid_logitech_dj' or 
> 'hid_logitech_hidpp'
> module loaded is causing the issue, just one of them loaded is
> enough 
> to create
> the issue. This led me to contact you by looking at
> 'drivers/hid/hid-logitech-dj.c' and 'drivers/hid/hid-logitech-
> hidpp.c').
> rmmod'ing the modules and using 'usbhid' module alone is solving the 
> issue, as
> Linux is now receiving correct input from the buttons.
> 
> Blacklisting the modules would do the trick for wireless on my local 
> system, but
> it doesn't seem right no to report this bug for others.
> 
> For info, it works perfectly wired, so I guess the issue might be
> with 
> the dj
> receiver code.
> 
> Before thinking of modifying the code myself, I am sending you this 
> message and
> see what would be a clean fix for the issue.
> 
> Thanks,
> Hamza ATTAK.
> 

Hello Hamza,

Which kernel version are you using? I am pretty sure this is an issue
that was fixed in newer versions.

Thank you,
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: hid-logitech-hidpp / hid-logitech-dj driver hiding inputs and breaking Logitech G700s buttons
  2019-12-16  0:49 ` Filipe Laíns
@ 2019-12-16  1:12   ` Hamza Attak
  2019-12-16  1:48     ` Filipe Laíns
  0 siblings, 1 reply; 6+ messages in thread
From: Hamza Attak @ 2019-12-16  1:12 UTC (permalink / raw)
  To: Filipe Laíns; +Cc: nlopezcasad, benjamin.tissoires, linux-input

Hi Filipe,

I'm on the latest 5.4.3 from kernel from kernel.org git repository. Only
a few security options are tweaked in the kconfig.
For your information, I am also facing the same issue on untouched 
Ubuntu
built kernels,

I never followed linux-input before and don't know how active was the 
code
taking care of the G700s, but do you think there might have been a 
regression
since you say that it was a fixed issue?

Unfortunately, I didn't keep track on when it happened, ie after a 
kernel
upgrade or if it was always there and I only noticed after trying the 
mouse
wirelessly.

Thanks,
Hamza ATTAK.


On Mon, 16 Dec, 2019 at 12:49 AM, Filipe Laíns <lains@archlinux.org> 
wrote:
> On Sun, 2019-12-15 at 19:34 +0000, Hamza Attak wrote:
>>  Hi,
>> 
>>  I have been facing an issue with my Logitech G700s mouse on wireless
>>  (id of
>>  the receiver is 046d:c531).
>>  Most of the buttons are not working, namely:
>>   G6, G7, G8, G9, G10
>> 
>>  My testing has shown that when pressing these buttons, no input at
>>  all
>>  is
>>  showing on both interfaces:
>>   /dev/input/by-id/usb-Logitech_USB_Receiver-if01-event-mouse
>>   /dev/input/by-id/usb-Logitech_USB_Receiver-if01-mouse
>> 
>>  Further testing shown that having 'hid_logitech_dj' or
>>  'hid_logitech_hidpp'
>>  module loaded is causing the issue, just one of them loaded is
>>  enough
>>  to create
>>  the issue. This led me to contact you by looking at
>>  'drivers/hid/hid-logitech-dj.c' and 'drivers/hid/hid-logitech-
>>  hidpp.c').
>>  rmmod'ing the modules and using 'usbhid' module alone is solving the
>>  issue, as
>>  Linux is now receiving correct input from the buttons.
>> 
>>  Blacklisting the modules would do the trick for wireless on my local
>>  system, but
>>  it doesn't seem right no to report this bug for others.
>> 
>>  For info, it works perfectly wired, so I guess the issue might be
>>  with
>>  the dj
>>  receiver code.
>> 
>>  Before thinking of modifying the code myself, I am sending you this
>>  message and
>>  see what would be a clean fix for the issue.
>> 
>>  Thanks,
>>  Hamza ATTAK.
>> 
> 
> Hello Hamza,
> 
> Which kernel version are you using? I am pretty sure this is an issue
> that was fixed in newer versions.
> 
> Thank you,
> Filipe Laíns


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: hid-logitech-hidpp / hid-logitech-dj driver hiding inputs and breaking Logitech G700s buttons
  2019-12-16  1:12   ` Hamza Attak
@ 2019-12-16  1:48     ` Filipe Laíns
  2019-12-16 15:41       ` Benjamin Tissoires
  0 siblings, 1 reply; 6+ messages in thread
From: Filipe Laíns @ 2019-12-16  1:48 UTC (permalink / raw)
  To: Hamza Attak; +Cc: nlopezcasad, benjamin.tissoires, linux-input

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

On Mon, 2019-12-16 at 01:12 +0000, Hamza Attak wrote:
> Hi Filipe,
> 
> I'm on the latest 5.4.3 from kernel from kernel.org git repository. Only
> a few security options are tweaked in the kconfig.
> For your information, I am also facing the same issue on untouched 
> Ubuntu
> built kernels,
> 
> I never followed linux-input before and don't know how active was the 
> code
> taking care of the G700s, but do you think there might have been a 
> regression
> since you say that it was a fixed issue?
> 
> Unfortunately, I didn't keep track on when it happened, ie after a 
> kernel
> upgrade or if it was always there and I only noticed after trying the 
> mouse
> wirelessly.
> 
> Thanks,
> Hamza ATTAK.
> 

Okay. Do the logs show anything interesting?

I don't have the mouse but I think Benjamin does. Let's see if he knows
what's going on.

Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: hid-logitech-hidpp / hid-logitech-dj driver hiding inputs and breaking Logitech G700s buttons
  2019-12-16  1:48     ` Filipe Laíns
@ 2019-12-16 15:41       ` Benjamin Tissoires
  2019-12-16 17:33         ` Hamza Attak
  0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Tissoires @ 2019-12-16 15:41 UTC (permalink / raw)
  To: Filipe Laíns; +Cc: Hamza Attak, Nestor Lopez Casado, linux-input

On Mon, Dec 16, 2019 at 2:48 AM Filipe Laíns <lains@archlinux.org> wrote:
>
> On Mon, 2019-12-16 at 01:12 +0000, Hamza Attak wrote:
> > Hi Filipe,
> >
> > I'm on the latest 5.4.3 from kernel from kernel.org git repository. Only
> > a few security options are tweaked in the kconfig.
> > For your information, I am also facing the same issue on untouched
> > Ubuntu
> > built kernels,
> >
> > I never followed linux-input before and don't know how active was the
> > code
> > taking care of the G700s, but do you think there might have been a
> > regression
> > since you say that it was a fixed issue?
> >
> > Unfortunately, I didn't keep track on when it happened, ie after a
> > kernel
> > upgrade or if it was always there and I only noticed after trying the
> > mouse
> > wirelessly.
> >
> > Thanks,
> > Hamza ATTAK.
> >
>
> Okay. Do the logs show anything interesting?
>
> I don't have the mouse but I think Benjamin does. Let's see if he knows
> what's going on.

Hmm, I just gave a test on the G700 (not s) that I have, and  in both
cases (wired or not), I can see the incoming button events *when they
are mapped to something meaningful*.

FYI, 0xC531 wireless receiver has been added in v5.4, so that is when
you must have seen your problem appearing.

So:
- have you mapped any special buttons/macros to those buttons (G6-G10)?
- can we get the output of hid-recorder[1] so see what the mouse
actually sends (both in wired or wireless mode)?

Cheers,
Benjamin

[1] https://gitlab.freedesktop.org/libevdev/hid-tools

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: hid-logitech-hidpp / hid-logitech-dj driver hiding inputs and breaking Logitech G700s buttons
  2019-12-16 15:41       ` Benjamin Tissoires
@ 2019-12-16 17:33         ` Hamza Attak
  0 siblings, 0 replies; 6+ messages in thread
From: Hamza Attak @ 2019-12-16 17:33 UTC (permalink / raw)
  To: Benjamin Tissoires; +Cc: Filipe Laíns, Nestor Lopez Casado, linux-input

Hi Benjamin,

Yes I have macros on these buttons, most of them are the ones 
pre-recorded from
the Logitech Windows software (Previous, Forward, Ctrl+Tab, 
Ctrl+Shift+Tab). I
also have two custom ones which are Ctrl+W and Ctrl+T, respectively on 
G9 and
G10.

I do have an input recorded on hid-recorder. Thank you for the link.
Please find below the isolated output for each of the problematic 
buttons:

g06_ctrl_alt_tab.txt
	# ReportID: 16 /Vendor Defined Page 1 ['01', '41', '07', '12', '2a', 
'10']
	E: 000229.982728 7 10 01 41 07 12 2a 10
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000229.985686 9 02 00 00 00 00 00 00 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '81', '00', '10', '00', 
'00']
	E: 000229.993657 7 10 01 81 00 10 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '80', '00', '00', '00', 
'00']
	E: 000230.005685 7 10 01 80 00 00 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '81', '07', '01', '00', 
'00']
	E: 000230.017710 7 10 01 81 07 01 00 00
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000230.170755 9 02 00 00 00 00 00 00 00 00

g07_ctrl_tab.txt
	# ReportID: 16 /Vendor Defined Page 1 ['01', '41', '07', '12', '2a', 
'10']
	E: 000204.737718 7 10 01 41 07 12 2a 10
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000204.740705 9 02 00 00 00 00 00 00 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '81', '00', '10', '00', 
'00']
	E: 000204.748724 7 10 01 81 00 10 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '80', '00', '00', '00', 
'00']
	E: 000204.760914 7 10 01 80 00 00 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '81', '07', '01', '00', 
'00']
	E: 000204.772824 7 10 01 81 07 01 00 00
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000204.907710 9 02 00 00 00 00 00 00 00 00

g08_battery_level.txt (on-mice LED display only)
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000635.415154 9 02 00 00 00 00 00 00 00 00
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000635.718188 9 02 00 00 00 00 00 00 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '81', '07', '01', '00', 
'00']
	E: 000635.970283 7 10 01 81 07 01 00 00

g09_ctrl_w.txt
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000162.848869 9 02 00 00 00 00 00 00 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '41', '07', '12', '2a', 
'10']
	E: 000162.858891 7 10 01 41 07 12 2a 10
	# ReportID: 16 /Vendor Defined Page 1 ['01', '81', '00', '10', '00', 
'00']
	E: 000162.875925 7 10 01 81 00 10 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '80', '00', '00', '00', 
'00']
	E: 000162.887846 7 10 01 80 00 00 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '81', '07', '01', '00', 
'00']
	E: 000162.899826 7 10 01 81 07 01 00 00
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000163.100815 9 02 00 00 00 00 00 00 00 00

g10_ctrl_t.txt
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000046.352043 9 02 00 00 00 00 00 00 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '41', '07', '12', '2a', 
'10']
	E: 000046.364976 7 10 01 41 07 12 2a 10
	# ReportID: 16 /Vendor Defined Page 1 ['01', '81', '00', '10', '00', 
'00']
	E: 000046.381939 7 10 01 81 00 10 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '80', '00', '00', '00', 
'00']
	E: 000046.394148 7 10 01 80 00 00 00 00
	# ReportID: 16 /Vendor Defined Page 1 ['01', '81', '07', '01', '00', 
'00']
	E: 000046.406072 7 10 01 81 07 01 00 00
	# ReportID: 2 / Button: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
	| X: 0 | Y: 0 | Wheel: 0 | AC Pan: 0
	E: 000046.600971 9 02 00 00 00 00 00 00 00 00

For info, all the mouse functionalities seems to work fine with bare 
usbhid
driver and upower picking up the battery level, is there a feature 
added or a
specific reason to use Logitech drivers?

Thanks,
Hamza.


On Mon, 16 Dec, 2019 at 3:41 PM, Benjamin Tissoires 
<benjamin.tissoires@gmail.com> wrote:
> On Mon, Dec 16, 2019 at 2:48 AM Filipe Laíns <lains@archlinux.org> 
> wrote:
>> 
>>  On Mon, 2019-12-16 at 01:12 +0000, Hamza Attak wrote:
>>  > Hi Filipe,
>>  >
>>  > I'm on the latest 5.4.3 from kernel from kernel.org git 
>> repository. Only
>>  > a few security options are tweaked in the kconfig.
>>  > For your information, I am also facing the same issue on untouched
>>  > Ubuntu
>>  > built kernels,
>>  >
>>  > I never followed linux-input before and don't know how active was 
>> the
>>  > code
>>  > taking care of the G700s, but do you think there might have been a
>>  > regression
>>  > since you say that it was a fixed issue?
>>  >
>>  > Unfortunately, I didn't keep track on when it happened, ie after a
>>  > kernel
>>  > upgrade or if it was always there and I only noticed after trying 
>> the
>>  > mouse
>>  > wirelessly.
>>  >
>>  > Thanks,
>>  > Hamza ATTAK.
>>  >
>> 
>>  Okay. Do the logs show anything interesting?
>> 
>>  I don't have the mouse but I think Benjamin does. Let's see if he 
>> knows
>>  what's going on.
> 
> Hmm, I just gave a test on the G700 (not s) that I have, and  in both
> cases (wired or not), I can see the incoming button events *when they
> are mapped to something meaningful*.
> 
> FYI, 0xC531 wireless receiver has been added in v5.4, so that is when
> you must have seen your problem appearing.
> 
> So:
> - have you mapped any special buttons/macros to those buttons 
> (G6-G10)?
> - can we get the output of hid-recorder[1] so see what the mouse
> actually sends (both in wired or wireless mode)?
> 
> Cheers,
> Benjamin
> 
> [1] https://gitlab.freedesktop.org/libevdev/hid-tools


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-12-16 17:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-15 19:34 hid-logitech-hidpp / hid-logitech-dj driver hiding inputs and breaking Logitech G700s buttons Hamza Attak
2019-12-16  0:49 ` Filipe Laíns
2019-12-16  1:12   ` Hamza Attak
2019-12-16  1:48     ` Filipe Laíns
2019-12-16 15:41       ` Benjamin Tissoires
2019-12-16 17:33         ` Hamza Attak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.