* [Intel-gfx] [PATCH v4 i-g-t 1/2] NOMERGE: Import drm.h up to 54ecb8f7028c
@ 2019-12-17 3:48 Juston Li
2019-12-17 3:48 ` [Intel-gfx] [PATCH v4 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests Juston Li
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Juston Li @ 2019-12-17 3:48 UTC (permalink / raw)
To: igt-dev, intel-gfx, ville.syrjala, daniel
Depends on ummerged kernel code for getfb2
Rest of drm.h taken from:
commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon Sep 30 10:35:40 2019 -0700
Linux 5.4-rc1
Signed-off-by: Juston Li <juston.li@intel.com>
---
include/drm-uapi/drm.h | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/include/drm-uapi/drm.h b/include/drm-uapi/drm.h
index 85c685a2075e..0b02f4c92d1e 100644
--- a/include/drm-uapi/drm.h
+++ b/include/drm-uapi/drm.h
@@ -643,6 +643,7 @@ struct drm_gem_open {
#define DRM_CAP_PAGE_FLIP_TARGET 0x11
#define DRM_CAP_CRTC_IN_VBLANK_EVENT 0x12
#define DRM_CAP_SYNCOBJ 0x13
+#define DRM_CAP_SYNCOBJ_TIMELINE 0x14
/** DRM_IOCTL_GET_CAP ioctl argument type */
struct drm_get_cap {
@@ -729,8 +730,18 @@ struct drm_syncobj_handle {
__u32 pad;
};
+struct drm_syncobj_transfer {
+ __u32 src_handle;
+ __u32 dst_handle;
+ __u64 src_point;
+ __u64 dst_point;
+ __u32 flags;
+ __u32 pad;
+};
+
#define DRM_SYNCOBJ_WAIT_FLAGS_WAIT_ALL (1 << 0)
#define DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT (1 << 1)
+#define DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE (1 << 2) /* wait for time point to become available */
struct drm_syncobj_wait {
__u64 handles;
/* absolute timeout */
@@ -741,12 +752,33 @@ struct drm_syncobj_wait {
__u32 pad;
};
+struct drm_syncobj_timeline_wait {
+ __u64 handles;
+ /* wait on specific timeline point for every handles*/
+ __u64 points;
+ /* absolute timeout */
+ __s64 timeout_nsec;
+ __u32 count_handles;
+ __u32 flags;
+ __u32 first_signaled; /* only valid when not waiting all */
+ __u32 pad;
+};
+
+
struct drm_syncobj_array {
__u64 handles;
__u32 count_handles;
__u32 pad;
};
+struct drm_syncobj_timeline_array {
+ __u64 handles;
+ __u64 points;
+ __u32 count_handles;
+ __u32 pad;
+};
+
+
/* Query current scanout sequence number */
struct drm_crtc_get_sequence {
__u32 crtc_id; /* requested crtc_id */
@@ -903,6 +935,13 @@ extern "C" {
#define DRM_IOCTL_MODE_GET_LEASE DRM_IOWR(0xC8, struct drm_mode_get_lease)
#define DRM_IOCTL_MODE_REVOKE_LEASE DRM_IOWR(0xC9, struct drm_mode_revoke_lease)
+#define DRM_IOCTL_SYNCOBJ_TIMELINE_WAIT DRM_IOWR(0xCA, struct drm_syncobj_timeline_wait)
+#define DRM_IOCTL_SYNCOBJ_QUERY DRM_IOWR(0xCB, struct drm_syncobj_timeline_array)
+#define DRM_IOCTL_SYNCOBJ_TRANSFER DRM_IOWR(0xCC, struct drm_syncobj_transfer)
+#define DRM_IOCTL_SYNCOBJ_TIMELINE_SIGNAL DRM_IOWR(0xCD, struct drm_syncobj_timeline_array)
+
+#define DRM_IOCTL_MODE_GETFB2 DRM_IOWR(0xCE, struct drm_mode_fb_cmd2)
+
/**
* Device specific ioctls should only be in their respective headers
* The device specific ioctl range is from 0x40 to 0x9f.
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH v4 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests
2019-12-17 3:48 [Intel-gfx] [PATCH v4 i-g-t 1/2] NOMERGE: Import drm.h up to 54ecb8f7028c Juston Li
@ 2019-12-17 3:48 ` Juston Li
2020-01-13 17:21 ` [igt-dev] " Ville Syrjälä
2019-12-17 4:25 ` [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [v4,i-g-t,1/2] NOMERGE: Import drm.h up to 54ecb8f7028c Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Juston Li @ 2019-12-17 3:48 UTC (permalink / raw)
To: igt-dev, intel-gfx, ville.syrjala, daniel; +Cc: Daniel Stone
From: Daniel Stone <daniels@collabora.com>
Mirroring addfb2, add tests for the new ioctl which will return us
information about framebuffers containing multiple buffers, as well as
modifiers.
Changes since v3:
- Add subtests to ensure handles aren't returned for non-root and
non-master callers
- Fix getfb2-handle-not-fb to use getfb2
Changes since v1:
- Add test that uses getfb2 output to call addfb2 as suggested by Ville
Signed-off-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: Juston Li <juston.li@intel.com>
---
tests/kms_getfb.c | 160 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 160 insertions(+)
diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
index ca0b01c05e5c..ffd8f9117c92 100644
--- a/tests/kms_getfb.c
+++ b/tests/kms_getfb.c
@@ -40,6 +40,8 @@
#include "drm.h"
#include "drm_fourcc.h"
+#include "igt_device.h"
+
static bool has_getfb_iface(int fd)
{
struct drm_mode_fb_cmd arg = { };
@@ -228,6 +230,158 @@ static void test_duplicate_handles(int fd)
}
}
+static void test_getfb2(int fd)
+{
+ struct drm_mode_fb_cmd2 add_basic = {};
+
+ igt_fixture {
+ struct drm_mode_fb_cmd2 get = {};
+
+ add_basic.width = 1024;
+ add_basic.height = 1024;
+ add_basic.pixel_format = DRM_FORMAT_XRGB8888;
+ add_basic.pitches[0] = 1024*4;
+ add_basic.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
+ DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+ igt_assert(add_basic.handles[0]);
+ do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add_basic);
+
+ get.fb_id = add_basic.fb_id;
+ do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &get);
+ igt_assert_neq_u32(get.handles[0], 0);
+ gem_close(fd, get.handles[0]);
+ }
+
+ igt_subtest("getfb2-handle-zero") {
+ struct drm_mode_fb_cmd2 get = {};
+ do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT);
+ }
+
+ igt_subtest("getfb2-handle-closed") {
+ struct drm_mode_fb_cmd2 add = add_basic;
+ struct drm_mode_fb_cmd2 get = { };
+
+ add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
+ DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+ igt_assert(add.handles[0]);
+ do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
+ do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &add.fb_id);
+
+ get.fb_id = add.fb_id;
+ do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT);
+ gem_close(fd, add.handles[0]);
+ }
+
+ igt_subtest("getfb2-handle-not-fb") {
+ struct drm_mode_fb_cmd2 get = { .fb_id = get_any_prop_id(fd) };
+ igt_require(get.fb_id > 0);
+ do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT);
+ }
+
+ igt_subtest("getfb2-accept-ccs") {
+ struct drm_mode_fb_cmd2 add_ccs = { };
+ struct drm_mode_fb_cmd2 get = { };
+ int i;
+
+ get_ccs_fb(fd, &add_ccs);
+ igt_require(add_ccs.fb_id != 0);
+ get.fb_id = add_ccs.fb_id;
+ do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &get);
+
+ igt_assert_eq_u32(get.width, add_ccs.width);
+ igt_assert_eq_u32(get.height, add_ccs.height);
+ igt_assert(get.flags & DRM_MODE_FB_MODIFIERS);
+
+ for (i = 0; i < ARRAY_SIZE(get.handles); i++) {
+ igt_assert_eq_u32(get.pitches[i], add_ccs.pitches[i]);
+ igt_assert_eq_u32(get.offsets[i], add_ccs.offsets[i]);
+ if (add_ccs.handles[i] != 0) {
+ igt_assert_neq_u32(get.handles[i], 0);
+ igt_assert_neq_u32(get.handles[i],
+ add_ccs.handles[i]);
+ igt_assert_eq_u64(get.modifier[i],
+ add_ccs.modifier[i]);
+ } else {
+ igt_assert_eq_u32(get.handles[i], 0);
+ igt_assert_eq_u64(get.modifier[i], 0);
+ }
+ }
+ igt_assert_eq_u32(get.handles[0], get.handles[1]);
+
+ do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &get.fb_id);
+ gem_close(fd, add_ccs.handles[0]);
+ gem_close(fd, get.handles[0]);
+ }
+
+ igt_subtest("getfb2-into-addfb2") {
+ struct drm_mode_fb_cmd2 cmd = { };
+
+ cmd.fb_id = add_basic.fb_id;
+ do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &cmd);
+ do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &cmd);
+
+ do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &cmd.fb_id);
+ gem_close(fd, cmd.handles[0]);
+ }
+
+ igt_fixture {
+ do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &add_basic.fb_id);
+ gem_close(fd, add_basic.handles[0]);
+ }
+}
+
+static void test_handle_protection(void) {
+ int non_master_fd;
+ struct drm_mode_fb_cmd2 non_master_add = {};
+
+ igt_fixture {
+ non_master_fd = drm_open_driver(DRIVER_ANY);
+
+ non_master_add.width = 1024;
+ non_master_add.height = 1024;
+ non_master_add.pixel_format = DRM_FORMAT_XRGB8888;
+ non_master_add.pitches[0] = 1024*4;
+ non_master_add.handles[0] = igt_create_bo_with_dimensions(non_master_fd, 1024, 1024,
+ DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+ igt_require(non_master_add.handles[0] != 0);
+ do_ioctl(non_master_fd, DRM_IOCTL_MODE_ADDFB2, &non_master_add);
+ }
+
+ igt_subtest("getfb-handle-protection") {
+ struct drm_mode_fb_cmd get = { .fb_id = non_master_add.fb_id};
+
+ igt_fork(child, 1) {
+ igt_drop_root();
+
+ do_ioctl(non_master_fd, DRM_IOCTL_MODE_GETFB, &get);
+ /* ioctl succeeds but handle should be 0 */
+ igt_assert_eq_u32(get.handle, 0);
+ }
+ igt_waitchildren();
+ }
+
+ igt_subtest("getfb2-handle-protection") {
+ struct drm_mode_fb_cmd2 get = { .fb_id = non_master_add.fb_id};
+ int i;
+
+ igt_fork(child, 1) {
+ igt_drop_root();
+
+ do_ioctl(non_master_fd, DRM_IOCTL_MODE_GETFB2, &get);
+ /* ioctl succeeds but handles should be 0 */
+ for (i = 0; i < ARRAY_SIZE(get.handles); i++) {
+ igt_assert_eq_u32(get.handles[i], 0);
+ }
+ }
+ igt_waitchildren();
+ }
+
+ igt_fixture {
+ do_ioctl(non_master_fd, DRM_IOCTL_MODE_RMFB, &non_master_add.fb_id);
+ gem_close(non_master_fd, non_master_add.handles[0]);
+ }
+}
+
igt_main
{
int fd;
@@ -243,6 +397,12 @@ igt_main
igt_subtest_group
test_duplicate_handles(fd);
+ igt_subtest_group
+ test_getfb2(fd);
+
+ igt_subtest_group
+ test_handle_protection();
+
igt_fixture
close(fd);
}
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [v4,i-g-t,1/2] NOMERGE: Import drm.h up to 54ecb8f7028c
2019-12-17 3:48 [Intel-gfx] [PATCH v4 i-g-t 1/2] NOMERGE: Import drm.h up to 54ecb8f7028c Juston Li
2019-12-17 3:48 ` [Intel-gfx] [PATCH v4 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests Juston Li
@ 2019-12-17 4:25 ` Patchwork
2019-12-17 4:44 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-12-17 11:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-12-17 4:25 UTC (permalink / raw)
To: Juston Li; +Cc: igt-dev
== Series Details ==
Series: series starting with [v4,i-g-t,1/2] NOMERGE: Import drm.h up to 54ecb8f7028c
URL : https://patchwork.freedesktop.org/series/71025/
State : failure
== Summary ==
ERROR! This series introduces new undocumented tests:
kms_getfb@getfb-handle-protection
kms_getfb@getfb2-accept-ccs
kms_getfb@getfb2-handle-closed
kms_getfb@getfb2-handle-not-fb
kms_getfb@getfb2-handle-protection
kms_getfb@getfb2-handle-zero
kms_getfb@getfb2-into-addfb2
Can you document them as per the requirement in the [CONTRIBUTING.md]?
[Documentation] has more details on how to do this.
Here are few examples:
https://gitlab.freedesktop.org/drm/igt-gpu-tools/commit/0316695d03aa46108296b27f3982ec93200c7a6e
https://gitlab.freedesktop.org/drm/igt-gpu-tools/commit/443cc658e1e6b492ee17bf4f4d891029eb7a205d
Thanks in advance!
[CONTRIBUTING.md]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/CONTRIBUTING.md#L19
[Documentation]: https://drm.pages.freedesktop.org/igt-gpu-tools/igt-gpu-tools-Core.html#igt-describe
Other than that, pipeline status: SUCCESS.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/89624 for the overview.
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/89624
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v4,i-g-t,1/2] NOMERGE: Import drm.h up to 54ecb8f7028c
2019-12-17 3:48 [Intel-gfx] [PATCH v4 i-g-t 1/2] NOMERGE: Import drm.h up to 54ecb8f7028c Juston Li
2019-12-17 3:48 ` [Intel-gfx] [PATCH v4 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests Juston Li
2019-12-17 4:25 ` [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [v4,i-g-t,1/2] NOMERGE: Import drm.h up to 54ecb8f7028c Patchwork
@ 2019-12-17 4:44 ` Patchwork
2019-12-17 11:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-12-17 4:44 UTC (permalink / raw)
To: Juston Li; +Cc: igt-dev
== Series Details ==
Series: series starting with [v4,i-g-t,1/2] NOMERGE: Import drm.h up to 54ecb8f7028c
URL : https://patchwork.freedesktop.org/series/71025/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7578 -> IGTPW_3870
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/index.html
Known issues
------------
Here are the changes found in IGTPW_3870 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-skl-6700k2: [PASS][1] -> [INCOMPLETE][2] ([i915#69])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-skl-6700k2/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-skl-6700k2/igt@gem_exec_suspend@basic-s3.html
#### Possible fixes ####
* igt@gem_exec_parallel@basic:
- {fi-tgl-u}: [INCOMPLETE][3] ([i915#476]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-tgl-u/igt@gem_exec_parallel@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-tgl-u/igt@gem_exec_parallel@basic.html
* igt@gem_exec_suspend@basic-s3:
- fi-icl-u2: [FAIL][5] ([fdo#103375]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-u2: [FAIL][7] ([fdo#111550]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][9] ([i915#553] / [i915#725]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [DMESG-FAIL][11] ([i915#722]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
- fi-cfl-guc: [DMESG-FAIL][13] ([i915#730]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][15] ([fdo#109635] / [i915#217]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@kms_busy@basic-flip-pipe-a:
- fi-icl-u2: [INCOMPLETE][19] ([i915#140]) -> [TIMEOUT][20] ([i915#449])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][21] ([fdo#111096] / [i915#323]) -> [FAIL][22] ([fdo#111407])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][24] ([i915#62] / [i915#92]) +12 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#449]: https://gitlab.freedesktop.org/drm/intel/issues/449
[i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#730]: https://gitlab.freedesktop.org/drm/intel/issues/730
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (51 -> 44)
------------------------------
Additional (1): fi-kbl-soraka
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5349 -> IGTPW_3870
CI-20190529: 20190529
CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3870: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/index.html
IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_getfb@getfb2-accept-ccs
+igt@kms_getfb@getfb2-handle-closed
+igt@kms_getfb@getfb2-handle-not-fb
+igt@kms_getfb@getfb2-handle-protection
+igt@kms_getfb@getfb2-handle-zero
+igt@kms_getfb@getfb2-into-addfb2
+igt@kms_getfb@getfb-handle-protection
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [v4,i-g-t,1/2] NOMERGE: Import drm.h up to 54ecb8f7028c
2019-12-17 3:48 [Intel-gfx] [PATCH v4 i-g-t 1/2] NOMERGE: Import drm.h up to 54ecb8f7028c Juston Li
` (2 preceding siblings ...)
2019-12-17 4:44 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2019-12-17 11:44 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-12-17 11:44 UTC (permalink / raw)
To: Juston Li; +Cc: igt-dev
== Series Details ==
Series: series starting with [v4,i-g-t,1/2] NOMERGE: Import drm.h up to 54ecb8f7028c
URL : https://patchwork.freedesktop.org/series/71025/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7578_full -> IGTPW_3870_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3870_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_getfb@getfb-handle-protection} (NEW):
- shard-tglb: NOTRUN -> [WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb5/igt@kms_getfb@getfb-handle-protection.html
- shard-glk: NOTRUN -> [WARN][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-glk4/igt@kms_getfb@getfb-handle-protection.html
- shard-iclb: NOTRUN -> [WARN][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb8/igt@kms_getfb@getfb-handle-protection.html
- shard-apl: NOTRUN -> [WARN][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-apl6/igt@kms_getfb@getfb-handle-protection.html
- shard-kbl: NOTRUN -> [WARN][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-kbl2/igt@kms_getfb@getfb-handle-protection.html
* {igt@kms_getfb@getfb2-accept-ccs} (NEW):
- shard-hsw: NOTRUN -> [FAIL][6] +4 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-hsw5/igt@kms_getfb@getfb2-accept-ccs.html
* {igt@kms_getfb@getfb2-handle-protection} (NEW):
- shard-apl: NOTRUN -> [FAIL][7] +5 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-apl6/igt@kms_getfb@getfb2-handle-protection.html
* {igt@kms_getfb@getfb2-handle-zero} (NEW):
- shard-glk: NOTRUN -> [FAIL][8] +5 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-glk9/igt@kms_getfb@getfb2-handle-zero.html
New tests
---------
New tests have been introduced between CI_DRM_7578_full and IGTPW_3870_full:
### New IGT tests (7) ###
* igt@kms_getfb@getfb-handle-protection:
- Statuses : 5 warn(s)
- Exec time: [0.01, 0.02] s
* igt@kms_getfb@getfb2-accept-ccs:
- Statuses : 5 fail(s)
- Exec time: [0.0] s
* igt@kms_getfb@getfb2-handle-closed:
- Statuses : 5 fail(s)
- Exec time: [0.0] s
* igt@kms_getfb@getfb2-handle-not-fb:
- Statuses : 5 fail(s)
- Exec time: [0.0] s
* igt@kms_getfb@getfb2-handle-protection:
- Statuses : 6 fail(s)
- Exec time: [0.01, 0.03] s
* igt@kms_getfb@getfb2-handle-zero:
- Statuses : 4 fail(s)
- Exec time: [0.0] s
* igt@kms_getfb@getfb2-into-addfb2:
- Statuses : 4 fail(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_3870_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276] / [fdo#112080])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_exec_gttfill@basic:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111593])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_exec_gttfill@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb5/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_parallel@fds:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([i915#470])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@gem_exec_parallel@fds.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb4/igt@gem_exec_parallel@fds.html
* igt@gem_exec_schedule@fifo-bsd1:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109276]) +5 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@gem_exec_schedule@fifo-bsd1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb3/igt@gem_exec_schedule@fifo-bsd1.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@i915_selftest@live_gt_timelines:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([i915#455])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@i915_selftest@live_gt_timelines.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb6/igt@i915_selftest@live_gt_timelines.html
* igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge:
- shard-hsw: [PASS][21] -> [INCOMPLETE][22] ([i915#61])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw4/igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-hsw5/igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#49])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-glk7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
- shard-kbl: [PASS][25] -> [FAIL][26] ([i915#49])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
- shard-apl: [PASS][27] -> [FAIL][28] ([i915#49])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#180]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [PASS][31] -> [INCOMPLETE][32] ([i915#123] / [i915#140])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-pwrite:
- shard-tglb: [PASS][33] -> [FAIL][34] ([i915#49]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-pwrite.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-tglb: [PASS][35] -> [INCOMPLETE][36] ([i915#456] / [i915#460])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@psr-suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb3/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][41] -> [FAIL][42] ([i915#31])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-apl4/igt@kms_setmode@basic.html
* igt@perf_pmu@busy-accuracy-2-vcs1:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#112080]) +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb2/igt@perf_pmu@busy-accuracy-2-vcs1.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb6/igt@perf_pmu@busy-accuracy-2-vcs1.html
#### Possible fixes ####
* igt@gem_busy@close-race:
- shard-tglb: [INCOMPLETE][45] ([i915#435]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb2/igt@gem_busy@close-race.html
* igt@gem_ctx_isolation@bcs0-s3:
- shard-tglb: [INCOMPLETE][47] ([i915#456]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb4/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_persistence@vcs0-mixed-process:
- shard-apl: [FAIL][49] ([i915#679]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [SKIP][51] ([fdo#109276] / [fdo#112080]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_eio@banned:
- shard-tglb: [INCOMPLETE][53] ([i915#476]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb7/igt@gem_eio@banned.html
* igt@gem_eio@suspend:
- shard-tglb: [INCOMPLETE][55] ([i915#460]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_eio@suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb9/igt@gem_eio@suspend.html
* {igt@gem_exec_schedule@pi-common-bsd1}:
- shard-iclb: [SKIP][57] ([fdo#109276]) -> [PASS][58] +8 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb3/igt@gem_exec_schedule@pi-common-bsd1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb1/igt@gem_exec_schedule@pi-common-bsd1.html
* {igt@gem_exec_schedule@pi-distinct-iova-bsd}:
- shard-iclb: [SKIP][59] ([i915#677]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb2/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@gem_exec_schedule@preempt-bsd.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb3/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_exec_schedule@preempt-queue-contexts-vebox:
- shard-tglb: [INCOMPLETE][63] ([fdo#111677]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb2/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
* {igt@gen7_exec_parse@basic-allocation}:
- shard-hsw: [FAIL][65] ([i915#819]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@gen7_exec_parse@basic-allocation.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-hsw7/igt@gen7_exec_parse@basic-allocation.html
* {igt@gen9_exec_parse@allowed-single}:
- shard-glk: [DMESG-WARN][67] ([i915#716]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-glk3/igt@gen9_exec_parse@allowed-single.html
- shard-apl: [DMESG-WARN][69] ([i915#716]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-apl3/igt@gen9_exec_parse@allowed-single.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][71] ([i915#180]) -> [PASS][72] +3 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
- shard-hsw: [DMESG-WARN][73] ([IGT#6]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-hsw1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-tglb: [INCOMPLETE][75] ([i915#456] / [i915#460]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][77] ([i915#79]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: [FAIL][79] ([i915#79]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-apl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
- shard-glk: [FAIL][81] ([i915#49]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-tglb: [FAIL][83] ([i915#49]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-iclb: [DMESG-WARN][85] ([fdo#111764]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb2/igt@kms_frontbuffer_tracking@psr-suspend.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb2/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-WARN][87] ([i915#180]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][89] ([fdo#109441]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@perf_pmu@render-node-busy-idle-vcs1:
- shard-iclb: [SKIP][91] ([fdo#112080]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb5/igt@perf_pmu@render-node-busy-idle-vcs1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-iclb2/igt@perf_pmu@render-node-busy-idle-vcs1.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs2-dirty-create:
- shard-tglb: [SKIP][93] ([fdo#111912] / [fdo#112080]) -> [SKIP][94] ([fdo#112080])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_ctx_isolation@vcs2-dirty-create.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/shard-tglb9/igt@gem_ctx_isolation@vcs2-dirty-create.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
[fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
[i915#455]: https://gitlab.freedesktop.org/drm/intel/issues/455
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
[i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
[i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#819]: https://gitlab.freedesktop.org/drm/intel/issues/819
Participating hosts (10 -> 8)
------------------------------
Missing (2): pig-skl-6260u pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5349 -> IGTPW_3870
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3870: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/index.html
IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3870/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH v4 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests
2019-12-17 3:48 ` [Intel-gfx] [PATCH v4 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests Juston Li
@ 2020-01-13 17:21 ` Ville Syrjälä
0 siblings, 0 replies; 7+ messages in thread
From: Ville Syrjälä @ 2020-01-13 17:21 UTC (permalink / raw)
To: Juston Li; +Cc: igt-dev, intel-gfx, Daniel Stone
On Mon, Dec 16, 2019 at 07:48:40PM -0800, Juston Li wrote:
> From: Daniel Stone <daniels@collabora.com>
>
> Mirroring addfb2, add tests for the new ioctl which will return us
> information about framebuffers containing multiple buffers, as well as
> modifiers.
>
> Changes since v3:
> - Add subtests to ensure handles aren't returned for non-root and
> non-master callers
> - Fix getfb2-handle-not-fb to use getfb2
>
> Changes since v1:
> - Add test that uses getfb2 output to call addfb2 as suggested by Ville
>
> Signed-off-by: Daniel Stone <daniels@collabora.com>
> Signed-off-by: Juston Li <juston.li@intel.com>
> ---
> tests/kms_getfb.c | 160 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 160 insertions(+)
>
> diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
> index ca0b01c05e5c..ffd8f9117c92 100644
> --- a/tests/kms_getfb.c
> +++ b/tests/kms_getfb.c
> @@ -40,6 +40,8 @@
> #include "drm.h"
> #include "drm_fourcc.h"
>
> +#include "igt_device.h"
> +
> static bool has_getfb_iface(int fd)
> {
> struct drm_mode_fb_cmd arg = { };
> @@ -228,6 +230,158 @@ static void test_duplicate_handles(int fd)
> }
> }
>
> +static void test_getfb2(int fd)
> +{
> + struct drm_mode_fb_cmd2 add_basic = {};
> +
> + igt_fixture {
> + struct drm_mode_fb_cmd2 get = {};
> +
> + add_basic.width = 1024;
> + add_basic.height = 1024;
> + add_basic.pixel_format = DRM_FORMAT_XRGB8888;
> + add_basic.pitches[0] = 1024*4;
> + add_basic.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> + DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> + igt_assert(add_basic.handles[0]);
> + do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add_basic);
> +
> + get.fb_id = add_basic.fb_id;
> + do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &get);
> + igt_assert_neq_u32(get.handles[0], 0);
> + gem_close(fd, get.handles[0]);
> + }
> +
> + igt_subtest("getfb2-handle-zero") {
> + struct drm_mode_fb_cmd2 get = {};
> + do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT);
> + }
> +
> + igt_subtest("getfb2-handle-closed") {
> + struct drm_mode_fb_cmd2 add = add_basic;
> + struct drm_mode_fb_cmd2 get = { };
> +
> + add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> + DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> + igt_assert(add.handles[0]);
Not sure why we're creating another bo here. Can't we reuse the one we
already have?
Otherwise seems sane
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> + do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
> + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &add.fb_id);
> +
> + get.fb_id = add.fb_id;
> + do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT);
> + gem_close(fd, add.handles[0]);
> + }
> +
> + igt_subtest("getfb2-handle-not-fb") {
> + struct drm_mode_fb_cmd2 get = { .fb_id = get_any_prop_id(fd) };
> + igt_require(get.fb_id > 0);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT);
> + }
> +
> + igt_subtest("getfb2-accept-ccs") {
> + struct drm_mode_fb_cmd2 add_ccs = { };
> + struct drm_mode_fb_cmd2 get = { };
> + int i;
> +
> + get_ccs_fb(fd, &add_ccs);
> + igt_require(add_ccs.fb_id != 0);
> + get.fb_id = add_ccs.fb_id;
> + do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &get);
> +
> + igt_assert_eq_u32(get.width, add_ccs.width);
> + igt_assert_eq_u32(get.height, add_ccs.height);
> + igt_assert(get.flags & DRM_MODE_FB_MODIFIERS);
> +
> + for (i = 0; i < ARRAY_SIZE(get.handles); i++) {
> + igt_assert_eq_u32(get.pitches[i], add_ccs.pitches[i]);
> + igt_assert_eq_u32(get.offsets[i], add_ccs.offsets[i]);
> + if (add_ccs.handles[i] != 0) {
> + igt_assert_neq_u32(get.handles[i], 0);
> + igt_assert_neq_u32(get.handles[i],
> + add_ccs.handles[i]);
> + igt_assert_eq_u64(get.modifier[i],
> + add_ccs.modifier[i]);
> + } else {
> + igt_assert_eq_u32(get.handles[i], 0);
> + igt_assert_eq_u64(get.modifier[i], 0);
> + }
> + }
> + igt_assert_eq_u32(get.handles[0], get.handles[1]);
> +
> + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &get.fb_id);
> + gem_close(fd, add_ccs.handles[0]);
> + gem_close(fd, get.handles[0]);
> + }
> +
> + igt_subtest("getfb2-into-addfb2") {
> + struct drm_mode_fb_cmd2 cmd = { };
> +
> + cmd.fb_id = add_basic.fb_id;
> + do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &cmd);
> + do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &cmd);
> +
> + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &cmd.fb_id);
> + gem_close(fd, cmd.handles[0]);
> + }
> +
> + igt_fixture {
> + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &add_basic.fb_id);
> + gem_close(fd, add_basic.handles[0]);
> + }
> +}
> +
> +static void test_handle_protection(void) {
> + int non_master_fd;
> + struct drm_mode_fb_cmd2 non_master_add = {};
> +
> + igt_fixture {
> + non_master_fd = drm_open_driver(DRIVER_ANY);
> +
> + non_master_add.width = 1024;
> + non_master_add.height = 1024;
> + non_master_add.pixel_format = DRM_FORMAT_XRGB8888;
> + non_master_add.pitches[0] = 1024*4;
> + non_master_add.handles[0] = igt_create_bo_with_dimensions(non_master_fd, 1024, 1024,
> + DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> + igt_require(non_master_add.handles[0] != 0);
> + do_ioctl(non_master_fd, DRM_IOCTL_MODE_ADDFB2, &non_master_add);
> + }
> +
> + igt_subtest("getfb-handle-protection") {
> + struct drm_mode_fb_cmd get = { .fb_id = non_master_add.fb_id};
> +
> + igt_fork(child, 1) {
> + igt_drop_root();
> +
> + do_ioctl(non_master_fd, DRM_IOCTL_MODE_GETFB, &get);
> + /* ioctl succeeds but handle should be 0 */
> + igt_assert_eq_u32(get.handle, 0);
> + }
> + igt_waitchildren();
> + }
> +
> + igt_subtest("getfb2-handle-protection") {
> + struct drm_mode_fb_cmd2 get = { .fb_id = non_master_add.fb_id};
> + int i;
> +
> + igt_fork(child, 1) {
> + igt_drop_root();
> +
> + do_ioctl(non_master_fd, DRM_IOCTL_MODE_GETFB2, &get);
> + /* ioctl succeeds but handles should be 0 */
> + for (i = 0; i < ARRAY_SIZE(get.handles); i++) {
> + igt_assert_eq_u32(get.handles[i], 0);
> + }
> + }
> + igt_waitchildren();
> + }
> +
> + igt_fixture {
> + do_ioctl(non_master_fd, DRM_IOCTL_MODE_RMFB, &non_master_add.fb_id);
> + gem_close(non_master_fd, non_master_add.handles[0]);
> + }
> +}
> +
> igt_main
> {
> int fd;
> @@ -243,6 +397,12 @@ igt_main
> igt_subtest_group
> test_duplicate_handles(fd);
>
> + igt_subtest_group
> + test_getfb2(fd);
> +
> + igt_subtest_group
> + test_handle_protection();
> +
> igt_fixture
> close(fd);
> }
> --
> 2.21.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH v4 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests
@ 2020-01-13 17:21 ` Ville Syrjälä
0 siblings, 0 replies; 7+ messages in thread
From: Ville Syrjälä @ 2020-01-13 17:21 UTC (permalink / raw)
To: Juston Li; +Cc: igt-dev, intel-gfx, Daniel Stone, daniel
On Mon, Dec 16, 2019 at 07:48:40PM -0800, Juston Li wrote:
> From: Daniel Stone <daniels@collabora.com>
>
> Mirroring addfb2, add tests for the new ioctl which will return us
> information about framebuffers containing multiple buffers, as well as
> modifiers.
>
> Changes since v3:
> - Add subtests to ensure handles aren't returned for non-root and
> non-master callers
> - Fix getfb2-handle-not-fb to use getfb2
>
> Changes since v1:
> - Add test that uses getfb2 output to call addfb2 as suggested by Ville
>
> Signed-off-by: Daniel Stone <daniels@collabora.com>
> Signed-off-by: Juston Li <juston.li@intel.com>
> ---
> tests/kms_getfb.c | 160 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 160 insertions(+)
>
> diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
> index ca0b01c05e5c..ffd8f9117c92 100644
> --- a/tests/kms_getfb.c
> +++ b/tests/kms_getfb.c
> @@ -40,6 +40,8 @@
> #include "drm.h"
> #include "drm_fourcc.h"
>
> +#include "igt_device.h"
> +
> static bool has_getfb_iface(int fd)
> {
> struct drm_mode_fb_cmd arg = { };
> @@ -228,6 +230,158 @@ static void test_duplicate_handles(int fd)
> }
> }
>
> +static void test_getfb2(int fd)
> +{
> + struct drm_mode_fb_cmd2 add_basic = {};
> +
> + igt_fixture {
> + struct drm_mode_fb_cmd2 get = {};
> +
> + add_basic.width = 1024;
> + add_basic.height = 1024;
> + add_basic.pixel_format = DRM_FORMAT_XRGB8888;
> + add_basic.pitches[0] = 1024*4;
> + add_basic.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> + DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> + igt_assert(add_basic.handles[0]);
> + do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add_basic);
> +
> + get.fb_id = add_basic.fb_id;
> + do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &get);
> + igt_assert_neq_u32(get.handles[0], 0);
> + gem_close(fd, get.handles[0]);
> + }
> +
> + igt_subtest("getfb2-handle-zero") {
> + struct drm_mode_fb_cmd2 get = {};
> + do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT);
> + }
> +
> + igt_subtest("getfb2-handle-closed") {
> + struct drm_mode_fb_cmd2 add = add_basic;
> + struct drm_mode_fb_cmd2 get = { };
> +
> + add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> + DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> + igt_assert(add.handles[0]);
Not sure why we're creating another bo here. Can't we reuse the one we
already have?
Otherwise seems sane
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> + do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
> + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &add.fb_id);
> +
> + get.fb_id = add.fb_id;
> + do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT);
> + gem_close(fd, add.handles[0]);
> + }
> +
> + igt_subtest("getfb2-handle-not-fb") {
> + struct drm_mode_fb_cmd2 get = { .fb_id = get_any_prop_id(fd) };
> + igt_require(get.fb_id > 0);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT);
> + }
> +
> + igt_subtest("getfb2-accept-ccs") {
> + struct drm_mode_fb_cmd2 add_ccs = { };
> + struct drm_mode_fb_cmd2 get = { };
> + int i;
> +
> + get_ccs_fb(fd, &add_ccs);
> + igt_require(add_ccs.fb_id != 0);
> + get.fb_id = add_ccs.fb_id;
> + do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &get);
> +
> + igt_assert_eq_u32(get.width, add_ccs.width);
> + igt_assert_eq_u32(get.height, add_ccs.height);
> + igt_assert(get.flags & DRM_MODE_FB_MODIFIERS);
> +
> + for (i = 0; i < ARRAY_SIZE(get.handles); i++) {
> + igt_assert_eq_u32(get.pitches[i], add_ccs.pitches[i]);
> + igt_assert_eq_u32(get.offsets[i], add_ccs.offsets[i]);
> + if (add_ccs.handles[i] != 0) {
> + igt_assert_neq_u32(get.handles[i], 0);
> + igt_assert_neq_u32(get.handles[i],
> + add_ccs.handles[i]);
> + igt_assert_eq_u64(get.modifier[i],
> + add_ccs.modifier[i]);
> + } else {
> + igt_assert_eq_u32(get.handles[i], 0);
> + igt_assert_eq_u64(get.modifier[i], 0);
> + }
> + }
> + igt_assert_eq_u32(get.handles[0], get.handles[1]);
> +
> + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &get.fb_id);
> + gem_close(fd, add_ccs.handles[0]);
> + gem_close(fd, get.handles[0]);
> + }
> +
> + igt_subtest("getfb2-into-addfb2") {
> + struct drm_mode_fb_cmd2 cmd = { };
> +
> + cmd.fb_id = add_basic.fb_id;
> + do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &cmd);
> + do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &cmd);
> +
> + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &cmd.fb_id);
> + gem_close(fd, cmd.handles[0]);
> + }
> +
> + igt_fixture {
> + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &add_basic.fb_id);
> + gem_close(fd, add_basic.handles[0]);
> + }
> +}
> +
> +static void test_handle_protection(void) {
> + int non_master_fd;
> + struct drm_mode_fb_cmd2 non_master_add = {};
> +
> + igt_fixture {
> + non_master_fd = drm_open_driver(DRIVER_ANY);
> +
> + non_master_add.width = 1024;
> + non_master_add.height = 1024;
> + non_master_add.pixel_format = DRM_FORMAT_XRGB8888;
> + non_master_add.pitches[0] = 1024*4;
> + non_master_add.handles[0] = igt_create_bo_with_dimensions(non_master_fd, 1024, 1024,
> + DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> + igt_require(non_master_add.handles[0] != 0);
> + do_ioctl(non_master_fd, DRM_IOCTL_MODE_ADDFB2, &non_master_add);
> + }
> +
> + igt_subtest("getfb-handle-protection") {
> + struct drm_mode_fb_cmd get = { .fb_id = non_master_add.fb_id};
> +
> + igt_fork(child, 1) {
> + igt_drop_root();
> +
> + do_ioctl(non_master_fd, DRM_IOCTL_MODE_GETFB, &get);
> + /* ioctl succeeds but handle should be 0 */
> + igt_assert_eq_u32(get.handle, 0);
> + }
> + igt_waitchildren();
> + }
> +
> + igt_subtest("getfb2-handle-protection") {
> + struct drm_mode_fb_cmd2 get = { .fb_id = non_master_add.fb_id};
> + int i;
> +
> + igt_fork(child, 1) {
> + igt_drop_root();
> +
> + do_ioctl(non_master_fd, DRM_IOCTL_MODE_GETFB2, &get);
> + /* ioctl succeeds but handles should be 0 */
> + for (i = 0; i < ARRAY_SIZE(get.handles); i++) {
> + igt_assert_eq_u32(get.handles[i], 0);
> + }
> + }
> + igt_waitchildren();
> + }
> +
> + igt_fixture {
> + do_ioctl(non_master_fd, DRM_IOCTL_MODE_RMFB, &non_master_add.fb_id);
> + gem_close(non_master_fd, non_master_add.handles[0]);
> + }
> +}
> +
> igt_main
> {
> int fd;
> @@ -243,6 +397,12 @@ igt_main
> igt_subtest_group
> test_duplicate_handles(fd);
>
> + igt_subtest_group
> + test_getfb2(fd);
> +
> + igt_subtest_group
> + test_handle_protection();
> +
> igt_fixture
> close(fd);
> }
> --
> 2.21.0
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-01-13 17:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 3:48 [Intel-gfx] [PATCH v4 i-g-t 1/2] NOMERGE: Import drm.h up to 54ecb8f7028c Juston Li
2019-12-17 3:48 ` [Intel-gfx] [PATCH v4 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests Juston Li
2020-01-13 17:21 ` Ville Syrjälä
2020-01-13 17:21 ` [igt-dev] " Ville Syrjälä
2019-12-17 4:25 ` [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [v4,i-g-t,1/2] NOMERGE: Import drm.h up to 54ecb8f7028c Patchwork
2019-12-17 4:44 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-12-17 11:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.