All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanley Chu <stanley.chu@mediatek.com>
To: Alim Akhtar <alim.akhtar@gmail.com>
Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Leon Chen (陳文鏘)" <Leon.Chen@mediatek.com>,
	"Andy Teng ( ^[$B{}G!9(^[(B)" <Andy.Teng@mediatek.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
	"Kuohong Wang (王國鴻)" <kuohong.wang@mediatek.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Avri Altman" <avri.altman@wdc.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Peter Wang (王信友)" <peter.wang@mediatek.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Pedro Sousa" <pedrom.sousa@synopsys.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Bean Huo (beanhuo)" <beanhuo@micron.com>
Subject: Re: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service interface
Date: Fri, 20 Dec 2019 09:15:40 +0800	[thread overview]
Message-ID: <1576804540.13056.22.camel@mtkswgap22> (raw)
In-Reply-To: <CAGOxZ50RKYAEw=HwYMH=Jm7cagUV12C-fwhauJhJqx6HscAmFA@mail.gmail.com>

Hi Alim,

On Fri, 2019-12-20 at 02:00 +0800, Alim Akhtar wrote:
> > +/* UFS related SMC call */
> > +#define MTK_SIP_UFS_CONTROL \
> > +       MTK_SIP_SMC_CMD(0x276)
> > +
> How about moving UFS specific stuff to MTK UFS driver and include this
> header in driver file?
> Rest looks fine.

Thanks so much for your review.

Our intention is to collect all SMC call command types in MediaTek
Chipsets here for easier management.

This is the first time we show this header thus only UFS related stuff
is present here.

> > +#endif
> > --
> > 2.18.0
> 
> 

Thanks,
Stanley





WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: Alim Akhtar <alim.akhtar@gmail.com>
Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Leon Chen (陳文鏘)" <Leon.Chen@mediatek.com>,
	"Andy Teng (^[$B{}G!9(^[(B)" <Andy.Teng@mediatek.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
	"Kuohong Wang (王國鴻)" <kuohong.wang@mediatek.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Avri Altman" <avri.altman@wdc.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Peter Wang (王信友)" <peter.wang@mediatek.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Pedro Sousa" <pedrom.sousa@synopsys.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Bean Huo (beanhuo)" <beanhuo@micron.com>
Subject: Re: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service interface
Date: Fri, 20 Dec 2019 09:15:40 +0800	[thread overview]
Message-ID: <1576804540.13056.22.camel@mtkswgap22> (raw)
In-Reply-To: <CAGOxZ50RKYAEw=HwYMH=Jm7cagUV12C-fwhauJhJqx6HscAmFA@mail.gmail.com>

Hi Alim,

On Fri, 2019-12-20 at 02:00 +0800, Alim Akhtar wrote:
> > +/* UFS related SMC call */
> > +#define MTK_SIP_UFS_CONTROL \
> > +       MTK_SIP_SMC_CMD(0x276)
> > +
> How about moving UFS specific stuff to MTK UFS driver and include this
> header in driver file?
> Rest looks fine.

Thanks so much for your review.

Our intention is to collect all SMC call command types in MediaTek
Chipsets here for easier management.

This is the first time we show this header thus only UFS related stuff
is present here.

> > +#endif
> > --
> > 2.18.0
> 
> 

Thanks,
Stanley




_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: Alim Akhtar <alim.akhtar@gmail.com>
Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Leon Chen (陳文鏘)" <Leon.Chen@mediatek.com>,
	"Andy Teng (^[$B{}G!9(^[(B)" <Andy.Teng@mediatek.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
	"Kuohong Wang (王國鴻)" <kuohong.wang@mediatek.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Avri Altman" <avri.altman@wdc.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Peter Wang (王信友)" <peter.wang@mediatek.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Pedro Sousa" <pedrom.sousa@synopsys.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Bean Huo (beanhuo)" <beanhuo@micron.com>
Subject: Re: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service interface
Date: Fri, 20 Dec 2019 09:15:40 +0800	[thread overview]
Message-ID: <1576804540.13056.22.camel@mtkswgap22> (raw)
In-Reply-To: <CAGOxZ50RKYAEw=HwYMH=Jm7cagUV12C-fwhauJhJqx6HscAmFA@mail.gmail.com>

Hi Alim,

On Fri, 2019-12-20 at 02:00 +0800, Alim Akhtar wrote:
> > +/* UFS related SMC call */
> > +#define MTK_SIP_UFS_CONTROL \
> > +       MTK_SIP_SMC_CMD(0x276)
> > +
> How about moving UFS specific stuff to MTK UFS driver and include this
> header in driver file?
> Rest looks fine.

Thanks so much for your review.

Our intention is to collect all SMC call command types in MediaTek
Chipsets here for easier management.

This is the first time we show this header thus only UFS related stuff
is present here.

> > +#endif
> > --
> > 2.18.0
> 
> 

Thanks,
Stanley




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-20  1:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16  3:48 [PATCH v2 0/2 RESEND] scsi: ufs-mediatek: add device reset implementation Stanley Chu
2019-12-16  3:48 ` Stanley Chu
2019-12-16  3:48 ` Stanley Chu
2019-12-16  3:48 ` [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service interface Stanley Chu
2019-12-16  3:48   ` Stanley Chu
2019-12-16  3:48   ` Stanley Chu
2019-12-16  3:52   ` Stanley Chu
2019-12-16  3:52     ` Stanley Chu
2019-12-16  3:52     ` Stanley Chu
2019-12-19 18:00   ` Alim Akhtar
2019-12-19 18:00     ` Alim Akhtar
2019-12-19 18:00     ` Alim Akhtar
2019-12-20  1:15     ` Stanley Chu [this message]
2019-12-20  1:15       ` Stanley Chu
2019-12-20  1:15       ` Stanley Chu
2019-12-25  7:34       ` Stanley Chu
2019-12-25  7:34         ` Stanley Chu
2019-12-25  7:34         ` Stanley Chu
2019-12-26  8:40         ` Alim Akhtar
2019-12-26  8:40           ` Alim Akhtar
2019-12-16  3:48 ` [PATCH v2 2/2 RESEND] scsi: ufs-mediatek: add device reset implementation Stanley Chu
2019-12-16  3:48   ` Stanley Chu
2019-12-16  3:48   ` Stanley Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1576804540.13056.22.camel@mtkswgap22 \
    --to=stanley.chu@mediatek.com \
    --cc=Andy.Teng@mediatek.com \
    --cc=Chun-hung.Wu@mediatek.com \
    --cc=Leon.Chen@mediatek.com \
    --cc=alim.akhtar@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=f.fainelli@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=kuohong.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=pedrom.sousa@synopsys.com \
    --cc=peter.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.