[integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?

[integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity-testing
head:   11b771ffff8fc0bfc176b829d986896a7d97a44c
commit: 466a4c055a9b9efc8704591bbfa9041c77f66c46 [3/5] IMA: Define workqueue for early boot "key" measurements
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-129-g341daf20-dirty
        git checkout 466a4c055a9b9efc8704591bbfa9041c77f66c46
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity-testing
head:   11b771ffff8fc0bfc176b829d986896a7d97a44c
commit: 466a4c055a9b9efc8704591bbfa9041c77f66c46 [3/5] IMA: Define workqueue for early boot "key" measurements
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-129-g341daf20-dirty
        git checkout 466a4c055a9b9efc8704591bbfa9041c77f66c46
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[RFC PATCH integrity] IMA: ima_queue_key() can be static

[kbuild test robot]

Fixes: 466a4c055a9b ("IMA: Define workqueue for early boot "key" measurements")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 ima_asymmetric_keys.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/integrity/ima/ima_asymmetric_keys.c b/security/integrity/ima/ima_asymmetric_keys.c
index d520a67180d89..745bb90f1604f 100644
--- a/security/integrity/ima/ima_asymmetric_keys.c
+++ b/security/integrity/ima/ima_asymmetric_keys.c
@@ -67,8 +67,8 @@ static struct ima_key_entry *ima_alloc_key_entry(
 	return entry;
 }
 
-bool ima_queue_key(struct key *keyring, const void *payload,
-		   size_t payload_len)
+static bool ima_queue_key(struct key *keyring, const void *payload,
+			  size_t payload_len)
 {
 	bool queued = false;
 	struct ima_key_entry *entry;

[RFC PATCH integrity] IMA: ima_queue_key() can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]


Fixes: 466a4c055a9b ("IMA: Define workqueue for early boot "key" measurements")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 ima_asymmetric_keys.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/integrity/ima/ima_asymmetric_keys.c b/security/integrity/ima/ima_asymmetric_keys.c
index d520a67180d89..745bb90f1604f 100644
--- a/security/integrity/ima/ima_asymmetric_keys.c
+++ b/security/integrity/ima/ima_asymmetric_keys.c
@@ -67,8 +67,8 @@ static struct ima_key_entry *ima_alloc_key_entry(
 	return entry;
 }
 
-bool ima_queue_key(struct key *keyring, const void *payload,
-		   size_t payload_len)
+static bool ima_queue_key(struct key *keyring, const void *payload,
+			  size_t payload_len)
 {
 	bool queued = false;
 	struct ima_key_entry *entry;

Re: [RFC PATCH integrity] IMA: ima_queue_key() can be static

[Lakshmi Ramasubramanian]

Hi Mimi,

On 12/24/2019 8:54 PM, kbuild test robot wrote:
> 
> Fixes: 466a4c055a9b ("IMA: Define workqueue for early boot "key" measurements")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>   ima_asymmetric_keys.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>   
> -bool ima_queue_key(struct key *keyring, const void *payload,
> -		   size_t payload_len)
> +static bool ima_queue_key(struct key *keyring, const void *payload,
> +			  size_t payload_len)
>   {
>   	bool queued = false;
>   	struct ima_key_entry *entry;
> 

I'd defined ima_queue_key() as non-static when it could have been 
defined as static.

 From this patch I understand this change is done. Is there anything I 
need to do to address this issue?

thanks,
  -lakshmi

Re: [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?

[Mimi Zohar]

On Wed, 2019-12-25 at 12:54 +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity-testing
> head:   11b771ffff8fc0bfc176b829d986896a7d97a44c
> commit: 466a4c055a9b9efc8704591bbfa9041c77f66c46 [3/5] IMA: Define workqueue for early boot "key" measurements
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.1-129-g341daf20-dirty
>         git checkout 466a4c055a9b9efc8704591bbfa9041c77f66c46
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static?
> 
> Please review and possibly fold the followup patch.

Thank you for following next-integrity-testing branch and providing a fix.

Mimi

Re: [RFC PATCH integrity] IMA: ima_queue_key() can be static

[Mimi Zohar]

On Tue, 2019-12-24 at 22:43 -0800, Lakshmi Ramasubramanian wrote:
> Hi Mimi,
> 
> On 12/24/2019 8:54 PM, kbuild test robot wrote:
> > 
> > Fixes: 466a4c055a9b ("IMA: Define workqueue for early boot "key" measurements")
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > ---
> >   ima_asymmetric_keys.c |    4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >   
> > -bool ima_queue_key(struct key *keyring, const void *payload,
> > -		   size_t payload_len)
> > +static bool ima_queue_key(struct key *keyring, const void *payload,
> > +			  size_t payload_len)
> >   {
> >   	bool queued = false;
> >   	struct ima_key_entry *entry;
> > 
> 
> I'd defined ima_queue_key() as non-static when it could have been 
> defined as static.
> 
>  From this patch I understand this change is done. Is there anything I 
> need to do to address this issue?

No, I'll squash this patch with the original patch, adding the
requested tags.

Mimi

Re: [RFC PATCH integrity] IMA: ima_queue_key() can be static

[Lakshmi Ramasubramanian]

On 12/26/2019 6:27 AM, Mimi Zohar wrote:

>>
>>   From this patch I understand this change is done. Is there anything I
>> need to do to address this issue?
> 
> No, I'll squash this patch with the original patch, adding the
> requested tags.
> 
> Mimi

Thanks a lot for your help Mimi.

  -lakshmi