* [Intel-gfx] [PATCH] drm/i915/selftests: Err out on coherency if initialisation failed
@ 2019-12-27 10:30 Chris Wilson
2019-12-27 16:54 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 1 reply; 2+ messages in thread
From: Chris Wilson @ 2019-12-27 10:30 UTC (permalink / raw)
To: intel-gfx
If gt initialisation failed, we are left with no engines to use for
coherency testing. Currently we bug out, which makes the actual error,
so fail more gracefully instead.
Closes: https://gitlab.freedesktop.org/drm/intel/issues/896
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
.../gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
index 49edc51111d5..3f6079e1dfb6 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
@@ -325,7 +325,10 @@ static int igt_gem_coherency(void *arg)
values = offsets + ncachelines;
ctx.engine = random_engine(i915, &prng);
- GEM_BUG_ON(!ctx.engine);
+ if (!ctx.engine) {
+ err = -ENODEV;
+ goto out_free;
+ }
pr_info("%s: using %s\n", __func__, ctx.engine->name);
intel_engine_pm_get(ctx.engine);
@@ -354,7 +357,7 @@ static int igt_gem_coherency(void *arg)
ctx.obj = i915_gem_object_create_internal(i915, PAGE_SIZE);
if (IS_ERR(ctx.obj)) {
err = PTR_ERR(ctx.obj);
- goto free;
+ goto out_pm;
}
i915_random_reorder(offsets, ncachelines, &prng);
@@ -405,14 +408,15 @@ static int igt_gem_coherency(void *arg)
}
}
}
-free:
+out_pm:
intel_engine_pm_put(ctx.engine);
+out_free:
kfree(offsets);
return err;
put_object:
i915_gem_object_put(ctx.obj);
- goto free;
+ goto out_pm;
}
int i915_gem_coherency_live_selftests(struct drm_i915_private *i915)
--
2.24.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Err out on coherency if initialisation failed
2019-12-27 10:30 [Intel-gfx] [PATCH] drm/i915/selftests: Err out on coherency if initialisation failed Chris Wilson
@ 2019-12-27 16:54 ` Patchwork
0 siblings, 0 replies; 2+ messages in thread
From: Patchwork @ 2019-12-27 16:54 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Err out on coherency if initialisation failed
URL : https://patchwork.freedesktop.org/series/71433/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7642 -> Patchwork_15932
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15932 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15932, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15932:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_client:
- fi-skl-6600u: NOTRUN -> [DMESG-WARN][1] +9 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-skl-6600u/igt@i915_selftest@live_client.html
* igt@i915_selftest@live_reset:
- fi-skl-6600u: NOTRUN -> [DMESG-FAIL][2] +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-skl-6600u/igt@i915_selftest@live_reset.html
Known issues
------------
Here are the changes found in Patchwork_15932 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][3] -> [DMESG-WARN][4] ([i915#44])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
* igt@prime_busy@basic-before-default:
- fi-icl-dsi: [PASS][5] -> [DMESG-WARN][6] ([i915#109])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-icl-dsi/igt@prime_busy@basic-before-default.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-icl-dsi/igt@prime_busy@basic-before-default.html
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-ivb-3770: [DMESG-FAIL][7] ([i915#725]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-ivb-3770/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-ivb-3770/igt@i915_selftest@live_blt.html
- fi-byt-j1900: [DMESG-FAIL][9] ([i915#725]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-byt-j1900/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-byt-j1900/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_coherency:
- fi-bxt-dsi: [INCOMPLETE][11] ([fdo#103927]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-bxt-dsi/igt@i915_selftest@live_coherency.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-bxt-dsi/igt@i915_selftest@live_coherency.html
* igt@i915_selftest@live_gt_engines:
- fi-bxt-dsi: [DMESG-FAIL][13] ([i915#889]) -> [PASS][14] +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-bxt-dsi/igt@i915_selftest@live_gt_engines.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-bxt-dsi/igt@i915_selftest@live_gt_engines.html
* igt@i915_selftest@live_mman:
- fi-bxt-dsi: [DMESG-WARN][15] ([i915#889]) -> [PASS][16] +13 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-bxt-dsi/igt@i915_selftest@live_mman.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-bxt-dsi/igt@i915_selftest@live_mman.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-7500u: [FAIL][17] ([i915#217]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][19] ([fdo#111096] / [i915#323]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][21] ([i915#553] / [i915#725]) -> [DMESG-FAIL][22] ([i915#725])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-hsw-4770/igt@i915_selftest@live_blt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][24] ([i915#62] / [i915#92]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92]) -> [DMESG-WARN][26] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7642/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-wf_vblank.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-wf_vblank.html
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (44 -> 44)
------------------------------
Additional (9): fi-tgl-guc fi-bdw-5557u fi-skl-6770hq fi-snb-2520m fi-whl-u fi-bsw-kefka fi-skl-lmem fi-tgl-y fi-skl-6600u
Missing (9): fi-kbl-soraka fi-hsw-4770r fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7642 -> Patchwork_15932
CI-20190529: 20190529
CI_DRM_7642: c040b352eb9c72e9a6a8dc830245b2ae8089a54e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5352: 0586d205f651674e575351c2d5a7d0760716c9f1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15932: d70126307f740a7aaa9984d935f1b6e3a4009d03 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d70126307f74 drm/i915/selftests: Err out on coherency if initialisation failed
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15932/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-27 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-27 10:30 [Intel-gfx] [PATCH] drm/i915/selftests: Err out on coherency if initialisation failed Chris Wilson
2019-12-27 16:54 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.