All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Alexey Brodkin <abrodkin@synopsys.com>,
	Vineet Gupta <vgupta@synopsys.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>, Dave Airlie <airlied@redhat.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Ben Skeggs <bskeggs@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Jiri Slaby <jirislaby@gmail.com>,
	Nick Kossifidis <mickflemm@gmail.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	Dave Jiang <dave.jiang@intel.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [RFT 11/13] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation)
Date: Tue,  7 Jan 2020 17:53:10 +0100	[thread overview]
Message-ID: <1578415992-24054-14-git-send-email-krzk__30298.035573081$1578416146$gmane$org@kernel.org> (raw)
In-Reply-To: <1578415992-24054-1-git-send-email-krzk@kernel.org>

The ioreadX() helpers have inconsistent interface.  On some architectures
void *__iomem address argument is a pointer to const, on some not.

Implementations of ioreadX() do not modify the memory under the address
so they can be converted to a "const" version for const-safety and
consistency among architectures.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h b/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h
index 7948a2da195a..2ff00800d45b 100644
--- a/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h
+++ b/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h
@@ -150,17 +150,17 @@ void rtl8180_write_phy(struct ieee80211_hw *dev, u8 addr, u32 data);
 void rtl8180_set_anaparam(struct rtl8180_priv *priv, u32 anaparam);
 void rtl8180_set_anaparam2(struct rtl8180_priv *priv, u32 anaparam2);
 
-static inline u8 rtl818x_ioread8(struct rtl8180_priv *priv, u8 __iomem *addr)
+static inline u8 rtl818x_ioread8(struct rtl8180_priv *priv, const u8 __iomem *addr)
 {
 	return ioread8(addr);
 }
 
-static inline u16 rtl818x_ioread16(struct rtl8180_priv *priv, __le16 __iomem *addr)
+static inline u16 rtl818x_ioread16(struct rtl8180_priv *priv, const __le16 __iomem *addr)
 {
 	return ioread16(addr);
 }
 
-static inline u32 rtl818x_ioread32(struct rtl8180_priv *priv, __le32 __iomem *addr)
+static inline u32 rtl818x_ioread32(struct rtl8180_priv *priv, const __le32 __iomem *addr)
 {
 	return ioread32(addr);
 }
-- 
2.7.4

  parent reply	other threads:[~2020-01-07 16:53 UTC|newest]

Thread overview: 189+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 16:52 [RFT 00/13] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` [RFT 01/13] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52   ` Krzysztof Kozlowski
2020-01-07 16:52   ` Krzysztof Kozlowski
2020-01-07 16:52   ` Krzysztof Kozlowski
     [not found] ` <1578415992-24054-1-git-send-email-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-07 16:52   ` Krzysztof Kozlowski
2020-01-07 16:52   ` [RFT 02/13] alpha: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 02/13] sh: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 03/13] alpha: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 03/13] sh: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 04/13] parisc: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 05/13] powerpc: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 06/13] arc: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 07/13] drm/mgag200: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 08/13] drm/nouveau: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 09/13] media: fsl-viu: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 10/13] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 11/13] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 12/13] ntb: intel: " Krzysztof Kozlowski
2020-01-07 16:53   ` [RFT 13/13] virtio: pci: " Krzysztof Kozlowski
2020-01-07 16:52 ` [RFT 02/13] alpha: " Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52   ` Krzysztof Kozlowski
2020-01-07 16:52   ` Krzysztof Kozlowski
2020-01-07 16:52   ` Krzysztof Kozlowski
2020-01-08  8:10   ` Geert Uytterhoeven
2020-01-08  8:10   ` Geert Uytterhoeven
2020-01-08  8:10     ` Geert Uytterhoeven
2020-01-08  8:10     ` Geert Uytterhoeven
2020-01-08  8:10     ` Geert Uytterhoeven
2020-01-08  8:10     ` Geert Uytterhoeven
2020-01-08  9:07     ` Krzysztof Kozlowski
2020-01-08  9:07     ` Krzysztof Kozlowski
2020-01-08  9:07       ` Krzysztof Kozlowski
2020-01-08  9:07       ` Krzysztof Kozlowski
2020-01-08  9:07       ` Krzysztof Kozlowski
2020-01-08  9:07       ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 02/13] sh: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 03/13] alpha: " Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 03/13] sh: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 17:08   ` Arnd Bergmann
2020-01-07 17:08     ` Arnd Bergmann
2020-01-07 17:08     ` Arnd Bergmann
2020-01-07 17:08     ` Arnd Bergmann
2020-01-07 17:08     ` Arnd Bergmann
2020-01-07 17:08   ` Arnd Bergmann
2020-01-07 16:53 ` [RFT 04/13] parisc: " Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 05/13] powerpc: " Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 06/13] arc: " Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 17:10   ` Arnd Bergmann
2020-01-07 17:10     ` Arnd Bergmann
2020-01-07 17:10     ` Arnd Bergmann
2020-01-07 17:10     ` Arnd Bergmann
2020-01-07 17:10     ` Arnd Bergmann
2020-01-07 17:10   ` Arnd Bergmann
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 07/13] drm/mgag200: " Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 08/13] drm/nouveau: " Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 09/13] media: fsl-viu: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 10/13] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski [this message]
2020-01-07 16:53 ` [RFT 11/13] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 12/13] ntb: intel: " Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 13/13] virtio: pci: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-07 16:53   ` Krzysztof Kozlowski
2020-01-08  8:07 ` [RFT 00/13] iomap: Constify ioreadX() iomem argument Geert Uytterhoeven
2020-01-08  8:07   ` Geert Uytterhoeven
2020-01-08  8:07   ` Geert Uytterhoeven
2020-01-08  8:07   ` Geert Uytterhoeven
2020-01-08  8:07   ` Geert Uytterhoeven
2020-01-08  8:12   ` Geert Uytterhoeven
2020-01-08  8:12   ` Geert Uytterhoeven
2020-01-08  8:12     ` Geert Uytterhoeven
2020-01-08  8:12     ` Geert Uytterhoeven
2020-01-08  8:12     ` Geert Uytterhoeven
2020-01-08  8:12     ` Geert Uytterhoeven
2020-01-08  8:18     ` Krzysztof Kozlowski
2020-01-08  8:18       ` Krzysztof Kozlowski
2020-01-08  8:18       ` Krzysztof Kozlowski
2020-01-08  8:18       ` Krzysztof Kozlowski
2020-01-08  8:18       ` Krzysztof Kozlowski
2020-01-08  8:35       ` Christophe Leroy
2020-01-08  8:35         ` Christophe Leroy
2020-01-08  8:35         ` Christophe Leroy
2020-01-08  8:35         ` Christophe Leroy
2020-01-08  8:35         ` Christophe Leroy
2020-01-08  8:35         ` Christophe Leroy
2020-01-08  8:43         ` Geert Uytterhoeven
2020-01-08  8:43         ` Geert Uytterhoeven
2020-01-08  8:43           ` Geert Uytterhoeven
2020-01-08  8:43           ` Geert Uytterhoeven
2020-01-08  8:43           ` Geert Uytterhoeven
2020-01-08  8:43           ` Geert Uytterhoeven
2020-01-08  8:43           ` Geert Uytterhoeven
2020-01-08  8:43           ` Geert Uytterhoeven
2020-01-08  8:48           ` Christophe Leroy
2020-01-08  8:48           ` Christophe Leroy
2020-01-08  8:48             ` Christophe Leroy
2020-01-08  8:48             ` Christophe Leroy
2020-01-08  8:48             ` Christophe Leroy
2020-01-08  8:48             ` Christophe Leroy
2020-01-08  8:48             ` Christophe Leroy
2020-01-08  8:48             ` Christophe Leroy
2020-01-08 17:39             ` David Laight
2020-01-08 17:39               ` David Laight
2020-01-08 17:39               ` David Laight
2020-01-08 17:39               ` David Laight
2020-01-08 17:39               ` David Laight
2020-01-08  8:44         ` Arnd Bergmann
2020-01-08  8:44         ` Arnd Bergmann
2020-01-08  8:44           ` Arnd Bergmann
2020-01-08  8:44           ` Arnd Bergmann
2020-01-08  8:44           ` Arnd Bergmann
2020-01-08  8:44           ` Arnd Bergmann
2020-01-08  8:44           ` Arnd Bergmann
2020-01-08  9:15           ` Krzysztof Kozlowski
2020-01-08  9:15             ` Krzysztof Kozlowski
2020-01-08  9:15             ` Krzysztof Kozlowski
2020-01-08  9:15             ` Krzysztof Kozlowski
2020-01-08  9:15             ` Krzysztof Kozlowski
2020-01-08 11:55             ` Arnd Bergmann
2020-01-08 11:55             ` Arnd Bergmann
2020-01-08 11:55               ` Arnd Bergmann
2020-01-08 11:55               ` Arnd Bergmann
2020-01-08 11:55               ` Arnd Bergmann
2020-01-08 11:55               ` Arnd Bergmann
2020-01-08 11:55               ` Arnd Bergmann
2020-01-08  8:35       ` Christophe Leroy
2020-01-08  8:18     ` Krzysztof Kozlowski
2020-01-08  8:15   ` Krzysztof Kozlowski
2020-01-08  8:15   ` Krzysztof Kozlowski
2020-01-08  8:15     ` Krzysztof Kozlowski
2020-01-08  8:15     ` Krzysztof Kozlowski
2020-01-08  8:15     ` Krzysztof Kozlowski
2020-01-08  8:15     ` Krzysztof Kozlowski
2020-01-08  8:07 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1578415992-24054-14-git-send-email-krzk__30298.035573081$1578416146$gmane$org@kernel.org' \
    --to=krzk@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=abrodkin@synopsys.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=bskeggs@redhat.com \
    --cc=dalias@libc.org \
    --cc=daniel@ffwll.ch \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jirislaby@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=mattst88@gmail.com \
    --cc=mcgrof@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mickflemm@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=rth@twiddle.net \
    --cc=vgupta@synopsys.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.