From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rich Felker <dalias@libc.org>, Jiri Slaby <jirislaby@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Airlie <airlied@linux.ie>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
virtualization@lists.linux-foundation.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Networking <netdev@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
linux-arch <linux-arch@vger.kernel.org>,
Dave Jiang <dave.jiang@intel.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Ellerman <mpe@ellerman.id.au>,
Helge Deller <deller@gmx.de>,
Linux-sh list <linux-sh@vger.kernel.org>,
Alexey Brodkin <abrodkin@synopsys.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ben Skeggs <bskeggs@redhat.com>,
ML nouveau <nouveau@lists.freedesktop.org>,
Dave Airlie <airlied@redhat.com>,
Matt Turner <mattst88@gmail.com>,
open lis
Subject: Re: [RFT 06/13] arc: Constify ioreadX() iomem argument (as in generic implementation)
Date: Tue, 7 Jan 2020 18:10:07 +0100 [thread overview]
Message-ID: <CAK8P3a1RibnRU6SiVjrOy-q+ZDdKacQgD9mrft_aHMgA9hm3PA__3492.88810264028$1578417048$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <1578415992-24054-9-git-send-email-krzk@kernel.org>
On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The ioreadX() helpers have inconsistent interface. On some architectures
> void *__iomem address argument is a pointer to const, on some not.
>
> Implementations of ioreadX() do not modify the memory under the
> address so they can be converted to a "const" version for const-safety
> and consistency among architectures.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
The patch looks correct, but I would not bother here, as it has no
effect on the compiler or its output.
Arnd
next prev parent reply other threads:[~2020-01-07 17:10 UTC|newest]
Thread overview: 189+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 16:52 [RFT 00/13] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` [RFT 01/13] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
[not found] ` <1578415992-24054-1-git-send-email-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` [RFT 02/13] alpha: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 02/13] sh: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 03/13] alpha: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 03/13] sh: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 04/13] parisc: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 05/13] powerpc: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 06/13] arc: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 07/13] drm/mgag200: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 08/13] drm/nouveau: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 09/13] media: fsl-viu: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 10/13] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 11/13] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 12/13] ntb: intel: " Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 13/13] virtio: pci: " Krzysztof Kozlowski
2020-01-07 16:52 ` [RFT 02/13] alpha: " Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-07 16:52 ` Krzysztof Kozlowski
2020-01-08 8:10 ` Geert Uytterhoeven
2020-01-08 8:10 ` Geert Uytterhoeven
2020-01-08 8:10 ` Geert Uytterhoeven
2020-01-08 8:10 ` Geert Uytterhoeven
2020-01-08 8:10 ` Geert Uytterhoeven
2020-01-08 8:10 ` Geert Uytterhoeven
2020-01-08 9:07 ` Krzysztof Kozlowski
2020-01-08 9:07 ` Krzysztof Kozlowski
2020-01-08 9:07 ` Krzysztof Kozlowski
2020-01-08 9:07 ` Krzysztof Kozlowski
2020-01-08 9:07 ` Krzysztof Kozlowski
2020-01-08 9:07 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 02/13] sh: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 03/13] alpha: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 03/13] sh: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 17:08 ` Arnd Bergmann
2020-01-07 17:08 ` Arnd Bergmann
2020-01-07 17:08 ` Arnd Bergmann
2020-01-07 17:08 ` Arnd Bergmann
2020-01-07 17:08 ` Arnd Bergmann
2020-01-07 17:08 ` Arnd Bergmann
2020-01-07 16:53 ` [RFT 04/13] parisc: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 05/13] powerpc: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 06/13] arc: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 17:10 ` Arnd Bergmann
2020-01-07 17:10 ` Arnd Bergmann
2020-01-07 17:10 ` Arnd Bergmann
2020-01-07 17:10 ` Arnd Bergmann
2020-01-07 17:10 ` Arnd Bergmann
2020-01-07 17:10 ` Arnd Bergmann [this message]
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 07/13] drm/mgag200: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 08/13] drm/nouveau: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 09/13] media: fsl-viu: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 10/13] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 11/13] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 12/13] ntb: intel: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` [RFT 13/13] virtio: pci: " Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-07 16:53 ` Krzysztof Kozlowski
2020-01-08 8:07 ` [RFT 00/13] iomap: Constify ioreadX() iomem argument Geert Uytterhoeven
2020-01-08 8:07 ` Geert Uytterhoeven
2020-01-08 8:07 ` Geert Uytterhoeven
2020-01-08 8:07 ` Geert Uytterhoeven
2020-01-08 8:07 ` Geert Uytterhoeven
2020-01-08 8:12 ` Geert Uytterhoeven
2020-01-08 8:12 ` Geert Uytterhoeven
2020-01-08 8:12 ` Geert Uytterhoeven
2020-01-08 8:12 ` Geert Uytterhoeven
2020-01-08 8:12 ` Geert Uytterhoeven
2020-01-08 8:12 ` Geert Uytterhoeven
2020-01-08 8:18 ` Krzysztof Kozlowski
2020-01-08 8:18 ` Krzysztof Kozlowski
2020-01-08 8:18 ` Krzysztof Kozlowski
2020-01-08 8:18 ` Krzysztof Kozlowski
2020-01-08 8:18 ` Krzysztof Kozlowski
2020-01-08 8:35 ` Christophe Leroy
2020-01-08 8:35 ` Christophe Leroy
2020-01-08 8:35 ` Christophe Leroy
2020-01-08 8:35 ` Christophe Leroy
2020-01-08 8:35 ` Christophe Leroy
2020-01-08 8:35 ` Christophe Leroy
2020-01-08 8:43 ` Geert Uytterhoeven
2020-01-08 8:43 ` Geert Uytterhoeven
2020-01-08 8:43 ` Geert Uytterhoeven
2020-01-08 8:43 ` Geert Uytterhoeven
2020-01-08 8:43 ` Geert Uytterhoeven
2020-01-08 8:43 ` Geert Uytterhoeven
2020-01-08 8:43 ` Geert Uytterhoeven
2020-01-08 8:43 ` Geert Uytterhoeven
2020-01-08 8:48 ` Christophe Leroy
2020-01-08 8:48 ` Christophe Leroy
2020-01-08 8:48 ` Christophe Leroy
2020-01-08 8:48 ` Christophe Leroy
2020-01-08 8:48 ` Christophe Leroy
2020-01-08 8:48 ` Christophe Leroy
2020-01-08 8:48 ` Christophe Leroy
2020-01-08 8:48 ` Christophe Leroy
2020-01-08 17:39 ` David Laight
2020-01-08 17:39 ` David Laight
2020-01-08 17:39 ` David Laight
2020-01-08 17:39 ` David Laight
2020-01-08 17:39 ` David Laight
2020-01-08 8:44 ` Arnd Bergmann
2020-01-08 8:44 ` Arnd Bergmann
2020-01-08 8:44 ` Arnd Bergmann
2020-01-08 8:44 ` Arnd Bergmann
2020-01-08 8:44 ` Arnd Bergmann
2020-01-08 8:44 ` Arnd Bergmann
2020-01-08 8:44 ` Arnd Bergmann
2020-01-08 9:15 ` Krzysztof Kozlowski
2020-01-08 9:15 ` Krzysztof Kozlowski
2020-01-08 9:15 ` Krzysztof Kozlowski
2020-01-08 9:15 ` Krzysztof Kozlowski
2020-01-08 9:15 ` Krzysztof Kozlowski
2020-01-08 11:55 ` Arnd Bergmann
2020-01-08 11:55 ` Arnd Bergmann
2020-01-08 11:55 ` Arnd Bergmann
2020-01-08 11:55 ` Arnd Bergmann
2020-01-08 11:55 ` Arnd Bergmann
2020-01-08 11:55 ` Arnd Bergmann
2020-01-08 11:55 ` Arnd Bergmann
2020-01-08 8:35 ` Christophe Leroy
2020-01-08 8:18 ` Krzysztof Kozlowski
2020-01-08 8:15 ` Krzysztof Kozlowski
2020-01-08 8:15 ` Krzysztof Kozlowski
2020-01-08 8:15 ` Krzysztof Kozlowski
2020-01-08 8:15 ` Krzysztof Kozlowski
2020-01-08 8:15 ` Krzysztof Kozlowski
2020-01-08 8:15 ` Krzysztof Kozlowski
2020-01-08 8:07 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1RibnRU6SiVjrOy-q+ZDdKacQgD9mrft_aHMgA9hm3PA__3492.88810264028$1578417048$gmane$org@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bskeggs@redhat.com \
--cc=dalias@libc.org \
--cc=dave.jiang@intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=jirislaby@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=paulus@samba.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.