* [PATCH] x86: Add a kvm module parameter check for vmware_backdoors test
@ 2020-01-15 19:55 Babu Moger
2020-01-15 22:16 ` Liran Alon
0 siblings, 1 reply; 2+ messages in thread
From: Babu Moger @ 2020-01-15 19:55 UTC (permalink / raw)
To: pbonzini; +Cc: kvm
vmware_backdoors test fails if the kvm module parameter
enable_vmware_backdoor is not set to Y. Add a check before
running the test.
Suggested-by: Huang2, Wei <Wei.Huang2@amd.com>
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
x86/unittests.cfg | 1 +
1 file changed, 1 insertion(+)
diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index 51e4ba5..aae1523 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -164,6 +164,7 @@ check = /proc/sys/kernel/nmi_watchdog=0
[vmware_backdoors]
file = vmware_backdoors.flat
extra_params = -machine vmport=on -cpu host
+check = /sys/module/kvm/parameters/enable_vmware_backdoor=Y
arch = x86_64
[port80]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: Add a kvm module parameter check for vmware_backdoors test
2020-01-15 19:55 [PATCH] x86: Add a kvm module parameter check for vmware_backdoors test Babu Moger
@ 2020-01-15 22:16 ` Liran Alon
0 siblings, 0 replies; 2+ messages in thread
From: Liran Alon @ 2020-01-15 22:16 UTC (permalink / raw)
To: Babu Moger; +Cc: pbonzini, kvm
> On 15 Jan 2020, at 21:55, Babu Moger <babu.moger@amd.com> wrote:
>
> vmware_backdoors test fails if the kvm module parameter
> enable_vmware_backdoor is not set to Y. Add a check before
> running the test.
>
> Suggested-by: Huang2, Wei <Wei.Huang2@amd.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> x86/unittests.cfg | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> index 51e4ba5..aae1523 100644
> --- a/x86/unittests.cfg
> +++ b/x86/unittests.cfg
> @@ -164,6 +164,7 @@ check = /proc/sys/kernel/nmi_watchdog=0
> [vmware_backdoors]
> file = vmware_backdoors.flat
> extra_params = -machine vmport=on -cpu host
> +check = /sys/module/kvm/parameters/enable_vmware_backdoor=Y
> arch = x86_64
>
> [port80]
>
Nice!
I didn’t notice there is a “check” feature when I first introduced vmware_backdoor tests.
Sorry for that.
Reviewed-by: Liran Alon <liran.alon@oracle.com>
-Liran
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-15 22:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 19:55 [PATCH] x86: Add a kvm module parameter check for vmware_backdoors test Babu Moger
2020-01-15 22:16 ` Liran Alon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.