All of lore.kernel.org
 help / color / mirror / Atom feed
* "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2019-12-19  3:58 ` Qian Cai
  0 siblings, 0 replies; 16+ messages in thread
From: Qian Cai @ 2019-12-19  3:58 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: clang-built-linux, Steven Rostedt (VMware),
	Alexei Starovoitov, Ingo Molnar, Linux Kernel Mailing List,
	Michael Ellerman, linuxppc-dev, Catalin Marinas, Will Deacon,
	linux-arm-kernel

The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.

configs:
https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config

[1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/

[  115.799327][    T1] Registered efivars operations
[  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
[  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
[  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
[  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
[  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
[  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
[  116.069828][    T1] Could not create directory for event sys_enter_getpid
[  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
[  116.085181][    T1] Could not create directory for event sys_enter_gettid
[  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
[  116.100612][    T1] Could not create directory for event sys_enter_getppid
[  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
[  116.116058][    T1] Could not create directory for event sys_enter_getuid
[  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
[  116.131457][    T1] Could not create directory for event sys_enter_geteuid
[  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
[  116.146908][    T1] Could not create directory for event sys_enter_getgid
[  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
[  116.162370][    T1] Could not create directory for event sys_enter_getegid
[  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
[  116.185138][    T1] Could not create directory for event sys_enter_setsid
[  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
[  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
[  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
[  116.535126][    T1] Could not create directory for event sys_enter_munlockall
[  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
[  116.629307][    T1] Could not create directory for event sys_enter_vhangup
[  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
[  116.790819][    T1] Could not create directory for event sys_enter_sync
[  117.723402][    T1] pnp: PnP ACPI init
[  117.736379][    T1] system 00:00: [mem 0x30000000-0x3fffffff window] could not be reserved
[  126.020353][    T1] pnp: PnP ACPI: found 1 devices
[  126.093919][    T1] NET: Registered protocol family 2
[  126.180007][    T1] tcp_listen_portaddr_hash hash table entries: 65536 (order: 6, 4718592 bytes, vmalloc)
[  126.206510][    T1] TCP established hash table entries: 524288 (order: 6, 4194304 bytes, vmalloc)
[  126.227766][    T1] TCP bind hash table entries: 65536 (order: 6, 4194304 bytes, vmalloc)
[  126.240146][    T1] TCP: Hash tables configured (established 524288 bind 65536)

^ permalink raw reply	[flat|nested] 16+ messages in thread
* "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2019-12-19  3:58 ` Qian Cai
  0 siblings, 0 replies; 16+ messages in thread
From: Qian Cai @ 2019-12-19  3:58 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: Will Deacon, Linux Kernel Mailing List, Steven Rostedt (VMware),
	Alexei Starovoitov, clang-built-linux, Catalin Marinas,
	linuxppc-dev, Ingo Molnar, linux-arm-kernel

The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.

configs:
https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config

[1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/

[  115.799327][    T1] Registered efivars operations
[  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
[  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
[  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
[  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
[  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
[  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
[  116.069828][    T1] Could not create directory for event sys_enter_getpid
[  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
[  116.085181][    T1] Could not create directory for event sys_enter_gettid
[  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
[  116.100612][    T1] Could not create directory for event sys_enter_getppid
[  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
[  116.116058][    T1] Could not create directory for event sys_enter_getuid
[  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
[  116.131457][    T1] Could not create directory for event sys_enter_geteuid
[  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
[  116.146908][    T1] Could not create directory for event sys_enter_getgid
[  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
[  116.162370][    T1] Could not create directory for event sys_enter_getegid
[  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
[  116.185138][    T1] Could not create directory for event sys_enter_setsid
[  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
[  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
[  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
[  116.535126][    T1] Could not create directory for event sys_enter_munlockall
[  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
[  116.629307][    T1] Could not create directory for event sys_enter_vhangup
[  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
[  116.790819][    T1] Could not create directory for event sys_enter_sync
[  117.723402][    T1] pnp: PnP ACPI init
[  117.736379][    T1] system 00:00: [mem 0x30000000-0x3fffffff window] could not be reserved
[  126.020353][    T1] pnp: PnP ACPI: found 1 devices
[  126.093919][    T1] NET: Registered protocol family 2
[  126.180007][    T1] tcp_listen_portaddr_hash hash table entries: 65536 (order: 6, 4718592 bytes, vmalloc)
[  126.206510][    T1] TCP established hash table entries: 524288 (order: 6, 4194304 bytes, vmalloc)
[  126.227766][    T1] TCP bind hash table entries: 65536 (order: 6, 4194304 bytes, vmalloc)
[  126.240146][    T1] TCP: Hash tables configured (established 524288 bind 65536)

^ permalink raw reply	[flat|nested] 16+ messages in thread
* "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2019-12-19  3:58 ` Qian Cai
  0 siblings, 0 replies; 16+ messages in thread
From: Qian Cai @ 2019-12-19  3:58 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: Will Deacon, Michael Ellerman, Linux Kernel Mailing List,
	Steven Rostedt (VMware),
	Alexei Starovoitov, clang-built-linux, Catalin Marinas,
	linuxppc-dev, Ingo Molnar, linux-arm-kernel

The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.

configs:
https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config

[1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/

[  115.799327][    T1] Registered efivars operations
[  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
[  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
[  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
[  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
[  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
[  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
[  116.069828][    T1] Could not create directory for event sys_enter_getpid
[  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
[  116.085181][    T1] Could not create directory for event sys_enter_gettid
[  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
[  116.100612][    T1] Could not create directory for event sys_enter_getppid
[  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
[  116.116058][    T1] Could not create directory for event sys_enter_getuid
[  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
[  116.131457][    T1] Could not create directory for event sys_enter_geteuid
[  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
[  116.146908][    T1] Could not create directory for event sys_enter_getgid
[  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
[  116.162370][    T1] Could not create directory for event sys_enter_getegid
[  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
[  116.185138][    T1] Could not create directory for event sys_enter_setsid
[  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
[  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
[  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
[  116.535126][    T1] Could not create directory for event sys_enter_munlockall
[  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
[  116.629307][    T1] Could not create directory for event sys_enter_vhangup
[  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
[  116.790819][    T1] Could not create directory for event sys_enter_sync
[  117.723402][    T1] pnp: PnP ACPI init
[  117.736379][    T1] system 00:00: [mem 0x30000000-0x3fffffff window] could not be reserved
[  126.020353][    T1] pnp: PnP ACPI: found 1 devices
[  126.093919][    T1] NET: Registered protocol family 2
[  126.180007][    T1] tcp_listen_portaddr_hash hash table entries: 65536 (order: 6, 4718592 bytes, vmalloc)
[  126.206510][    T1] TCP established hash table entries: 524288 (order: 6, 4194304 bytes, vmalloc)
[  126.227766][    T1] TCP bind hash table entries: 65536 (order: 6, 4194304 bytes, vmalloc)
[  126.240146][    T1] TCP: Hash tables configured (established 524288 bind 65536)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
  2019-12-19  3:58 ` Qian Cai
  (?)
@ 2019-12-19  4:31   ` Steven Rostedt
  -1 siblings, 0 replies; 16+ messages in thread
From: Steven Rostedt @ 2019-12-19  4:31 UTC (permalink / raw)
  To: Qian Cai
  Cc: Peter Zijlstra, clang-built-linux, Alexei Starovoitov,
	Ingo Molnar, Linux Kernel Mailing List, Michael Ellerman,
	linuxppc-dev, Catalin Marinas, Will Deacon, linux-arm-kernel

On Wed, 18 Dec 2019 22:58:23 -0500
Qian Cai <cai@lca.pw> wrote:

> The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
> for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
> Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.
> 
> configs:
> https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
> 
> [1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/
> 
> [  115.799327][    T1] Registered efivars operations
> [  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
> [  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
> [  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
> [  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
> [  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
> [  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
> [  116.069828][    T1] Could not create directory for event sys_enter_getpid
> [  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
> [  116.085181][    T1] Could not create directory for event sys_enter_gettid
> [  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
> [  116.100612][    T1] Could not create directory for event sys_enter_getppid
> [  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
> [  116.116058][    T1] Could not create directory for event sys_enter_getuid
> [  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
> [  116.131457][    T1] Could not create directory for event sys_enter_geteuid
> [  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
> [  116.146908][    T1] Could not create directory for event sys_enter_getgid
> [  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
> [  116.162370][    T1] Could not create directory for event sys_enter_getegid
> [  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
> [  116.185138][    T1] Could not create directory for event sys_enter_setsid
> [  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
> [  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
> [  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
> [  116.535126][    T1] Could not create directory for event sys_enter_munlockall
> [  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
> [  116.629307][    T1] Could not create directory for event sys_enter_vhangup
> [  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
> [  116.790819][    T1] Could not create directory for event sys_enter_sync
> [  117.723402][    T1] pnp: PnP ACPI init

I noticed that all of the above have zero parameters. Does the
following patch fix it?

(note, I prefer "ret" and "i" on different lines anyway)

-- Steve

diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
index 53935259f701..abb70c71fe60 100644
--- a/kernel/trace/trace_syscalls.c
+++ b/kernel/trace/trace_syscalls.c
@@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
 	struct syscall_trace_enter trace;
 	struct syscall_metadata *meta = call->data;
 	int offset = offsetof(typeof(trace), args);
-	int ret, i;
+	int ret = 0;
+	int i;
 
 	for (i = 0; i < meta->nb_args; i++) {
 		ret = trace_define_field(call, meta->types[i],

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2019-12-19  4:31   ` Steven Rostedt
  0 siblings, 0 replies; 16+ messages in thread
From: Steven Rostedt @ 2019-12-19  4:31 UTC (permalink / raw)
  To: Qian Cai
  Cc: Will Deacon, Peter Zijlstra, Alexei Starovoitov,
	Linux Kernel Mailing List, clang-built-linux, Catalin Marinas,
	linuxppc-dev, Ingo Molnar, linux-arm-kernel

On Wed, 18 Dec 2019 22:58:23 -0500
Qian Cai <cai@lca.pw> wrote:

> The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
> for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
> Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.
> 
> configs:
> https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
> 
> [1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/
> 
> [  115.799327][    T1] Registered efivars operations
> [  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
> [  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
> [  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
> [  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
> [  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
> [  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
> [  116.069828][    T1] Could not create directory for event sys_enter_getpid
> [  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
> [  116.085181][    T1] Could not create directory for event sys_enter_gettid
> [  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
> [  116.100612][    T1] Could not create directory for event sys_enter_getppid
> [  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
> [  116.116058][    T1] Could not create directory for event sys_enter_getuid
> [  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
> [  116.131457][    T1] Could not create directory for event sys_enter_geteuid
> [  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
> [  116.146908][    T1] Could not create directory for event sys_enter_getgid
> [  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
> [  116.162370][    T1] Could not create directory for event sys_enter_getegid
> [  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
> [  116.185138][    T1] Could not create directory for event sys_enter_setsid
> [  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
> [  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
> [  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
> [  116.535126][    T1] Could not create directory for event sys_enter_munlockall
> [  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
> [  116.629307][    T1] Could not create directory for event sys_enter_vhangup
> [  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
> [  116.790819][    T1] Could not create directory for event sys_enter_sync
> [  117.723402][    T1] pnp: PnP ACPI init

I noticed that all of the above have zero parameters. Does the
following patch fix it?

(note, I prefer "ret" and "i" on different lines anyway)

-- Steve

diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
index 53935259f701..abb70c71fe60 100644
--- a/kernel/trace/trace_syscalls.c
+++ b/kernel/trace/trace_syscalls.c
@@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
 	struct syscall_trace_enter trace;
 	struct syscall_metadata *meta = call->data;
 	int offset = offsetof(typeof(trace), args);
-	int ret, i;
+	int ret = 0;
+	int i;
 
 	for (i = 0; i < meta->nb_args; i++) {
 		ret = trace_define_field(call, meta->types[i],

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2019-12-19  4:31   ` Steven Rostedt
  0 siblings, 0 replies; 16+ messages in thread
From: Steven Rostedt @ 2019-12-19  4:31 UTC (permalink / raw)
  To: Qian Cai
  Cc: Will Deacon, Peter Zijlstra, Michael Ellerman,
	Alexei Starovoitov, Linux Kernel Mailing List, clang-built-linux,
	Catalin Marinas, linuxppc-dev, Ingo Molnar, linux-arm-kernel

On Wed, 18 Dec 2019 22:58:23 -0500
Qian Cai <cai@lca.pw> wrote:

> The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
> for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
> Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.
> 
> configs:
> https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
> 
> [1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/
> 
> [  115.799327][    T1] Registered efivars operations
> [  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
> [  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
> [  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
> [  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
> [  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
> [  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
> [  116.069828][    T1] Could not create directory for event sys_enter_getpid
> [  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
> [  116.085181][    T1] Could not create directory for event sys_enter_gettid
> [  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
> [  116.100612][    T1] Could not create directory for event sys_enter_getppid
> [  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
> [  116.116058][    T1] Could not create directory for event sys_enter_getuid
> [  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
> [  116.131457][    T1] Could not create directory for event sys_enter_geteuid
> [  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
> [  116.146908][    T1] Could not create directory for event sys_enter_getgid
> [  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
> [  116.162370][    T1] Could not create directory for event sys_enter_getegid
> [  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
> [  116.185138][    T1] Could not create directory for event sys_enter_setsid
> [  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
> [  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
> [  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
> [  116.535126][    T1] Could not create directory for event sys_enter_munlockall
> [  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
> [  116.629307][    T1] Could not create directory for event sys_enter_vhangup
> [  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
> [  116.790819][    T1] Could not create directory for event sys_enter_sync
> [  117.723402][    T1] pnp: PnP ACPI init

I noticed that all of the above have zero parameters. Does the
following patch fix it?

(note, I prefer "ret" and "i" on different lines anyway)

-- Steve

diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
index 53935259f701..abb70c71fe60 100644
--- a/kernel/trace/trace_syscalls.c
+++ b/kernel/trace/trace_syscalls.c
@@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
 	struct syscall_trace_enter trace;
 	struct syscall_metadata *meta = call->data;
 	int offset = offsetof(typeof(trace), args);
-	int ret, i;
+	int ret = 0;
+	int i;
 
 	for (i = 0; i < meta->nb_args; i++) {
 		ret = trace_define_field(call, meta->types[i],

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
  2019-12-19  4:31   ` Steven Rostedt
  (?)
@ 2019-12-19  6:06     ` Qian Cai
  -1 siblings, 0 replies; 16+ messages in thread
From: Qian Cai @ 2019-12-19  6:06 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Peter Zijlstra, clang-built-linux, Alexei Starovoitov,
	Ingo Molnar, Linux Kernel Mailing List, Michael Ellerman,
	linuxppc-dev, Catalin Marinas, Will Deacon, linux-arm-kernel



> On Dec 18, 2019, at 11:31 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> On Wed, 18 Dec 2019 22:58:23 -0500
> Qian Cai <cai@lca.pw> wrote:
> 
>> The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
>> for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
>> Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.
>> 
>> configs:
>> https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
>> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
>> 
>> [1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/
>> 
>> [  115.799327][    T1] Registered efivars operations
>> [  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
>> [  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
>> [  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
>> [  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
>> [  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
>> [  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
>> [  116.069828][    T1] Could not create directory for event sys_enter_getpid
>> [  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
>> [  116.085181][    T1] Could not create directory for event sys_enter_gettid
>> [  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
>> [  116.100612][    T1] Could not create directory for event sys_enter_getppid
>> [  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
>> [  116.116058][    T1] Could not create directory for event sys_enter_getuid
>> [  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
>> [  116.131457][    T1] Could not create directory for event sys_enter_geteuid
>> [  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
>> [  116.146908][    T1] Could not create directory for event sys_enter_getgid
>> [  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
>> [  116.162370][    T1] Could not create directory for event sys_enter_getegid
>> [  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
>> [  116.185138][    T1] Could not create directory for event sys_enter_setsid
>> [  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
>> [  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
>> [  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
>> [  116.535126][    T1] Could not create directory for event sys_enter_munlockall
>> [  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
>> [  116.629307][    T1] Could not create directory for event sys_enter_vhangup
>> [  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
>> [  116.790819][    T1] Could not create directory for event sys_enter_sync
>> [  117.723402][    T1] pnp: PnP ACPI init
> 
> I noticed that all of the above have zero parameters. Does the
> following patch fix it?

Yes, it works.

> 
> (note, I prefer "ret" and "i" on different lines anyway)
> 
> -- Steve
> 
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 53935259f701..abb70c71fe60 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> 	struct syscall_trace_enter trace;
> 	struct syscall_metadata *meta = call->data;
> 	int offset = offsetof(typeof(trace), args);
> -	int ret, i;
> +	int ret = 0;
> +	int i;
> 
> 	for (i = 0; i < meta->nb_args; i++) {
> 		ret = trace_define_field(call, meta->types[i],


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2019-12-19  6:06     ` Qian Cai
  0 siblings, 0 replies; 16+ messages in thread
From: Qian Cai @ 2019-12-19  6:06 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Will Deacon, Peter Zijlstra, Alexei Starovoitov,
	Linux Kernel Mailing List, clang-built-linux, Catalin Marinas,
	linuxppc-dev, Ingo Molnar, linux-arm-kernel



> On Dec 18, 2019, at 11:31 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> On Wed, 18 Dec 2019 22:58:23 -0500
> Qian Cai <cai@lca.pw> wrote:
> 
>> The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
>> for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
>> Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.
>> 
>> configs:
>> https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
>> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
>> 
>> [1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/
>> 
>> [  115.799327][    T1] Registered efivars operations
>> [  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
>> [  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
>> [  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
>> [  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
>> [  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
>> [  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
>> [  116.069828][    T1] Could not create directory for event sys_enter_getpid
>> [  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
>> [  116.085181][    T1] Could not create directory for event sys_enter_gettid
>> [  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
>> [  116.100612][    T1] Could not create directory for event sys_enter_getppid
>> [  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
>> [  116.116058][    T1] Could not create directory for event sys_enter_getuid
>> [  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
>> [  116.131457][    T1] Could not create directory for event sys_enter_geteuid
>> [  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
>> [  116.146908][    T1] Could not create directory for event sys_enter_getgid
>> [  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
>> [  116.162370][    T1] Could not create directory for event sys_enter_getegid
>> [  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
>> [  116.185138][    T1] Could not create directory for event sys_enter_setsid
>> [  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
>> [  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
>> [  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
>> [  116.535126][    T1] Could not create directory for event sys_enter_munlockall
>> [  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
>> [  116.629307][    T1] Could not create directory for event sys_enter_vhangup
>> [  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
>> [  116.790819][    T1] Could not create directory for event sys_enter_sync
>> [  117.723402][    T1] pnp: PnP ACPI init
> 
> I noticed that all of the above have zero parameters. Does the
> following patch fix it?

Yes, it works.

> 
> (note, I prefer "ret" and "i" on different lines anyway)
> 
> -- Steve
> 
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 53935259f701..abb70c71fe60 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> 	struct syscall_trace_enter trace;
> 	struct syscall_metadata *meta = call->data;
> 	int offset = offsetof(typeof(trace), args);
> -	int ret, i;
> +	int ret = 0;
> +	int i;
> 
> 	for (i = 0; i < meta->nb_args; i++) {
> 		ret = trace_define_field(call, meta->types[i],


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2019-12-19  6:06     ` Qian Cai
  0 siblings, 0 replies; 16+ messages in thread
From: Qian Cai @ 2019-12-19  6:06 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Will Deacon, Peter Zijlstra, Michael Ellerman,
	Alexei Starovoitov, Linux Kernel Mailing List, clang-built-linux,
	Catalin Marinas, linuxppc-dev, Ingo Molnar, linux-arm-kernel



> On Dec 18, 2019, at 11:31 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> On Wed, 18 Dec 2019 22:58:23 -0500
> Qian Cai <cai@lca.pw> wrote:
> 
>> The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
>> for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
>> Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.
>> 
>> configs:
>> https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
>> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
>> 
>> [1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/
>> 
>> [  115.799327][    T1] Registered efivars operations
>> [  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
>> [  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
>> [  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
>> [  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
>> [  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
>> [  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
>> [  116.069828][    T1] Could not create directory for event sys_enter_getpid
>> [  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
>> [  116.085181][    T1] Could not create directory for event sys_enter_gettid
>> [  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
>> [  116.100612][    T1] Could not create directory for event sys_enter_getppid
>> [  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
>> [  116.116058][    T1] Could not create directory for event sys_enter_getuid
>> [  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
>> [  116.131457][    T1] Could not create directory for event sys_enter_geteuid
>> [  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
>> [  116.146908][    T1] Could not create directory for event sys_enter_getgid
>> [  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
>> [  116.162370][    T1] Could not create directory for event sys_enter_getegid
>> [  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
>> [  116.185138][    T1] Could not create directory for event sys_enter_setsid
>> [  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
>> [  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
>> [  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
>> [  116.535126][    T1] Could not create directory for event sys_enter_munlockall
>> [  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
>> [  116.629307][    T1] Could not create directory for event sys_enter_vhangup
>> [  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
>> [  116.790819][    T1] Could not create directory for event sys_enter_sync
>> [  117.723402][    T1] pnp: PnP ACPI init
> 
> I noticed that all of the above have zero parameters. Does the
> following patch fix it?

Yes, it works.

> 
> (note, I prefer "ret" and "i" on different lines anyway)
> 
> -- Steve
> 
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 53935259f701..abb70c71fe60 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> 	struct syscall_trace_enter trace;
> 	struct syscall_metadata *meta = call->data;
> 	int offset = offsetof(typeof(trace), args);
> -	int ret, i;
> +	int ret = 0;
> +	int i;
> 
> 	for (i = 0; i < meta->nb_args; i++) {
> 		ret = trace_define_field(call, meta->types[i],


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
  2019-12-19  4:31   ` Steven Rostedt
  (?)
@ 2020-01-06 17:05     ` Qian Cai
  -1 siblings, 0 replies; 16+ messages in thread
From: Qian Cai @ 2020-01-06 17:05 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Peter Zijlstra, clang-built-linux, Alexei Starovoitov,
	Ingo Molnar, Linux Kernel Mailing List, Michael Ellerman,
	linuxppc-dev, Catalin Marinas, Will Deacon, linux-arm-kernel



> On Dec 18, 2019, at 11:31 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> On Wed, 18 Dec 2019 22:58:23 -0500
> Qian Cai <cai@lca.pw> wrote:
> 
>> The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
>> for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
>> Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.
>> 
>> configs:
>> https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
>> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
>> 
>> [1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/
>> 
>> [  115.799327][    T1] Registered efivars operations
>> [  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
>> [  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
>> [  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
>> [  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
>> [  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
>> [  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
>> [  116.069828][    T1] Could not create directory for event sys_enter_getpid
>> [  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
>> [  116.085181][    T1] Could not create directory for event sys_enter_gettid
>> [  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
>> [  116.100612][    T1] Could not create directory for event sys_enter_getppid
>> [  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
>> [  116.116058][    T1] Could not create directory for event sys_enter_getuid
>> [  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
>> [  116.131457][    T1] Could not create directory for event sys_enter_geteuid
>> [  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
>> [  116.146908][    T1] Could not create directory for event sys_enter_getgid
>> [  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
>> [  116.162370][    T1] Could not create directory for event sys_enter_getegid
>> [  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
>> [  116.185138][    T1] Could not create directory for event sys_enter_setsid
>> [  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
>> [  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
>> [  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
>> [  116.535126][    T1] Could not create directory for event sys_enter_munlockall
>> [  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
>> [  116.629307][    T1] Could not create directory for event sys_enter_vhangup
>> [  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
>> [  116.790819][    T1] Could not create directory for event sys_enter_sync
>> [  117.723402][    T1] pnp: PnP ACPI init
> 
> I noticed that all of the above have zero parameters. Does the
> following patch fix it?
> 
> (note, I prefer "ret" and "i" on different lines anyway)
> 
> -- Steve
> 
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 53935259f701..abb70c71fe60 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> 	struct syscall_trace_enter trace;
> 	struct syscall_metadata *meta = call->data;
> 	int offset = offsetof(typeof(trace), args);
> -	int ret, i;
> +	int ret = 0;
> +	int i;
> 
> 	for (i = 0; i < meta->nb_args; i++) {
> 		ret = trace_define_field(call, meta->types[i],

Steve, those errors are still there in today’s linux-next. Is this patch on the way to the linux-next?


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2020-01-06 17:05     ` Qian Cai
  0 siblings, 0 replies; 16+ messages in thread
From: Qian Cai @ 2020-01-06 17:05 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Will Deacon, Peter Zijlstra, Alexei Starovoitov,
	Linux Kernel Mailing List, clang-built-linux, Catalin Marinas,
	linuxppc-dev, Ingo Molnar, linux-arm-kernel



> On Dec 18, 2019, at 11:31 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> On Wed, 18 Dec 2019 22:58:23 -0500
> Qian Cai <cai@lca.pw> wrote:
> 
>> The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
>> for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
>> Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.
>> 
>> configs:
>> https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
>> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
>> 
>> [1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/
>> 
>> [  115.799327][    T1] Registered efivars operations
>> [  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
>> [  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
>> [  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
>> [  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
>> [  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
>> [  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
>> [  116.069828][    T1] Could not create directory for event sys_enter_getpid
>> [  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
>> [  116.085181][    T1] Could not create directory for event sys_enter_gettid
>> [  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
>> [  116.100612][    T1] Could not create directory for event sys_enter_getppid
>> [  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
>> [  116.116058][    T1] Could not create directory for event sys_enter_getuid
>> [  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
>> [  116.131457][    T1] Could not create directory for event sys_enter_geteuid
>> [  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
>> [  116.146908][    T1] Could not create directory for event sys_enter_getgid
>> [  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
>> [  116.162370][    T1] Could not create directory for event sys_enter_getegid
>> [  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
>> [  116.185138][    T1] Could not create directory for event sys_enter_setsid
>> [  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
>> [  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
>> [  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
>> [  116.535126][    T1] Could not create directory for event sys_enter_munlockall
>> [  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
>> [  116.629307][    T1] Could not create directory for event sys_enter_vhangup
>> [  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
>> [  116.790819][    T1] Could not create directory for event sys_enter_sync
>> [  117.723402][    T1] pnp: PnP ACPI init
> 
> I noticed that all of the above have zero parameters. Does the
> following patch fix it?
> 
> (note, I prefer "ret" and "i" on different lines anyway)
> 
> -- Steve
> 
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 53935259f701..abb70c71fe60 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> 	struct syscall_trace_enter trace;
> 	struct syscall_metadata *meta = call->data;
> 	int offset = offsetof(typeof(trace), args);
> -	int ret, i;
> +	int ret = 0;
> +	int i;
> 
> 	for (i = 0; i < meta->nb_args; i++) {
> 		ret = trace_define_field(call, meta->types[i],

Steve, those errors are still there in today’s linux-next. Is this patch on the way to the linux-next?


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2020-01-06 17:05     ` Qian Cai
  0 siblings, 0 replies; 16+ messages in thread
From: Qian Cai @ 2020-01-06 17:05 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Will Deacon, Peter Zijlstra, Michael Ellerman,
	Alexei Starovoitov, Linux Kernel Mailing List, clang-built-linux,
	Catalin Marinas, linuxppc-dev, Ingo Molnar, linux-arm-kernel



> On Dec 18, 2019, at 11:31 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> On Wed, 18 Dec 2019 22:58:23 -0500
> Qian Cai <cai@lca.pw> wrote:
> 
>> The linux-next commit "ftrace: Rework event_create_dir()” [1] triggers boot warnings
>> for Clang-build (Clang version 8.0.1) kernels (reproduced on both arm64 and powerpc).
>> Reverted it (with trivial conflict fixes) on the top of today’s linux-next fixed the issue.
>> 
>> configs:
>> https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config
>> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
>> 
>> [1] https://lore.kernel.org/lkml/20191111132458.342979914@infradead.org/
>> 
>> [  115.799327][    T1] Registered efivars operations
>> [  115.849770][    T1] clocksource: Switched to clocksource arch_sys_counter
>> [  115.901145][    T1] Could not initialize trace point events/sys_enter_rt_sigreturn
>> [  115.908854][    T1] Could not create directory for event sys_enter_rt_sigreturn
>> [  115.998949][    T1] Could not initialize trace point events/sys_enter_restart_syscall
>> [  116.006802][    T1] Could not create directory for event sys_enter_restart_syscall
>> [  116.062702][    T1] Could not initialize trace point events/sys_enter_getpid
>> [  116.069828][    T1] Could not create directory for event sys_enter_getpid
>> [  116.078058][    T1] Could not initialize trace point events/sys_enter_gettid
>> [  116.085181][    T1] Could not create directory for event sys_enter_gettid
>> [  116.093405][    T1] Could not initialize trace point events/sys_enter_getppid
>> [  116.100612][    T1] Could not create directory for event sys_enter_getppid
>> [  116.108989][    T1] Could not initialize trace point events/sys_enter_getuid
>> [  116.116058][    T1] Could not create directory for event sys_enter_getuid
>> [  116.124250][    T1] Could not initialize trace point events/sys_enter_geteuid
>> [  116.131457][    T1] Could not create directory for event sys_enter_geteuid
>> [  116.139840][    T1] Could not initialize trace point events/sys_enter_getgid
>> [  116.146908][    T1] Could not create directory for event sys_enter_getgid
>> [  116.155163][    T1] Could not initialize trace point events/sys_enter_getegid
>> [  116.162370][    T1] Could not create directory for event sys_enter_getegid
>> [  116.178015][    T1] Could not initialize trace point events/sys_enter_setsid
>> [  116.185138][    T1] Could not create directory for event sys_enter_setsid
>> [  116.269307][    T1] Could not initialize trace point events/sys_enter_sched_yield
>> [  116.276811][    T1] Could not create directory for event sys_enter_sched_yield
>> [  116.527652][    T1] Could not initialize trace point events/sys_enter_munlockall
>> [  116.535126][    T1] Could not create directory for event sys_enter_munlockall
>> [  116.622096][    T1] Could not initialize trace point events/sys_enter_vhangup
>> [  116.629307][    T1] Could not create directory for event sys_enter_vhangup
>> [  116.783867][    T1] Could not initialize trace point events/sys_enter_sync
>> [  116.790819][    T1] Could not create directory for event sys_enter_sync
>> [  117.723402][    T1] pnp: PnP ACPI init
> 
> I noticed that all of the above have zero parameters. Does the
> following patch fix it?
> 
> (note, I prefer "ret" and "i" on different lines anyway)
> 
> -- Steve
> 
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 53935259f701..abb70c71fe60 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> 	struct syscall_trace_enter trace;
> 	struct syscall_metadata *meta = call->data;
> 	int offset = offsetof(typeof(trace), args);
> -	int ret, i;
> +	int ret = 0;
> +	int i;
> 
> 	for (i = 0; i < meta->nb_args; i++) {
> 		ret = trace_define_field(call, meta->types[i],

Steve, those errors are still there in today’s linux-next. Is this patch on the way to the linux-next?


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
  2020-01-06 17:05     ` Qian Cai
  (?)
@ 2020-01-06 17:54       ` Steven Rostedt
  -1 siblings, 0 replies; 16+ messages in thread
From: Steven Rostedt @ 2020-01-06 17:54 UTC (permalink / raw)
  To: Qian Cai
  Cc: Peter Zijlstra, clang-built-linux, Alexei Starovoitov,
	Ingo Molnar, Linux Kernel Mailing List, Michael Ellerman,
	linuxppc-dev, Catalin Marinas, Will Deacon, linux-arm-kernel

On Mon, 6 Jan 2020 12:05:58 -0500
Qian Cai <cai@lca.pw> wrote:

> > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> > index 53935259f701..abb70c71fe60 100644
> > --- a/kernel/trace/trace_syscalls.c
> > +++ b/kernel/trace/trace_syscalls.c
> > @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> > 	struct syscall_trace_enter trace;
> > 	struct syscall_metadata *meta = call->data;
> > 	int offset = offsetof(typeof(trace), args);
> > -	int ret, i;
> > +	int ret = 0;
> > +	int i;
> > 
> > 	for (i = 0; i < meta->nb_args; i++) {
> > 		ret = trace_define_field(call, meta->types[i],  
> 
> Steve, those errors are still there in today’s linux-next. Is this patch on the way to the linux-next?

No, because this bug is not in my tree.

I'll send a proper patch to the tip folks.

-- Steve

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2020-01-06 17:54       ` Steven Rostedt
  0 siblings, 0 replies; 16+ messages in thread
From: Steven Rostedt @ 2020-01-06 17:54 UTC (permalink / raw)
  To: Qian Cai
  Cc: Will Deacon, Peter Zijlstra, Alexei Starovoitov,
	Linux Kernel Mailing List, clang-built-linux, Catalin Marinas,
	linuxppc-dev, Ingo Molnar, linux-arm-kernel

On Mon, 6 Jan 2020 12:05:58 -0500
Qian Cai <cai@lca.pw> wrote:

> > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> > index 53935259f701..abb70c71fe60 100644
> > --- a/kernel/trace/trace_syscalls.c
> > +++ b/kernel/trace/trace_syscalls.c
> > @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> > 	struct syscall_trace_enter trace;
> > 	struct syscall_metadata *meta = call->data;
> > 	int offset = offsetof(typeof(trace), args);
> > -	int ret, i;
> > +	int ret = 0;
> > +	int i;
> > 
> > 	for (i = 0; i < meta->nb_args; i++) {
> > 		ret = trace_define_field(call, meta->types[i],  
> 
> Steve, those errors are still there in today’s linux-next. Is this patch on the way to the linux-next?

No, because this bug is not in my tree.

I'll send a proper patch to the tip folks.

-- Steve

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: "ftrace: Rework event_create_dir()" triggers boot error messages
@ 2020-01-06 17:54       ` Steven Rostedt
  0 siblings, 0 replies; 16+ messages in thread
From: Steven Rostedt @ 2020-01-06 17:54 UTC (permalink / raw)
  To: Qian Cai
  Cc: Will Deacon, Peter Zijlstra, Michael Ellerman,
	Alexei Starovoitov, Linux Kernel Mailing List, clang-built-linux,
	Catalin Marinas, linuxppc-dev, Ingo Molnar, linux-arm-kernel

On Mon, 6 Jan 2020 12:05:58 -0500
Qian Cai <cai@lca.pw> wrote:

> > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> > index 53935259f701..abb70c71fe60 100644
> > --- a/kernel/trace/trace_syscalls.c
> > +++ b/kernel/trace/trace_syscalls.c
> > @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> > 	struct syscall_trace_enter trace;
> > 	struct syscall_metadata *meta = call->data;
> > 	int offset = offsetof(typeof(trace), args);
> > -	int ret, i;
> > +	int ret = 0;
> > +	int i;
> > 
> > 	for (i = 0; i < meta->nb_args; i++) {
> > 		ret = trace_define_field(call, meta->types[i],  
> 
> Steve, those errors are still there in today’s linux-next. Is this patch on the way to the linux-next?

No, because this bug is not in my tree.

I'll send a proper patch to the tip folks.

-- Steve

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [tip: core/kprobes] tracing: Initialize ret in syscall_enter_define_fields()
  2019-12-19  3:58 ` Qian Cai
                   ` (2 preceding siblings ...)
  (?)
@ 2020-01-17 10:08 ` tip-bot2 for Steven Rostedt (VMware)
  -1 siblings, 0 replies; 16+ messages in thread
From: tip-bot2 for Steven Rostedt (VMware) @ 2020-01-17 10:08 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Qian Cai, Steven Rostedt (VMware), Peter Zijlstra (Intel), x86, LKML

The following commit has been merged into the core/kprobes branch of tip:

Commit-ID:     31537cf8f3f95d45360b995ad8be2c870edc5b02
Gitweb:        https://git.kernel.org/tip/31537cf8f3f95d45360b995ad8be2c870edc5b02
Author:        Steven Rostedt (VMware) <rostedt@goodmis.org>
AuthorDate:    Wed, 08 Jan 2020 08:57:55 -05:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Fri, 17 Jan 2020 10:19:18 +01:00

tracing: Initialize ret in syscall_enter_define_fields()

If syscall_enter_define_fields() is called on a system call with no
arguments, the return code variable "ret" will never get initialized.
Initialize it to zero.

Fixes: 04ae87a52074e ("ftrace: Rework event_create_dir()")
Reported-by: Qian Cai <cai@lca.pw>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/0FA8C6E3-D9F5-416D-A1B0-5E4CD583A101@lca.pw
---
 kernel/trace/trace_syscalls.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
index 73140d8..2978c29 100644
--- a/kernel/trace/trace_syscalls.c
+++ b/kernel/trace/trace_syscalls.c
@@ -274,7 +274,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
 	struct syscall_trace_enter trace;
 	struct syscall_metadata *meta = call->data;
 	int offset = offsetof(typeof(trace), args);
-	int ret, i;
+	int ret = 0;
+	int i;
 
 	for (i = 0; i < meta->nb_args; i++) {
 		ret = trace_define_field(call, meta->types[i],

^ permalink raw reply related	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2020-01-17 10:09 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19  3:58 "ftrace: Rework event_create_dir()" triggers boot error messages Qian Cai
2019-12-19  3:58 ` Qian Cai
2019-12-19  3:58 ` Qian Cai
2019-12-19  4:31 ` Steven Rostedt
2019-12-19  4:31   ` Steven Rostedt
2019-12-19  4:31   ` Steven Rostedt
2019-12-19  6:06   ` Qian Cai
2019-12-19  6:06     ` Qian Cai
2019-12-19  6:06     ` Qian Cai
2020-01-06 17:05   ` Qian Cai
2020-01-06 17:05     ` Qian Cai
2020-01-06 17:05     ` Qian Cai
2020-01-06 17:54     ` Steven Rostedt
2020-01-06 17:54       ` Steven Rostedt
2020-01-06 17:54       ` Steven Rostedt
2020-01-17 10:08 ` [tip: core/kprobes] tracing: Initialize ret in syscall_enter_define_fields() tip-bot2 for Steven Rostedt (VMware)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.